RubyGems - capybara - Versions diffs - 3.37.1 → 3.39.0 - Mend

capybara 3.37.1 → 3.39.0

Files changed (100) hide show

checksums.yaml +4 -4
data/History.md +54 -4
data/README.md +23 -11
data/lib/capybara/helpers.rb +5 -1
data/lib/capybara/node/actions.rb +4 -4
data/lib/capybara/node/base.rb +2 -1
data/lib/capybara/node/finders.rb +2 -0
data/lib/capybara/node/whitespace_normalizer.rb +81 -0
data/lib/capybara/queries/base_query.rb +2 -2
data/lib/capybara/queries/selector_query.rb +4 -2
data/lib/capybara/queries/text_query.rb +1 -1
data/lib/capybara/rack_test/browser.rb +8 -2
data/lib/capybara/rack_test/form.rb +29 -7
data/lib/capybara/rack_test/node.rb +18 -15
data/lib/capybara/registrations/drivers.rb +3 -3
data/lib/capybara/registrations/servers.rb +30 -10
data/lib/capybara/rspec/matcher_proxies.rb +3 -3
data/lib/capybara/rspec/matchers/base.rb +8 -6
data/lib/capybara/rspec/matchers/compound.rb +1 -1
data/lib/capybara/selector/definition/link.rb +2 -1
data/lib/capybara/selector/definition.rb +1 -1
data/lib/capybara/selector/filter_set.rb +4 -5
data/lib/capybara/selector/regexp_disassembler.rb +2 -5
data/lib/capybara/selenium/driver.rb +6 -3
data/lib/capybara/selenium/driver_specializations/edge_driver.rb +8 -4
data/lib/capybara/selenium/extensions/html5_drag.rb +5 -4
data/lib/capybara/selenium/logger_suppressor.rb +4 -0
data/lib/capybara/selenium/node.rb +60 -25
data/lib/capybara/selenium/nodes/chrome_node.rb +5 -1
data/lib/capybara/selenium/nodes/edge_node.rb +24 -2
data/lib/capybara/selenium/nodes/firefox_node.rb +2 -2
data/lib/capybara/selenium/nodes/safari_node.rb +2 -2
data/lib/capybara/selenium/patches/action_pauser.rb +3 -3
data/lib/capybara/selenium/patches/atoms.rb +1 -1
data/lib/capybara/selenium/patches/pause_duration_fix.rb +1 -1
data/lib/capybara/server/animation_disabler.rb +21 -22
data/lib/capybara/server/middleware.rb +1 -1
data/lib/capybara/session/config.rb +3 -1
data/lib/capybara/session.rb +11 -9
data/lib/capybara/spec/public/test.js +4 -0
data/lib/capybara/spec/session/all_spec.rb +1 -1
data/lib/capybara/spec/session/attach_file_spec.rb +6 -0
data/lib/capybara/spec/session/check_spec.rb +1 -0
data/lib/capybara/spec/session/click_link_spec.rb +11 -0
data/lib/capybara/spec/session/current_scope_spec.rb +1 -1
data/lib/capybara/spec/session/fill_in_spec.rb +6 -0
data/lib/capybara/spec/session/find_link_spec.rb +10 -0
data/lib/capybara/spec/session/find_spec.rb +2 -2
data/lib/capybara/spec/session/first_spec.rb +1 -1
data/lib/capybara/spec/session/frame/within_frame_spec.rb +2 -0
data/lib/capybara/spec/session/has_all_selectors_spec.rb +5 -5
data/lib/capybara/spec/session/has_ancestor_spec.rb +2 -2
data/lib/capybara/spec/session/has_any_selectors_spec.rb +2 -2
data/lib/capybara/spec/session/has_button_spec.rb +6 -0
data/lib/capybara/spec/session/has_current_path_spec.rb +1 -1
data/lib/capybara/spec/session/has_link_spec.rb +10 -0
data/lib/capybara/spec/session/has_none_selectors_spec.rb +7 -7
data/lib/capybara/spec/session/has_select_spec.rb +6 -0
data/lib/capybara/spec/session/has_text_spec.rb +4 -8
data/lib/capybara/spec/session/matches_style_spec.rb +2 -0
data/lib/capybara/spec/session/node_spec.rb +40 -1
data/lib/capybara/spec/session/reset_session_spec.rb +13 -0
data/lib/capybara/spec/session/scroll_spec.rb +3 -1
data/lib/capybara/spec/session/window/windows_spec.rb +1 -1
data/lib/capybara/spec/session/within_spec.rb +13 -0
data/lib/capybara/spec/spec_helper.rb +8 -2
data/lib/capybara/spec/test_app.rb +25 -6
data/lib/capybara/spec/views/form.erb +17 -0
data/lib/capybara/spec/views/with_html.erb +3 -3
data/lib/capybara/spec/views/with_scope.erb +2 -2
data/lib/capybara/version.rb +1 -1
data/lib/capybara.rb +4 -2
data/spec/capybara_spec.rb +12 -0
data/spec/counter_spec.rb +35 -0
data/spec/css_builder_spec.rb +1 -1
data/spec/css_splitter_spec.rb +1 -1
data/spec/dsl_spec.rb +2 -0
data/spec/minitest_spec.rb +4 -0
data/spec/minitest_spec_spec.rb +4 -0
data/spec/per_session_config_spec.rb +1 -1
data/spec/rack_test_spec.rb +10 -2
data/spec/rspec/scenarios_spec.rb +1 -1
data/spec/rspec/shared_spec_matchers.rb +1 -1
data/spec/rspec_matchers_spec.rb +25 -0
data/spec/rspec_spec.rb +2 -2
data/spec/sauce_spec_chrome.rb +1 -1
data/spec/selector_spec.rb +2 -2
data/spec/selenium_spec_chrome.rb +7 -6
data/spec/selenium_spec_chrome_remote.rb +8 -8
data/spec/selenium_spec_edge.rb +12 -6
data/spec/selenium_spec_firefox.rb +20 -8
data/spec/selenium_spec_firefox_remote.rb +19 -4
data/spec/selenium_spec_ie.rb +4 -2
data/spec/selenium_spec_safari.rb +3 -1
data/spec/server_spec.rb +2 -2
data/spec/shared_selenium_session.rb +5 -5
data/spec/spec_helper.rb +33 -0
data/spec/whitespace_normalizer_spec.rb +54 -0
data/spec/xpath_builder_spec.rb +1 -1
metadata +5 -2

data/lib/capybara/spec/spec_helper.rb CHANGED Viewed

@@ -24,6 +24,7 @@ module Capybara
         Capybara.app_host = nil
         Capybara.default_selector = :xpath
         Capybara.default_max_wait_time = 1
+        Capybara.default_retry_interval = 0.01
         Capybara.ignore_hidden_elements = true
         Capybara.exact = false
         Capybara.raise_server_errors = true
@@ -37,7 +38,7 @@ module Capybara
         Capybara.predicates_wait = true
         Capybara.default_normalize_ws = false
         Capybara.use_html5_parsing = !ENV['HTML5_PARSING'].nil?
-        Capybara.w3c_click_offset = false
+        Capybara.w3c_click_offset = true
         reset_threadsafe
       end
@@ -122,6 +123,11 @@ module Capybara
       YAML.safe_load results, permitted_classes: perms
     end
+    def extract_content_type(session)
+      expect(session).to have_xpath("//pre[@id='content_type']")
+      Capybara::HTML(session.body).xpath("//pre[@id='content_type']").first.text
+    end
     def be_an_invalid_element_error(session)
       satisfy { |error| session.driver.invalid_element_errors.any? { |e| error.is_a? e } }
     end
@@ -132,4 +138,4 @@ module Capybara
   end
 end
-Dir["#{File.dirname(__FILE__)}/session/**/*.rb"].each { |file| require_relative file }
+Dir["#{File.dirname(__FILE__)}/session/**/*.rb"].sort.each { |file| require_relative file }

data/lib/capybara/spec/test_app.rb CHANGED Viewed

@@ -177,6 +177,22 @@ class TestApp < Sinatra::Base
     HTML
   end
+  get '/with_iframe' do
+    <<-HTML
+      <!DOCTYPE html>
+      <html lang="en">
+        <head>
+          <meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
+          <title>Test with Iframe</title>
+        </head>
+        <body>
+          <iframe src="#{params[:url]}" id="#{params[:id]}"></iframe>
+        </body>
+      </html>
+    HTML
+  end
   get '/base/with_base' do
     <<-HTML
       <!DOCTYPE html>
@@ -232,6 +248,10 @@ class TestApp < Sinatra::Base
       'Thomas, Walpole, was , here'
   end
+  get '/apple-touch-icon-precomposed.png' do
+    halt(404)
+  end
   get '/:view' do |view|
     view_template = "#{__dir__}/views/#{view}.erb"
     has_layout = File.exist?(view_template) && File.open(view_template) { |f| f.first.downcase.include?('doctype') }
@@ -240,12 +260,15 @@ class TestApp < Sinatra::Base
   post '/form' do
     self.class.form_post_count += 1
-    %(<pre id="results">#{params[:form].merge('post_count' => self.class.form_post_count).to_yaml}</pre>)
+    %(
+      <pre id="content_type">#{request.content_type}</pre>
+      <pre id="results">#{params.fetch(:form, {}).merge('post_count' => self.class.form_post_count).to_yaml}</pre>
+    )
   end
   post '/upload_empty' do
     if params[:form][:file].nil?
-      'Successfully ignored empty file field.'
+      "Successfully ignored empty file field. Content type was #{request.content_type}"
     else
       'Something went wrong.'
     end
@@ -272,10 +295,6 @@ class TestApp < Sinatra::Base
     'No files uploaded'
   end
-  get '/apple-touch-icon-precomposed.png' do
-    halt(404)
-  end
   class << self
     attr_accessor :form_post_count
   end

data/lib/capybara/spec/views/form.erb CHANGED Viewed

@@ -586,6 +586,19 @@ New line after and before textarea tag
   <p>
 </form>
+<form action="/form" method="post" enctype="multipart/form-data">
+  <input type="hidden" name="form[document2]" value="hidden_field"/>
+  <p>
+    <label for="form_document">Document with hidden</label>
+    <input type="file" name="form[document2]" id="form_document2"/>
+  </p>
+  <p>
+    <input type="submit" value="Upload Empty With Hidden"/>
+  <p>
+</form>
 <form action="/upload_multiple" method="post" enctype="multipart/form-data">
   <p>
     <label for="form_multiple_file_name">File Name</label>
@@ -682,6 +695,10 @@ New line after and before textarea tag
   </p>
 </form>
+<form id="single_input_form" action="/form" method="post">
+  <input type="text" name="form[single_input]" id="single_input"/>
+</form>
 <label>Confusion
   <input type="checkbox" id="confusion_checkbox" class="confusion-checkbox confusion"/>
 </label>

data/lib/capybara/spec/views/with_html.erb CHANGED Viewed

@@ -19,7 +19,7 @@
 <p class="para" id="first" data-random="abc\def" style="line-height: 25px;">
   Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod
-  tempor incididunt ut <a href="/with_simple_html" title="awesome title" class="simple" tabindex="1">labore</a>
+  tempor incididunt ut <a href="/with_simple_html" title="awesome title" class="simple" tabindex="1" target="_self">labore</a>
   et dolore magna aliqua. Ut enim ad minim veniam,
   quis nostrud exercitation <a href="/foo" id="foo" data-test-id="test-foo">ullamco</a> laboris nisi
   ut aliquip ex ea commodo consequat.
@@ -88,7 +88,7 @@ banana</textarea>
 </div>
 <div style="display: none;">
-  <a id="first_invisble" class="hidden">first hidden link</a>
+  <a id="first_invisible" class="hidden">first hidden link</a>
 </div>
 <div style="display: none;">
@@ -138,7 +138,7 @@ banana</textarea>
       Ancestor
       <div id="child">Child</div>
     </div>
-    <div id="ancestor1_sibiling">
+    <div id="ancestor1_sibling">
       ASibling
     </div>
   </div>

data/lib/capybara/spec/views/with_scope.erb CHANGED Viewed

@@ -35,8 +35,8 @@
   </ul>
 </div>
-<div id="another_foo">
+<div id="another_foo" onclick="this.innerHTML = 'I was clicked';">
   <ul>
-    <li>With Simple HTML: <a href="/">Go</a>
+    <li>With Simple HTML: <a href="/">Go</a></li>
   </ul>
 </div>

data/lib/capybara/version.rb CHANGED Viewed

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Capybara
-  VERSION = '3.37.1'
+  VERSION = '3.39.0'
 end

data/lib/capybara.rb CHANGED Viewed

@@ -79,6 +79,7 @@ module Capybara
     # - **automatic_reload** (Boolean = `true`) - Whether to automatically reload elements as Capybara is waiting.
     # - **default_max_wait_time** (Numeric = `2`) - The maximum number of seconds to wait for asynchronous processes to finish.
     # - **default_normalize_ws** (Boolean = `false`) - Whether text predicates and matchers use normalize whitespace behavior.
+    # - **default_retry_interval** (Numeric = `0.01`) - The number of seconds to delay the next check in asynchronous processes.
     # - **default_selector** (`:css`, `:xpath` = `:css`) - Methods which take a selector use the given type by default. See also {Capybara::Selector}.
     # - **default_set_options** (Hash = `{}`) - The default options passed to {Capybara::Node::Element#set Element#set}.
     # - **enable_aria_label** (Boolean = `false`) - Whether fields, links, and buttons will match against `aria-label` attribute.
@@ -101,7 +102,7 @@ module Capybara
     #   and {configure raise_server_errors} is `true`.
     # - **test_id** (Symbol, String, `nil` = `nil`) - Optional attribute to match locator against with built-in selectors along with id.
     # - **threadsafe** (Boolean = `false`) - Whether sessions can be configured individually.
-    # - **w3c_click_offset** (Boolean = 'false') - Whether click offsets should be from element center (true) or top left (false)
+    # - **w3c_click_offset** (Boolean = 'true') - Whether click offsets should be from element center (true) or top left (false)
     #
     # #### DSL Options
     #
@@ -496,6 +497,7 @@ Capybara.configure do |config|
   config.server = :default
   config.default_selector = :css
   config.default_max_wait_time = 2
+  config.default_retry_interval = 0.01
   config.ignore_hidden_elements = true
   config.default_host = 'http://www.example.com'
   config.automatic_reload = true
@@ -514,5 +516,5 @@ Capybara.configure do |config|
   config.predicates_wait = true
   config.default_normalize_ws = false
   config.use_html5_parsing = false
-  config.w3c_click_offset = false
+  config.w3c_click_offset = true
 end

data/spec/capybara_spec.rb CHANGED Viewed

@@ -15,6 +15,18 @@ RSpec.describe Capybara do
     end
   end
+  describe 'default_retry_interval' do
+    before { @previous_default_interval = described_class.default_retry_interval }
+    after { described_class.default_retry_interval = @previous_default_interval } # rubocop:disable RSpec/InstanceVariable
+    it 'should be changeable' do
+      expect(described_class.default_retry_interval).not_to eq(0.1)
+      described_class.default_retry_interval = 0.1
+      expect(described_class.default_retry_interval).to eq(0.1)
+    end
+  end
   describe '.register_driver' do
     it 'should add a new driver' do
       described_class.register_driver :schmoo do |app|

data/spec/counter_spec.rb ADDED Viewed

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+require 'spec_helper'
+RSpec.describe Capybara::Server::Middleware::Counter do
+  let(:counter) { described_class.new }
+  let(:uri) { '/example' }
+  describe '#increment' do
+    it 'successfully' do
+      counter.increment(uri)
+      expect(counter).to be_positive
+    end
+  end
+  describe '#decrement' do
+    before do
+      counter.increment(uri)
+    end
+    context 'successfully' do
+      it 'with same uri' do
+        expect(counter).to be_positive
+        counter.decrement(uri)
+        expect(counter).not_to be_positive
+      end
+      it 'with changed uri' do
+        expect(counter).to be_positive
+        counter.decrement('/')
+        expect(counter).not_to be_positive
+      end
+    end
+  end
+end

data/spec/css_builder_spec.rb CHANGED Viewed

@@ -5,7 +5,7 @@ require 'spec_helper'
 # rubocop:disable RSpec/InstanceVariable
 RSpec.describe Capybara::Selector::CSSBuilder do
   let :builder do
-    ::Capybara::Selector::CSSBuilder.new(@css)
+    described_class.new(@css)
   end
   context 'add_attribute_conditions' do

data/spec/css_splitter_spec.rb CHANGED Viewed

@@ -4,7 +4,7 @@ require 'spec_helper'
 RSpec.describe Capybara::Selector::CSS::Splitter do
   let :splitter do
-    ::Capybara::Selector::CSS::Splitter.new
+    described_class.new
   end
   context 'split not needed' do

data/spec/dsl_spec.rb CHANGED Viewed

@@ -15,6 +15,8 @@ Capybara::SpecHelper.run_specs TestClass.new, 'DSL', capybara_skip: %i[
     pending "Nokogiri doesn't support case insensitive CSS attribute matchers"
   when /#click_button should follow permanent redirects that maintain method/
     pending "Rack < 2 doesn't support 308" if Gem.loaded_specs['rack'].version < Gem::Version.new('2.0.0')
+  when /#attach_file with multipart form should send prior hidden field if no file submitted/
+    skip 'Rack-test < 2 needs an empty file to detect multipart form' if Gem.loaded_specs['rack-test'].version < Gem::Version.new('2.0.0')
   end
 end

data/spec/minitest_spec.rb CHANGED Viewed

@@ -15,6 +15,10 @@ class MinitestTest < Minitest::Test
     Capybara.reset_sessions!
   end
+  def self.test_order
+    :sorted
+  end
   def test_assert_text
     assert_text('Form', normalize_ws: false)
     assert_no_text('Not on the page')

data/spec/minitest_spec_spec.rb CHANGED Viewed

@@ -16,6 +16,10 @@ class MinitestSpecTest < Minitest::Spec
     Capybara.reset_sessions!
   end
+  def self.test_order
+    :sorted
+  end
   it 'supports text expectations' do
     _(page).must_have_text('Form', minimum: 1)
     _(page).wont_have_text('Not a form')

data/spec/per_session_config_spec.rb CHANGED Viewed

@@ -12,7 +12,7 @@ RSpec.describe Capybara::SessionConfig do
          default_selector default_max_wait_time ignore_hidden_elements
          automatic_reload match exact raise_server_errors visible_text_only
          automatic_label_click enable_aria_label save_path
-         asset_host].each do |m|
+         asset_host default_retry_interval].each do |m|
            expect(session.config.public_send(m)).to eq Capybara.public_send(m)
          end
     end

data/spec/rack_test_spec.rb CHANGED Viewed

@@ -30,6 +30,8 @@ Capybara::SpecHelper.run_specs TestSessions::RackTest, 'RackTest', capybara_skip
     skip "Nokogiri doesn't support case insensitive CSS attribute matchers"
   when /#click_button should follow permanent redirects that maintain method/
     skip "Rack < 2 doesn't support 308" if Gem.loaded_specs['rack'].version < Gem::Version.new('2.0.0')
+  when /#attach_file with multipart form should send prior hidden field if no file submitted/
+    skip 'Rack-test < 2 needs an empty file to detect multipart form' if Gem.loaded_specs['rack-test'].version < Gem::Version.new('2.0.0')
   end
 end
@@ -93,6 +95,12 @@ RSpec.describe Capybara::Session do # rubocop:disable RSpec/MultipleDescribes
           session.click_button('Upload Empty')
           expect(session.html).to include('Successfully ignored empty file field.')
         end
+        it 'should submit multipart even if no file is submitted' do
+          session.visit('/form')
+          session.click_button('Upload Empty')
+          expect(session.html).to include('Content type was multipart/form-data;')
+        end
       end
       it 'should not submit an obsolete mime type' do
@@ -212,7 +220,7 @@ RSpec.describe Capybara::RackTest::Driver do
       driver = described_class.new(TestApp)
       driver.visit('/redirect')
-      expect(driver.response.header['Location']).to be_nil
+      expect(driver.response.headers['Location']).to be_nil
       expect(driver.current_url).to match %r{/landed$}
     end
@@ -226,7 +234,7 @@ RSpec.describe Capybara::RackTest::Driver do
       driver = described_class.new(TestApp, follow_redirects: false)
       driver.visit('/redirect')
-      expect(driver.response.header['Location']).to match %r{/redirect_again$}
+      expect(driver.response.headers['Location']).to match %r{/redirect_again$}
       expect(driver.current_url).to match %r{/redirect$}
     end
   end

data/spec/rspec/scenarios_spec.rb CHANGED Viewed

@@ -16,7 +16,7 @@ feature 'if fscenario aliases focused tag then' do
 end
 feature 'if xscenario aliases to pending then' do
-  xscenario "this test should be 'temporarily disabled with xscenario'" do
+  xscenario "this test should be 'temporarily disabled with xscenario'" do # rubocop:disable RSpec/PendingWithoutReason
   end
 end

data/spec/rspec/shared_spec_matchers.rb CHANGED Viewed

@@ -120,7 +120,7 @@ RSpec.shared_examples Capybara::RSpecMatchers do |session, _mode|
   describe 'have_xpath matcher' do
     it 'gives proper description' do
-      expect(have_xpath('//h1').description).to eq("have visible xpath \"\/\/h1\"")
+      expect(have_xpath('//h1').description).to eq('have visible xpath "//h1"')
     end
     context 'on a string' do

data/spec/rspec_matchers_spec.rb CHANGED Viewed

@@ -56,6 +56,31 @@ RSpec.describe 'Capybara RSpec Matchers', type: :feature do
     end
   end
+  context 'with a filter block' do
+    it 'applies the filter' do
+      visit('/with_html')
+      expect(page).to have_selector(:css, 'input#test_field')
+      expect(page).to have_selector(:css, 'input', count: 1) { |input| input.value == 'monkey' }
+      expect(page).to have_selector(:css, 'input', count: 1) do |input|
+        input.value == 'monkey'
+      end
+      expect(page).to have_no_selector(:css, 'input#test_field') { |input| input.value == 'not a monkey' }
+      expect(page).to have_no_selector(:css, 'input#test_field') do |input|
+        input.value == 'not a monkey'
+      end
+      expect(page).not_to have_selector(:css, 'input#test_field') { |input| input.value == 'not a monkey' }
+      expect(page).not_to have_selector(:css, 'input#test_field') do |input|
+        input.value == 'not a monkey'
+      end
+      expect(page).not_to have_no_selector(:css, 'input', count: 1) { |input| input.value == 'monkey' }
+      expect(page).not_to have_no_selector(:css, 'input#test_field', count: 1) do |input|
+        input.value == 'monkey'
+      end
+    end
+  end
   def error_msg_for(&block)
     expect(&block).to(raise_error { |e| return e.message })
   end

data/spec/rspec_spec.rb CHANGED Viewed

@@ -15,7 +15,7 @@ RSpec.describe 'capybara/rspec' do
       expect(self.class.ancestors).to include Capybara::RSpecMatcherProxies
     end
-    context 'resetting session' do
+    context 'resetting session', order: :defined do
       it 'sets a cookie in one example...' do
         visit('/set_cookie')
         expect(page.body).to include('Cookie set to test_cookie')
@@ -27,7 +27,7 @@ RSpec.describe 'capybara/rspec' do
       end
     end
-    context 'setting the current driver' do
+    context 'setting the current driver', order: :defined do
       it 'sets the current driver in one example...' do
         Capybara.current_driver = :selenium
       end

data/spec/sauce_spec_chrome.rb CHANGED Viewed

@@ -27,7 +27,7 @@ Capybara.register_driver :sauce_chrome do |app|
   Capybara::Selenium::Driver.new(app,
                                  browser: :remote, url: url,
-                                 desired_capabilities: capabilities,
+                                 capabilities: capabilities,
                                  options: Selenium::WebDriver::Chrome::Options.new(args: ['']))
 end

data/spec/selector_spec.rb CHANGED Viewed

@@ -111,13 +111,13 @@ RSpec.describe Capybara do
     end
     describe 'adding a selector' do
-      it 'can set default visiblity' do
+      it 'can set default visibility' do
         described_class.add_selector :hidden_field do
           visible :hidden
           css { |_sel| 'input[type="hidden"]' }
         end
-        expect(string).to have_no_css('input[type="hidden"]')
+        expect(string).to have_no_css('input[type="hidden"]') # rubocop:disable RSpec/Capybara/SpecificMatcher
         expect(string).to have_selector(:hidden_field)
       end
     end

data/spec/selenium_spec_chrome.rb CHANGED Viewed

@@ -10,8 +10,8 @@ CHROME_DRIVER = :selenium_chrome
 Selenium::WebDriver::Chrome.path = '/usr/bin/google-chrome-beta' if ENV.fetch('CI', nil) && ENV.fetch('CHROME_BETA', nil)
-browser_options = ::Selenium::WebDriver::Chrome::Options.new
-browser_options.headless! if ENV['HEADLESS']
+browser_options = Selenium::WebDriver::Chrome::Options.new
+browser_options.add_argument('--headless') if ENV['HEADLESS']
 # Chromedriver 77 requires setting this for headless mode on linux
 # Different versions of Chrome/selenium-webdriver require setting differently - jus set them all
@@ -85,6 +85,11 @@ Capybara::SpecHelper.run_specs TestSessions::Chrome, CHROME_DRIVER.to_s, capybar
     skip 'Need to figure out testing of file downloading on windows platform' if Gem.win_platform?
   when /Capybara::Session selenium_chrome Capybara::Window#maximize/
     pending "Chrome headless doesn't support maximize" if ENV['HEADLESS']
+  when /Capybara::Session selenium_chrome node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
+  when /Capybara::Session selenium_chrome node #shadow_root/
+    skip 'Not supported with this Selenium version' if selenium_lt?('4.1', @session)
+    skip 'Not supported with this chromedriver version' if chromedriver_lt?('96.0', @session)
   end
 end
@@ -199,8 +204,4 @@ RSpec.describe 'Capybara::Session with chrome' do
       end.not_to raise_error
     end
   end
-  def chromedriver_version
-    Gem::Version.new(session.driver.browser.capabilities['chrome']['chromedriverVersion'].split[0])
-  end
 end

data/spec/selenium_spec_chrome_remote.rb CHANGED Viewed

@@ -21,8 +21,8 @@ def ensure_selenium_running!
   rescue StandardError
     if timer.expired?
       raise 'Selenium is not running. ' \
-            "You can run a selenium server easily with: \n" \
-            '  $ docker-compose up -d selenium_chrome'
+            "You can run a selenium server easily with: \n  " \
+            '$ docker-compose up -d selenium_chrome'
     else
       puts 'Waiting for Selenium docker instance...'
       sleep 1
@@ -39,11 +39,10 @@ Capybara.register_driver :selenium_chrome_remote do |app|
   ensure_selenium_running!
   url = "http://#{selenium_host}:#{selenium_port}/wd/hub"
-  browser_options = ::Selenium::WebDriver::Chrome::Options.new
+  browser_options = Selenium::WebDriver::Chrome::Options.new
   Capybara::Selenium::Driver.new app,
                                  browser: :remote,
-                                 desired_capabilities: :chrome,
                                  options: browser_options,
                                  url: url
 end
@@ -62,6 +61,11 @@ Capybara::SpecHelper.run_specs TestSessions::Chrome, CHROME_REMOTE_DRIVER.to_s,
        'Capybara::Session selenium_chrome_remote #attach_file with multipart form should fire change once for each set of files uploaded',
        'Capybara::Session selenium_chrome_remote #attach_file with multipart form should fire change once when uploading multiple files from empty'
     pending "Selenium with Remote Chrome doesn't support multiple file upload" unless selenium_gte?(3.14)
+  when /Capybara::Session selenium_chrome_remote node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
+  when /Capybara::Session selenium_chrome_remote node #shadow_root/
+    skip 'Not supported with this Selenium version' if selenium_lt?('4.1', @session)
+    skip 'Not supported with this chromedriver version' if chromedriver_lt?('96.0', @session)
   end
 end
@@ -94,8 +98,4 @@ RSpec.describe 'Capybara::Session with remote Chrome' do
       end.not_to raise_error
     end
   end
-  def chromedriver_version
-    Gem::Version.new(session.driver.browser.capabilities['chrome']['chromedriverVersion'].split[0])
-  end
 end

data/spec/selenium_spec_edge.rb CHANGED Viewed

@@ -10,15 +10,17 @@ require 'rspec/shared_spec_matchers'
 #   Selenium::WebDriver::Edge::Service.driver_path = '/usr/local/bin/msedgedriver'
 # end
-if ::Selenium::WebDriver::Platform.mac?
-  Selenium::WebDriver::EdgeChrome.path = '/Applications/Microsoft Edge Dev.app/Contents/MacOS/Microsoft Edge Dev'
+if Selenium::WebDriver::Platform.mac?
+  Selenium::WebDriver::Edge.path = '/Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge'
 end
 Capybara.register_driver :selenium_edge do |app|
   # ::Selenium::WebDriver.logger.level = "debug"
   # If we don't create an options object the path set above won't be used
-  browser_options = ::Selenium::WebDriver::EdgeChrome::Options.new
-  Capybara::Selenium::Driver.new(app, browser: :edge_chrome, options: browser_options).tap do |driver|
+  browser_options = Selenium::WebDriver::Edge::Options.new
+  browser_options.add_argument('--headless') if ENV['HEADLESS']
+  Capybara::Selenium::Driver.new(app, browser: :edge, options: browser_options).tap do |driver|
     driver.browser
     driver.download_path = Capybara.save_path
   end
@@ -30,12 +32,16 @@ end
 skipped_tests = %i[response_headers status_code trigger]
-Capybara::SpecHelper.log_selenium_driver_version(Selenium::WebDriver::EdgeChrome) if ENV['CI']
+Capybara::SpecHelper.log_selenium_driver_version(Selenium::WebDriver::Edge) if ENV['CI']
 Capybara::SpecHelper.run_specs TestSessions::SeleniumEdge, 'selenium', capybara_skip: skipped_tests do |example|
   case example.metadata[:full_description]
   when 'Capybara::Session selenium #attach_file with a block can upload by clicking the file input'
-    pending "EdgeChrome doesn't allow clicking on file inputs"
+    pending "Edge doesn't allow clicking on file inputs"
+  when /Capybara::Session selenium node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
+  when /Capybara::Session selenium Capybara::Window#maximize/
+    pending "Edge headless doesn't support maximize" if ENV['HEADLESS']
   end
 end

data/spec/selenium_spec_firefox.rb CHANGED Viewed

@@ -6,7 +6,7 @@ require 'shared_selenium_session'
 require 'shared_selenium_node'
 require 'rspec/shared_spec_matchers'
-browser_options = ::Selenium::WebDriver::Firefox::Options.new
+browser_options = Selenium::WebDriver::Firefox::Options.new
 browser_options.headless! if ENV['HEADLESS']
 # browser_options.add_option("log", {"level": "trace"})
@@ -62,20 +62,32 @@ Capybara::SpecHelper.run_specs TestSessions::SeleniumFirefox, 'selenium', capyba
   when 'Capybara::Session selenium #accept_confirm should work with nested modals'
     skip 'Broken in 63 <= FF < 69 - https://bugzilla.mozilla.org/show_bug.cgi?id=1487358' if firefox_gte?(63, @session) && firefox_lt?(69, @session)
     skip 'Hangs in 69 <= FF < 71 - Dont know what issue for this - previous issue was closed as fixed but it is not' if firefox_gte?(69, @session) && firefox_lt?(71, @session)
-    skip 'Broken again intermittently in FF 71 - jus skip it'
+    skip 'Broken again intermittently in FF 71 - jus skip it' if firefox_lt?(109, @session) # don't really know when it was fixed
   when 'Capybara::Session selenium #click_link can download a file'
     skip 'Need to figure out testing of file downloading on windows platform' if Gem.win_platform?
   when 'Capybara::Session selenium #reset_session! removes ALL cookies'
     pending "Geckodriver doesn't provide a way to remove cookies outside the current domain"
   when /drag_to.*HTML5/
-    pending "Firefox < 62 doesn't support a DataTransfer constuctor" if firefox_lt?(62.0, @session)
+    pending "Firefox < 62 doesn't support a DataTransfer constructor" if firefox_lt?(62.0, @session)
   when 'Capybara::Session selenium #accept_alert should handle the alert if the page changes',
        'Capybara::Session selenium #accept_alert with an asynchronous alert should accept the alert'
-    skip 'No clue what Firefox is doing here - works fine on MacOS locally'
-  when 'Capybara::Session selenium node #shadow_root should get the shadow root',
-       'Capybara::Session selenium node #shadow_root should find elements inside the shadow dom using CSS',
-       'Capybara::Session selenium node #shadow_root should find nested shadow roots'
-    pending "Firefox doesn't yet have W3C shadow root support"
+    skip 'No clue what Firefox is doing here - works fine on MacOS locally' if firefox_lt?(109, @session) # don't really know when it was fixed
+  when 'Capybara::Session selenium node #shadow_root should find elements inside the shadow dom using CSS',
+       'Capybara::Session selenium node #shadow_root should find nested shadow roots',
+       'Capybara::Session selenium node #shadow_root should click on elements',
+       'Capybara::Session selenium node #shadow_root should use convenience methods once moved to a descendant of the shadow root',
+       'Capybara::Session selenium node #shadow_root should produce error messages when failing',
+       'Capybara::Session with firefox with selenium driver #evaluate_script returns a shadow root'
+    pending "Firefox doesn't yet have full W3C shadow root support"
+  when 'Capybara::Session selenium #fill_in should handle carriage returns with line feeds in a textarea correctly'
+    pending 'Not sure what firefox is doing here'
+  when /Capybara::Session selenium node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
+  when /Capybara::Session selenium node #shadow_root/
+    skip 'Not supported with this Selenium version' if selenium_lt?('4.1', @session)
+    skip 'Not supported with this geckodriver version' if geckodriver_lt?('0.31.0', @session)
+  when /Capybara::Session selenium node #set should submit single text input forms if ended with \\n/
+    pending 'Firefox/geckodriver doesn\'t submit with values ending in \n'
   end
 end