capybara 3.37.1 → 3.38.0

data/spec/dsl_spec.rb

@@ -15,6 +15,8 @@ Capybara::SpecHelper.run_specs TestClass.new, 'DSL', capybara_skip: %i[
     pending "Nokogiri doesn't support case insensitive CSS attribute matchers"
   when /#click_button should follow permanent redirects that maintain method/
     pending "Rack < 2 doesn't support 308" if Gem.loaded_specs['rack'].version < Gem::Version.new('2.0.0')
+  when /#attach_file with multipart form should send prior hidden field if no file submitted/
+    skip 'Rack-test < 2 needs an empty file to detect multipart form' if Gem.loaded_specs['rack-test'].version < Gem::Version.new('2.0.0')
   end
 end
 

data/spec/minitest_spec.rb

@@ -15,6 +15,10 @@ class MinitestTest < Minitest::Test
     Capybara.reset_sessions!
   end
 
+  def self.test_order
+    :sorted
+  end
+
   def test_assert_text
     assert_text('Form', normalize_ws: false)
     assert_no_text('Not on the page')

data/spec/minitest_spec_spec.rb

@@ -16,6 +16,10 @@ class MinitestSpecTest < Minitest::Spec
     Capybara.reset_sessions!
   end
 
+  def self.test_order
+    :sorted
+  end
+
   it 'supports text expectations' do
     _(page).must_have_text('Form', minimum: 1)
     _(page).wont_have_text('Not a form')

data/spec/per_session_config_spec.rb

@@ -12,7 +12,7 @@ RSpec.describe Capybara::SessionConfig do
          default_selector default_max_wait_time ignore_hidden_elements
          automatic_reload match exact raise_server_errors visible_text_only
          automatic_label_click enable_aria_label save_path
-         asset_host].each do |m|
+         asset_host default_retry_interval].each do |m|
            expect(session.config.public_send(m)).to eq Capybara.public_send(m)
          end
     end

data/spec/rack_test_spec.rb

@@ -30,6 +30,8 @@ Capybara::SpecHelper.run_specs TestSessions::RackTest, 'RackTest', capybara_skip
     skip "Nokogiri doesn't support case insensitive CSS attribute matchers"
   when /#click_button should follow permanent redirects that maintain method/
     skip "Rack < 2 doesn't support 308" if Gem.loaded_specs['rack'].version < Gem::Version.new('2.0.0')
+  when /#attach_file with multipart form should send prior hidden field if no file submitted/
+    skip 'Rack-test < 2 needs an empty file to detect multipart form' if Gem.loaded_specs['rack-test'].version < Gem::Version.new('2.0.0')
   end
 end
 
@@ -93,6 +95,12 @@ RSpec.describe Capybara::Session do # rubocop:disable RSpec/MultipleDescribes
           session.click_button('Upload Empty')
           expect(session.html).to include('Successfully ignored empty file field.')
         end
+
+        it 'should submit multipart even if no file is submitted' do
+          session.visit('/form')
+          session.click_button('Upload Empty')
+          expect(session.html).to include('Content type was multipart/form-data;')
+        end
       end
 
       it 'should not submit an obsolete mime type' do

data/spec/rspec/shared_spec_matchers.rb

@@ -120,7 +120,7 @@ RSpec.shared_examples Capybara::RSpecMatchers do |session, _mode|
 
   describe 'have_xpath matcher' do
     it 'gives proper description' do
-      expect(have_xpath('//h1').description).to eq("have visible xpath \"\/\/h1\"")
+      expect(have_xpath('//h1').description).to eq('have visible xpath "//h1"')
     end
 
     context 'on a string' do

data/spec/rspec_spec.rb

@@ -15,7 +15,7 @@ RSpec.describe 'capybara/rspec' do
       expect(self.class.ancestors).to include Capybara::RSpecMatcherProxies
     end
 
-    context 'resetting session' do
+    context 'resetting session', order: :defined do
       it 'sets a cookie in one example...' do
         visit('/set_cookie')
         expect(page.body).to include('Cookie set to test_cookie')
@@ -27,7 +27,7 @@ RSpec.describe 'capybara/rspec' do
       end
     end
 
-    context 'setting the current driver' do
+    context 'setting the current driver', order: :defined do
       it 'sets the current driver in one example...' do
         Capybara.current_driver = :selenium
       end

data/spec/selector_spec.rb

@@ -111,13 +111,13 @@ RSpec.describe Capybara do
     end
 
     describe 'adding a selector' do
-      it 'can set default visiblity' do
+      it 'can set default visibility' do
         described_class.add_selector :hidden_field do
           visible :hidden
           css { |_sel| 'input[type="hidden"]' }
         end
 
-        expect(string).to have_no_css('input[type="hidden"]')
+        expect(string).to have_no_css('input[type="hidden"]') # rubocop:disable RSpec/Capybara/SpecificMatcher
         expect(string).to have_selector(:hidden_field)
       end
     end

data/spec/selenium_spec_chrome.rb

@@ -85,6 +85,8 @@ Capybara::SpecHelper.run_specs TestSessions::Chrome, CHROME_DRIVER.to_s, capybar
     skip 'Need to figure out testing of file downloading on windows platform' if Gem.win_platform?
   when /Capybara::Session selenium_chrome Capybara::Window#maximize/
     pending "Chrome headless doesn't support maximize" if ENV['HEADLESS']
+  when /Capybara::Session selenium_chrome node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
   end
 end
 

data/spec/selenium_spec_chrome_remote.rb

@@ -21,8 +21,8 @@ def ensure_selenium_running!
   rescue StandardError
     if timer.expired?
       raise 'Selenium is not running. ' \
-            "You can run a selenium server easily with: \n" \
-            '  $ docker-compose up -d selenium_chrome'
+            "You can run a selenium server easily with: \n  " \
+            '$ docker-compose up -d selenium_chrome'
     else
       puts 'Waiting for Selenium docker instance...'
       sleep 1
@@ -62,6 +62,8 @@ Capybara::SpecHelper.run_specs TestSessions::Chrome, CHROME_REMOTE_DRIVER.to_s,
        'Capybara::Session selenium_chrome_remote #attach_file with multipart form should fire change once for each set of files uploaded',
        'Capybara::Session selenium_chrome_remote #attach_file with multipart form should fire change once when uploading multiple files from empty'
     pending "Selenium with Remote Chrome doesn't support multiple file upload" unless selenium_gte?(3.14)
+  when /Capybara::Session selenium_chrome node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
   end
 end
 

data/spec/selenium_spec_edge.rb

@@ -36,6 +36,8 @@ Capybara::SpecHelper.run_specs TestSessions::SeleniumEdge, 'selenium', capybara_
   case example.metadata[:full_description]
   when 'Capybara::Session selenium #attach_file with a block can upload by clicking the file input'
     pending "EdgeChrome doesn't allow clicking on file inputs"
+  when /Capybara::Session selenium_chrome node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
   end
 end
 

data/spec/selenium_spec_firefox.rb

@@ -68,14 +68,20 @@ Capybara::SpecHelper.run_specs TestSessions::SeleniumFirefox, 'selenium', capyba
   when 'Capybara::Session selenium #reset_session! removes ALL cookies'
     pending "Geckodriver doesn't provide a way to remove cookies outside the current domain"
   when /drag_to.*HTML5/
-    pending "Firefox < 62 doesn't support a DataTransfer constuctor" if firefox_lt?(62.0, @session)
+    pending "Firefox < 62 doesn't support a DataTransfer constructor" if firefox_lt?(62.0, @session)
   when 'Capybara::Session selenium #accept_alert should handle the alert if the page changes',
        'Capybara::Session selenium #accept_alert with an asynchronous alert should accept the alert'
     skip 'No clue what Firefox is doing here - works fine on MacOS locally'
-  when 'Capybara::Session selenium node #shadow_root should get the shadow root',
-       'Capybara::Session selenium node #shadow_root should find elements inside the shadow dom using CSS',
-       'Capybara::Session selenium node #shadow_root should find nested shadow roots'
-    pending "Firefox doesn't yet have W3C shadow root support"
+  when 'Capybara::Session selenium node #shadow_root should find elements inside the shadow dom using CSS',
+       'Capybara::Session selenium node #shadow_root should find nested shadow roots',
+       'Capybara::Session selenium node #shadow_root should click on elements',
+       'Capybara::Session selenium node #shadow_root should use convenience methods once moved to a descendant of the shadow root',
+       'Capybara::Session with firefox with selenium driver #evaluate_script returns a shadow root'
+    pending "Firefox doesn't yet have full W3C shadow root support"
+  when 'Capybara::Session selenium #fill_in should handle carriage returns with line feeds in a textarea correctly'
+    pending 'Not sure what firefox is doing here'
+  when /Capybara::Session selenium_chrome node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
   end
 end
 

data/spec/selenium_spec_firefox_remote.rb

@@ -21,8 +21,8 @@ def ensure_selenium_running!
   rescue StandardError
     if timer.expired?
       raise 'Selenium is not running. ' \
-            "You can run a selenium server easily with: \n" \
-            '  $ docker-compose up -d selenium_firefox'
+            "You can run a selenium server easily with: \n. " \
+            '$ docker-compose up -d selenium_firefox'
     else
       puts 'Waiting for Selenium docker instance...'
       sleep 1
@@ -65,6 +65,8 @@ Capybara::SpecHelper.run_specs TestSessions::RemoteFirefox, FIREFOX_REMOTE_DRIVE
   when /#accept_confirm should work with nested modals$/
     # skip because this is timing based and hence flaky when set to pending
     skip 'Broken in FF 63 - https://bugzilla.mozilla.org/show_bug.cgi?id=1487358' if firefox_gte?(63, @session)
+  when /Capybara::Session selenium_chrome node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
   end
 end
 

data/spec/selenium_spec_ie.rb

@@ -103,11 +103,13 @@ Capybara::SpecHelper.run_specs TestSessions::SeleniumIE, 'selenium', capybara_sk
   when /#attach_file with a block/
     skip 'Hangs IE testing for unknown reason'
   when /drag_to.*HTML5/
-    pending "IE doesn't support a DataTransfer constuctor"
+    pending "IE doesn't support a DataTransfer constructor"
   when /template elements should not be visible/
     skip "IE doesn't support template elements"
   when /Element#drop/
     pending "IE doesn't support DataTransfer constructor"
+  when /Capybara::Session selenium_chrome node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
   end
 end
 

data/spec/selenium_spec_safari.rb

@@ -88,6 +88,8 @@ Capybara::SpecHelper.run_specs TestSessions::Safari, SAFARI_DRIVER.to_s, capybar
     'Capybara::Session selenium node #shadow_root should find elements inside the shadow dom using CSS',
     'Capybara::Session selenium node #shadow_root should find nested shadow roots'
     pending "Safari doesn't yet have W3C shadow root support"
+  when /Capybara::Session selenium_chrome node #shadow_root should get visible text/
+    pending "Selenium doesn't currently support getting visible text for shadow root elements"
   end
 end
 

data/spec/shared_selenium_session.rb

@@ -281,6 +281,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       end
 
       it 'returns a shadow root' do
+        pending "Geckodriver doesn't fully support shadow root yet" if firefox?(session)
         session.visit('/with_shadow')
         shadow = session.find(:css, '#shadow_host')
         element = session.evaluate_script('arguments[0].shadowRoot', shadow)
@@ -346,14 +347,12 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
         pending "Headless Chrome doesn't support directory upload - https://bugs.chromium.org/p/chromedriver/issues/detail?id=2521&q=directory%20upload&colspec=ID%20Status%20Pri%20Owner%20Summary" if chrome?(session) && ENV.fetch('HEADLESS', nil)
         pending "IE doesn't support uploading a directory" if ie?(session)
         pending 'Chrome/chromedriver 73 breaks this' if chrome?(session) && chrome_gte?(73, session) && chrome_lt?(75, session)
-        pending "Safari doesn't support uploading a directory" if safari?(session)
-        # pending "Edge/msedgedriver doesn't support directory upload" if edge?(session) && edge_gte?(75, session)
 
         session.visit('/form')
         test_file_dir = File.expand_path('./fixtures', File.dirname(__FILE__))
         session.attach_file('Directory Upload', test_file_dir)
         session.click_button('Upload Multiple')
-        expect(session.body).to include('5 | ') # number of files
+        expect(session).to have_text('5 | ') # number of files
       end
 
       it 'can attach a relative file' do
@@ -362,7 +361,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
         session.visit('/form')
         session.attach_file('Single Document', 'spec/fixtures/capybara.csv')
         session.click_button('Upload Single')
-        expect(session.body).to include('Content-type: text/csv')
+        expect(session).to have_text('Content-type: text/csv')
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara
 version: !ruby/object:Gem::Version
-  version: 3.37.1
+  version: 3.38.0
 platform: ruby
 authors:
 - Thomas Walpole
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-09 00:00:00.000000000 Z
+date: 2022-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -745,6 +745,7 @@ files:
 - lib/capybara/window.rb
 - spec/basic_node_spec.rb
 - spec/capybara_spec.rb
+- spec/counter_spec.rb
 - spec/css_builder_spec.rb
 - spec/css_splitter_spec.rb
 - spec/dsl_spec.rb