RubyGems - capybara - Versions diffs - 3.35.0 → 3.40.0 - Mend

capybara 3.35.0 → 3.40.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (184) hide show

checksums.yaml +4 -4
data/History.md +168 -5
data/README.md +199 -39
data/lib/capybara/config.rb +16 -4
data/lib/capybara/driver/base.rb +4 -0
data/lib/capybara/driver/node.rb +5 -1
data/lib/capybara/dsl.rb +4 -10
data/lib/capybara/helpers.rb +9 -14
data/lib/capybara/minitest/spec.rb +18 -6
data/lib/capybara/minitest.rb +14 -1
data/lib/capybara/node/actions.rb +14 -9
data/lib/capybara/node/base.rb +2 -1
data/lib/capybara/node/document.rb +2 -2
data/lib/capybara/node/element.rb +13 -2
data/lib/capybara/node/finders.rb +11 -2
data/lib/capybara/node/matchers.rb +25 -0
data/lib/capybara/node/simple.rb +5 -1
data/lib/capybara/node/whitespace_normalizer.rb +81 -0
data/lib/capybara/queries/active_element_query.rb +18 -0
data/lib/capybara/queries/ancestor_query.rb +2 -1
data/lib/capybara/queries/base_query.rb +2 -2
data/lib/capybara/queries/current_path_query.rb +1 -1
data/lib/capybara/queries/selector_query.rb +40 -11
data/lib/capybara/queries/sibling_query.rb +2 -1
data/lib/capybara/queries/text_query.rb +1 -1
data/lib/capybara/rack_test/browser.rb +64 -8
data/lib/capybara/rack_test/driver.rb +4 -4
data/lib/capybara/rack_test/form.rb +29 -7
data/lib/capybara/rack_test/node.rb +32 -33
data/lib/capybara/registration_container.rb +2 -5
data/lib/capybara/registrations/drivers.rb +7 -7
data/lib/capybara/registrations/servers.rb +37 -16
data/lib/capybara/result.rb +2 -2
data/lib/capybara/rspec/matcher_proxies.rb +6 -6
data/lib/capybara/rspec/matchers/base.rb +8 -6
data/lib/capybara/rspec/matchers/compound.rb +1 -1
data/lib/capybara/rspec/matchers/have_selector.rb +9 -17
data/lib/capybara/rspec/matchers.rb +21 -16
data/lib/capybara/selector/builders/css_builder.rb +1 -1
data/lib/capybara/selector/builders/xpath_builder.rb +1 -1
data/lib/capybara/selector/css.rb +6 -6
data/lib/capybara/selector/definition/button.rb +10 -5
data/lib/capybara/selector/definition/checkbox.rb +1 -1
data/lib/capybara/selector/definition/file_field.rb +1 -1
data/lib/capybara/selector/definition/fillable_field.rb +1 -1
data/lib/capybara/selector/definition/link.rb +2 -1
data/lib/capybara/selector/definition/radio_button.rb +1 -1
data/lib/capybara/selector/definition/table.rb +1 -1
data/lib/capybara/selector/definition/table_row.rb +2 -2
data/lib/capybara/selector/definition.rb +4 -2
data/lib/capybara/selector/filter_set.rb +4 -7
data/lib/capybara/selector/regexp_disassembler.rb +2 -5
data/lib/capybara/selector/selector.rb +5 -1
data/lib/capybara/selector.rb +252 -0
data/lib/capybara/selenium/driver.rb +31 -54
data/lib/capybara/selenium/driver_specializations/chrome_driver.rb +1 -1
data/lib/capybara/selenium/driver_specializations/edge_driver.rb +9 -5
data/lib/capybara/selenium/driver_specializations/firefox_driver.rb +2 -7
data/lib/capybara/selenium/extensions/html5_drag.rb +5 -4
data/lib/capybara/selenium/node.rb +60 -38
data/lib/capybara/selenium/nodes/chrome_node.rb +4 -16
data/lib/capybara/selenium/nodes/edge_node.rb +19 -13
data/lib/capybara/selenium/nodes/firefox_node.rb +3 -3
data/lib/capybara/selenium/nodes/safari_node.rb +4 -4
data/lib/capybara/selenium/patches/atoms.rb +1 -1
data/lib/capybara/selenium/patches/pause_duration_fix.rb +1 -1
data/lib/capybara/server/animation_disabler.rb +40 -23
data/lib/capybara/server/middleware.rb +1 -1
data/lib/capybara/server.rb +1 -1
data/lib/capybara/session/config.rb +4 -2
data/lib/capybara/session.rb +34 -34
data/lib/capybara/spec/public/test.js +4 -0
data/lib/capybara/spec/session/active_element_spec.rb +31 -0
data/lib/capybara/spec/session/all_spec.rb +11 -15
data/lib/capybara/spec/session/assert_text_spec.rb +17 -17
data/lib/capybara/spec/session/attach_file_spec.rb +6 -0
data/lib/capybara/spec/session/check_spec.rb +10 -0
data/lib/capybara/spec/session/choose_spec.rb +6 -0
data/lib/capybara/spec/session/click_link_or_button_spec.rb +9 -0
data/lib/capybara/spec/session/click_link_spec.rb +12 -1
data/lib/capybara/spec/session/current_scope_spec.rb +1 -1
data/lib/capybara/spec/session/fill_in_spec.rb +6 -0
data/lib/capybara/spec/session/find_link_spec.rb +10 -0
data/lib/capybara/spec/session/find_spec.rb +15 -1
data/lib/capybara/spec/session/first_spec.rb +1 -1
data/lib/capybara/spec/session/frame/within_frame_spec.rb +2 -0
data/lib/capybara/spec/session/has_all_selectors_spec.rb +5 -5
data/lib/capybara/spec/session/has_ancestor_spec.rb +2 -2
data/lib/capybara/spec/session/has_any_selectors_spec.rb +6 -2
data/lib/capybara/spec/session/has_button_spec.rb +30 -0
data/lib/capybara/spec/session/has_current_path_spec.rb +3 -3
data/lib/capybara/spec/session/has_element_spec.rb +47 -0
data/lib/capybara/spec/session/has_field_spec.rb +25 -1
data/lib/capybara/spec/session/has_link_spec.rb +40 -0
data/lib/capybara/spec/session/has_none_selectors_spec.rb +7 -7
data/lib/capybara/spec/session/has_select_spec.rb +10 -4
data/lib/capybara/spec/session/has_selector_spec.rb +15 -0
data/lib/capybara/spec/session/has_table_spec.rb +13 -2
data/lib/capybara/spec/session/has_text_spec.rb +6 -14
data/lib/capybara/spec/session/matches_style_spec.rb +2 -0
data/lib/capybara/spec/session/node_spec.rb +88 -1
data/lib/capybara/spec/session/node_wrapper_spec.rb +1 -1
data/lib/capybara/spec/session/reset_session_spec.rb +13 -0
data/lib/capybara/spec/session/scroll_spec.rb +7 -5
data/lib/capybara/spec/session/uncheck_spec.rb +1 -1
data/lib/capybara/spec/session/visit_spec.rb +20 -0
data/lib/capybara/spec/session/window/window_spec.rb +1 -1
data/lib/capybara/spec/session/window/windows_spec.rb +1 -1
data/lib/capybara/spec/session/within_spec.rb +13 -0
data/lib/capybara/spec/spec_helper.rb +12 -5
data/lib/capybara/spec/test_app.rb +91 -14
data/lib/capybara/spec/views/animated.erb +1 -1
data/lib/capybara/spec/views/form.erb +34 -4
data/lib/capybara/spec/views/frame_child.erb +1 -1
data/lib/capybara/spec/views/frame_one.erb +1 -1
data/lib/capybara/spec/views/frame_parent.erb +1 -1
data/lib/capybara/spec/views/frame_two.erb +1 -1
data/lib/capybara/spec/views/initial_alert.erb +2 -1
data/lib/capybara/spec/views/layout.erb +10 -0
data/lib/capybara/spec/views/obscured.erb +1 -1
data/lib/capybara/spec/views/offset.erb +2 -1
data/lib/capybara/spec/views/path.erb +2 -2
data/lib/capybara/spec/views/popup_one.erb +1 -1
data/lib/capybara/spec/views/popup_two.erb +1 -1
data/lib/capybara/spec/views/react.erb +2 -2
data/lib/capybara/spec/views/scroll.erb +2 -1
data/lib/capybara/spec/views/spatial.erb +1 -1
data/lib/capybara/spec/views/with_animation.erb +2 -3
data/lib/capybara/spec/views/with_base_tag.erb +2 -2
data/lib/capybara/spec/views/with_dragula.erb +2 -2
data/lib/capybara/spec/views/with_fixed_header_footer.erb +2 -1
data/lib/capybara/spec/views/with_hover.erb +2 -2
data/lib/capybara/spec/views/with_html.erb +5 -3
data/lib/capybara/spec/views/with_jquery_animation.erb +1 -1
data/lib/capybara/spec/views/with_js.erb +2 -3
data/lib/capybara/spec/views/with_jstree.erb +1 -1
data/lib/capybara/spec/views/with_namespace.erb +1 -0
data/lib/capybara/spec/views/with_scope.erb +2 -2
data/lib/capybara/spec/views/with_shadow.erb +31 -0
data/lib/capybara/spec/views/with_slow_unload.erb +2 -1
data/lib/capybara/spec/views/with_sortable_js.erb +2 -2
data/lib/capybara/spec/views/with_unload_alert.erb +1 -0
data/lib/capybara/spec/views/with_windows.erb +1 -1
data/lib/capybara/spec/views/within_frames.erb +1 -1
data/lib/capybara/version.rb +1 -1
data/lib/capybara/window.rb +1 -1
data/lib/capybara.rb +30 -30
data/spec/basic_node_spec.rb +16 -3
data/spec/capybara_spec.rb +12 -0
data/spec/counter_spec.rb +35 -0
data/spec/css_builder_spec.rb +1 -1
data/spec/css_splitter_spec.rb +1 -1
data/spec/dsl_spec.rb +5 -3
data/spec/fixtures/selenium_driver_rspec_failure.rb +2 -2
data/spec/fixtures/selenium_driver_rspec_success.rb +2 -2
data/spec/minitest_spec.rb +12 -1
data/spec/minitest_spec_spec.rb +4 -0
data/spec/per_session_config_spec.rb +1 -1
data/spec/rack_test_spec.rb +30 -12
data/spec/result_spec.rb +41 -35
data/spec/rspec/features_spec.rb +3 -3
data/spec/rspec/scenarios_spec.rb +2 -2
data/spec/rspec/shared_spec_matchers.rb +27 -3
data/spec/rspec_matchers_spec.rb +25 -0
data/spec/rspec_spec.rb +3 -3
data/spec/sauce_spec_chrome.rb +5 -5
data/spec/selector_spec.rb +4 -4
data/spec/selenium_spec_chrome.rb +20 -18
data/spec/selenium_spec_chrome_remote.rb +15 -19
data/spec/selenium_spec_edge.rb +19 -6
data/spec/selenium_spec_firefox.rb +26 -8
data/spec/selenium_spec_firefox_remote.rb +18 -4
data/spec/selenium_spec_ie.rb +7 -8
data/spec/selenium_spec_safari.rb +34 -20
data/spec/server_spec.rb +19 -7
data/spec/shared_selenium_node.rb +0 -4
data/spec/shared_selenium_session.rb +22 -14
data/spec/spec_helper.rb +36 -3
data/spec/whitespace_normalizer_spec.rb +54 -0
data/spec/xpath_builder_spec.rb +1 -1
metadata +49 -30
data/lib/capybara/selenium/logger_suppressor.rb +0 -34
data/lib/capybara/selenium/patches/action_pauser.rb +0 -26
data/lib/capybara/spec/views/with_title.erb +0 -5

data/lib/capybara/spec/views/with_sortable_js.erb CHANGED Viewed

@@ -1,4 +1,5 @@
-<html xmlns="http://www.w3.org/1999/xhtml" lang="en">
+<!DOCTYPE html>
+<html lang="en">
   <head>
     <meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
     <title>with_sortable_js</title>
@@ -18,4 +19,3 @@
     </script>
   </body>
 </html>

data/lib/capybara/spec/views/with_unload_alert.erb CHANGED Viewed

@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <html>
 <head>
   <script>

data/lib/capybara/spec/views/with_windows.erb CHANGED Viewed

@@ -1,4 +1,4 @@
+<!DOCTYPE html>
 <html>
   <head>
     <title>With Windows</title>

data/lib/capybara/spec/views/within_frames.erb CHANGED Viewed

@@ -1,4 +1,4 @@
+<!DOCTYPE html>
 <html>
     <head>
         <title>With Frames</title>

data/lib/capybara/version.rb CHANGED Viewed

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Capybara
-  VERSION = '3.35.0'
+  VERSION = '3.40.0'
 end

data/lib/capybara/window.rb CHANGED Viewed

@@ -118,7 +118,7 @@ module Capybara
     alias_method :==, :eql?
     def hash
-      @session.hash ^ @handle.hash
+      [@session, @handle].hash
     end
     def inspect

data/lib/capybara.rb CHANGED Viewed

@@ -39,7 +39,7 @@ module Capybara
     #   See {Capybara.configure}
     # @!method javascript_driver
     #   See {Capybara.configure}
-    # @!method allow_gumbo
+    # @!method use_html5_parsing
     #   See {Capybara.configure}
     Config::OPTIONS.each do |method|
       def_delegators :config, method, "#{method}="
@@ -69,7 +69,7 @@ module Capybara
     #
     # #### Configurable options
     #
-    # - **allow_gumbo** (Boolean = `false`) - When `nokogumbo` is available, whether it will be used to parse HTML strings.
+    # - **use_html5_parsing** (Boolean = `false`) - When Nokogiri >= 1.12.0 or `nokogumbo` is installed, whether HTML5 parsing will be used for HTML strings.
     # - **always_include_port** (Boolean = `false`) - Whether the Rack server's port should automatically be inserted into every visited URL
     #   unless another port is explicitly specified.
     # - **app_host** (String, `nil`) - The default host to use when giving a relative URL to visit, must be a valid URL e.g. `http://www.example.com`.
@@ -79,6 +79,7 @@ module Capybara
     # - **automatic_reload** (Boolean = `true`) - Whether to automatically reload elements as Capybara is waiting.
     # - **default_max_wait_time** (Numeric = `2`) - The maximum number of seconds to wait for asynchronous processes to finish.
     # - **default_normalize_ws** (Boolean = `false`) - Whether text predicates and matchers use normalize whitespace behavior.
+    # - **default_retry_interval** (Numeric = `0.01`) - The number of seconds to delay the next check in asynchronous processes.
     # - **default_selector** (`:css`, `:xpath` = `:css`) - Methods which take a selector use the given type by default. See also {Capybara::Selector}.
     # - **default_set_options** (Hash = `{}`) - The default options passed to {Capybara::Node::Element#set Element#set}.
     # - **enable_aria_label** (Boolean = `false`) - Whether fields, links, and buttons will match against `aria-label` attribute.
@@ -96,11 +97,12 @@ module Capybara
     #   {Capybara::Session#save_and_open_page save_and_open_page}, or {Capybara::Session#save_and_open_screenshot save_and_open_screenshot}.
     # - **server** (Symbol = `:default` (which uses puma)) - The name of the registered server to use when running the app under test.
     # - **server_port** (Integer) - The port Capybara will run the application server on, if not specified a random port will be used.
+    # - **server_host** (String = "127.0.0.1") - The IP address Capybara will bind the application server to. If the test application is to be accessed from an external host, you will want to change this to "0.0.0.0" or to a more specific IP address that your test client can reach.
     # - **server_errors** (Array\<Class> = `[Exception]`) - Error classes that should be raised in the tests if they are raised in the server
     #   and {configure raise_server_errors} is `true`.
     # - **test_id** (Symbol, String, `nil` = `nil`) - Optional attribute to match locator against with built-in selectors along with id.
     # - **threadsafe** (Boolean = `false`) - Whether sessions can be configured individually.
-    # - **w3c_click_offset** (Boolean = 'false') - Whether click offsets should be from element center (true) or top left (false)
+    # - **w3c_click_offset** (Boolean = 'true') - Whether click offsets should be from element center (true) or top left (false)
     #
     # #### DSL Options
     #
@@ -258,7 +260,7 @@ module Capybara
     #
     def current_driver
       if threadsafe
-        Thread.current['capybara_current_driver']
+        Thread.current.thread_variable_get :capybara_current_driver
       else
         @current_driver
       end || default_driver
@@ -267,7 +269,7 @@ module Capybara
     def current_driver=(name)
       if threadsafe
-        Thread.current['capybara_current_driver'] = name
+        Thread.current.thread_variable_set :capybara_current_driver, name
       else
         @current_driver = name
       end
@@ -334,7 +336,8 @@ module Capybara
     #
     def session_name
       if threadsafe
-        Thread.current['capybara_session_name'] ||= :default
+        Thread.current.thread_variable_get(:capybara_session_name) ||
+          Thread.current.thread_variable_set(:capybara_session_name, :default)
       else
         @session_name ||= :default
       end
@@ -342,7 +345,7 @@ module Capybara
     def session_name=(name)
       if threadsafe
-        Thread.current['capybara_session_name'] = name
+        Thread.current.thread_variable_set :capybara_session_name, name
       else
         @session_name = name
       end
@@ -385,26 +388,21 @@ module Capybara
     # @return [Nokogiri::HTML::Document]      HTML document
     #
     def HTML(html) # rubocop:disable Naming/MethodName
-      if Nokogiri.respond_to?(:HTML5) && Capybara.allow_gumbo # Nokogumbo installed and allowed for use
-        Nokogiri::HTML5(html).tap do |document|
-          document.xpath('//template').each do |template|
-            # template elements content is not part of the document
-            template.inner_html = ''
-          end
-          document.xpath('//textarea').each do |textarea|
-            # The Nokogumbo HTML5 parser already returns spec compliant contents
-            textarea['_capybara_raw_value'] = textarea.content
-          end
-        end
+      # Nokogiri >= 1.12.0 or Nokogumbo installed and allowed for use
+      html_parser, using_html5 = if defined?(Nokogiri::HTML5) && Capybara.use_html5_parsing
+        [Nokogiri::HTML5, true]
       else
-        Nokogiri::HTML(html).tap do |document|
-          document.xpath('//template').each do |template|
-            # template elements content is not part of the document
-            template.inner_html = ''
-          end
-          document.xpath('//textarea').each do |textarea|
-            textarea['_capybara_raw_value'] = textarea.content.delete_prefix("\n")
-          end
+        [defined?(Nokogiri::HTML4) ? Nokogiri::HTML4 : Nokogiri::HTML, false]
+      end
+      html_parser.parse(html).tap do |document|
+        document.xpath('//template').each do |template|
+          # template elements content is not part of the document
+          template.inner_html = ''
+        end
+        document.xpath('//textarea').each do |textarea|
+          # The Nokogiri HTML5 parser already returns spec compliant contents
+          textarea['_capybara_raw_value'] = using_html5 ? textarea.content : textarea.content.delete_prefix("\n")
         end
       end
     end
@@ -427,7 +425,7 @@ module Capybara
     def specified_session
       if threadsafe
-        Thread.current['capybara_specified_session']
+        Thread.current.thread_variable_get :capybara_specified_session
       else
         @specified_session ||= nil
       end
@@ -435,7 +433,7 @@ module Capybara
     def specified_session=(session)
       if threadsafe
-        Thread.current['capybara_specified_session'] = session
+        Thread.current.thread_variable_set :capybara_specified_session, session
       else
         @specified_session = session
       end
@@ -467,6 +465,7 @@ module Capybara
   require 'capybara/queries/ancestor_query'
   require 'capybara/queries/sibling_query'
   require 'capybara/queries/style_query'
+  require 'capybara/queries/active_element_query'
   require 'capybara/node/finders'
   require 'capybara/node/matchers'
@@ -499,6 +498,7 @@ Capybara.configure do |config|
   config.server = :default
   config.default_selector = :css
   config.default_max_wait_time = 2
+  config.default_retry_interval = 0.01
   config.ignore_hidden_elements = true
   config.default_host = 'http://www.example.com'
   config.automatic_reload = true
@@ -516,6 +516,6 @@ Capybara.configure do |config|
   config.test_id = nil
   config.predicates_wait = true
   config.default_normalize_ws = false
-  config.allow_gumbo = false
-  config.w3c_click_offset = false
+  config.use_html5_parsing = false
+  config.w3c_click_offset = true
 end

data/spec/basic_node_spec.rb CHANGED Viewed

@@ -111,14 +111,27 @@ RSpec.describe Capybara do
       expect(string.find('//form/input[@name="meh"]')).not_to be_disabled
     end
+    it 'allows finding siblings' do
+      h1 = string.find(:css, 'h1')
+      expect(h1).to have_sibling(:css, 'p', text: 'Yes it is')
+      expect(h1).not_to have_sibling(:css, 'p', text: 'Jonas Nicklas')
+    end
+    it 'allows finding ancestor' do
+      h1 = string.find(:css, 'h1')
+      expect(h1).to have_ancestor(:css, '#content')
+      expect(h1).not_to have_ancestor(:css, '#footer')
+    end
     it 'drops illegal fragments when using gumbo' do
       skip 'libxml is less strict than Gumbo' unless Nokogiri.respond_to?(:HTML5)
+      described_class.use_html5_parsing = true
       expect(described_class.string('<td>1</td>')).not_to have_css('td')
     end
-    it 'can disable use of gumbo' do
-      skip "Test doesn't make sense unlesss nokogumbo is loaded" unless Nokogiri.respond_to?(:HTML5)
-      described_class.allow_gumbo = false
+    it 'can disable use of HTML5 parsing' do
+      skip "Test doesn't make sense unlesss HTML5 parsing is loaded (Nokogumbo or Nokogiri >= 1.12.0)" unless Nokogiri.respond_to?(:HTML5)
+      described_class.use_html5_parsing = false
       expect(described_class.string('<td>1</td>')).to have_css('td')
     end

data/spec/capybara_spec.rb CHANGED Viewed

@@ -15,6 +15,18 @@ RSpec.describe Capybara do
     end
   end
+  describe 'default_retry_interval' do
+    before { @previous_default_interval = described_class.default_retry_interval }
+    after { described_class.default_retry_interval = @previous_default_interval } # rubocop:disable RSpec/InstanceVariable
+    it 'should be changeable' do
+      expect(described_class.default_retry_interval).not_to eq(0.1)
+      described_class.default_retry_interval = 0.1
+      expect(described_class.default_retry_interval).to eq(0.1)
+    end
+  end
   describe '.register_driver' do
     it 'should add a new driver' do
       described_class.register_driver :schmoo do |app|

data/spec/counter_spec.rb ADDED Viewed

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+require 'spec_helper'
+RSpec.describe Capybara::Server::Middleware::Counter do
+  let(:counter) { described_class.new }
+  let(:uri) { '/example' }
+  describe '#increment' do
+    it 'successfully' do
+      counter.increment(uri)
+      expect(counter).to be_positive
+    end
+  end
+  describe '#decrement' do
+    before do
+      counter.increment(uri)
+    end
+    context 'successfully' do
+      it 'with same uri' do
+        expect(counter).to be_positive
+        counter.decrement(uri)
+        expect(counter).not_to be_positive
+      end
+      it 'with changed uri' do
+        expect(counter).to be_positive
+        counter.decrement('/')
+        expect(counter).not_to be_positive
+      end
+    end
+  end
+end

data/spec/css_builder_spec.rb CHANGED Viewed

@@ -5,7 +5,7 @@ require 'spec_helper'
 # rubocop:disable RSpec/InstanceVariable
 RSpec.describe Capybara::Selector::CSSBuilder do
   let :builder do
-    ::Capybara::Selector::CSSBuilder.new(@css)
+    described_class.new(@css)
   end
   context 'add_attribute_conditions' do

data/spec/css_splitter_spec.rb CHANGED Viewed

@@ -4,7 +4,7 @@ require 'spec_helper'
 RSpec.describe Capybara::Selector::CSS::Splitter do
   let :splitter do
-    ::Capybara::Selector::CSS::Splitter.new
+    described_class.new
   end
   context 'split not needed' do

data/spec/dsl_spec.rb CHANGED Viewed

@@ -8,13 +8,15 @@ class TestClass
 end
 Capybara::SpecHelper.run_specs TestClass.new, 'DSL', capybara_skip: %i[
-  js modals screenshot frames windows send_keys server hover about_scheme psc download css driver scroll spatial html_validation shadow_dom
+  js modals screenshot frames windows send_keys server hover about_scheme psc download css driver scroll spatial html_validation shadow_dom active_element
 ] do |example|
   case example.metadata[:full_description]
   when /has_css\? should support case insensitive :class and :id options/
     pending "Nokogiri doesn't support case insensitive CSS attribute matchers"
   when /#click_button should follow permanent redirects that maintain method/
     pending "Rack < 2 doesn't support 308" if Gem.loaded_specs['rack'].version < Gem::Version.new('2.0.0')
+  when /#attach_file with multipart form should send prior hidden field if no file submitted/
+    skip 'Rack-test < 2 needs an empty file to detect multipart form' if Gem.loaded_specs['rack-test'].version < Gem::Version.new('2.0.0')
   end
 end
@@ -115,7 +117,7 @@ RSpec.describe Capybara::DSL do
     it 'should yield the passed block' do
       called = false
       Capybara.using_driver(:selenium) { called = true }
-      expect(called).to eq(true)
+      expect(called).to be(true)
     end
   end
@@ -220,7 +222,7 @@ RSpec.describe Capybara::DSL do
     it 'should yield the passed block' do
       called = false
       Capybara.using_session(:administrator) { called = true }
-      expect(called).to eq(true)
+      expect(called).to be(true)
     end
     it 'should be nestable' do

data/spec/fixtures/selenium_driver_rspec_failure.rb CHANGED Viewed

@@ -5,9 +5,9 @@ require 'selenium-webdriver'
 RSpec.describe Capybara::Selenium::Driver do
   it 'should exit with a non-zero exit status' do
-    options = { browser: (ENV['SELENIUM_BROWSER'] || :firefox).to_sym }
+    options = { browser: ENV.fetch('SELENIUM_BROWSER', :firefox).to_sym }
     browser = described_class.new(TestApp, options).browser
     expect(browser).to be_truthy
-    expect(true).to eq(false) # rubocop:disable RSpec/ExpectActual
+    expect(true).to be(false) # rubocop:disable RSpec/ExpectActual
   end
 end

data/spec/fixtures/selenium_driver_rspec_success.rb CHANGED Viewed

@@ -5,9 +5,9 @@ require 'selenium-webdriver'
 RSpec.describe Capybara::Selenium::Driver do
   it 'should exit with a zero exit status' do
-    options = { browser: (ENV['SELENIUM_BROWSER'] || :firefox).to_sym }
+    options = { browser: ENV.fetch('SELENIUM_BROWSER', :firefox).to_sym }
     browser = described_class.new(TestApp, **options).browser
     expect(browser).to be_truthy
-    expect(true).to eq(true) # rubocop:disable RSpec/ExpectActual
+    expect(true).to be(true) # rubocop:disable RSpec/ExpectActual,RSpec/IdenticalEqualityAssertion
   end
 end

data/spec/minitest_spec.rb CHANGED Viewed

@@ -15,6 +15,10 @@ class MinitestTest < Minitest::Test
     Capybara.reset_sessions!
   end
+  def self.test_order
+    :sorted
+  end
   def test_assert_text
     assert_text('Form', normalize_ws: false)
     assert_no_text('Not on the page')
@@ -56,6 +60,13 @@ class MinitestTest < Minitest::Test
     refute_selector(:css, 'select#not_form_title')
   end
+  def test_assert_element
+    visit('/with_html')
+    assert_element('a', text: 'A link')
+    assert_element(count: 1) { |el| el.text == 'A link' }
+    assert_no_element(text: 'Not on page')
+  end
   def test_assert_link
     visit('/with_html')
     assert_link('A link')
@@ -159,6 +170,6 @@ RSpec.describe 'capybara/minitest' do
     reporter.start
     MinitestTest.run reporter, {}
     reporter.report
-    expect(output.string).to include('22 runs, 53 assertions, 0 failures, 0 errors, 1 skips')
+    expect(output.string).to include('23 runs, 56 assertions, 0 failures, 0 errors, 1 skips')
   end
 end

data/spec/minitest_spec_spec.rb CHANGED Viewed

@@ -16,6 +16,10 @@ class MinitestSpecTest < Minitest::Spec
     Capybara.reset_sessions!
   end
+  def self.test_order
+    :sorted
+  end
   it 'supports text expectations' do
     _(page).must_have_text('Form', minimum: 1)
     _(page).wont_have_text('Not a form')

data/spec/per_session_config_spec.rb CHANGED Viewed

@@ -12,7 +12,7 @@ RSpec.describe Capybara::SessionConfig do
          default_selector default_max_wait_time ignore_hidden_elements
          automatic_reload match exact raise_server_errors visible_text_only
          automatic_label_click enable_aria_label save_path
-         asset_host].each do |m|
+         asset_host default_retry_interval].each do |m|
            expect(session.config.public_send(m)).to eq Capybara.public_send(m)
          end
     end

data/spec/rack_test_spec.rb CHANGED Viewed

@@ -1,12 +1,6 @@
 # frozen_string_literal: true
 require 'spec_helper'
-nokogumbo_required = begin
-  require 'nokogumbo'
-  true
-rescue LoadError
-  false
-end
 module TestSessions
   RackTest = Capybara::Session.new(:rack_test, TestApp)
@@ -28,6 +22,7 @@ skipped_tests = %i[
   spatial
   html_validation
   shadow_dom
+  active_element
 ]
 Capybara::SpecHelper.run_specs TestSessions::RackTest, 'RackTest', capybara_skip: skipped_tests do |example|
   case example.metadata[:full_description]
@@ -35,6 +30,8 @@ Capybara::SpecHelper.run_specs TestSessions::RackTest, 'RackTest', capybara_skip
     skip "Nokogiri doesn't support case insensitive CSS attribute matchers"
   when /#click_button should follow permanent redirects that maintain method/
     skip "Rack < 2 doesn't support 308" if Gem.loaded_specs['rack'].version < Gem::Version.new('2.0.0')
+  when /#attach_file with multipart form should send prior hidden field if no file submitted/
+    skip 'Rack-test < 2 needs an empty file to detect multipart form' if Gem.loaded_specs['rack-test'].version < Gem::Version.new('2.0.0')
   end
 end
@@ -98,6 +95,12 @@ RSpec.describe Capybara::Session do # rubocop:disable RSpec/MultipleDescribes
           session.click_button('Upload Empty')
           expect(session.html).to include('Successfully ignored empty file field.')
         end
+        it 'should submit multipart even if no file is submitted' do
+          session.visit('/form')
+          session.click_button('Upload Empty')
+          expect(session.html).to include('Content type was multipart/form-data;')
+        end
       end
       it 'should not submit an obsolete mime type' do
@@ -153,6 +156,14 @@ RSpec.describe Capybara::Session do # rubocop:disable RSpec/MultipleDescribes
       end
     end
+    describe '#active_element' do
+      it 'raises an UnsupportedMethodError' do
+        session.visit('/form')
+        expect { session.active_element }.to raise_error(Capybara::NotSupportedByDriverError)
+      end
+    end
     describe '#text' do
       it 'should return original text content for textareas' do
         session.visit('/with_html')
@@ -209,15 +220,21 @@ RSpec.describe Capybara::RackTest::Driver do
       driver = described_class.new(TestApp)
       driver.visit('/redirect')
-      expect(driver.response.header['Location']).to be_nil
+      expect(driver.response.headers['Location']).to be_nil
       expect(driver.current_url).to match %r{/landed$}
     end
+    it 'should not include fragments in the referer header' do
+      driver.visit('/header_links#an-anchor')
+      driver.find_xpath('.//input').first.click
+      expect(driver.request.get_header('HTTP_REFERER')).to eq('http://www.example.com/header_links')
+    end
     it 'is possible to not follow redirects' do
       driver = described_class.new(TestApp, follow_redirects: false)
       driver.visit('/redirect')
-      expect(driver.response.header['Location']).to match %r{/redirect_again$}
+      expect(driver.response.headers['Location']).to match %r{/redirect_again$}
       expect(driver.current_url).to match %r{/redirect$}
     end
   end
@@ -256,11 +273,12 @@ RSpec.describe Capybara::RackTest::Driver do
 end
 RSpec.describe 'Capybara::String' do
-  it 'should use gumbo' do
-    skip 'Only  valid if gumbo is included' unless nokogumbo_required
-    allow(Nokogiri).to receive(:HTML5).and_call_original
+  it 'should use HTML5 parsing' do
+    skip 'Only valid if Nokogiri >= 1.12.0 or gumbo is included' unless defined? Nokogiri::HTML5
+    Capybara.use_html5_parsing = true
+    allow(Nokogiri::HTML5).to receive(:parse).and_call_original
     Capybara.string('<div id=test_div></div>')
-    expect(Nokogiri).to have_received(:HTML5)
+    expect(Nokogiri::HTML5).to have_received(:parse)
   end
 end