capybara 3.26.0 → 3.27.0

data/spec/session_spec.rb

@@ -6,13 +6,13 @@ RSpec.describe Capybara::Session do
   context '#new' do
     it 'should raise an error if passed non-existent driver' do
       expect do
-        Capybara::Session.new(:quox, TestApp).driver
+        described_class.new(:quox, TestApp).driver
       end.to raise_error(Capybara::DriverNotFoundError)
     end
 
     it 'verifies a passed app is a rack app' do
       expect do
-        Capybara::Session.new(:unknown, random: 'hash')
+        described_class.new(:unknown, random: 'hash')
       end.to raise_error TypeError, 'The second parameter to Session::new should be a rack app if passed.'
     end
   end
@@ -75,14 +75,14 @@ RSpec.describe Capybara::Session do
 
   context 'quit' do
     it 'will reset the driver' do
-      session = Capybara::Session.new(:rack_test, TestApp)
+      session = described_class.new(:rack_test, TestApp)
       driver = session.driver
       session.quit
       expect(session.driver).not_to eql driver
     end
 
     it 'resets the document' do
-      session = Capybara::Session.new(:rack_test, TestApp)
+      session = described_class.new(:rack_test, TestApp)
       document = session.document
       session.quit
       expect(session.document.base).not_to eql document.base

data/spec/shared_selenium_node.rb

@@ -26,4 +26,40 @@ RSpec.shared_examples 'Capybara::Node' do |session, _mode|
       expect(session.find(:css, '#address1_city').value).to eq 'ocean SIDE'
     end
   end
+
+  context '#visible?' do
+    let(:bridge) do
+      session.driver.browser.send(:bridge)
+    end
+
+    around do |example|
+      native_displayed = session.driver.options[:native_displayed]
+      example.run
+      session.driver.options[:native_displayed] = native_displayed
+    end
+
+    before do
+      allow(bridge).to receive(:execute_atom).and_call_original
+    end
+
+    it 'will use native displayed if told to' do
+      pending "Chromedriver < 76.0.3809.25 doesn't support native displayed in W3C mode" if chrome_lt?(76, session) && (ENV['W3C'] != 'false')
+
+      session.driver.options[:native_displayed] = true
+      session.visit('/form')
+      session.find(:css, '#address1_city', visible: true)
+
+      expect(bridge).not_to have_received(:execute_atom)
+    end
+
+    it "won't use native displayed if told not to" do
+      skip 'Non-W3C uses native' if chrome?(session) && (ENV['W3C'] == 'false')
+
+      session.driver.options[:native_displayed] = false
+      session.visit('/form')
+      session.find(:css, '#address1_city', visible: true)
+
+      expect(bridge).to have_received(:execute_atom).with(:isDisplayed, any_args)
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara
 version: !ruby/object:Gem::Version
-  version: 3.26.0
+  version: 3.27.0
 platform: ruby
 authors:
 - Thomas Walpole
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain:
 - gem-public_cert.pem
-date: 2019-07-15 00:00:00.000000000 Z
+date: 2019-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -526,6 +526,7 @@ files:
 - lib/capybara/selenium/nodes/ie_node.rb
 - lib/capybara/selenium/nodes/safari_node.rb
 - lib/capybara/selenium/patches/atoms.rb
+- lib/capybara/selenium/patches/is_displayed.rb
 - lib/capybara/selenium/patches/logs.rb
 - lib/capybara/selenium/patches/pause_duration_fix.rb
 - lib/capybara/selenium/patches/persistent_client.rb