capybara 3.25.0 → 3.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 439a641ea3d9a06bcc674c159c3ef16612fb29874e71f11ef7bb2d0e73382892
-  data.tar.gz: a5e57dfb62e3682a87f05650a13945545a61183a84a15498390d07aa3ec6e4ed
+  metadata.gz: 59f170c7004d4936ffb0d136a4dd0755a9c1ec5870f6bf1114d693b99a8fed51
+  data.tar.gz: 955e163359d522952afdc7d776458667f97aa053e6eb704320733eae8340544a
 SHA512:
-  metadata.gz: d50ab813eecabef7465c9a42904174f65eefe6dc8e0f92fea59d523753582c1797a1a87880a1d9805edb8f74e33585314841d6fac7abcf2781a627ac9703191e
-  data.tar.gz: 0d4f2b360e528a3fae6357072592ac5295cb500d68251d23bc66a014fc62528473e960b4049d4e24a5339a8a41f02f15c70b7ae59b5f51ebfb1a7369afa47f27
+  metadata.gz: 13d33c4977455c5d2e9a5aa7532ffed98573795a1528685ded75574dfabd58512f5d3e71d3582d8155fe4325209ba3bbde3246a29b4436de573c5b492dffe1cc
+  data.tar.gz: 52b33d646ec5c86b61a04b7f2c354a1d1e77d1c363b0ba8d19e7ad1b48679a53078766c8f018f1d7f223b730d9b4d951f005a689a3f143999fdeead4c522242c

data/History.md

@@ -1,3 +1,48 @@
+# Version 3.28.0
+Release date: 2019-08-03
+
+### Added
+
+* Allow forcing HTML5 or legacy dragging via the `:html5` option to `drag_to` when using Selenium with Chrome or Firefox
+* Autodetection of drag type interprets not seeing the mousedown event as legacy.
+* HTML5 form validation `:valid` node filter added to `:field` and `:fillable_field` selectors
+* When using Capybara registered :puma server - patches Puma 4.0.x to fix SSL connection behavior. Removes
+  default `queue_requests` setting - Issue #2227
+
+# Version 3.27.0
+Release date: 2019-07-28
+
+### Added
+
+* Allow to use chromedriver/geckodriver native `is_element_displayed` endpoint via Selenium
+  driver `native_displayed` option for performance reasons. Disabled by default due to endpoints
+  currently not handling <details> element descendants visibility correctly.
+
+### Fixed
+
+* Ignore negative lookahead/lookbehind regex when performing initial XPath text matching
+* Reloading of elements found via `ancestor` and `sibling`
+* Only default puma settings to `queue_requests: false` when using SSL
+* Visibility of descendants of <details> elements is correctly determined when using rack_test
+  and the selenium driver with Capybara optimized atoms
+* local/session storage clearance in Chrome when clearing only one of them - Issue #2233
+
+# Version 3.26.0
+Release date: 2019-07-15
+
+### Added
+
+* `w3c_click_offset` configuration option applies to `right_click` and `double_click` as well as `click`
+* Warning when passing `nil` to the text/content assertions/expectations
+* `Session#server_url` returns the base url the AUT is being run at (when controlled by Capybara)
+* `option` selector type accepts an integer as locator
+
+### Fixed
+
+* Default puma server registration now specifies `queue_requests: false` - Issue #2227
+* Workaround issue with FF 68 and hanging during reset if a system modal is visible
+* Don't expand file path if it's already absolute - Issue #2228
+
 # Version 3.25.0
 Release date: 2019-06-27
 

data/README.md

@@ -7,7 +7,7 @@
 [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/jnicklas/capybara?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![SemVer](https://api.dependabot.com/badges/compatibility_score?dependency-name=capybara&package-manager=bundler&version-scheme=semver)](https://dependabot.com/compatibility-score.html?dependency-name=capybara&package-manager=bundler&version-scheme=semver)
 
-**Note** You are viewing the README for the 3.25.x version of Capybara
+**Note** You are viewing the README for the 3.28.x version of Capybara.
 
 Capybara helps you test web applications by simulating how a real user would
 interact with your app. It is agnostic about the driver running your tests and

data/lib/capybara/minitest.rb

@@ -9,38 +9,38 @@ module Capybara
       ## Assert text exists
       #
       # @!method assert_text
-      #  see {Capybara::Node::Matchers#assert_text}
+      #   @see Capybara::Node::Matchers#assert_text
 
       ## Assert text does not exist
       #
       # @!method assert_no_text
-      #  see {Capybara::Node::Matchers#assert_no_text}
+      #   @see Capybara::Node::Matchers#assert_no_text
 
       ##
       # Assertion that page title does match
       #
       # @!method assert_title
-      #   see {Capybara::Node::DocumentMatchers#assert_title}
+      #   @see Capybara::Node::DocumentMatchers#assert_title
 
       ##
       # Assertion that page title does not match
       #
       # @!method refute_title
       # @!method assert_no_title
-      #   see {Capybara::Node::DocumentMatchers#assert_no_title}
+      #   @see Capybara::Node::DocumentMatchers#assert_no_title
 
       ##
       # Assertion that current path matches
       #
       # @!method assert_current_path
-      #   see {Capybara::SessionMatchers#assert_current_path}
+      #   @see Capybara::SessionMatchers#assert_current_path
 
       ##
       # Assertion that current page does not match
       #
       # @!method refute_current_path
       # @!method assert_no_current_path
-      #   see {Capybara::SessionMatchers#assert_no_current_path}
+      #   @see Capybara::SessionMatchers#assert_no_current_path
 
       %w[text no_text title no_title current_path no_current_path].each do |assertion_name|
         class_eval <<-ASSERTION, __FILE__, __LINE__ + 1
@@ -64,37 +64,37 @@ module Capybara
       ## Assert selector exists on page
       #
       # @!method assert_selector
-      #   see {Capybara::Node::Matchers#assert_selector}
+      #   @see Capybara::Node::Matchers#assert_selector
 
       ## Assert selector does not exist on page
       #
       # @!method assert_no_selector
-      #   see {Capybara::Node::Matchers#assert_no_selector}
+      #   @see Capybara::Node::Matchers#assert_no_selector
 
       ## Assert element matches selector
       #
       # @!method assert_matches_selector
-      #   see {Capybara::Node::Matchers#assert_matches_selector}
+      #   @see Capybara::Node::Matchers#assert_matches_selector
 
       ## Assert element does not match selector
       #
       # @!method assert_xpath
-      #   see {Capybara::Node::Matchers#assert_not_matches_selector}
+      #   @see Capybara::Node::Matchers#assert_not_matches_selector
 
       ## Assert element has the provided CSS styles
       #
       # @!method assert_matches_style
-      #   see {Capybara::Node::Matchers#assert_matches_style}
+      #   @see Capybara::Node::Matchers#assert_matches_style
 
       ## Assert element has a matching sibling
       #
       # @!method assert_sibling
-      #   see {Capybara::Node::Matchers#assert_sibling}
+      #   @see Capybara::Node::Matchers#assert_sibling
 
       ## Assert element has a matching ancestor
       #
       # @!method assert_ancestor
-      #   see {Capybara::Node::Matchers#assert_ancestor}
+      #   @see Capybara::Node::Matchers#assert_ancestor
 
       %w[selector no_selector matches_style
          all_of_selectors none_of_selectors any_of_selectors
@@ -163,72 +163,72 @@ module Capybara
     # Assertion that there is xpath
     #
     # @!method assert_xpath
-    #   see {Capybara::Node::Matchers#has_xpath?}
+    #   @see Capybara::Node::Matchers#has_xpath?
 
     ##
     # Assertion that there is no xpath
     #
     # @!method refute_xpath
     # @!method assert_no_xpath
-    #   see {Capybara::Node::Matchers#has_no_xpath?}
+    #   @see Capybara::Node::Matchers#has_no_xpath?
 
     ##
     # Assertion that there is css
     #
     # @!method assert_css
-    #   see {Capybara::Node::Matchers#has_css?}
+    #   @see Capybara::Node::Matchers#has_css?
 
     ##
     # Assertion that there is no css
     #
     # @!method refute_css
     # @!method assert_no_css
-    #   see {Capybara::Node::Matchers#has_no_css?}
+    #   @see Capybara::Node::Matchers#has_no_css?
 
     ##
     # Assertion that there is link
     #
     # @!method assert_link
-    #   see {Capybara::Node::Matchers#has_link?}
+    #   @see Capybara::Node::Matchers#has_link?
 
     ##
     # Assertion that there is no link
     #
     # @!method assert_no_link
     # @!method refute_link
-    # see {Capybara::Node::Matchers#has_no_link?}
+    #   @see Capybara::Node::Matchers#has_no_link?
 
     ##
     # Assertion that there is button
     #
     # @!method assert_button
-    #   see {Capybara::Node::Matchers#has_button?}
+    #   @see Capybara::Node::Matchers#has_button?
 
     ##
     # Assertion that there is no button
     #
     # @!method refute_button
     # @!method assert_no_button
-    #   see {Capybara::Node::Matchers#has_no_button?}
+    #   @see Capybara::Node::Matchers#has_no_button?
 
     ##
     # Assertion that there is field
     #
     # @!method assert_field
-    #   see {Capybara::Node::Matchers#has_field?}
+    #   @see Capybara::Node::Matchers#has_field?
 
     ##
     # Assertion that there is no field
     #
     # @!method refute_field
     # @!method assert_no_field
-    #   see {Capybara::Node::Matchers#has_no_field?}
+    #   @see Capybara::Node::Matchers#has_no_field?
 
     ##
     # Assertion that there is checked_field
     #
     # @!method assert_checked_field
-    #   see {Capybara::Node::Matchers#has_checked_field?}
+    #   @see Capybara::Node::Matchers#has_checked_field?
 
     ##
     # Assertion that there is no checked_field
@@ -240,7 +240,7 @@ module Capybara
     # Assertion that there is unchecked_field
     #
     # @!method assert_unchecked_field
-    #   see {Capybara::Node::Matchers#has_unchecked_field?}
+    #   @see Capybara::Node::Matchers#has_unchecked_field?
 
     ##
     # Assertion that there is no unchecked_field
@@ -252,27 +252,27 @@ module Capybara
     # Assertion that there is select
     #
     # @!method assert_select
-    #   see {Capybara::Node::Matchers#has_select?}
+    #   @see Capybara::Node::Matchers#has_select?
 
     ##
     # Assertion that there is no select
     #
     # @!method refute_select
     # @!method assert_no_select
-    #   see {Capybara::Node::Matchers#has_no_select?}
+    #   @see Capybara::Node::Matchers#has_no_select?
 
     ##
     # Assertion that there is table
     #
     # @!method assert_table
-    #   see {Capybara::Node::Matchers#has_table?}
+    #   @see Capybara::Node::Matchers#has_table?
 
     ##
     # Assertion that there is no table
     #
     # @!method refute_table
     # @!method assert_no_table
-    #   see {Capybara::Node::Matchers#has_no_table?}
+    #   @see Capybara::Node::Matchers#has_no_table?
 
     private
 

data/lib/capybara/node/element.rb

@@ -162,12 +162,10 @@ module Capybara
       #     @option options [Integer] y  Y coordinate to offset the click location. If {Capybara.configure w3c_click_offset} is `true` the
       #       offset will be from the element center, otherwise it will be from the top left corner of the element
       # @return [Capybara::Node::Element]  The element
-      def click(*keys, wait: nil, **options)
-        raise ArgumentError, 'You must specify both x: and y: for a click offset' if nil ^ options[:x] ^ options[:y]
-
-        options[:offset] = :center if session_options.w3c_click_offset
-        synchronize(wait) { base.click(Array(keys), options) }
-        self
+      def click(*keys, **options)
+        perform_click_action(keys, options) do |k, opts|
+          base.click(k, opts)
+        end
       end
 
       ##
@@ -177,11 +175,10 @@ module Capybara
       # @macro action_waiting_behavior
       # @macro click_modifiers
       # @return [Capybara::Node::Element]  The element
-      def right_click(*keys, wait: nil, **offset)
-        raise ArgumentError, 'You must specify both x: and y: for a click offset' if nil ^ offset[:x] ^ offset[:y]
-
-        synchronize(wait) { base.right_click(keys, offset) }
-        self
+      def right_click(*keys, **options)
+        perform_click_action(keys, options) do |k, opts|
+          base.right_click(k, opts)
+        end
       end
 
       ##
@@ -191,11 +188,10 @@ module Capybara
       # @macro action_waiting_behavior
       # @macro click_modifiers
       # @return [Capybara::Node::Element]  The element
-      def double_click(*keys, wait: nil, **offset)
-        raise ArgumentError, 'You must specify both x: and y: for a click offset' if nil ^ offset[:x] ^ offset[:y]
-
-        synchronize(wait) { base.double_click(keys, offset) }
-        self
+      def double_click(*keys, **options)
+        perform_click_action(keys, options) do |k, opts|
+          base.double_click(k, opts)
+        end
       end
 
       ##
@@ -400,8 +396,13 @@ module Capybara
       #
       # @param [Capybara::Node::Element] node     The element to drag to
       # @param [Hash] options  Driver specific options for dragging. May not be supported by all drivers.
+      # @option options [Numeric] :delay   (0.05) When using Chrome/Firefox with Selenium and HTML5 dragging this is the number
+      #                                    of seconds between each stage of the drag.
+      # @option options [Boolean] :html5   When using Chrome/Firefox with Selenium enables to force the use of HTML5
+      #                                    (true) or legacy (false) dragging. If not specified the driver will attempt to
+      #                                    detect the correct method to use.
       #
-      # @return [Capybara::Node::Element]  The element
+      # @return [Capybara::Node::Element]  The dragged element
       def drag_to(node, **options)
         synchronize { base.drag_to(node.base, **options) }
         self
@@ -514,11 +515,34 @@ module Capybara
         JS
       end
 
+      ##
+      #
+      # Toggle the elements background color between white and black for a period of time.
+      #
+      # @return [Capybara::Node::Element]  The element
+      def flash
+        execute_script(<<~JS, 100)
+          async function flash(el, delay){
+            var old_bg = el.style.backgroundColor;
+            var colors = ["black", "white"];
+            for(var i=0; i<20; i++){
+              el.style.backgroundColor = colors[i % colors.length];
+              await new Promise(resolve => setTimeout(resolve, delay));
+            }
+            el.style.backgroundColor = old_bg;
+          }
+          flash(this, arguments[0]);
+        JS
+
+        self
+      end
+
       # @api private
       def reload
         if @allow_reload
           begin
-            reloaded = query_scope.reload.first(@query.name, @query.locator, @query.options)
+            reloaded = @query.resolve_for(query_scope.reload)&.first
+
             @base = reloaded.base if reloaded
           rescue StandardError => e
             raise e unless catch_error?(e)
@@ -556,6 +580,16 @@ module Capybara
           return result;
         }).apply(this, arguments)
       JS
+
+    private
+
+      def perform_click_action(keys, wait: nil, **options)
+        raise ArgumentError, 'You must specify both x: and y: for a click offset' if nil ^ options[:x] ^ options[:y]
+
+        options[:offset] ||= :center if session_options.w3c_click_offset
+        synchronize(wait) { yield keys, options }
+        self
+      end
     end
   end
 end

data/lib/capybara/node/matchers.rb

@@ -141,8 +141,8 @@ module Capybara
       # or descendants of the current node.  If options are provided, the assertion
       # will check that each locator is present with those options as well (other than `:wait`).
       #
-      #   page.assert_all_of_selectors(:custom, 'Tom', 'Joe', visible: all)
-      #   page.assert_all_of_selectors(:css, '#my_div', 'a.not_clicked')
+      #     page.assert_all_of_selectors(:custom, 'Tom', 'Joe', visible: all)
+      #     page.assert_all_of_selectors(:css, '#my_div', 'a.not_clicked')
       #
       # It accepts all options that {Capybara::Node::Finders#all} accepts,
       # such as `:text` and `:visible`.
@@ -162,8 +162,8 @@ module Capybara
       # or descendants of the current node. If options are provided, the assertion
       # will check that each locator is not present with those options as well (other than `:wait`).
       #
-      #   page.assert_none_of_selectors(:custom, 'Tom', 'Joe', visible: all)
-      #   page.assert_none_of_selectors(:css, '#my_div', 'a.not_clicked')
+      #     page.assert_none_of_selectors(:custom, 'Tom', 'Joe', visible: all)
+      #     page.assert_none_of_selectors(:css, '#my_div', 'a.not_clicked')
       #
       # It accepts all options that {Capybara::Node::Finders#all} accepts,
       # such as `:text` and `:visible`.
@@ -183,8 +183,8 @@ module Capybara
       # or descendants of the current node. If options are provided, the assertion
       # will check that each locator is present with those options as well (other than `:wait`).
       #
-      #   page.assert_any_of_selectors(:custom, 'Tom', 'Joe', visible: all)
-      #   page.assert_any_of_selectors(:css, '#my_div', 'a.not_clicked')
+      #     page.assert_any_of_selectors(:custom, 'Tom', 'Joe', visible: all)
+      #     page.assert_any_of_selectors(:css, '#my_div', 'a.not_clicked')
       #
       # It accepts all options that {Capybara::Node::Finders#all} accepts,
       # such as `:text` and `:visible`.

data/lib/capybara/node/simple.rb

@@ -197,7 +197,8 @@ module Capybara
         x.ancestor_or_self[
           x.attr(:style)[x.contains('display:none') | x.contains('display: none')] |
           x.attr(:hidden) |
-          x.qname.one_of('script', 'head')
+          x.qname.one_of('script', 'head') |
+          (~x.self(:summary) & XPath.parent(:details))
         ].boolean
       end.to_s.freeze
     end

data/lib/capybara/queries/ancestor_query.rb

@@ -3,20 +3,16 @@
 module Capybara
   module Queries
     class AncestorQuery < Capybara::Queries::SelectorQuery
-      def initialize(*args)
-        super
-        @count_options = {}
-        COUNT_KEYS.each do |key|
-          @count_options[key] = @options.delete(key) if @options.key?(key)
-        end
-      end
-
       # @api private
       def resolve_for(node, exact = nil)
         @child_node = node
+
         node.synchronize do
           match_results = super(node.session.current_scope, exact)
-          node.all(:xpath, XPath.ancestor, **@count_options) { |el| match_results.include?(el) }
+          ancestors = node.find_xpath(XPath.ancestor.to_s)
+                          .map(&method(:to_element))
+                          .select { |el| match_results.include?(el) }
+          Capybara::Result.new(ancestors, self)
         end
       end