capybara 3.24.0 → 3.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ea1da81bd27199aadc0d73d61e33b7ff0ea9911114acc375ea2e6f798a49eb4
-  data.tar.gz: 30279a8a5ab221ae029bc95625c7c82ad11cdf68d91ef6be33e7a0b022268537
+  metadata.gz: 5f11a887ca6aed51d064d9c8eb797e0db4605a3d013082a11f4f4b1013b27bef
+  data.tar.gz: 714e834fdb1c2f0e692f547a1d032113dd888d6905eddecc60f05503720bcd8e
 SHA512:
-  metadata.gz: 0b8d7f760540297a204ae5eb0dac8b9450e8961652de87d543ae114edb9af6a48219db7c55a40e004d49847431ef545cc5628a6bbde858e58921209f984852d2
-  data.tar.gz: 56d10157a97fd98f7e2e23c98fc21f0dc0f70f53338a271c9fa22b639648d919134fe1c7c803be43f435a9618d49e2517ccce5d207139635c49d9f6f18a66bd6
+  metadata.gz: 82c37d1b9c8d1c7f9d858f8d7aebebfc2ecee4c5e35d35f9a3c949d978e4e97d48f78b9d5f93079e209fc779ab31e5707ecce8ac0d2a4ce8108fc3be2437e1bc
+  data.tar.gz: '06886b335dd0ef5f93f59a09026877bc460e6430b2d2f1902cd31a3179b1bd52b9418a1b43ab558dcf18e92b198506023c3549a065949bb33f881538ec9e018d'

data/History.md

@@ -1,5 +1,83 @@
+# Version 3.29.0
+Release date: Unreleased
+
+### Added
+
+* Allow clicking on file input when using the block version of `attach_file` with Chrome and Firefox
+* Spatial filters (`left_of`, `right_of`, `above`, `below`, `near`)
+* rack_test driver now supports clicking on details elements to open/close them
+
+### Fixed
+
+* rack_test driver correctly determines visibility for open details elements descendants
+
+### Changed
+
+* Results will now be lazily evaluated when using JRuby >= 9.2.8.0
+
+
+# Version 3.28.0
+Release date: 2019-08-03
+
+### Added
+
+* Allow forcing HTML5 or legacy dragging via the `:html5` option to `drag_to` when using Selenium with Chrome or Firefox
+* Autodetection of drag type interprets not seeing the mousedown event as legacy.
+* HTML5 form validation `:valid` node filter added to `:field` and `:fillable_field` selectors
+* When using Capybara registered :puma server - patches Puma 4.0.x to fix SSL connection behavior. Removes
+  default `queue_requests` setting - Issue #2227
+
+# Version 3.27.0
+Release date: 2019-07-28
+
+### Added
+
+* Allow to use chromedriver/geckodriver native `is_element_displayed` endpoint via Selenium
+  driver `native_displayed` option for performance reasons. Disabled by default due to endpoints
+  currently not handling <details> element descendants visibility correctly.
+
+### Fixed
+
+* Ignore negative lookahead/lookbehind regex when performing initial XPath text matching
+* Reloading of elements found via `ancestor` and `sibling`
+* Only default puma settings to `queue_requests: false` when using SSL
+* Visibility of descendants of <details> elements is correctly determined when using rack_test
+  and the selenium driver with Capybara optimized atoms
+* local/session storage clearance in Chrome when clearing only one of them - Issue #2233
+
+# Version 3.26.0
+Release date: 2019-07-15
+
+### Added
+
+* `w3c_click_offset` configuration option applies to `right_click` and `double_click` as well as `click`
+* Warning when passing `nil` to the text/content assertions/expectations
+* `Session#server_url` returns the base url the AUT is being run at (when controlled by Capybara)
+* `option` selector type accepts an integer as locator
+
+### Fixed
+
+* Default puma server registration now specifies `queue_requests: false` - Issue #2227
+* Workaround issue with FF 68 and hanging during reset if a system modal is visible
+* Don't expand file path if it's already absolute - Issue #2228
+
+# Version 3.25.0
+Release date: 2019-06-27
+
+### Added
+
+* Animation disabler also disables before and after pseudoelements - Issue #2221 [Daniel Heath]
+* `w3c_click_offset` configuration option to determine whether click offsets are calculated from element
+  center or top left corner
+
+### Fixed
+
+* Woraround issue with chromedriver 76/77 in W3C mode losing mouse state during legacy drag. Only fixed if
+  both source and target are simultaenously inside the viewport - Issue #2223
+* Negative ancestor expectations/predicates were incorrectly checking siblings rather than ancestors
+
 # Version 3.24.0
-Release date: 2079-06-13
+Release date: 2019-06-13
 
 ### Added
 

data/README.md

@@ -7,7 +7,7 @@
 [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/jnicklas/capybara?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![SemVer](https://api.dependabot.com/badges/compatibility_score?dependency-name=capybara&package-manager=bundler&version-scheme=semver)](https://dependabot.com/compatibility-score.html?dependency-name=capybara&package-manager=bundler&version-scheme=semver)
 
-**Note** You are viewing the README for the 3.24.x version of Capybara.
+**Note** You are viewing the README for the 3.29.x version of Capybara.
 
 Capybara helps you test web applications by simulating how a real user would
 interact with your app. It is agnostic about the driver running your tests and
@@ -391,7 +391,7 @@ Capybara supports [Selenium 3.5+
 In order to use Selenium, you'll need to install the `selenium-webdriver` gem,
 and add it to your Gemfile if you're using bundler.
 
-Capybara pre-registers a number of named drives that use Selenium - they are:
+Capybara pre-registers a number of named drivers that use Selenium - they are:
 
   * :selenium                 => Selenium driving Firefox
   * :selenium_headless        => Selenium driving Firefox in a headless configuration

data/lib/capybara.rb

@@ -97,6 +97,7 @@ module Capybara
     #   and {configure raise_server_errors} is `true`.
     # - **test_id** (Symbol, String, `nil` = `nil`) - Optional attribute to match locator against with built-in selectors along with id.
     # - **threadsafe** (Boolean = `false`) - Whether sessions can be configured individually.
+    # - **w3c_click_offset** (Boolean = 'false') - Whether click offsets should be from element center (true) or top left (false)
     #
     # #### DSL Options
     #
@@ -506,4 +507,5 @@ Capybara.configure do |config|
   config.predicates_wait = true
   config.default_normalize_ws = false
   config.allow_gumbo = false
+  config.w3c_click_offset = false
 end

data/lib/capybara/driver/node.rb

@@ -113,6 +113,10 @@ module Capybara
         !!self[:multiple]
       end
 
+      def rect
+        raise NotSupportedByDriverError, 'Capybara::Driver::Node#rect'
+      end
+
       def path
         raise NotSupportedByDriverError, 'Capybara::Driver::Node#path'
       end

data/lib/capybara/minitest.rb

@@ -9,38 +9,38 @@ module Capybara
       ## Assert text exists
       #
       # @!method assert_text
-      #  see {Capybara::Node::Matchers#assert_text}
+      #   @see Capybara::Node::Matchers#assert_text
 
       ## Assert text does not exist
       #
       # @!method assert_no_text
-      #  see {Capybara::Node::Matchers#assert_no_text}
+      #   @see Capybara::Node::Matchers#assert_no_text
 
       ##
       # Assertion that page title does match
       #
       # @!method assert_title
-      #   see {Capybara::Node::DocumentMatchers#assert_title}
+      #   @see Capybara::Node::DocumentMatchers#assert_title
 
       ##
       # Assertion that page title does not match
       #
       # @!method refute_title
       # @!method assert_no_title
-      #   see {Capybara::Node::DocumentMatchers#assert_no_title}
+      #   @see Capybara::Node::DocumentMatchers#assert_no_title
 
       ##
       # Assertion that current path matches
       #
       # @!method assert_current_path
-      #   see {Capybara::SessionMatchers#assert_current_path}
+      #   @see Capybara::SessionMatchers#assert_current_path
 
       ##
       # Assertion that current page does not match
       #
       # @!method refute_current_path
       # @!method assert_no_current_path
-      #   see {Capybara::SessionMatchers#assert_no_current_path}
+      #   @see Capybara::SessionMatchers#assert_no_current_path
 
       %w[text no_text title no_title current_path no_current_path].each do |assertion_name|
         class_eval <<-ASSERTION, __FILE__, __LINE__ + 1
@@ -64,37 +64,37 @@ module Capybara
       ## Assert selector exists on page
       #
       # @!method assert_selector
-      #   see {Capybara::Node::Matchers#assert_selector}
+      #   @see Capybara::Node::Matchers#assert_selector
 
       ## Assert selector does not exist on page
       #
       # @!method assert_no_selector
-      #   see {Capybara::Node::Matchers#assert_no_selector}
+      #   @see Capybara::Node::Matchers#assert_no_selector
 
       ## Assert element matches selector
       #
       # @!method assert_matches_selector
-      #   see {Capybara::Node::Matchers#assert_matches_selector}
+      #   @see Capybara::Node::Matchers#assert_matches_selector
 
       ## Assert element does not match selector
       #
       # @!method assert_xpath
-      #   see {Capybara::Node::Matchers#assert_not_matches_selector}
+      #   @see Capybara::Node::Matchers#assert_not_matches_selector
 
       ## Assert element has the provided CSS styles
       #
       # @!method assert_matches_style
-      #   see {Capybara::Node::Matchers#assert_matches_style}
+      #   @see Capybara::Node::Matchers#assert_matches_style
 
       ## Assert element has a matching sibling
       #
       # @!method assert_sibling
-      #   see {Capybara::Node::Matchers#assert_sibling}
+      #   @see Capybara::Node::Matchers#assert_sibling
 
       ## Assert element has a matching ancestor
       #
       # @!method assert_ancestor
-      #   see {Capybara::Node::Matchers#assert_ancestor}
+      #   @see Capybara::Node::Matchers#assert_ancestor
 
       %w[selector no_selector matches_style
          all_of_selectors none_of_selectors any_of_selectors
@@ -163,72 +163,72 @@ module Capybara
     # Assertion that there is xpath
     #
     # @!method assert_xpath
-    #   see {Capybara::Node::Matchers#has_xpath?}
+    #   @see Capybara::Node::Matchers#has_xpath?
 
     ##
     # Assertion that there is no xpath
     #
     # @!method refute_xpath
     # @!method assert_no_xpath
-    #   see {Capybara::Node::Matchers#has_no_xpath?}
+    #   @see Capybara::Node::Matchers#has_no_xpath?
 
     ##
     # Assertion that there is css
     #
     # @!method assert_css
-    #   see {Capybara::Node::Matchers#has_css?}
+    #   @see Capybara::Node::Matchers#has_css?
 
     ##
     # Assertion that there is no css
     #
     # @!method refute_css
     # @!method assert_no_css
-    #   see {Capybara::Node::Matchers#has_no_css?}
+    #   @see Capybara::Node::Matchers#has_no_css?
 
     ##
     # Assertion that there is link
     #
     # @!method assert_link
-    #   see {Capybara::Node::Matchers#has_link?}
+    #   @see Capybara::Node::Matchers#has_link?
 
     ##
     # Assertion that there is no link
     #
     # @!method assert_no_link
     # @!method refute_link
-    # see {Capybara::Node::Matchers#has_no_link?}
+    #   @see Capybara::Node::Matchers#has_no_link?
 
     ##
     # Assertion that there is button
     #
     # @!method assert_button
-    #   see {Capybara::Node::Matchers#has_button?}
+    #   @see Capybara::Node::Matchers#has_button?
 
     ##
     # Assertion that there is no button
     #
     # @!method refute_button
     # @!method assert_no_button
-    #   see {Capybara::Node::Matchers#has_no_button?}
+    #   @see Capybara::Node::Matchers#has_no_button?
 
     ##
     # Assertion that there is field
     #
     # @!method assert_field
-    #   see {Capybara::Node::Matchers#has_field?}
+    #   @see Capybara::Node::Matchers#has_field?
 
     ##
     # Assertion that there is no field
     #
     # @!method refute_field
     # @!method assert_no_field
-    #   see {Capybara::Node::Matchers#has_no_field?}
+    #   @see Capybara::Node::Matchers#has_no_field?
 
     ##
     # Assertion that there is checked_field
     #
     # @!method assert_checked_field
-    #   see {Capybara::Node::Matchers#has_checked_field?}
+    #   @see Capybara::Node::Matchers#has_checked_field?
 
     ##
     # Assertion that there is no checked_field
@@ -240,7 +240,7 @@ module Capybara
     # Assertion that there is unchecked_field
     #
     # @!method assert_unchecked_field
-    #   see {Capybara::Node::Matchers#has_unchecked_field?}
+    #   @see Capybara::Node::Matchers#has_unchecked_field?
 
     ##
     # Assertion that there is no unchecked_field
@@ -252,27 +252,27 @@ module Capybara
     # Assertion that there is select
     #
     # @!method assert_select
-    #   see {Capybara::Node::Matchers#has_select?}
+    #   @see Capybara::Node::Matchers#has_select?
 
     ##
     # Assertion that there is no select
     #
     # @!method refute_select
     # @!method assert_no_select
-    #   see {Capybara::Node::Matchers#has_no_select?}
+    #   @see Capybara::Node::Matchers#has_no_select?
 
     ##
     # Assertion that there is table
     #
     # @!method assert_table
-    #   see {Capybara::Node::Matchers#has_table?}
+    #   @see Capybara::Node::Matchers#has_table?
 
     ##
     # Assertion that there is no table
     #
     # @!method refute_table
     # @!method assert_no_table
-    #   see {Capybara::Node::Matchers#has_no_table?}
+    #   @see Capybara::Node::Matchers#has_no_table?
 
     private
 

data/lib/capybara/node/actions.rb

@@ -288,6 +288,7 @@ module Capybara
             execute_script CAPTURE_FILE_ELEMENT_SCRIPT
             yield
             file_field = evaluate_script 'window._capybara_clicked_file_input'
+            raise ArgumentError, "Capybara was unable to determine the file input you're attaching to" unless file_field
           rescue ::Capybara::NotSupportedByDriverError
             warn 'Block mode of `#attach_file` is not supported by the current driver - ignoring.'
           end
@@ -307,12 +308,12 @@ module Capybara
         synchronize(Capybara::Queries::BaseQuery.wait(options, session_options.default_max_wait_time)) do
           begin
             find(:select, from, options)
-          rescue Capybara::ElementNotFound => select_error
+          rescue Capybara::ElementNotFound => select_error # rubocop:disable Naming/RescuedExceptionsVariableName
             raise if %i[selected with_selected multiple].any? { |option| options.key?(option) }
 
             begin
               find(:datalist_input, from, options)
-            rescue Capybara::ElementNotFound => dlinput_error
+            rescue Capybara::ElementNotFound => dlinput_error # rubocop:disable Naming/RescuedExceptionsVariableName
               raise Capybara::ElementNotFound, "#{select_error.message} and #{dlinput_error.message}"
             end
           end

data/lib/capybara/node/element.rb

@@ -157,14 +157,15 @@ module Capybara
       #   Both x: and y: must be specified if an offset is wanted, if not specified the click will occur at the middle of the element.
       #   @overload $0(*modifier_keys, wait: nil, **offset)
       #     @param *modifier_keys [:alt, :control, :meta, :shift] ([]) Keys to be held down when clicking
-      #     @option offset [Integer] x  X coordinate to offset the click location from the top left corner of the element
-      #     @option offset [Integer] y  Y coordinate to offset the click location from the top left corner of the element
+      #     @option options [Integer] x  X coordinate to offset the click location. If {Capybara.configure w3c_click_offset} is `true` the
+      #       offset will be from the element center, otherwise it will be from the top left corner of the element
+      #     @option options [Integer] y  Y coordinate to offset the click location. If {Capybara.configure w3c_click_offset} is `true` the
+      #       offset will be from the element center, otherwise it will be from the top left corner of the element
       # @return [Capybara::Node::Element]  The element
-      def click(*keys, wait: nil, **offset)
-        raise ArgumentError, 'You must specify both x: and y: for a click offset' if nil ^ offset[:x] ^ offset[:y]
-
-        synchronize(wait) { base.click(Array(keys), offset) }
-        self
+      def click(*keys, **options)
+        perform_click_action(keys, options) do |k, opts|
+          base.click(k, opts)
+        end
       end
 
       ##
@@ -174,11 +175,10 @@ module Capybara
       # @macro action_waiting_behavior
       # @macro click_modifiers
       # @return [Capybara::Node::Element]  The element
-      def right_click(*keys, wait: nil, **offset)
-        raise ArgumentError, 'You must specify both x: and y: for a click offset' if nil ^ offset[:x] ^ offset[:y]
-
-        synchronize(wait) { base.right_click(keys, offset) }
-        self
+      def right_click(*keys, **options)
+        perform_click_action(keys, options) do |k, opts|
+          base.right_click(k, opts)
+        end
       end
 
       ##
@@ -188,11 +188,10 @@ module Capybara
       # @macro action_waiting_behavior
       # @macro click_modifiers
       # @return [Capybara::Node::Element]  The element
-      def double_click(*keys, wait: nil, **offset)
-        raise ArgumentError, 'You must specify both x: and y: for a click offset' if nil ^ offset[:x] ^ offset[:y]
-
-        synchronize(wait) { base.double_click(keys, offset) }
-        self
+      def double_click(*keys, **options)
+        perform_click_action(keys, options) do |k, opts|
+          base.double_click(k, opts)
+        end
       end
 
       ##
@@ -372,6 +371,10 @@ module Capybara
         synchronize { base.path }
       end
 
+      def rect
+        synchronize { base.rect }
+      end
+
       ##
       #
       # Trigger any event on the current element, for example mouseover or focus
@@ -397,8 +400,13 @@ module Capybara
       #
       # @param [Capybara::Node::Element] node     The element to drag to
       # @param [Hash] options  Driver specific options for dragging. May not be supported by all drivers.
+      # @option options [Numeric] :delay   (0.05) When using Chrome/Firefox with Selenium and HTML5 dragging this is the number
+      #                                    of seconds between each stage of the drag.
+      # @option options [Boolean] :html5   When using Chrome/Firefox with Selenium enables to force the use of HTML5
+      #                                    (true) or legacy (false) dragging. If not specified the driver will attempt to
+      #                                    detect the correct method to use.
       #
-      # @return [Capybara::Node::Element]  The element
+      # @return [Capybara::Node::Element]  The dragged element
       def drag_to(node, **options)
         synchronize { base.drag_to(node.base, **options) }
         self
@@ -511,11 +519,34 @@ module Capybara
         JS
       end
 
+      ##
+      #
+      # Toggle the elements background color between white and black for a period of time.
+      #
+      # @return [Capybara::Node::Element]  The element
+      def flash
+        execute_script(<<~JS, 100)
+          async function flash(el, delay){
+            var old_bg = el.style.backgroundColor;
+            var colors = ["black", "white"];
+            for(var i=0; i<20; i++){
+              el.style.backgroundColor = colors[i % colors.length];
+              await new Promise(resolve => setTimeout(resolve, delay));
+            }
+            el.style.backgroundColor = old_bg;
+          }
+          flash(this, arguments[0]);
+        JS
+
+        self
+      end
+
       # @api private
       def reload
         if @allow_reload
           begin
-            reloaded = query_scope.reload.first(@query.name, @query.locator, @query.options)
+            reloaded = @query.resolve_for(query_scope.reload)&.first
+
             @base = reloaded.base if reloaded
           rescue StandardError => e
             raise e unless catch_error?(e)
@@ -553,6 +584,16 @@ module Capybara
           return result;
         }).apply(this, arguments)
       JS
+
+    private
+
+      def perform_click_action(keys, wait: nil, **options)
+        raise ArgumentError, 'You must specify both x: and y: for a click offset' if nil ^ options[:x] ^ options[:y]
+
+        options[:offset] ||= :center if session_options.w3c_click_offset
+        synchronize(wait) { yield keys, options }
+        self
+      end
     end
   end
 end