capybara 3.23.0 → 3.35.3

data/spec/selenium_spec_firefox_remote.rb

@@ -50,12 +50,6 @@ module TestSessions
   RemoteFirefox = Capybara::Session.new(FIREFOX_REMOTE_DRIVER, TestApp)
 end
 
-TestSessions::RemoteFirefox.driver.browser.file_detector = lambda do |args|
-  # args => ["/path/to/file"]
-  str = args.first.to_s
-  str if File.exist?(str)
-end
-
 skipped_tests = %i[response_headers status_code trigger download]
 
 Capybara::SpecHelper.run_specs TestSessions::RemoteFirefox, FIREFOX_REMOTE_DRIVER.to_s, capybara_skip: skipped_tests do |example|
@@ -71,8 +65,6 @@ Capybara::SpecHelper.run_specs TestSessions::RemoteFirefox, FIREFOX_REMOTE_DRIVE
   when /#accept_confirm should work with nested modals$/
     # skip because this is timing based and hence flaky when set to pending
     skip 'Broken in FF 63 - https://bugzilla.mozilla.org/show_bug.cgi?id=1487358' if firefox_gte?(63, @session)
-  when 'Capybara::Session selenium_firefox_remote #attach_file with a block can upload by clicking the file input'
-    pending "Geckodriver doesn't allow clicking on file inputs"
   end
 end
 

data/spec/selenium_spec_ie.rb

@@ -39,12 +39,7 @@ Capybara.register_driver :selenium_ie do |app|
     Capybara::Selenium::Driver.new(app,
                                    browser: :remote,
                                    options: options,
-                                   url: url).tap do |driver|
-      driver.browser.file_detector = lambda do |args|
-        str = args.first.to_s
-        str if File.exist?(str)
-      end
-    end
+                                   url: url)
   else
     Capybara::Selenium::Driver.new(
       app,

data/spec/server_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 RSpec.describe Capybara::Server do
   it 'should spool up a rack server' do
     app = proc { |_env| [200, {}, ['Hello Server!']] }
-    server = Capybara::Server.new(app).boot
+    server = described_class.new(app).boot
 
     res = Net::HTTP.start(server.host, server.port) { |http| http.get('/') }
 
@@ -14,7 +14,7 @@ RSpec.describe Capybara::Server do
 
   it 'should do nothing when no server given' do
     expect do
-      Capybara::Server.new(nil).boot
+      described_class.new(nil).boot
     end.not_to raise_error
   end
 
@@ -26,12 +26,12 @@ RSpec.describe Capybara::Server do
       app = proc { |_env| [200, {}, ['Hello Server!']] }
 
       Capybara.server_host = '127.0.0.1'
-      server = Capybara::Server.new(app).boot
+      server = described_class.new(app).boot
       res = Net::HTTP.get(URI("http://127.0.0.1:#{server.port}"))
       expect(res).to eq('Hello Server!')
 
       Capybara.server_host = '0.0.0.0'
-      server = Capybara::Server.new(app).boot
+      server = described_class.new(app).boot
       res = Net::HTTP.get(URI("http://127.0.0.1:#{server.port}"))
       expect(res).to eq('Hello Server!')
     ensure
@@ -43,7 +43,7 @@ RSpec.describe Capybara::Server do
     Capybara.server_port = 22789
 
     app = proc { |_env| [200, {}, ['Hello Server!']] }
-    server = Capybara::Server.new(app).boot
+    server = described_class.new(app).boot
 
     res = Net::HTTP.start(server.host, 22789) { |http| http.get('/') }
     expect(res.body).to include('Hello Server')
@@ -53,7 +53,7 @@ RSpec.describe Capybara::Server do
 
   it 'should use given port' do
     app = proc { |_env| [200, {}, ['Hello Server!']] }
-    server = Capybara::Server.new(app, port: 22790).boot
+    server = described_class.new(app, port: 22790).boot
 
     res = Net::HTTP.start(server.host, 22790) { |http| http.get('/') }
     expect(res.body).to include('Hello Server')
@@ -66,7 +66,7 @@ RSpec.describe Capybara::Server do
     apps = responses.map do |response|
       proc { |_env| [200, {}, [response]] }
     end
-    servers = apps.map { |app| Capybara::Server.new(app).boot }
+    servers = apps.map { |app| described_class.new(app).boot }
 
     servers.each_with_index do |server, idx|
       result = Net::HTTP.start(server.host, server.port) { |http| http.get('/') }
@@ -74,28 +74,72 @@ RSpec.describe Capybara::Server do
     end
   end
 
-  it 'should support SSL' do
-    begin
-      key = File.join(Dir.pwd, 'spec', 'fixtures', 'key.pem')
-      cert = File.join(Dir.pwd, 'spec', 'fixtures', 'certificate.pem')
-      Capybara.server = :puma, { Host: "ssl://#{Capybara.server_host}?key=#{key}&cert=#{cert}" }
-      app = proc { |_env| [200, {}, ['Hello SSL Server!']] }
-      server = Capybara::Server.new(app).boot
+  it 'should handle that getting available ports fails randomly' do
+    # Use a port to force a EADDRINUSE error to be generated
+    server = TCPServer.new('0.0.0.0', 0)
+    server_port = server.addr[1]
+    d_server = instance_double('TCPServer', addr: [nil, server_port, nil, nil], close: nil)
+    call_count = 0
+    allow(TCPServer).to receive(:new).and_wrap_original do |m, *args|
+      call_count.zero? ? d_server : m.call(*args)
+    ensure
+      call_count += 1
+    end
 
-      expect do
-        Net::HTTP.start(server.host, server.port, max_retries: 0) { |http| http.get('/__identify__') }
-      end.to(raise_error do |e|
-        expect(e.is_a?(EOFError) || e.is_a?(Net::ReadTimeout)).to be true
-      end)
+    port = described_class.new(Object.new, host: '0.0.0.0').port
+    expect(port).not_to eq(server_port)
+  ensure
+    server&.close
+  end
 
-      res = Net::HTTP.start(server.host, server.port, use_ssl: true, verify_mode: OpenSSL::SSL::VERIFY_NONE) do |https|
-        https.get('/')
-      end
+  it 'should return its #base_url' do
+    app = proc { |_env| [200, {}, ['Hello Server!']] }
+    server = described_class.new(app).boot
+    uri = ::Addressable::URI.parse(server.base_url)
+    expect(uri.to_hash).to include(scheme: 'http', host: server.host, port: server.port)
+  end
 
-      expect(res.body).to include('Hello SSL Server!')
-    ensure
-      Capybara.server = :default
+  it 'should call #clamp on the puma configuration to ensure that environment is a string' do
+    Capybara.server = :puma
+    app_proc = proc { |_env| [200, {}, ['Hello Puma!']] }
+    require 'puma'
+    allow(Puma::Server).to receive(:new).and_wrap_original do |method, app, events, options|
+      # If #clamp is not called on the puma config then this will be a Proc
+      expect(options.fetch(:environment)).to be_a(String)
+      method.call(app, events, options)
+    end
+    server = described_class.new(app_proc).boot
+    expect(Puma::Server).to have_received(:new).with(
+      anything,
+      anything,
+      satisfy { |opts| opts.final_options[:Port] == server.port }
+    )
+  ensure
+    Capybara.server = :default
+  end
+
+  it 'should support SSL' do
+    key = File.join(Dir.pwd, 'spec', 'fixtures', 'key.pem')
+    cert = File.join(Dir.pwd, 'spec', 'fixtures', 'certificate.pem')
+    Capybara.server = :puma, { Host: "ssl://#{Capybara.server_host}?key=#{key}&cert=#{cert}" }
+    app = proc { |_env| [200, {}, ['Hello SSL Server!']] }
+    server = described_class.new(app).boot
+
+    expect do
+      Net::HTTP.start(server.host, server.port, max_retries: 0) { |http| http.get('/__identify__') }
+    end.to(raise_error do |e|
+      expect(e.is_a?(EOFError) || e.is_a?(Net::ReadTimeout)).to be true
+    end)
+
+    res = Net::HTTP.start(server.host, server.port, use_ssl: true, verify_mode: OpenSSL::SSL::VERIFY_NONE) do |https|
+      https.get('/')
     end
+
+    expect(res.body).to include('Hello SSL Server!')
+    uri = ::Addressable::URI.parse(server.base_url)
+    expect(uri.to_hash).to include(scheme: 'https', host: server.host, port: server.port)
+  ensure
+    Capybara.server = :default
   end
 
   context 'When Capybara.reuse_server is true' do
@@ -112,7 +156,7 @@ RSpec.describe Capybara::Server do
     it 'should use the existing server if it already running' do
       app = proc { |_env| [200, {}, ['Hello Server!']] }
 
-      servers = Array.new(2) { Capybara::Server.new(app).boot }
+      servers = Array.new(2) { described_class.new(app).boot }
 
       servers.each do |server|
         res = Net::HTTP.start(server.host, server.port) { |http| http.get('/') }
@@ -132,8 +176,8 @@ RSpec.describe Capybara::Server do
         [200, {}, ['Hello Server!']]
       end
 
-      server1 = Capybara::Server.new(app).boot
-      server2 = Capybara::Server.new(app).boot
+      server1 = described_class.new(app).boot
+      server2 = described_class.new(app).boot
 
       expect do
         start_request(server1, 1.0)
@@ -157,7 +201,7 @@ RSpec.describe Capybara::Server do
     it 'should not reuse an already running server' do
       app = proc { |_env| [200, {}, ['Hello Server!']] }
 
-      servers = Array.new(2) { Capybara::Server.new(app).boot }
+      servers = Array.new(2) { described_class.new(app).boot }
 
       servers.each do |server|
         res = Net::HTTP.start(server.host, server.port) { |http| http.get('/') }
@@ -177,8 +221,8 @@ RSpec.describe Capybara::Server do
         [200, {}, ['Hello Server!']]
       end
 
-      server1 = Capybara::Server.new(app).boot
-      server2 = Capybara::Server.new(app).boot
+      server1 = described_class.new(app).boot
+      server2 = described_class.new(app).boot
 
       expect do
         start_request(server1, 1.0)
@@ -193,24 +237,42 @@ RSpec.describe Capybara::Server do
   end
 
   it 'should raise server errors when the server errors before the timeout' do
-    begin
-      Capybara.register_server :kaboom do
-        sleep 0.1
-        raise 'kaboom'
-      end
-      Capybara.server = :kaboom
+    Capybara.register_server :kaboom do
+      sleep 0.1
+      raise 'kaboom'
+    end
+    Capybara.server = :kaboom
 
-      expect do
-        Capybara::Server.new(proc { |e| }).boot
-      end.to raise_error(RuntimeError, 'kaboom')
-    ensure
-      Capybara.server = :default
+    expect do
+      described_class.new(proc { |e| }).boot
+    end.to raise_error(RuntimeError, 'kaboom')
+  ensure
+    Capybara.server = :default
+  end
+
+  it 'should raise an error when there are pending requests' do
+    app = proc do |env|
+      request = Rack::Request.new(env)
+      sleep request.params['wait_time'].to_f
+      [200, {}, ['Hello Server!']]
     end
+
+    server = described_class.new(app).boot
+
+    expect do
+      start_request(server, 59.0)
+      server.wait_for_pending_requests
+    end.not_to raise_error
+
+    expect do
+      start_request(server, 61.0)
+      server.wait_for_pending_requests
+    end.to raise_error('Requests did not finish in 60 seconds: ["/?wait_time=61.0"]')
   end
 
   it 'is not #responsive? when Net::HTTP raises a SystemCallError' do
     app = -> { [200, {}, ['Hello, world']] }
-    server = Capybara::Server.new(app)
+    server = described_class.new(app)
     allow(Net::HTTP).to receive(:start).and_raise(SystemCallError.allocate)
     expect(server.responsive?).to eq false
   end
@@ -225,7 +287,7 @@ RSpec.describe Capybara::Server do
       response = Net::HTTPSuccess.allocate
       allow(response).to receive(:body).and_return app.object_id.to_s
       allow(Net::HTTP).to receive(:start).with(anything, anything, hash_including(use_ssl: true)).and_return(response).once
-      Capybara::Server.new(app).boot
+      described_class.new(app).boot
       expect(Net::HTTP).to have_received(:start).exactly(3).times
     end
   end

data/spec/session_spec.rb

@@ -3,16 +3,16 @@
 require 'spec_helper'
 
 RSpec.describe Capybara::Session do
-  context '#new' do
+  describe '#new' do
     it 'should raise an error if passed non-existent driver' do
       expect do
-        Capybara::Session.new(:quox, TestApp).driver
+        described_class.new(:quox, TestApp).driver
       end.to raise_error(Capybara::DriverNotFoundError)
     end
 
     it 'verifies a passed app is a rack app' do
       expect do
-        Capybara::Session.new(:unknown, random: 'hash')
+        described_class.new(:unknown, random: 'hash')
       end.to raise_error TypeError, 'The second parameter to Session::new should be a rack app if passed.'
     end
   end
@@ -75,14 +75,14 @@ RSpec.describe Capybara::Session do
 
   context 'quit' do
     it 'will reset the driver' do
-      session = Capybara::Session.new(:rack_test, TestApp)
+      session = described_class.new(:rack_test, TestApp)
       driver = session.driver
       session.quit
       expect(session.driver).not_to eql driver
     end
 
     it 'resets the document' do
-      session = Capybara::Session.new(:rack_test, TestApp)
+      session = described_class.new(:rack_test, TestApp)
       document = session.document
       session.quit
       expect(session.document.base).not_to eql document.base

data/spec/shared_selenium_node.rb

@@ -6,7 +6,7 @@ require 'selenium-webdriver'
 RSpec.shared_examples 'Capybara::Node' do |session, _mode|
   let(:session) { session }
 
-  context '#content_editable?' do
+  describe '#content_editable?' do
     it 'returns true when the element is content editable' do
       session.visit('/with_js')
       expect(session.find(:css, '#existing_content_editable').base.content_editable?).to be true
@@ -19,11 +19,65 @@ RSpec.shared_examples 'Capybara::Node' do |session, _mode|
     end
   end
 
-  context '#send_keys' do
+  describe '#send_keys' do
     it 'should process space' do
       session.visit('/form')
       session.find(:css, '#address1_city').send_keys('ocean', [:shift, :space, 'side'])
       expect(session.find(:css, '#address1_city').value).to eq 'ocean SIDE'
     end
   end
+
+  describe '#[]' do
+    it 'should work for spellcheck' do
+      session.visit('/with_html')
+      expect(session.find('//input[@spellcheck="TRUE"]')[:spellcheck]).to eq('true')
+      expect(session.find('//input[@spellcheck="FALSE"]')[:spellcheck]).to eq('false')
+    end
+  end
+
+  describe '#set' do
+    it 'respects maxlength when using rapid set' do
+      session.visit('/form')
+      inp = session.find(:css, '#long_length')
+      value = (0...50).map { |i| ((i % 26) + 65).chr }.join
+      inp.set(value, rapid: true)
+      expect(inp.value).to eq value[0...35]
+    end
+  end
+
+  describe '#visible?' do
+    let(:bridge) do
+      session.driver.browser.send(:bridge)
+    end
+
+    around do |example|
+      native_displayed = session.driver.options[:native_displayed]
+      example.run
+      session.driver.options[:native_displayed] = native_displayed
+    end
+
+    before do
+      allow(bridge).to receive(:execute_atom).and_call_original
+    end
+
+    it 'will use native displayed if told to' do
+      pending "Chromedriver < 76.0.3809.25 doesn't support native displayed in W3C mode" if chrome_lt?(76, session) && (ENV['W3C'] != 'false')
+
+      session.driver.options[:native_displayed] = true
+      session.visit('/form')
+      session.find(:css, '#address1_city', visible: true)
+
+      expect(bridge).not_to have_received(:execute_atom)
+    end
+
+    it "won't use native displayed if told not to" do
+      skip 'Non-W3C uses native' if chrome?(session) && (ENV['W3C'] == 'false')
+
+      session.driver.options[:native_displayed] = false
+      session.visit('/form')
+      session.find(:css, '#address1_city', visible: true)
+
+      expect(bridge).to have_received(:execute_atom).with(:isDisplayed, any_args)
+    end
+  end
 end

data/spec/shared_selenium_session.rb

@@ -72,7 +72,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       end
     end
 
-    context '#fill_in_with empty string and no options' do
+    describe '#fill_in_with empty string and no options' do
       it 'should trigger change when clearing a field' do
         pending "safaridriver doesn't trigger change for clear" if safari?(session)
         session.visit('/with_js')
@@ -83,7 +83,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       end
     end
 
-    context '#fill_in with { :clear => :backspace } fill_option', requires: [:js] do
+    describe '#fill_in with { :clear => :backspace } fill_option', requires: [:js] do
       before do
         # Firefox has an issue with change events if the main window doesn't think it's focused
         session.execute_script('window.focus()')
@@ -150,7 +150,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       end
     end
 
-    context '#fill_in with { clear: :none } fill_options' do
+    describe '#fill_in with { clear: :none } fill_options' do
       it 'should append to content in a field' do
         pending 'Safari overwrites by default - need to figure out a workaround' if safari?(session)
 
@@ -160,9 +160,18 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
                         fill_options: { clear: :none })
         expect(session.find(:fillable_field, 'form_first_name').value).to eq('JohnHarry')
       end
+
+      it 'works with rapid fill' do
+        pending 'Safari overwrites by default - need to figure out a workaround' if safari?(session)
+
+        long_string = (0...60).map { |i| ((i % 26) + 65).chr }.join
+        session.visit('/form')
+        session.fill_in('form_first_name', with: long_string, fill_options: { clear: :none })
+        expect(session.find(:fillable_field, 'form_first_name').value).to eq("John#{long_string}")
+      end
     end
 
-    context  '#fill_in with Date' do
+    describe '#fill_in with Date' do
       before do
         session.visit('/form')
         session.find(:css, '#form_date').execute_script <<-JS
@@ -194,7 +203,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       end
     end
 
-    context '#fill_in with { clear: Array } fill_options' do
+    describe '#fill_in with { clear: Array } fill_options' do
       it 'should pass the array through to the element' do
         # this is mainly for use with [[:control, 'a'], :backspace] - however since that is platform dependant I'm testing with something less useful
         session.visit('/form')
@@ -205,6 +214,26 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       end
     end
 
+    describe '#fill_in with Emoji' do
+      it 'sends emojis' do
+        session.visit('/form')
+        session.fill_in('form_first_name', with: 'a😀cd😴 🛌🏽🇵🇹 e🤾🏽‍♀️f')
+        expect(session.find(:fillable_field, 'form_first_name').value).to eq('a😀cd😴 🛌🏽🇵🇹 e🤾🏽‍♀️f')
+      end
+    end
+
+    describe '#send_keys' do
+      it 'defaults to sending keys to the document.activeElement' do
+        session.visit('/form')
+
+        expect(session.evaluate_script('document.activeElement')).to eq(session.find('//body'))
+
+        session.send_keys(:tab)
+
+        expect(session.evaluate_script('document.activeElement')).to eq(session.first(:field))
+      end
+    end
+
     describe '#path' do
       it 'returns xpath' do
         # this is here because it is testing for an XPath that is specific to the algorithm used in the selenium driver
@@ -299,8 +328,9 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
     describe 'Element#click' do
       it 'should handle fixed headers/footers' do
         session.visit('/with_fixed_header_footer')
-        # session.click_link('Go to root')
-        session.find(:link, 'Go to root').click
+        session.using_wait_time(2) do
+          session.find(:link, 'Go to root').click
+        end
         expect(session).to have_current_path('/')
       end
     end
@@ -321,6 +351,15 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
         session.click_button('Upload Multiple')
         expect(session.body).to include('5 | ') # number of files
       end
+
+      it 'can attach a relative file' do
+        pending 'Geckdoriver on windows requires alternate file separator which path expansion replaces' if Gem.win_platform? && firefox?(session)
+
+        session.visit('/form')
+        session.attach_file('Single Document', 'spec/fixtures/capybara.csv')
+        session.click_button('Upload Single')
+        expect(session.body).to include('Content-type: text/csv')
+      end
     end
 
     context 'Windows' do
@@ -348,11 +387,66 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
           expect(@animation_session).to have_no_link('transition me away', wait: 0.5)
         end
 
-        it 'should disable CSS animations' do
+        it 'should disable CSS animations (set to 0s)' do
           @animation_session.visit('with_animation')
+          sleep 1
           @animation_session.click_link('animate me away')
           expect(@animation_session).to have_no_link('animate me away', wait: 0.5)
         end
+
+        it 'should disable CSS animations on pseudo elements (set to 0s)' do
+          @animation_session.visit('with_animation')
+          sleep 1
+          @animation_session.find_link('animate me away').right_click
+          expect(@animation_session).to have_content('Animation Ended', wait: 0.1)
+        end
+
+        it 'should scroll the page instantly', requires: [:js] do
+          @animation_session.visit('with_animation')
+          scroll_y = @animation_session.evaluate_script(<<~JS)
+            (function(){
+              window.scrollTo(0,500);
+              return window.scrollY;
+            })()
+          JS
+          expect(scroll_y).to eq 500
+        end
+
+        it 'should scroll the page instantly without jquery animation', requires: [:js] do
+          @animation_session.visit('with_jquery_animation')
+          @animation_session.click_link('scroll top 500')
+          scroll_y = @animation_session.evaluate_script('window.scrollY')
+          expect(scroll_y).to eq 500
+        end
+      end
+
+      context 'when set to `false`' do
+        before(:context) do # rubocop:disable RSpec/BeforeAfterAll
+          skip "Safari doesn't support multiple sessions" if safari?(session)
+          # NOTE: Although Capybara.SpecHelper.reset! sets Capybara.disable_animation to false,
+          # it doesn't affect any of these tests because the settings are applied per-session
+          Capybara.disable_animation = false
+          @animation_session = Capybara::Session.new(session.mode, TestApp.new)
+        end
+
+        it 'should scroll the page with a smooth animation', requires: [:js] do
+          @animation_session.visit('with_animation')
+          scroll_y = @animation_session.evaluate_script(<<~JS)
+            (function(){
+              window.scrollTo(0,500);
+              return window.scrollY;
+            })()
+          JS
+          # measured over 0.5 seconds: 0, 75, 282, 478, 500
+          expect(scroll_y).to be < 500
+        end
+
+        it 'should scroll the page with jquery animation', requires: [:js] do
+          @animation_session.visit('with_jquery_animation')
+          @animation_session.click_link('scroll top 500')
+          scroll_y = @animation_session.evaluate_script('window.scrollY')
+          expect(scroll_y).to be < 500
+        end
       end
 
       context 'if we pass in css that matches elements' do
@@ -366,12 +460,14 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
 
         it 'should disable CSS transitions' do
           @animation_session_with_matching_css.visit('with_animation')
+          sleep 1
           @animation_session_with_matching_css.click_link('transition me away')
           expect(@animation_session_with_matching_css).to have_no_link('transition me away', wait: 0.5)
         end
 
         it 'should disable CSS animations' do
           @animation_session_with_matching_css.visit('with_animation')
+          sleep 1
           @animation_session_with_matching_css.click_link('animate me away')
           expect(@animation_session_with_matching_css).to have_no_link('animate me away', wait: 0.5)
         end
@@ -388,6 +484,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
 
         it 'should not disable CSS transitions' do
           @animation_session_without_matching_css.visit('with_animation')
+          sleep 1
           @animation_session_without_matching_css.click_link('transition me away')
           sleep 0.5 # Wait long enough for click to have been processed
           expect(@animation_session_without_matching_css).to have_link('transition me away', wait: false)
@@ -396,6 +493,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
 
         it 'should not disable CSS animations' do
           @animation_session_without_matching_css.visit('with_animation')
+          sleep 1
           @animation_session_without_matching_css.click_link('animate me away')
           sleep 0.5 # Wait long enough for click to have been processed
           expect(@animation_session_without_matching_css).to have_link('animate me away', wait: false)
@@ -409,7 +507,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       it 'can find html5 svg elements' do
         session.visit('with_html5_svg')
         expect(session).to have_selector(:element, :svg)
-        expect(session).to have_selector(:element, :rect, visible: true)
+        expect(session).to have_selector(:element, :rect, visible: :visible)
         expect(session).to have_selector(:element, :circle)
         expect(session).to have_selector(:element, :linearGradient, visible: :all)
       end
@@ -425,21 +523,30 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
       context 'controlled components' do
         it 'can set and clear a text field' do
           skip "This test doesn't support older browsers" if ie?(session)
-          # session.visit 'https://reactjs.org/docs/forms.html'
-          # session.all(:css, 'h2#controlled-components ~ p a', text: 'Try it on CodePen')[0].click
-          # copied into local view
+
           session.visit 'react'
-          # Not necessary when accessed locally
-          # session.within_frame(:css, 'iframe.result-iframe:not([src=""])', wait: 10) do
+
           session.fill_in('Name:', with: 'abc')
           session.accept_prompt 'A name was submitted: abc' do
             session.click_button('Submit')
           end
+
           session.fill_in('Name:', with: '')
           session.accept_prompt(/A name was submitted: $/) do
             session.click_button('Submit')
           end
-          # end
+        end
+
+        it 'works with rapid fill' do
+          skip "This test doesn't support older browsers" if ie?(session)
+
+          session.visit 'react'
+          long_string = (0...60).map { |i| ((i % 26) + 65).chr }.join
+
+          session.fill_in('Name:', with: long_string)
+          session.accept_prompt "A name was submitted: #{long_string}" do
+            session.click_button('Submit')
+          end
         end
       end
     end