capybara 3.19.0 → 3.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cdee23fb17ec93c0e1c5e8e9b61607f11211e065ff94a99084dc28e3ff0cc24c
-  data.tar.gz: 428519d0593d850d7c355e7300ed0805637dbbd498805b70452dcb9521a78a04
+  metadata.gz: '087a3e5a863f14cabebd8344fa0e2f04cb5c48c386014e5fd46eab2e715a8040'
+  data.tar.gz: 2ea4bc5aec32f6a7bd63856d922264d29d9629f4c6af71867d30b963d2f04697
 SHA512:
-  metadata.gz: dd137a4698f4c9e797ecce6da32a1fb62e2011daf412b9898ecd85f1e8146447278c0fd60350b9b9baeff37ac35d1f3da62794ec7c17dd87509f767d5847cfa7
-  data.tar.gz: 85625218afed65274c180acb2e9cf2f8e809e52855150966f07c6db8e181dd0cd28bfd908ce39a1a53b52cdbcb09af631e7a4d5d694afd9af4330cd0588122fd
+  metadata.gz: cbc11a7fe022eb230aa9e9342d26b88619cb3cb65931b89487ff448575e6cb794e7460679bd1c37c336bdd65229ca72b4e489b5fbe1a5e2ea7ff92945bb1a1ca
+  data.tar.gz: 0a3103be3113216c40efa1cb22cc261141ed940e205c6e9e9483233c5e672079da5b6950aa4f1bf6871524a6f803eb400ed735f48e13429f57eaa9e8376ae367

data/History.md

@@ -1,11 +1,36 @@
+# Version 3.20.0
+Release date: 2019-05-14
+### Added
+
+* `Node#obscured?` to check viewport presence and element overlap
+* `:obscured` system filter to check whether elements are obscured in finders, assertions, and expectations
+* :label selector :for option can be a regexp
+* Significantly smaller `isDisplayed`/`getAttribute` atoms for selenium driver. If these produce issues you can disable their use
+  by setting an environment variable named 'DISABLE_CAPYBARA_SELENIUM_OPTIMIZATIONS' (Please also report any issues).
+* `href: false` option with `find_link`/`click_link`/:link selector ignores `href` presence/absence
+
+### Fixed
+
+* Workaround Safari issue with send_keys not correctly using top level modifiers
+* Workaround Safari not retrying click due to incorrect error type
+* Fix Safari attach_file block mode when clicking elements associated to the file input
+* Workaround Safari issue with repeated hover
+
+# Version 3.19.1
+Release date: 2019-05-11
+
+### Fixed
+
+* Fix access to specializations when Selenium::Driver is subclassed [James Mead]
+
 # Version 3.19.0
 Release date: 2019-05-09
 
 ### Added
 
 
-* Syntactic sugar `#once`, `#twice`, `#thrice`, `#excatly`, `#at_least`, `#at_most` to
-  `have_selector`, `have_css`, `have_xpath`, and `have_text` RSpec matchers
+* Syntactic sugar `#once`, `#twice`, `#thrice`, `#exactly`, `#at_least`, `#at_most`, and `#times`
+  added to `have_selector`, `have_css`, `have_xpath`, and `have_text` RSpec matchers
 * Support for multiple expression types in Selector definitions
 * Reduced wirecalls for common actions in Selenium driver
 

data/README.md

@@ -7,7 +7,7 @@
 [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/jnicklas/capybara?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![SemVer](https://api.dependabot.com/badges/compatibility_score?dependency-name=capybara&package-manager=bundler&version-scheme=semver)](https://dependabot.com/compatibility-score.html?dependency-name=capybara&package-manager=bundler&version-scheme=semver)
 
-**Note** You are viewing the README for the 3.19.x version of Capybara.
+**Note** You are viewing the README for the 3.20.x version of Capybara.
 
 
 Capybara helps you test web applications by simulating how a real user would

data/lib/capybara/driver/node.rb

@@ -85,6 +85,10 @@ module Capybara
         raise NotImplementedError
       end
 
+      def obscured?
+        raise NotImplementedError
+      end
+
       def checked?
         raise NotImplementedError
       end

data/lib/capybara/node/actions.rb

@@ -191,7 +191,7 @@ module Capybara
       #   @macro waiting_behavior
       #
       #   @param value [String] Which option to select
-      #   @param from [String]  The id, Capybara.test_id atrtribute, name or label of the select box
+      #   @param from [String]  The id, Capybara.test_id attribute, name or label of the select box
       #
       # @return [Capybara::Node::Element]  The option element selected
       def select(value = nil, from: nil, **options)
@@ -393,9 +393,10 @@ module Capybara
       JS
 
       CAPTURE_FILE_ELEMENT_SCRIPT = <<~'JS'
-        document.addEventListener('click', function(e){
+        document.addEventListener('click', function file_catcher(e){
           if (e.target.matches("input[type='file']")) {
             window._capybara_clicked_file_input = e.target;
+            this.removeEventListener('click', file_catcher);
             e.preventDefault();
           }
         })

data/lib/capybara/node/element.rb

@@ -290,6 +290,17 @@ module Capybara
         synchronize { base.visible? }
       end
 
+      ##
+      #
+      # Whether or not the element is currently in the viewport and it (or descendants)
+      # would be considered clickable at the elements center point.
+      #
+      # @return [Boolean]     Whether the elements center is obscured.
+      #
+      def obscured?
+        synchronize { base.obscured? }
+      end
+
       ##
       #
       # Whether or not the element is checked.

data/lib/capybara/node/finders.rb

@@ -31,6 +31,9 @@ module Capybara
       #                                              * :all - same as false; finds visible and invisible elements.
       #                                              * :hidden - only finds invisible elements.
       #                                              * :visible - same as true; only finds visible elements.
+      #   @option options [Boolean] obscured  Only find elements with the specified obscured state:
+      #                                       * true - only find elements whose centerpoint is not in the viewport or is obscured by another non-descendant element.
+      #                                       * false - only find elements whose centerpoint is in the viewport and is not obscured by other non-descendant elements.
       #   @option options [String, Regexp]  id           Only find elements with an id that matches the value passed
       #   @option options [String, Array<String>, Regexp] class  Only find elements with matching class/classes.
       #                                            + Absence of a class can be checked by prefixing the class name with !
@@ -139,7 +142,7 @@ module Capybara
       #
       #   @macro waiting_behavior
       #
-      #   @option options [String,Regexp,nil] href        Value to match against the links href, if nil finds link placeholders (<a> elements with no href attribute)
+      #   @option options [String,Regexp,nil] href        Value to match against the links href, if nil finds link placeholders (<a> elements with no href attribute), if false ignores the href
       #   @option options [String, Regexp] id                 Match links with the id provided
       #   @option options [String] title              Match links with the title provided
       #   @option options [String] alt                Match links with a contained img element whose alt matches

data/lib/capybara/queries/selector_query.rb

@@ -4,7 +4,8 @@ module Capybara
   module Queries
     class SelectorQuery < Queries::BaseQuery
       attr_reader :expression, :selector, :locator, :options
-      VALID_KEYS = COUNT_KEYS + %i[text id class style visible exact exact_text normalize_ws match wait filter_set]
+      VALID_KEYS = COUNT_KEYS +
+                   %i[text id class style visible obscured exact exact_text normalize_ws match wait filter_set]
       VALID_MATCH = %i[first smart prefer_exact one].freeze
 
       def initialize(*args,
@@ -386,7 +387,7 @@ module Capybara
       def matches_system_filters?(node)
         applied_filters << :system
 
-        matches_visible_filter?(node) &&
+        matches_visibility_filters?(node) &&
           matches_id_filter?(node) &&
           matches_class_filter?(node) &&
           matches_style_filter?(node) &&
@@ -443,14 +444,27 @@ module Capybara
         matches_text_exactly?(node, exact_text)
       end
 
-      def matches_visible_filter?(node)
-        case visible
+      def matches_visibility_filters?(node)
+        obscured = options[:obscured]
+        return (visible != :hidden) && (node.initial_cache[:visible] != false) && !node.obscured? if obscured == false
+
+        vis = case visible
         when :visible then
           node.initial_cache[:visible] || (node.initial_cache[:visible].nil? && node.visible?)
         when :hidden then
           (node.initial_cache[:visible] == false) || (node.initial_cache[:visbile].nil? && !node.visible?)
-        else true
+        else
+          true
         end
+
+        vis && case obscured
+               when true
+                 node.obscured?
+               when false
+                 !node.obscured?
+               else
+                 true
+               end
       end
 
       def matches_text_exactly?(node, value)

data/lib/capybara/selector/definition/label.rb

@@ -11,10 +11,9 @@ Capybara.add_selector(:label, locator_type: [String, Symbol]) do
     end
     if options.key?(:for)
       if (for_option = options[:for].is_a?(Capybara::Node::Element) ? options[:for][:id] : options[:for])
-        with_attr = XPath.attr(:for) == for_option.to_s
-        labelable_elements = %i[button input keygen meter output progress select textarea]
+        with_attr = builder(XPath.self).add_attribute_conditions(for: for_option)
         wrapped = !XPath.attr(:for) &
-                  XPath.descendant(*labelable_elements)[XPath.attr(:id) == for_option.to_s]
+                  builder(XPath.self.descendant(*labelable_elements)).add_attribute_conditions(id: for_option)
         xpath = xpath[with_attr | wrapped]
       end
     end
@@ -22,22 +21,40 @@ Capybara.add_selector(:label, locator_type: [String, Symbol]) do
   end
 
   node_filter(:for) do |node, field_or_value|
-    # Non element values were handled through the expression filter
-    next true unless field_or_value.is_a? Capybara::Node::Element
-
-    if (for_val = node[:for])
-      field_or_value[:id] == for_val
+    case field_or_value
+    when Capybara::Node::Element
+      if (for_val = node[:for])
+        field_or_value[:id] == for_val
+      else
+        field_or_value.find_xpath('./ancestor::label[1]').include? node.base
+      end
+    when Regexp
+      if (for_val = node[:for])
+        field_or_value.match? for_val
+      else
+        node.find_xpath(XPath.descendant(*labelable_elements).to_s)
+            .any? { |n| field_or_value.match? n[:id] }
+      end
     else
-      field_or_value.find_xpath('./ancestor::label[1]').include? node.base
+      # Non element/regexp values were handled through the expression filter
+      true
     end
   end
 
   describe_expression_filters do |**options|
     next unless options.key?(:for) && !options[:for].is_a?(Capybara::Node::Element)
 
-    " for element with id of \"#{options[:for]}\""
+    if options[:for].is_a? Regexp
+      " for element with id matching #{options[:for].inspect}"
+    else
+      " for element with id of \"#{options[:for]}\""
+    end
   end
   describe_node_filters do |**options|
     " for element #{options[:for]}" if options[:for]&.is_a?(Capybara::Node::Element)
   end
+
+  def labelable_elements
+    %i[button input keygen meter output progress select textarea]
+  end
 end

data/lib/capybara/selector/definition/link.rb

@@ -2,7 +2,8 @@
 
 Capybara.add_selector(:link, locator_type: [String, Symbol]) do
   xpath do |locator, href: true, alt: nil, title: nil, **|
-    xpath = builder(XPath.descendant(:a)).add_attribute_conditions(href: href)
+    xpath = XPath.descendant(:a)
+    xpath = builder(xpath).add_attribute_conditions(href: href) unless href == false
 
     unless locator.nil?
       locator = locator.to_s
@@ -35,7 +36,7 @@ Capybara.add_selector(:link, locator_type: [String, Symbol]) do
     desc = +''
     if (href = options[:href])
       desc << " with href #{'matching ' if href.is_a? Regexp}#{href.inspect}"
-    elsif options.key?(:href) # is nil/false specified?
+    elsif options.key?(:href) && href != false # is nil specified?
       desc << ' with no href attribute'
     end
     desc << " with download attribute#{" #{download}" if download.is_a? String}" if download

data/lib/capybara/selector.rb

@@ -48,7 +48,7 @@ require 'capybara/selector/definition'
 #       * :title (String) — Matches the title attribute
 #       * :alt (String) — Matches the alt attribute of a contained img element
 #       * :class (String, Array<String>, Regexp, XPath::Expression) — Matches the class(es) provided
-#       * :href (String, Regexp, nil) — Matches the normalized href of the link, if nil will find <a> elements with no href attribute
+#       * :href (String, Regexp, nil, false) — Matches the normalized href of the link, if nil will find <a> elements with no href attribute, if false ignores href
 #       * :style (String, Regexp, Hash)
 #
 #   * **:button** - Find buttons ( input [of type submit, reset, image, button] or button elements )
@@ -146,7 +146,7 @@ require 'capybara/selector/definition'
 #   * **:label** - Find label elements
 #     * Locator: Match id or text contents
 #     * Filters:
-#       * :for (Element, String) — The element or id of the element associated with the label
+#       * :for (Element, String, Regexp) — The element or id of the element associated with the label
 #
 #   * **:table** - Find table elements
 #     * Locator: id or caption text of table

data/lib/capybara/selenium/atoms/getAttribute.min.js

@@ -0,0 +1 @@
+(function(){function u(e){var t=e.tagName.toUpperCase();if("OPTION"==t)return!0;if("INPUT"!=t)return!1;var r=e.type.toLowerCase();return"checkbox"==r||"radio"==r}function s(e){var t="selected",r=e.type&&e.type.toLowerCase();return"checkbox"!=r&&"radio"!=r||(t="checked"),!!e[t]}function c(e,t){var r=e.getAttributeNode(t);return r&&r.specified?r.value:null}var i=["allowfullscreen","allowpaymentrequest","allowusermedia","async","autofocus","autoplay","checked","compact","complete","controls","declare","default","defaultchecked","defaultselected","defer","disabled","ended","formnovalidate","hidden","indeterminate","iscontenteditable","ismap","itemscope","loop","multiple","muted","nohref","nomodule","noresize","noshade","novalidate","nowrap","open","paused","playsinline","pubdate","readonly","required","reversed","scoped","seamless","seeking","selected","truespeed","typemustmatch","willvalidate"],d={"class":"className",readonly:"readOnly"};return function f(e,t){var r=null,a=t.toLowerCase();if("style"==a)return(r=e.style)&&"string"!=typeof r&&(r=r.cssText),r;if(("selected"==a||"checked"==a)&&u(e))return s(e)?"true":null;if(tagName=e.tagName.toUpperCase(),"IMG"==tagName&&"src"==a||"A"==tagName&&"href"==a)return(r=c(e,a))&&(r=e[a]),r;if("spellcheck"==a){if(null===!(r=c(e,a))){if("false"==r.toLowerCase())return"false";if("true"==r.toLowerCase())return"true"}return e[a]+""}var l,n=d[t]||t;if(i.some(function(e){e==a}))return(r=!(null===(r=c(e,a)))||e[n])?"true":null;try{l=e[n]}catch(o){}return null!=(r=null==l||"object"==typeof l||"function"==typeof l?c(e,t):l)?r.toString():null}})()

data/lib/capybara/selenium/atoms/isDisplayed.min.js

@@ -0,0 +1 @@
+(function(){function f(t,e,n){function r(t){var e=x(t);if(0<e.height&&0<e.width)return!0;if("PATH"==t.tagName.toUpperCase()&&(0<e.height||0<e.width)){var n=window.getComputedStyle(t)["stroke-width"];return!!n&&0<parseInt(n,10)}return"hidden"!=window.getComputedStyle(t).overflow&&Array.prototype.slice.call(t.childNodes).some(function(t){return t.nodeType==Node.TEXT_NODE||t.nodeType==Node.ELEMENT_NODE&&r(t)})}function i(t){return C(t)==T.HIDDEN&&Array.prototype.slice.call(t.childNodes).every(function(t){return t.nodeType!=Node.ELEMENT_NODE||i(t)||!r(t)})}var o=t.tagName.toUpperCase();if("BODY"==o)return!0;var a=D(t);if(a&&a.tagName&&"DETAILS"==a.tagName.toUpperCase()&&!a.open&&"SUMMARY"!=o)return!1;if("OPTION"==o||"OPTGROUP"==o){var u=v(t,function(t){return"SELECT"==t.tagName.toUpperCase()});return!!u&&f(u,!0,n)}var l=c(t);if(l)return!!l.image&&0<l.rect.width&&0<l.rect.height&&f(l.image,e,n);if("INPUT"==o&&"hidden"==t.type.toLowerCase())return!1;if("NOSCRIPT"==o)return!1;var d=window.getComputedStyle(t).visibility;return"collapse"!=d&&"hidden"!=d&&(!!n(t)&&(!(!e&&0==h(t))&&(!!r(t)&&!i(t))))}function E(t){var e=x(t);return{left:e.left,right:e.left+e.width,top:e.top,bottom:e.top+e.height}}function D(t){return t.parentElement}function C(t){function e(t){function e(t){if(t==u)return!0;var e=window.getComputedStyle(t),n=e.display;return 0!=n.indexOf("inline")&&"contents"!=n&&("absolute"!=r||"static"!=e.position)}var r=window.getComputedStyle(t).position;if("fixed"==r)return i=!0,t==u?null:u;for(var n=D(t);n&&!e(n);)n=D(n);return n}function n(t){var e=t;if("visible"==d)if(t==u&&l)e=l;else if(t==l)return{x:"visible",y:"visible"};var n=window.getComputedStyle(e),r={x:n["overflow-x"],y:n["overflow-y"]};return t==u&&(r.x="visible"==r.x?"auto":r.x,r.y="visible"==r.y?"auto":r.y),r}function r(t){return t==u?{x:window.scrollX,y:window.scrollY}:{x:t.scrollLeft,y:t.scrollTop}}for(var i,o=E(t),a=t.ownerDocument,u=a.documentElement,l=a.body,d=window.getComputedStyle(u).overflow,f=e(t);f;f=e(f)){var h=n(f);if("visible"!=h.x||"visible"!=h.y){var s=x(f);if(0==s.width||0==s.height)return T.HIDDEN;var p=o.right<s.left,c=o.bottom<s.top;if(p&&"hidden"==h.x||c&&"hidden"==h.y)return T.HIDDEN;if(p&&"visible"!=h.x||c&&"visible"!=h.y){var v=r(f),g=o.right<s.left-v.x,w=o.bottom<s.top-v.y;return g&&"visible"!=h.x||w&&"visible"!=h.x?T.HIDDEN:C(f)==T.HIDDEN?T.HIDDEN:T.SCROLL}var N=o.left>=s.left+s.width,m=o.top>=s.top+s.height;if(N&&"hidden"==h.x||m&&"hidden"==h.y)return T.HIDDEN;if(N&&"visible"!=h.x||m&&"visible"!=h.y){if(i){var y=r(f);if(o.left>=u.scrollWidth-y.x||o.right>=u.scrollHeight-y.y)return T.HIDDEN}return C(f)==T.HIDDEN?T.HIDDEN:T.SCROLL}}}return T.NONE}function o(t){var e=t.document.documentElement;return{width:e.clientWidth,height:e.clientHeight}}function p(t,e,n,r){return{left:t,top:e,width:n,height:r}}function x(t){var e,n=c(t);if(n)return n.rect;if("HTML"==t.tagName.toUpperCase()){t.ownerDocument;var r=o(window);return p(0,0,r.width,r.height)}try{e=t.getBoundingClientRect()}catch(i){return p(0,0,0,0)}return p(e.left,e.top,e.right-e.left,e.bottom-e.top)}function h(t){var e=1,n=window.getComputedStyle(t).opacity;n&&(e=Number(n));var r=D(t);return r&&r.nodeType==Node.ELEMENT_NODE&&(e*=h(r)),e}function s(t){var e=t.shape.toLowerCase(),n=t.coords.split(",");if("rect"==e&&4==n.length){var r=n[0],i=n[1];return p(r,i,n[2]-r,n[3]-i)}if("circle"==e&&3==n.length){var o=n[0],a=n[1],u=n[2];return p(o-u,a-u,2*u,2*u)}if("poly"==e&&2<n.length){for(var l=n[0],d=n[1],f=l,h=d,s=2;s+1<n.length;s+=2)l=Math.min(l,n[s]),f=Math.max(f,n[s]),d=Math.min(d,n[s+1]),h=Math.max(h,n[s+1]);return p(l,d,f-l,h-d)}return p(0,0,0,0)}function c(t){var e=t.tagName.toUpperCase(),n="MAP"==e;if(!n&&"AREA"!=e)return null;var r=n?t:"MAP"==D(t).tagName.toUpperCase()?D(t):null,i=null,o=null;if(r&&r.name&&((i=r.ownerDocument.querySelector("*[usemap='#"+r.name+"']"))&&(o=x(i),!n&&"default"!=t.shape.toLowerCase()))){var a=s(t),u=Math.min(Math.max(a.left,0),o.width),l=Math.min(Math.max(a.top,0),o.height),d=Math.min(a.width,o.width-u),f=Math.min(a.height,o.height-l);o=p(u+o.left,l+o.top,d,f)}return{image:i,rect:o||p(0,0,0,0)}}function v(t,e){for(t&&(t=D(t));t;){if(e(t))return t;t=D(t)}return null}function r(t){var e=t.parentNode;if(e&&e.shadowRoot&&t.assignedSlot!==undefined)return t.assignedSlot?t.assignedSlot.parentNode:null;if(t.getDestinationInsertionPoints){var n=t.getDestinationInsertionPoints();if(0<n.length)return n[n.length-1]}return e}var T={NONE:"none",HIDDEN:"hidden",SCROLL:"scroll"};return function i(t,e){function n(t){if("none"==window.getComputedStyle(t).display)return!1;var e=r(t);if("function"==typeof ShadowRoot&&e instanceof ShadowRoot){if(e.host.shadowRoot!==e)return!1;e=e.host}return!(!e||e.nodeType!=Node.DOCUMENT_NODE&&e.nodeType!=Node.DOCUMENT_FRAGMENT_NODE)||e&&n(e)}return f(t,!!e,n)}})()

data/lib/capybara/selenium/atoms/src/getAttribute.js

@@ -0,0 +1,161 @@
+(function(){
+  var BOOLEAN_PROPERTIES = [
+    "allowfullscreen",
+    "allowpaymentrequest",
+    "allowusermedia",
+    "async",
+    "autofocus",
+    "autoplay",
+    "checked",
+    "compact",
+    "complete",
+    "controls",
+    "declare",
+    "default",
+    "defaultchecked",
+    "defaultselected",
+    "defer",
+    "disabled",
+    "ended",
+    "formnovalidate",
+    "hidden",
+    "indeterminate",
+    "iscontenteditable",
+    "ismap",
+    "itemscope",
+    "loop",
+    "multiple",
+    "muted",
+    "nohref",
+    "nomodule",
+    "noresize",
+    "noshade",
+    "novalidate",
+    "nowrap",
+    "open",
+    "paused",
+    "playsinline",
+    "pubdate",
+    "readonly",
+    "required",
+    "reversed",
+    "scoped",
+    "seamless",
+    "seeking",
+    "selected",
+    "truespeed",
+    "typemustmatch",
+    "willvalidate"
+  ];
+
+  var PROPERTY_ALIASES = {
+    "class": "className",
+    "readonly": "readOnly"
+  };
+
+  function isSelectable(element){
+    var tagName = element.tagName.toUpperCase();
+
+    if (tagName == "OPTION"){
+      return true;
+    }
+
+    if (tagName == "INPUT") {
+      var type = element.type.toLowerCase();
+      return type == "checkbox" || type == "radio";
+    }
+
+    return false;
+  }
+
+  function isSelected(element){
+    var propertyName = "selected";
+    var type = element.type && element.type.toLowerCase();
+    if ("checkbox" == type || "radio" == type) {
+      propertyName = "checked";
+    }
+
+    return !!element[propertyName];
+  }
+
+  function getAttributeValue(element, name){
+    var attr = element.getAttributeNode(name);
+    return (attr && attr.specified) ? attr.value : null;
+  }
+
+  return function get(element, attribute){
+    var value = null;
+    var name = attribute.toLowerCase();
+
+    if ("style" == name) {
+      value = element.style;
+
+      if (value && (typeof value != "string")) {
+        value = value.cssText;
+      }
+
+      return value;
+    }
+
+    if (("selected" == name || "checked" == name) &&
+        isSelectable(element)) {
+      return isSelected(element) ? "true" : null;
+    }
+
+    tagName = element.tagName.toUpperCase();
+
+    // The property is consistent. Return that in preference to the attribute for links and images.
+    if (((tagName == "IMG") && name == "src") ||
+        ((tagName == "A") && name == "href")) {
+      value = getAttributeValue(element, name);
+      if (value) {
+        // We want the full URL if present
+        value = element[name];
+      }
+      return value;
+    }
+
+    if ("spellcheck" == name) {
+      value = getAttributeValue(element, name);
+      if (!value === null) {
+        if (value.toLowerCase() == "false") {
+          return "false";
+        } else if (value.toLowerCase() == "true") {
+          return "true";
+        }
+      }
+      // coerce the property value to a string
+      return element[name] + "";
+    }
+    var propName = PROPERTY_ALIASES[attribute] || attribute;
+    if (BOOLEAN_PROPERTIES.some(function(prop){ prop == name })) {
+      value = getAttributeValue(element, name);
+      value = !(value === null) || element[propName];
+      return value ? "true" : null;
+    }
+    var property;
+    try {
+      property = element[propName]
+    } catch (e) {
+      // Leaves property undefined or null
+    }
+    // 1- Call getAttribute if getProperty fails,
+    // i.e. property is null or undefined.
+    // This happens for event handlers in Firefox.
+    // For example, calling getProperty for 'onclick' would
+    // fail while getAttribute for 'onclick' will succeed and
+    // return the JS code of the handler.
+    //
+    // 2- When property is an object we fall back to the
+    // actual attribute instead.
+    // See issue http://code.google.com/p/selenium/issues/detail?id=966
+    if ((property == null) || (typeof property == "object") || (typeof property == "function")) {
+      value = getAttributeValue(element, attribute);
+    } else {
+      value = property;
+    };
+
+    // The empty string is a valid return value.
+    return value != null ? value.toString() : null;
+  };
+})()