capybara 3.13.0 → 3.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: da79991ce86301cce84e97c31e9c46424309edfaaef6c1f52316d78408673340
-  data.tar.gz: 0dbf02750a107ebc011c9899a60e5958099444f897cca384607919b58554dc9b
+  metadata.gz: 4ad63bae2dadd5002e7d92c25d32e737f282ae27d18e18aad1c9fff2bf597b97
+  data.tar.gz: 1236a46546043bf1e0dd4f022feb08ad85b06c9e78193a8045d4ab9617d926b7
 SHA512:
-  metadata.gz: 3718591ef61c25cadb6de5048b73095340b2fa983d0f978e016ec3da1348ea88bcac5797e717b2c8053e2804b7b94aa27b46e3b57ce40fcdfa33cf70fca43d52
-  data.tar.gz: 5cf850913d7c0624002f969bfc3c87661a30b475b9a35decb2d607a7be82456f406f1c3490a803d30cd3f573dccdece7ad66ef8d46be36a347476af01f9ce7b8
+  metadata.gz: 9d3cfc1fc6183456c14f603b39f31cdfb34561d1c6e49a3641dadd67a72a83484f7f6fd9a7ccb2d534d3063c7cf48c8b018943803d98545af51ecf422db07fba
+  data.tar.gz: 0e48f39175aa556ad2351d401a2363384136a05b047250f29c1cc3b097a47b32bc42ff480965b0f2c66ff3b87f9e7617ac4e612296f882e6259da331088563e2

data/History.md

@@ -1,3 +1,10 @@
+# Version 3.13.1
+Release date: 2019-01-24
+
+### Fixed
+
+* Only use Selenium visibility optimization when JS atom is available - Issue #2151
+
 # Version 3.13.0
 Release date: 2019-01-23
 

data/lib/capybara/selenium/extensions/find.rb

@@ -16,12 +16,14 @@ module Capybara
       def find_by(format, selector, uses_visibility:, texts:, styles:)
         els = find_context.find_elements(format, selector)
         hints = []
+
         if (els.size > 2) && !ENV['DISABLE_CAPYBARA_SELENIUM_OPTIMIZATIONS']
           els = filter_by_text(els, texts) unless texts.empty?
 
           hints_js = +''
           functions = []
-          if uses_visibility
+          if uses_visibility && !is_displayed_atom.empty?
+            puts "running vis func"
             hints_js << <<~VISIBILITY_JS
               var vis_func = #{is_displayed_atom};
             VISIBILITY_JS
@@ -74,7 +76,12 @@ module Capybara
       end
 
       def is_displayed_atom # rubocop:disable Naming/PredicateName
-        @@is_displayed_atom ||= browser.send(:bridge).send(:read_atom, 'isDisplayed')
+        @@is_displayed_atom ||= begin
+          browser.send(:bridge).send(:read_atom, 'isDisplayed')
+        rescue StandardError
+          # If the atom doesn't exist or other error
+          ""
+        end
       end
     end
   end

data/lib/capybara/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Capybara
-  VERSION = '3.13.0'
+  VERSION = '3.13.1'
 end

data/spec/dsl_spec.rb

@@ -13,6 +13,8 @@ Capybara::SpecHelper.run_specs TestClass.new, 'DSL', capybara_skip: %i[
   case example.metadata[:full_description]
   when /has_css\? should support case insensitive :class and :id options/
     pending "Nokogiri doesn't support case insensitive CSS attribute matchers"
+  when /#click_button should follow permanent redirects that maintain method/
+    pending "Rack < 2 doesn't support 308" if Gem.loaded_specs['rack'].version < Gem::Version.new('2.0.0')
   end
 end
 

data/spec/rack_test_spec.rb

@@ -29,7 +29,9 @@ skipped_tests = %i[
 Capybara::SpecHelper.run_specs TestSessions::RackTest, 'RackTest', capybara_skip: skipped_tests do |example|
   case example.metadata[:full_description]
   when /has_css\? should support case insensitive :class and :id options/
-    pending "Nokogiri doesn't support case insensitive CSS attribute matchers"
+    skip "Nokogiri doesn't support case insensitive CSS attribute matchers"
+  when /#click_button should follow permanent redirects that maintain method/
+    skip "Rack < 2 doesn't support 308" if Gem.loaded_specs['rack'].version < Gem::Version.new('2.0.0')
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara
 version: !ruby/object:Gem::Version
-  version: 3.13.0
+  version: 3.13.1
 platform: ruby
 authors:
 - Thomas Walpole
@@ -611,7 +611,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Capybara aims to simplify the process of integration testing Rack applications,