capybara 3.11.0 → 3.12.0

data/lib/capybara/selector/regexp_disassembler.rb

@@ -65,22 +65,6 @@ module Capybara
         strs
       end
 
-      def min_repeat(exp)
-        exp.quantifier&.min || 1
-      end
-
-      def max_repeat(exp)
-        exp.quantifier&.max || 1
-      end
-
-      def fixed_repeat?(exp)
-        min_repeat(exp) == max_repeat(exp)
-      end
-
-      def optional?(exp)
-        min_repeat(exp).zero?
-      end
-
       def combine(strs)
         suffixes = [[]]
         strs.reverse_each do |str|
@@ -91,9 +75,7 @@ module Capybara
             prefixes.product(suffixes) { |pair| result << pair.flatten(1) }
             suffixes = result
           else
-            suffixes.each do |arr|
-              arr.unshift str
-            end
+            suffixes.each { |arr| arr.unshift str }
           end
         end
         suffixes
@@ -106,59 +88,120 @@ module Capybara
       end
 
       def extract_strings(expression, alternation: false)
-        strings = []
-        expression.each do |exp| # rubocop:disable Metrics/BlockLength
-          if optional?(exp) && !alternation
-            strings.push(nil)
-            next
-          end
+        Expression.new(expression).extract_strings(alternation)
+      end
+
+      # @api private
+      class Expression
+        def initialize(exp)
+          @exp = exp
+        end
+
+        def extract_strings(process_alternatives)
+          strings = []
+          each do |exp|
+            next strings.push(nil) if exp.optional? && !process_alternatives
 
-          if %i[meta].include?(exp.type) && !exp.terminal? && alternation
-            strings.push(alternative_strings(exp))
-            next
+            next strings.push(exp.alternative_strings) if exp.alternation? && process_alternatives
+
+            strings.concat(exp.strings(process_alternatives))
           end
+          strings
+        end
+
+      protected
+
+        def alternation?
+          (type == :meta) && !terminal?
+        end
+
+        def optional?
+          min_repeat.zero?
+        end
+
+        def terminal?
+          @exp.terminal?
+        end
 
-          if %i[meta set].include?(exp.type)
-            strings.push(nil)
-            next
+        def strings(process_alternatives)
+          if indeterminate?
+            [nil]
+          elsif terminal?
+            terminal_strings
+          elsif optional?
+            optional_strings
+          else
+            repeated_strings(process_alternatives)
           end
+        end
 
-          if exp.terminal?
-            text = case exp.type
-            when :literal then exp.text
-            when :escape then exp.char
-            else
-              strings.push(nil)
-              next
-            end
-
-            if optional?(exp)
-              strings.push(Set.new([[''], [text]]))
-              strings.push(nil) unless max_repeat(exp) == 1
-              next
-            else
-              strings.push(text * min_repeat(exp))
-            end
-          elsif optional?(exp)
-            strings.push(Set.new([[''], extract_strings(exp, alternation: true)]))
-            strings.push(nil) unless max_repeat(exp) == 1
-            next
+        def terminal_strings
+          text = case @exp.type
+          when :literal then @exp.text
+          when :escape then @exp.char
           else
-            min_repeat(exp).times { strings.concat extract_strings(exp, alternation: alternation) }
+            return [nil]
           end
-          strings.push(nil) unless fixed_repeat?(exp)
+
+          optional? ? options_set(text) : repeat_set(text)
+        end
+
+        def optional_strings
+          options_set(extract_strings(true))
+        end
+
+        def repeated_strings(process_alternatives)
+          repeat_set extract_strings(process_alternatives)
+        end
+
+        def alternative_strings
+          alts = alternatives.map { |sub_exp| sub_exp.extract_strings(alternation: true) }
+          alts.all?(&:any?) ? Set.new(alts) : nil
+        end
+
+      private
+
+        def indeterminate?
+          %i[meta set].include?(type)
+        end
+
+        def min_repeat
+          @exp.quantifier&.min || 1
+        end
+
+        def max_repeat
+          @exp.quantifier&.max || 1
+        end
+
+        def fixed_repeat?
+          min_repeat == max_repeat
+        end
+
+        def type
+          @exp.type
+        end
+
+        def repeat_set(str)
+          strs = Array(str * min_repeat)
+          strs.push(nil) unless fixed_repeat?
+          strs
+        end
+
+        def options_set(strs)
+          strs = [Set.new([[''], Array(strs)])]
+          strs.push(nil) unless max_repeat == 1
+          strs
+        end
+
+        def alternatives
+          @exp.alternatives.map { |exp| Expression.new(exp) }
         end
-        strings
-      end
 
-      def alternative_strings(expression)
-        alternatives = expression.alternatives.map { |sub_exp| extract_strings(sub_exp, alternation: true) }
-        if alternatives.all?(&:any?)
-          Set.new(alternatives)
-        else
-          nil
+        def each
+          @exp.each { |exp| yield Expression.new(exp) }
         end
       end
+      private_constant :Expression
     end
   end
 end

data/lib/capybara/selector/selector.rb

@@ -169,17 +169,25 @@ module Capybara
         @selectors ||= {} # rubocop:disable Naming/MemoizedInstanceVariableName
       end
 
+      def [](name)
+        all.fetch(name.to_sym) { |sel_type| raise ArgumentError, "Unknown selector type (:#{sel_type})" }
+      end
+
       def add(name, &block)
         all[name.to_sym] = Capybara::Selector.new(name.to_sym, &block)
       end
 
       def update(name, &block)
-        all[name.to_sym].instance_eval(&block)
+        self[name].instance_eval(&block)
       end
 
       def remove(name)
         all.delete(name.to_sym)
       end
+
+      def for(locator)
+        all.values.find { |sel| sel.match?(locator) }
+      end
     end
 
     def initialize(name, &block)
@@ -348,8 +356,9 @@ module Capybara
 
     def_delegators :@filter_set, :node_filter, :expression_filter, :filter
 
-    def locator_filter(&block)
-      @locator_filter = block if block
+    def locator_filter(*types, **options, &block)
+      types.each { |type| options[type] = true }
+      @locator_filter = Filters::LocatorFilter.new(block, options) if block
       @locator_filter
     end
 
@@ -400,7 +409,7 @@ module Capybara
     end
 
     # @api private
-    def builder
+    def builder(expr = nil)
       case format
       when :css
         Capybara::Selector::CSSBuilder
@@ -408,7 +417,7 @@ module Capybara
         Capybara::Selector::XPathBuilder
       else
         raise NotImplementedError, "No builder exists for selector of type #{format}"
-      end
+      end.new(expr)
     end
 
     # @api private

data/lib/capybara/selector.rb

@@ -34,7 +34,7 @@ Capybara.add_selector(:css) do
 end
 
 Capybara.add_selector(:id) do
-  xpath { |id| XPath.descendant[builder.attribute_conditions(id: id)] }
+  xpath { |id| builder(XPath.descendant).add_attribute_conditions(id: id) }
   locator_filter {  |node, id| id.is_a?(Regexp) ? node[:id] =~ id : true }
 end
 
@@ -92,8 +92,7 @@ end
 
 Capybara.add_selector(:link) do
   xpath do |locator, href: true, alt: nil, title: nil, **|
-    xpath = XPath.descendant(:a)
-    xpath = xpath[@href_conditions = builder.attribute_conditions(href: href)]
+    xpath = builder(XPath.descendant(:a)).add_attribute_conditions(href: href)
 
     unless locator.nil?
       locator = locator.to_s
@@ -119,25 +118,18 @@ Capybara.add_selector(:link) do
   end
 
   expression_filter(:download, valid_values: [true, false, String]) do |expr, download|
-    expr[builder.attribute_conditions(download: download)]
+    builder(expr).add_attribute_conditions(download: download)
   end
 
   describe_expression_filters do |**options|
     desc = +''
     if (href = options[:href])
-      if !href.is_a?(Regexp)
-        desc << " with href #{href.inspect}"
-      elsif @href_conditions
-        desc << " with href matching #{href.inspect}"
-      end
+      desc << " with href #{'matching ' if href.is_a? Regexp}#{href.inspect}"
+    elsif options.key?(:href) # is nil/false specified?
+      desc << ' with no href attribute'
     end
-    desc << ' with no href attribute' if options.fetch(:href, true).nil?
     desc
   end
-
-  describe_node_filters do |href: nil, **|
-    " with href matching #{href.inspect}" if href.is_a?(Regexp) && @href_conditions.nil?
-  end
 end
 
 Capybara.add_selector(:button) do
@@ -161,11 +153,9 @@ Capybara.add_selector(:button) do
       image_btn_xpath = image_btn_xpath[alt_matches]
     end
 
-    res_xpath = input_btn_xpath.union(btn_xpath).union(image_btn_xpath)
-
-    res_xpath = expression_filters.keys.inject(res_xpath) { |memo, ef| memo[find_by_attr(ef, options[ef])] }
-
-    res_xpath
+    %i[value title type].inject(input_btn_xpath.union(btn_xpath).union(image_btn_xpath)) do |memo, ef|
+      memo[find_by_attr(ef, options[ef])]
+    end
   end
 
   node_filter(:disabled, :boolean, default: false, skip_if: :all) { |node, value| !(value ^ node.disabled?) }
@@ -491,7 +481,7 @@ Capybara.add_selector(:element) do
   end
 
   expression_filter(:attributes, matcher: /.+/) do |xpath, name, val|
-    xpath[builder.attribute_conditions(name => val)]
+    builder(xpath).add_attribute_conditions(name => val)
   end
 
   node_filter(:attributes, matcher: /.+/) do |node, name, val|

data/lib/capybara/selenium/driver.rb

@@ -6,10 +6,10 @@ require 'English'
 class Capybara::Selenium::Driver < Capybara::Driver::Base
   DEFAULT_OPTIONS = {
     browser: :firefox,
-    clear_local_storage: false,
-    clear_session_storage: false
+    clear_local_storage: nil,
+    clear_session_storage: nil
   }.freeze
-  SPECIAL_OPTIONS = %i[browser clear_local_storage clear_session_storage].freeze
+  SPECIAL_OPTIONS = %i[browser clear_local_storage clear_session_storage timeout].freeze
   attr_reader :app, :options
 
   def self.load_selenium
@@ -23,6 +23,9 @@ class Capybara::Selenium::Driver < Capybara::Driver::Base
 
   def browser
     @browser ||= begin
+      if options[:timeout]
+        options[:http_client] ||= Selenium::WebDriver::Remote::Http::Default.new(read_timeout: options[:timeout])
+      end
       processed_options = options.reject { |key, _val| SPECIAL_OPTIONS.include?(key) }
       Selenium::WebDriver.for(options[:browser], processed_options).tap do |driver|
         specialize_driver(driver)
@@ -260,15 +263,17 @@ private
   end
 
   def clear_storage
-    clear_session_storage if options[:clear_session_storage]
-    clear_local_storage if options[:clear_local_storage]
+    clear_session_storage unless options[:clear_session_storage] == false
+    clear_local_storage unless options[:clear_local_storage] == false
+  rescue Selenium::WebDriver::Error::JavascriptError # rubocop:disable Lint/HandleExceptions
+    # session/local storage may not be available if on non-http pages (e.g. about:blank)
   end
 
   def clear_session_storage
     if @browser.respond_to? :session_storage
       @browser.session_storage.clear
     else
-      warn 'sessionStorage clear requested but is not available for this driver'
+      warn 'sessionStorage clear requested but is not supported by this driver' unless options[:clear_session_storage].nil?
     end
   end
 
@@ -276,7 +281,7 @@ private
     if @browser.respond_to? :local_storage
       @browser.local_storage.clear
     else
-      warn 'localStorage clear requested but is not available for this driver'
+      warn 'localStorage clear requested but is not supported by this driver' unless options[:clear_local_storage].nil?
     end
   end
 
@@ -353,7 +358,7 @@ private
       extend ChromeDriver
     when :firefox
       require 'capybara/selenium/patches/pause_duration_fix' if pause_broken?(sel_driver)
-      extend MarionetteDriver if sel_driver.capabilities.is_a?(::Selenium::WebDriver::Remote::W3C::Capabilities)
+      extend FirefoxDriver if sel_driver.capabilities.is_a?(::Selenium::WebDriver::Remote::W3C::Capabilities)
     end
   end
 
@@ -396,4 +401,4 @@ private
 end
 
 require 'capybara/selenium/driver_specializations/chrome_driver'
-require 'capybara/selenium/driver_specializations/marionette_driver'
+require 'capybara/selenium/driver_specializations/firefox_driver'

data/lib/capybara/selenium/driver_specializations/{marionette_driver.rb → firefox_driver.rb}

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'capybara/selenium/nodes/marionette_node'
+require 'capybara/selenium/nodes/firefox_node'
 
-module Capybara::Selenium::Driver::MarionetteDriver
+module Capybara::Selenium::Driver::FirefoxDriver
   def resize_window_to(handle, width, height)
     within_given_window(handle) do
       # Don't set the size if already set - See https://github.com/mozilla/geckodriver/issues/643
@@ -45,6 +45,6 @@ module Capybara::Selenium::Driver::MarionetteDriver
 private
 
   def build_node(native_node)
-    ::Capybara::Selenium::MarionetteNode.new(self, native_node)
+    ::Capybara::Selenium::FirefoxNode.new(self, native_node)
   end
 end

data/lib/capybara/selenium/nodes/{marionette_node.rb → firefox_node.rb}

@@ -2,7 +2,7 @@
 
 require 'capybara/selenium/extensions/html5_drag'
 
-class Capybara::Selenium::MarionetteNode < Capybara::Selenium::Node
+class Capybara::Selenium::FirefoxNode < Capybara::Selenium::Node
   include Html5Drag
 
   def click(keys = [], **options)

data/lib/capybara/spec/session/all_spec.rb

@@ -30,7 +30,7 @@ Capybara::SpecHelper.spec '#all' do
 
   it 'should accept an XPath instance', :exact_false do
     @session.visit('/form')
-    @xpath = Capybara::Selector.all[:fillable_field].call('Name')
+    @xpath = Capybara::Selector[:fillable_field].call('Name')
     expect(@xpath).to be_a(::XPath::Union)
     @result = @session.all(@xpath).map(&:value)
     expect(@result).to include('Smith', 'John', 'John Smith')
@@ -135,6 +135,13 @@ Capybara::SpecHelper.spec '#all' do
       it 'should raise ExpectationNotMet when the number of elements founds does not match the expectation' do
         expect { @session.all(:css, 'h1, p', between: 0..3) }.to raise_error(Capybara::ExpectationNotMet)
       end
+
+      eval <<~TEST, binding, __FILE__, __LINE__ + 1 if RUBY_VERSION.to_f > 2.5
+        it'treats an endless range as minimum' do
+          expect { @session.all(:css, 'h1, p', between: 2..) }.not_to raise_error
+          expect { @session.all(:css, 'h1, p', between: 5..) }.to raise_error(Capybara::ExpectationNotMet)
+        end
+      TEST
     end
 
     context 'with multiple count filters' do

data/lib/capybara/spec/session/assert_selector_spec.rb

@@ -72,16 +72,6 @@ Capybara::SpecHelper.spec '#assert_selector' do
   end
 end
 
-Capybara::SpecHelper.spec '#refute_selector', requires: [:driver] do
-  it 'should warn not to use' do
-    @session.visit('/with_html')
-    doc = @session.document
-    allow(doc).to receive(:warn)
-    doc.refute_selector(:xpath, '//abbr')
-    expect(doc).to have_received(:warn)
-  end
-end
-
 Capybara::SpecHelper.spec '#assert_no_selector' do
   before do
     @session.visit('/with_html')

data/lib/capybara/spec/session/click_button_spec.rb

@@ -5,10 +5,12 @@ Capybara::SpecHelper.spec '#click_button' do
     @session.visit('/form')
   end
 
-  it 'should wait for asynchronous load', requires: [:js] do
+  it 'should wait for asynchronous load', :focus_, requires: [:js] do
     @session.visit('/with_js')
-    @session.click_link('Click me')
-    @session.click_button('New Here')
+    @session.using_wait_time(1.5) do
+      @session.click_link('Click me')
+      @session.click_button('New Here')
+    end
   end
 
   it 'casts to string' do

data/lib/capybara/spec/session/click_link_spec.rb

@@ -83,7 +83,7 @@ Capybara::SpecHelper.spec '#click_link' do
     end
 
     it "should raise error if link wasn't found" do
-      expect { @session.click_link('labore', href: 'invalid_href') }.to raise_error(Capybara::ElementNotFound)
+      expect { @session.click_link('labore', href: 'invalid_href') }.to raise_error(Capybara::ElementNotFound, /with href "invalid_href/)
     end
   end
 
@@ -104,8 +104,8 @@ Capybara::SpecHelper.spec '#click_link' do
     end
 
     it "should raise an error if no link's href matched the pattern" do
-      expect { @session.click_link('labore', href: /invalid_pattern/) }.to raise_error(Capybara::ElementNotFound)
-      expect { @session.click_link('labore', href: /.+d+/) }.to raise_error(Capybara::ElementNotFound)
+      expect { @session.click_link('labore', href: /invalid_pattern/) }.to raise_error(Capybara::ElementNotFound, %r{with href matching /invalid_pattern/})
+      expect { @session.click_link('labore', href: /.+d+/) }.to raise_error(Capybara::ElementNotFound, /#{Regexp.quote "with href matching /.+d+/"}/)
     end
 
     context 'href: nil' do
@@ -114,8 +114,8 @@ Capybara::SpecHelper.spec '#click_link' do
       end
 
       it 'should raise an error if href attribute exists' do
-        expect { @session.click_link('Blank Href', href: nil) }.to raise_error(Capybara::ElementNotFound)
-        expect { @session.click_link('Normal Anchor', href: nil) }.to raise_error(Capybara::ElementNotFound)
+        expect { @session.click_link('Blank Href', href: nil) }.to raise_error(Capybara::ElementNotFound, /with no href attribute/)
+        expect { @session.click_link('Normal Anchor', href: nil) }.to raise_error(Capybara::ElementNotFound, /with no href attribute/)
       end
     end
   end

data/lib/capybara/spec/session/find_spec.rb

@@ -224,7 +224,7 @@ Capybara::SpecHelper.spec '#find' do
 
   it 'should accept an XPath instance' do
     @session.visit('/form')
-    @xpath = Capybara::Selector.all[:fillable_field].call('First Name')
+    @xpath = Capybara::Selector[:fillable_field].call('First Name')
     expect(@xpath).to be_a(::XPath::Union)
     expect(@session.find(@xpath).value).to eq('John')
   end

data/lib/capybara/spec/session/first_spec.rb

@@ -24,7 +24,7 @@ Capybara::SpecHelper.spec '#first' do
 
   it 'should accept an XPath instance' do
     @session.visit('/form')
-    @xpath = Capybara::Selector.all[:fillable_field].call('First Name')
+    @xpath = Capybara::Selector[:fillable_field].call('First Name')
     expect(@xpath).to be_a(::XPath::Union)
     expect(@session.first(@xpath).value).to eq('John')
   end

data/lib/capybara/spec/session/has_css_spec.rb

@@ -27,11 +27,15 @@ Capybara::SpecHelper.spec '#has_css?' do
     expect(@session).to have_css('h2', id: 'h2one')
     expect(@session).to have_css('h2')
     expect(@session).to have_css('h2', id: /h2o/)
+    expect(@session).to have_css('li', id: /john|paul/)
   end
 
   it 'should support :class option' do
     expect(@session).to have_css('li', class: 'guitarist')
     expect(@session).to have_css('li', class: /guitar/)
+    expect(@session).to have_css('li', class: /guitar|drummer/)
+    expect(@session).to have_css('li', class: %w[beatle guitarist])
+    expect(@session).to have_css('li', class: /.*/)
   end
 
   it 'should support case insensitive :class and :id options' do
@@ -111,6 +115,9 @@ Capybara::SpecHelper.spec '#has_css?' do
       expect(@session).to have_css('p', count: 3)
       expect(@session).to have_css('p a#foo', count: 1)
       expect(@session).to have_css('p a.doesnotexist', count: 0)
+      expect(@session).to have_css('li', class: /guitar|drummer/, count: 4)
+      expect(@session).to have_css('li', id: /john|paul/, class: /guitar|drummer/, count: 2)
+      expect(@session).to have_css('li', class: %w[beatle guitarist], count: 2)
     end
 
     it 'should be false if the content occurs a different number of times than the given' do

data/lib/capybara/spec/session/has_xpath_spec.rb

@@ -11,6 +11,20 @@ Capybara::SpecHelper.spec '#has_xpath?' do
     expect(@session).to have_xpath("//p[contains(.,'est')]")
   end
 
+  it 'should support :id option' do
+    expect(@session).to have_xpath('//h2', id: 'h2one')
+    expect(@session).to have_xpath('//h2')
+    expect(@session).to have_xpath('//h2', id: /h2o/)
+  end
+
+  it 'should support :class option' do
+    expect(@session).to have_xpath('//li', class: 'guitarist')
+    expect(@session).to have_xpath('//li', class: /guitar/)
+    expect(@session).to have_xpath('//li', class: /guitar|drummer/)
+    expect(@session).to have_xpath('//li', class: %w[beatle guitarist])
+    expect(@session).to have_xpath('//li', class: /.*/)
+  end
+
   it 'should be false if the given selector is not on the page' do
     expect(@session).not_to have_xpath('//abbr')
     expect(@session).not_to have_xpath("//p//a[@id='doesnotexist']")
@@ -43,6 +57,9 @@ Capybara::SpecHelper.spec '#has_xpath?' do
       expect(@session).to have_xpath("//p//a[@id='foo']", count: 1)
       expect(@session).to have_xpath("//p[contains(.,'est')]", count: 1)
       expect(@session).to have_xpath("//p//a[@id='doesnotexist']", count: 0)
+      expect(@session).to have_xpath('//li', class: /guitar|drummer/, count: 4)
+      expect(@session).to have_xpath('//li', id: /john|paul/, class: /guitar|drummer/, count: 2)
+      expect(@session).to have_xpath('//li', class: %w[beatle guitarist], count: 2)
     end
 
     it 'should be false if the content occurs a different number of times than the given' do

data/lib/capybara/spec/session/node_spec.rb

@@ -406,6 +406,13 @@ Capybara::SpecHelper.spec 'node' do
       expect(locations[:y].to_f).to be_within(1).of(5)
     end
 
+    it 'should raise error if both x and y values are not passed' do
+      @session.visit('with_js')
+      el = @session.find(:css, '#click-test')
+      expect { el.click(x: 5) }.to raise_error ArgumentError
+      expect { el.click(x: nil, y: 3) }.to raise_error ArgumentError
+    end
+
     it 'should be able to click a table row', requires: [:js] do
       @session.visit('/tables')
       tr = @session.find(:css, '#agent_table tr:first-child').click
@@ -416,7 +423,7 @@ Capybara::SpecHelper.spec 'node' do
       @session.visit('/obscured')
       obscured = @session.find(:css, '#obscured')
       @session.execute_script <<~JS
-        setTimeout(function(){ $('#cover').hide(); }, 1000)
+        setTimeout(function(){ $('#cover').hide(); }, 700)
       JS
       expect { obscured.click }.not_to raise_error
     end
@@ -468,7 +475,7 @@ Capybara::SpecHelper.spec 'node' do
       @session.visit('/obscured')
       obscured = @session.find(:css, '#obscured')
       @session.execute_script <<~JS
-        setTimeout(function(){ $('#cover').hide(); }, 1000)
+        setTimeout(function(){ $('#cover').hide(); }, 700)
       JS
       expect { obscured.double_click }.not_to raise_error
     end
@@ -502,7 +509,7 @@ Capybara::SpecHelper.spec 'node' do
       @session.visit('/obscured')
       obscured = @session.find(:css, '#obscured')
       @session.execute_script <<~JS
-        setTimeout(function(){ $('#cover').hide(); }, 1000)
+        setTimeout(function(){ $('#cover').hide(); }, 700)
       JS
       expect { obscured.right_click }.not_to raise_error
     end

data/lib/capybara/spec/session/window/window_spec.rb

@@ -120,7 +120,7 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
 
     after do
       @session.current_window.resize_to(*@initial_size)
-      sleep 0.5
+      sleep 1
     end
 
     it 'should be able to resize window', requires: %i[windows js] do
@@ -194,7 +194,7 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
 
     after do
       @session.current_window.resize_to(*@initial_size)
-      sleep 0.5
+      sleep 1
     end
 
     it 'should be able to fullscreen the window' do

data/lib/capybara/spec/spec_helper.rb

@@ -16,8 +16,7 @@ module Capybara
         config.filter_run_excluding requires: method(:filter).to_proc
         config.before { Capybara::SpecHelper.reset! }
         config.after { Capybara::SpecHelper.reset! }
-        # Test in 3.5+ where metadata doesn't autotrigger shared context inclusion - will be only behavior in RSpec 4
-        config.shared_context_metadata_behavior = :apply_to_host_groups if config.respond_to?(:shared_context_metadata_behavior=)
+        config.shared_context_metadata_behavior = :apply_to_host_groups
       end
 
       def reset!

data/lib/capybara/spec/views/obscured.erb

@@ -3,6 +3,9 @@
     <meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
     <title>with_animation</title>
     <script src="/jquery.js" type="text/javascript" charset="utf-8"></script>
+    <script>
+      $(document).on('contextmenu', function(e){ e.preventDefault(); })
+    </script>
     <style>
       div {
         width: 400px;