capybara 3.0.0 → 3.36.0

data/lib/capybara/spec/session/dismiss_confirm_spec.rb

@@ -5,14 +5,14 @@ Capybara::SpecHelper.spec '#dismiss_confirm', requires: [:modals] do
     @session.visit('/with_js')
   end
 
-  it "should dismiss the confirm" do
+  it 'should dismiss the confirm' do
     @session.dismiss_confirm do
       @session.click_link('Open confirm')
     end
     expect(@session).to have_xpath("//a[@id='open-confirm' and @confirmed='false']")
   end
 
-  it "should dismiss the confirm if the message matches" do
+  it 'should dismiss the confirm if the message matches' do
     @session.dismiss_confirm 'Confirm opened' do
       @session.click_link('Open confirm')
     end
@@ -27,7 +27,7 @@ Capybara::SpecHelper.spec '#dismiss_confirm', requires: [:modals] do
     end.to raise_error(Capybara::ModalNotFound)
   end
 
-  it "should return the message presented" do
+  it 'should return the message presented' do
     message = @session.dismiss_confirm do
       @session.click_link('Open confirm')
     end

data/lib/capybara/spec/session/dismiss_prompt_spec.rb

@@ -5,14 +5,14 @@ Capybara::SpecHelper.spec '#dismiss_prompt', requires: [:modals] do
     @session.visit('/with_js')
   end
 
-  it "should dismiss the prompt" do
+  it 'should dismiss the prompt' do
     @session.dismiss_prompt do
       @session.click_link('Open prompt')
     end
     expect(@session).to have_xpath("//a[@id='open-prompt' and @response='dismissed']")
   end
 
-  it "should return the message presented" do
+  it 'should return the message presented' do
     message = @session.dismiss_prompt do
       @session.click_link('Open prompt')
     end

data/lib/capybara/spec/session/element/{assert_match_selector.rb → assert_match_selector_spec.rb}

@@ -1,22 +1,24 @@
+# frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#assert_matches_selector' do
   before do
     @session.visit('/with_html')
     @element = @session.find(:css, 'span', text: '42')
   end
 
-  it "should be true if the given selector matches the element" do
+  it 'should be true if the given selector matches the element' do
     expect(@element.assert_matches_selector(:css, '.number')).to be true
   end
 
-  it "should be false if the given selector does not match the element" do
+  it 'should be false if the given selector does not match the element' do
     expect { @element.assert_matches_selector(:css, '.not_number') }.to raise_error(Capybara::ElementNotFound)
   end
 
-  it "should not be callable on the session" do
+  it 'should not be callable on the session' do
     expect { @session.assert_matches_selector(:css, '.number') }.to raise_error(NoMethodError)
   end
 
-  it "should wait for match to occur", requires: [:js] do
+  it 'should wait for match to occur', requires: [:js] do
     @session.visit('/with_js')
     input = @session.find(:css, '#disable-on-click')
 
@@ -25,12 +27,12 @@ Capybara::SpecHelper.spec '#assert_matches_selector' do
     expect(input.assert_matches_selector(:css, 'input:disabled')).to be true
   end
 
-  it "should not accept count options" do
-    expect { @element.assert_matches_selector(:css, '.number', count: 1) }.to raise_error(ArgumentError)
+  it 'should not accept count options' do
+    expect { @element.assert_matches_selector(:css, '.number', count: 1) }.to raise_error(ArgumentError, /count/)
   end
 
-  it "should accept a filter block" do
-    @element.assert_matches_selector(:css, 'span') { |el| el[:class] == "number" }
-    @element.assert_not_matches_selector(:css, 'span') { |el| el[:class] == "not_number" }
+  it 'should accept a filter block' do
+    @element.assert_matches_selector(:css, 'span') { |el| el[:class] == 'number' }
+    @element.assert_not_matches_selector(:css, 'span') { |el| el[:class] == 'not_number' }
   end
 end

data/lib/capybara/spec/session/element/match_css_spec.rb

@@ -1,23 +1,31 @@
+# frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#match_css?' do
   before do
     @session.visit('/with_html')
     @element = @session.find(:css, 'span', text: '42')
   end
 
-  it "should be true if the given selector matches the element" do
-    expect(@element).to match_css("span")
-    expect(@element).to match_css("span.number")
+  it 'should be true if the given selector matches the element' do
+    expect(@element).to match_css('span')
+    expect(@element).to match_css('span.number')
   end
 
-  it "should be false if the given selector does not match" do
-    expect(@element).not_to match_css("div")
-    expect(@element).not_to match_css("p a#doesnotexist")
-    expect(@element).not_to match_css("p.nosuchclass")
+  it 'should be false if the given selector does not match' do
+    expect(@element).not_to match_css('div')
+    expect(@element).not_to match_css('p a#doesnotexist')
+    expect(@element).not_to match_css('p.nosuchclass')
   end
 
-  it "should accept an optional filter block" do
+  it 'should accept an optional filter block' do
     # This would be better done with
-    expect(@element).to match_css('span') { |el| el[:class] == "number" }
-    expect(@element).not_to match_css('span') { |el| el[:class] == "not_number" }
+    expect(@element).to match_css('span') { |el| el[:class] == 'number' }
+    expect(@element).not_to match_css('span') { |el| el[:class] == 'not_number' }
+  end
+
+  it 'should work with root element found via ancestor' do
+    el = @session.find(:css, 'body').find(:xpath, '..')
+    expect(el).to match_css('html')
+    expect { expect(el).to not_match_css('html') }.to raise_exception(RSpec::Expectations::ExpectationNotMetError)
   end
 end

data/lib/capybara/spec/session/element/match_xpath_spec.rb

@@ -1,21 +1,23 @@
+# frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#match_xpath?' do
   before do
     @session.visit('/with_html')
     @element = @session.find(:css, 'span.number')
   end
 
-  it "should be true if the given selector is on the page" do
-    expect(@element).to match_xpath("//span")
+  it 'should be true if the given selector is on the page' do
+    expect(@element).to match_xpath('//span')
     expect(@element).to match_xpath("//span[@class='number']")
   end
 
-  it "should be false if the given selector is not on the page" do
-    expect(@element).not_to match_xpath("//abbr")
-    expect(@element).not_to match_xpath("//div")
+  it 'should be false if the given selector is not on the page' do
+    expect(@element).not_to match_xpath('//abbr')
+    expect(@element).not_to match_xpath('//div')
     expect(@element).not_to match_xpath("//span[@class='not_a_number']")
   end
 
-  it "should use xpath even if default selector is CSS" do
+  it 'should use xpath even if default selector is CSS' do
     Capybara.default_selector = :css
     expect(@element).not_to have_xpath("//span[@class='not_a_number']")
     expect(@element).not_to have_xpath("//div[@class='number']")

data/lib/capybara/spec/session/element/matches_selector_spec.rb

@@ -1,46 +1,60 @@
+# frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#match_selector?' do
+  let(:element) { @session.find(:xpath, '//span', text: '42') }
+
   before do
     @session.visit('/with_html')
-    @element = @session.find('//span', text: '42')
   end
 
-  it "should be true if the element matches the given selector" do
-    expect(@element).to match_selector(:xpath, "//span")
-    expect(@element).to match_selector(:css, 'span.number')
-    expect(@element.matches_selector?(:css, 'span.number')).to be true
+  it 'should be true if the element matches the given selector' do
+    expect(element).to match_selector(:xpath, '//span')
+    expect(element).to match_selector(:css, 'span.number')
+    expect(element.matches_selector?(:css, 'span.number')).to be true
   end
 
-  it "should be false if the element does not match the given selector" do
-    expect(@element).not_to match_selector(:xpath, "//div")
-    expect(@element).not_to match_selector(:css, "span.not_a_number")
-    expect(@element.matches_selector?(:css, "span.not_a_number")).to be false
+  it 'should be false if the element does not match the given selector' do
+    expect(element).not_to match_selector(:xpath, '//div')
+    expect(element).not_to match_selector(:css, 'span.not_a_number')
+    expect(element.matches_selector?(:css, 'span.not_a_number')).to be false
   end
 
-  it "should use default selector" do
+  it 'should use default selector' do
     Capybara.default_selector = :css
-    expect(@element).not_to match_selector("span.not_a_number")
-    expect(@element).to match_selector("span.number")
+    expect(element).not_to match_selector('span.not_a_number')
+    expect(element).to match_selector('span.number')
+  end
+
+  it 'should work with elements located via a sibling selector' do
+    sibling = element.sibling(:css, 'span', text: 'Other span')
+    expect(sibling).to match_selector(:xpath, '//span')
+    expect(sibling).to match_selector(:css, 'span')
+  end
+
+  it 'should work with the html element' do
+    html = @session.find('/html')
+    expect(html).to match_selector(:css, 'html')
   end
 
-  context "with text" do
-    it "should discard all matches where the given string is not contained" do
-      expect(@element).to match_selector("//span", text: "42")
-      expect(@element).not_to match_selector("//span", text: "Doesnotexist")
+  context 'with text' do
+    it 'should discard all matches where the given string is not contained' do
+      expect(element).to match_selector('//span', text: '42')
+      expect(element).not_to match_selector('//span', text: 'Doesnotexist')
     end
   end
 
-  it "should have css sugar" do
-    expect(@element.matches_css?('span.number')).to be true
-    expect(@element.matches_css?('span.not_a_number')).to be false
-    expect(@element.matches_css?('span.number', text: "42")).to be true
-    expect(@element.matches_css?('span.number', text: "Nope")).to be false
+  it 'should have css sugar' do
+    expect(element.matches_css?('span.number')).to be true
+    expect(element.matches_css?('span.not_a_number')).to be false
+    expect(element.matches_css?('span.number', text: '42')).to be true
+    expect(element.matches_css?('span.number', text: 'Nope')).to be false
   end
 
-  it "should have xpath sugar" do
-    expect(@element.matches_xpath?("//span")).to be true
-    expect(@element.matches_xpath?("//div")).to be false
-    expect(@element.matches_xpath?("//span", text: '42')).to be true
-    expect(@element.matches_xpath?("//span", text: 'Nope')).to be false
+  it 'should have xpath sugar' do
+    expect(element.matches_xpath?('//span')).to be true
+    expect(element.matches_xpath?('//div')).to be false
+    expect(element.matches_xpath?('//span', text: '42')).to be true
+    expect(element.matches_xpath?('//span', text: 'Nope')).to be false
   end
 
   it 'should accept selector filters' do
@@ -52,55 +66,55 @@ Capybara::SpecHelper.spec '#match_selector?' do
   it 'should accept a custom filter block' do
     @session.visit('/form')
     cbox = @session.find(:css, '#form_pets_dog')
-    expect(cbox).to match_selector(:checkbox) { |node| node[:id] == "form_pets_dog" }
-    expect(cbox).not_to match_selector(:checkbox) { |node| node[:id] != "form_pets_dog" }
-    expect(cbox.matches_selector?(:checkbox) { |node| node[:id] == "form_pets_dog" }).to be true
-    expect(cbox.matches_selector?(:checkbox) { |node| node[:id] != "form_pets_dog" }).to be false
+    expect(cbox).to match_selector(:checkbox) { |node| node[:id] == 'form_pets_dog' }
+    expect(cbox).not_to match_selector(:checkbox) { |node| node[:id] != 'form_pets_dog' }
+    expect(cbox.matches_selector?(:checkbox) { |node| node[:id] == 'form_pets_dog' }).to be true
+    expect(cbox.matches_selector?(:checkbox) { |node| node[:id] != 'form_pets_dog' }).to be false
   end
 end
 
 Capybara::SpecHelper.spec '#not_matches_selector?' do
+  let(:element) { @session.find(:css, 'span', text: 42) }
   before do
     @session.visit('/with_html')
-    @element = @session.find(:css, "span", text: 42)
   end
 
-  it "should be false if the given selector matches the element" do
-    expect(@element).not_to not_match_selector(:xpath, "//span")
-    expect(@element).not_to not_match_selector(:css, "span.number")
-    expect(@element.not_matches_selector?(:css, "span.number")).to be false
+  it 'should be false if the given selector matches the element' do
+    expect(element).not_to not_match_selector(:xpath, '//span')
+    expect(element).not_to not_match_selector(:css, 'span.number')
+    expect(element.not_matches_selector?(:css, 'span.number')).to be false
   end
 
-  it "should be true if the given selector does not match the element" do
-    expect(@element).to not_match_selector(:xpath, "//abbr")
-    expect(@element).to not_match_selector(:css, "p a#doesnotexist")
-    expect(@element.not_matches_selector?(:css, "p a#doesnotexist")).to be true
+  it 'should be true if the given selector does not match the element' do
+    expect(element).to not_match_selector(:xpath, '//abbr')
+    expect(element).to not_match_selector(:css, 'p a#doesnotexist')
+    expect(element.not_matches_selector?(:css, 'p a#doesnotexist')).to be true
   end
 
-  it "should use default selector" do
+  it 'should use default selector' do
     Capybara.default_selector = :css
-    expect(@element).to not_match_selector("p a#doesnotexist")
-    expect(@element).not_to not_match_selector("span.number")
+    expect(element).to not_match_selector('p a#doesnotexist')
+    expect(element).not_to not_match_selector('span.number')
   end
 
-  context "with text" do
-    it "should discard all matches where the given string is contained" do
-      expect(@element).not_to not_match_selector(:css, "span.number", text: "42")
-      expect(@element).to not_match_selector(:css, "span.number", text: "Doesnotexist")
+  context 'with text' do
+    it 'should discard all matches where the given string is contained' do
+      expect(element).not_to not_match_selector(:css, 'span.number', text: '42')
+      expect(element).to not_match_selector(:css, 'span.number', text: 'Doesnotexist')
     end
   end
 
-  it "should have CSS sugar" do
-    expect(@element.not_matches_css?("span.number")).to be false
-    expect(@element.not_matches_css?("p a#doesnotexist")).to be true
-    expect(@element.not_matches_css?("span.number", text: "42")).to be false
-    expect(@element.not_matches_css?("span.number", text: "Doesnotexist")).to be true
+  it 'should have CSS sugar' do
+    expect(element.not_matches_css?('span.number')).to be false
+    expect(element.not_matches_css?('p a#doesnotexist')).to be true
+    expect(element.not_matches_css?('span.number', text: '42')).to be false
+    expect(element.not_matches_css?('span.number', text: 'Doesnotexist')).to be true
   end
 
-  it "should have xpath sugar" do
-    expect(@element.not_matches_xpath?("//span")).to be false
-    expect(@element.not_matches_xpath?("//div")).to be true
-    expect(@element.not_matches_xpath?("//span", text: "42")).to be false
-    expect(@element.not_matches_xpath?("//span", text: "Doesnotexist")).to be true
+  it 'should have xpath sugar' do
+    expect(element.not_matches_xpath?('//span')).to be false
+    expect(element.not_matches_xpath?('//div')).to be true
+    expect(element.not_matches_xpath?('//span', text: '42')).to be false
+    expect(element.not_matches_xpath?('//span', text: 'Doesnotexist')).to be true
   end
 end

data/lib/capybara/spec/session/evaluate_async_script_spec.rb

@@ -1,19 +1,19 @@
 # frozen_string_literal: true
 
-Capybara::SpecHelper.spec "#evaluate_async_script", requires: [:js] do
-  it "should evaluate the given script and return whatever it produces" do
+Capybara::SpecHelper.spec '#evaluate_async_script', requires: [:js] do
+  it 'should evaluate the given script and return whatever it produces' do
     @session.visit('/with_js')
-    expect(@session.evaluate_async_script("arguments[0](4)")).to eq(4)
+    expect(@session.evaluate_async_script('arguments[0](4)')).to eq(4)
   end
 
-  it "should support passing elements as arguments to the script", requires: %i[js es_args] do
+  it 'should support passing elements as arguments to the script', requires: %i[js es_args] do
     @session.visit('/with_js')
     el = @session.find(:css, '#drag p')
-    result = @session.evaluate_async_script("arguments[2]([arguments[0].innerText, arguments[1]])", el, "Doodle Funk")
-    expect(result).to eq ["This is a draggable element.", "Doodle Funk"]
+    result = @session.evaluate_async_script('arguments[2]([arguments[0].innerText, arguments[1]])', el, 'Doodle Funk')
+    expect(result).to eq ['This is a draggable element.', 'Doodle Funk']
   end
 
-  it "should support returning elements after asynchronous operation", requires: %i[js es_args] do
+  it 'should support returning elements after asynchronous operation', requires: %i[js es_args] do
     @session.visit('/with_js')
     @session.find(:css, '#change') # ensure page has loaded and element is available
     el = @session.evaluate_async_script("var cb = arguments[0]; setTimeout(function(){ cb(document.getElementById('change')) }, 100)")

data/lib/capybara/spec/session/evaluate_script_spec.rb

@@ -1,29 +1,49 @@
 # frozen_string_literal: true
 
-Capybara::SpecHelper.spec "#evaluate_script", requires: [:js] do
-  it "should evaluate the given script and return whatever it produces" do
+Capybara::SpecHelper.spec '#evaluate_script', requires: [:js] do
+  it 'should evaluate the given script and return whatever it produces' do
     @session.visit('/with_js')
-    expect(@session.evaluate_script("1+3")).to eq(4)
+    expect(@session.evaluate_script('1+3')).to eq(4)
   end
 
-  it "should pass arguments to the script", requires: %i[js es_args] do
+  it 'should ignore leading whitespace' do
     @session.visit('/with_js')
-    @session.evaluate_script("document.getElementById('change').textContent = arguments[0]", "Doodle Funk")
+    expect(@session.evaluate_script('
+      1 + 3
+    ')).to eq(4)
+  end
+
+  it 'should pass arguments to the script', requires: %i[js es_args] do
+    @session.visit('/with_js')
+    expect(@session).to have_css('#change')
+    @session.evaluate_script("document.getElementById('change').textContent = arguments[0]", 'Doodle Funk')
     expect(@session).to have_css('#change', text: 'Doodle Funk')
   end
 
-  it "should support passing elements as arguments to the script", requires: %i[js es_args] do
+  it 'should support passing elements as arguments to the script', requires: %i[js es_args] do
     @session.visit('/with_js')
     el = @session.find(:css, '#change')
-    @session.evaluate_script("arguments[0].textContent = arguments[1]", el, "Doodle Funk")
+    @session.evaluate_script('arguments[0].textContent = arguments[1]', el, 'Doodle Funk')
     expect(@session).to have_css('#change', text: 'Doodle Funk')
   end
 
-  it "should support returning elements", requires: %i[js es_args] do
+  it 'should support returning elements', requires: %i[js es_args] do
     @session.visit('/with_js')
     @session.find(:css, '#change') # ensure page has loaded and element is available
     el = @session.evaluate_script("document.getElementById('change')")
     expect(el).to be_instance_of(Capybara::Node::Element)
     expect(el).to eq(@session.find(:css, '#change'))
   end
+
+  it 'should support multi statement via IIFE' do
+    @session.visit('/with_js')
+    @session.find(:css, '#change')
+    el = @session.evaluate_script(<<~JS)
+      (function(){
+        var el = document.getElementById('change');
+        return el;
+      })()
+    JS
+    expect(el).to eq(@session.find(:css, '#change'))
+  end
 end

data/lib/capybara/spec/session/execute_script_spec.rb

@@ -1,27 +1,28 @@
 # frozen_string_literal: true
 
-Capybara::SpecHelper.spec "#execute_script", requires: [:js] do
-  it "should execute the given script and return nothing" do
+Capybara::SpecHelper.spec '#execute_script', requires: [:js] do
+  it 'should execute the given script and return nothing' do
     @session.visit('/with_js')
     expect(@session.execute_script("document.getElementById('change').textContent = 'Funky Doodle'")).to be_nil
     expect(@session).to have_css('#change', text: 'Funky Doodle')
   end
 
-  it "should be able to call functions defined in the page" do
+  it 'should be able to call functions defined in the page' do
     @session.visit('/with_js')
     expect { @session.execute_script("$('#change').text('Funky Doodle')") }.not_to raise_error
   end
 
-  it "should pass arguments to the script", requires: %i[js es_args] do
+  it 'should pass arguments to the script', requires: %i[js es_args] do
     @session.visit('/with_js')
-    @session.execute_script("document.getElementById('change').textContent = arguments[0]", "Doodle Funk")
+    expect(@session).to have_css('#change')
+    @session.execute_script("document.getElementById('change').textContent = arguments[0]", 'Doodle Funk')
     expect(@session).to have_css('#change', text: 'Doodle Funk')
   end
 
-  it "should support passing elements as arguments to the script", requires: %i[js es_args] do
+  it 'should support passing elements as arguments to the script', requires: %i[js es_args] do
     @session.visit('/with_js')
     el = @session.find(:css, '#change')
-    @session.execute_script("arguments[1].textContent = arguments[0]", "Doodle Funk", el)
+    @session.execute_script('arguments[1].textContent = arguments[0]', 'Doodle Funk', el)
     expect(@session).to have_css('#change', text: 'Doodle Funk')
   end
 end