capybara 2.7.1 → 2.8.0

data/lib/capybara/spec/session/find_button_spec.rb

@@ -9,6 +9,18 @@ Capybara::SpecHelper.spec '#find_button' do
     expect(@session.find_button('crap321').value).to eq("crappy")
   end
 
+  context "aria_label attribute with Capybara.enable_aria_label" do
+    it "should find when true" do
+      Capybara.enable_aria_label = true
+      expect(@session.find_button('Mediocre Button')[:id]).to eq("mediocre")
+    end
+
+    it "should not find when false" do
+      Capybara.enable_aria_label = false
+      expect { @session.find_button('Mediocre Button') }.to raise_error(Capybara::ElementNotFound)
+    end
+  end
+
   it "casts to string" do
     expect(@session.find_button(:'med')[:id]).to eq("mediocre")
   end
@@ -21,7 +33,7 @@ Capybara::SpecHelper.spec '#find_button' do
 
   context "with :exact option" do
     it "should accept partial matches when false" do
-      expect(@session.find_button('What an Awesome', :exact => false)[:value]).to eq("awesome")
+      expect(@session.find_button('What an Awesome', :exact => false).value).to eq("awesome")
     end
 
     it "should not accept partial matches when true" do
@@ -52,4 +64,10 @@ Capybara::SpecHelper.spec '#find_button' do
       expect(@session.find_button('Disabled button', :disabled => :all).value).to eq("Disabled button")
     end
   end
+
+  context "without locator" do
+    it "should use options" do
+      expect(@session.find_button(disabled: true).value).to eq("Disabled button")
+    end
+  end
 end

data/lib/capybara/spec/session/find_field_spec.rb

@@ -8,6 +8,21 @@ Capybara::SpecHelper.spec '#find_field' do
     expect(@session.find_field('Dog').value).to eq('dog')
     expect(@session.find_field('form_description').text).to eq('Descriptive text goes here')
     expect(@session.find_field('Region')[:name]).to eq('form[region]')
+
+  end
+
+  context "aria_label attribute with Capybara.enable_aria_label" do
+    it "should find when true" do
+      Capybara.enable_aria_label = true
+      expect(@session.find_field('Unlabelled Input')[:name]).to eq('form[which_form]')
+      # expect(@session.find_field('Emergency Number')[:id]).to eq('html5_tel')
+    end
+
+    it "should not find when false" do
+      Capybara.enable_aria_label = false
+      expect { @session.find_field('Unlabelled Input') }.to raise_error(Capybara::ElementNotFound)
+      # expect { @session.find_field('Emergency Number') }.to raise_error(Capybara::ElementNotFound)
+    end
   end
 
   it "casts to string" do
@@ -71,7 +86,6 @@ Capybara::SpecHelper.spec '#find_field' do
     end
   end
 
-
   context 'with :readonly option' do
     it "should find readonly fields when true" do
       expect(@session.find_field('form[readonly_test]', readonly: true)[:id]).to eq 'readonly'
@@ -87,4 +101,10 @@ Capybara::SpecHelper.spec '#find_field' do
       end.to raise_error(Capybara::Ambiguous, /found 2 elements/)
     end
   end
+
+  context 'with no locator' do
+    it 'should use options to find the field' do
+      expect(@session.find_field(with: 'dog')['id']).to eq "form_pets_dog"
+    end
+  end
 end

data/lib/capybara/spec/session/find_link_spec.rb

@@ -4,11 +4,23 @@ Capybara::SpecHelper.spec '#find_link' do
     @session.visit('/with_html')
   end
 
-  it "should find any field" do
+  it "should find any link" do
     expect(@session.find_link('foo').text).to eq("ullamco")
     expect(@session.find_link('labore')[:href]).to match %r(/with_simple_html$)
   end
 
+  context "aria_label attribute with Capybara.enable_aria_label" do
+    it "should find when true" do
+      Capybara.enable_aria_label = true
+      expect(@session.find_link('Go to simple')[:href]).to match %r(/with_simple_html$)
+    end
+
+    it "should not find when false" do
+      Capybara.enable_aria_label = false
+      expect { @session.find_link('Go to simple') }.to raise_error(Capybara::ElementNotFound)
+    end
+  end
+
   it "casts to string" do
     expect(@session.find_link(:'foo').text).to eq("ullamco")
   end
@@ -30,4 +42,10 @@ Capybara::SpecHelper.spec '#find_link' do
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
+
+  context "without locator" do
+    it "should use options" do
+      expect(@session.find_link(href: '#anchor').text).to eq "Normal Anchor"
+    end
+  end
 end

data/lib/capybara/spec/session/find_spec.rb

@@ -10,7 +10,7 @@ Capybara::SpecHelper.spec '#find' do
 
   it "should find the first element using the given locator" do
     expect(@session.find('//h1').text).to eq('This is a test')
-    expect(@session.find("//input[@id='test_field']")[:value]).to eq('monkey')
+    expect(@session.find("//input[@id='test_field']").value).to eq('monkey')
   end
 
   it "should find the first element using the given locator and options" do
@@ -79,7 +79,7 @@ Capybara::SpecHelper.spec '#find' do
   context "with css selectors" do
     it "should find the first element using the given locator" do
       expect(@session.find(:css, 'h1').text).to eq('This is a test')
-      expect(@session.find(:css, "input[id='test_field']")[:value]).to eq('monkey')
+      expect(@session.find(:css, "input[id='test_field']").value).to eq('monkey')
     end
 
     it "should support pseudo selectors" do
@@ -90,7 +90,7 @@ Capybara::SpecHelper.spec '#find' do
   context "with xpath selectors" do
     it "should find the first element using the given locator" do
       expect(@session.find(:xpath, '//h1').text).to eq('This is a test')
-      expect(@session.find(:xpath, "//input[@id='test_field']")[:value]).to eq('monkey')
+      expect(@session.find(:xpath, "//input[@id='test_field']").value).to eq('monkey')
     end
   end
 
@@ -165,11 +165,39 @@ Capybara::SpecHelper.spec '#find' do
     end
   end
 
+  context "with alternate filter set" do
+    before do
+      Capybara::Selector::FilterSet.add(:value) do
+        filter(:with) { |node, with| node.value == with.to_s }
+      end
+
+      Capybara.add_selector(:id_with_field_filters) do
+        xpath { |id| XPath.descendant[XPath.attr(:id) == id.to_s] }
+        filter_set(:field)
+      end
+    end
+
+    it "should allow use of filters from custom filter set" do
+      expect(@session.find(:id, 'test_field', filter_set: :value, with: 'monkey').value).to eq('monkey')
+      expect{ @session.find(:id, 'test_field', filter_set: :value, with: 'not_monkey') }.to raise_error(Capybara::ElementNotFound)
+    end
+
+    it "should allow use of filter set from a different selector" do
+      expect(@session.find(:id, 'test_field', filter_set: :field, with: 'monkey').value).to eq('monkey')
+      expect{ @session.find(:id, 'test_field', filter_set: :field, with: 'not_monkey') }.to raise_error(Capybara::ElementNotFound)
+    end
+
+    it "should allow importing of filter set into selector" do
+      expect(@session.find(:id_with_field_filters, 'test_field', with: 'monkey').value).to eq('monkey')
+      expect{ @session.find(:id_with_field_filters, 'test_field', with: 'not_monkey') }.to raise_error(Capybara::ElementNotFound)
+    end
+  end
+
   context "with css as default selector" do
     before { Capybara.default_selector = :css }
     it "should find the first element using the given locator" do
       expect(@session.find('h1').text).to eq('This is a test')
-      expect(@session.find("input[id='test_field']")[:value]).to eq('monkey')
+      expect(@session.find("input[id='test_field']").value).to eq('monkey')
     end
     after { Capybara.default_selector = :xpath }
   end

data/lib/capybara/spec/session/first_spec.rb

@@ -6,7 +6,7 @@ Capybara::SpecHelper.spec '#first' do
 
   it "should find the first element using the given locator" do
     expect(@session.first('//h1').text).to eq('This is a test')
-    expect(@session.first("//input[@id='test_field']")[:value]).to eq('monkey')
+    expect(@session.first("//input[@id='test_field']").value).to eq('monkey')
   end
 
   it "should return nil when nothing was found" do
@@ -22,14 +22,14 @@ Capybara::SpecHelper.spec '#first' do
   context "with css selectors" do
     it "should find the first element using the given selector" do
       expect(@session.first(:css, 'h1').text).to eq('This is a test')
-      expect(@session.first(:css, "input[id='test_field']")[:value]).to eq('monkey')
+      expect(@session.first(:css, "input[id='test_field']").value).to eq('monkey')
     end
   end
 
   context "with xpath selectors" do
     it "should find the first element using the given locator" do
       expect(@session.first(:xpath, '//h1').text).to eq('This is a test')
-      expect(@session.first(:xpath, "//input[@id='test_field']")[:value]).to eq('monkey')
+      expect(@session.first(:xpath, "//input[@id='test_field']").value).to eq('monkey')
     end
   end
 
@@ -37,7 +37,7 @@ Capybara::SpecHelper.spec '#first' do
     before { Capybara.default_selector = :css }
     it "should find the first element using the given locator" do
       expect(@session.first('h1').text).to eq('This is a test')
-      expect(@session.first("input[id='test_field']")[:value]).to eq('monkey')
+      expect(@session.first("input[id='test_field']").value).to eq('monkey')
     end
   end
 

data/lib/capybara/spec/session/has_field_spec.rb

@@ -16,6 +16,7 @@ Capybara::SpecHelper.spec '#has_field' do
   context 'with value' do
     it "should be true if a field with the given value is on the page" do
       expect(@session).to have_field('First Name', :with => 'John')
+      expect(@session).to have_field('First Name', :with => /^Joh/)
       expect(@session).to have_field('Phone', :with => '+1 555 7021')
       expect(@session).to have_field('Street', :with => 'Sesame street 66')
       expect(@session).to have_field('Description', :with => 'Descriptive text goes here')
@@ -23,6 +24,7 @@ Capybara::SpecHelper.spec '#has_field' do
 
     it "should be false if the given field is not on the page" do
       expect(@session).not_to have_field('First Name', :with => 'Peter')
+      expect(@session).not_to have_field('First Name', :with => /eter$/)
       expect(@session).not_to have_field('Wrong Name', :with => 'John')
       expect(@session).not_to have_field('Description', :with => 'Monkey')
     end
@@ -30,11 +32,13 @@ Capybara::SpecHelper.spec '#has_field' do
     it "should be true after the field has been filled in with the given value" do
       @session.fill_in('First Name', :with => 'Jonas')
       expect(@session).to have_field('First Name', :with => 'Jonas')
+      expect(@session).to have_field('First Name', :with => /ona/)
     end
 
     it "should be false after the field has been filled in with a different value" do
       @session.fill_in('First Name', :with => 'Jonas')
       expect(@session).not_to have_field('First Name', :with => 'John')
+      expect(@session).not_to have_field('First Name', :with => /John|Paul|George|Ringo/)
     end
   end
 

data/lib/capybara/spec/session/has_text_spec.rb

@@ -80,7 +80,7 @@ Capybara::SpecHelper.spec '#has_text?' do
     expect(@session).to have_text(:all, 'Some of this text is hidden!')
   end
 
-  it "should be true if `Capybara.ignore_hidden_elements = true` and text is invisible." do
+  it "should be true if `Capybara.ignore_hidden_elements = false` and text is invisible." do
     Capybara.ignore_hidden_elements = false
     @session.visit('/with_html')
     expect(@session).to have_text('Some of this text is hidden!')
@@ -280,7 +280,7 @@ Capybara::SpecHelper.spec '#has_no_text?' do
     expect(@session).not_to have_no_text(:all, 'Some of this text is hidden!')
   end
 
-  it "should be false if `Capybara.ignore_hidden_elements = true` and text is invisible." do
+  it "should be false if `Capybara.ignore_hidden_elements = false` and text is invisible." do
     Capybara.ignore_hidden_elements = false
     @session.visit('/with_html')
     expect(@session).not_to have_no_text('Some of this text is hidden!')

data/lib/capybara/spec/session/node_spec.rb

@@ -19,11 +19,19 @@ Capybara::SpecHelper.spec "node" do
     expect(@session.find(:css, '#second')).to have_no_css('h1')
   end
 
+  describe "#query_scope" do
+    it "should have a reference to the element the query was evaluated on if there is one" do
+      @node = @session.find(:css, '#first')
+      expect(@node.query_scope).to eq(@node.session.document)
+      expect(@node.find(:css, '#foo').query_scope).to eq(@node)
+    end
+  end
+
   describe "#parent" do
-    it "should have a reference to its parent if there is one" do
+    it "should be deprecated" do
       @node = @session.find(:css, '#first')
-      expect(@node.parent).to eq(@node.session.document)
-      expect(@node.find(:css, '#foo').parent).to eq(@node)
+      expect(@node).to receive(:warn).with(/^DEPRECATED:/)
+      expect(@node.parent).to eq(@node.query_scope)
     end
   end
 
@@ -409,6 +417,19 @@ Capybara::SpecHelper.spec "node" do
     end
   end
 
+  context "when #synchronize raises server errors" do
+    it "sets an explanatory exception as the cause of server exceptions", :requires => [:server, :js] do
+      skip "This version of ruby doesn't support exception causes" unless Exception.instance_methods.include? :cause
+      quietly { @session.visit("/error") }
+      expect do
+        @session.find(:css, 'span')
+      end.to raise_error(TestApp::TestAppError) do |e|
+        expect(e.cause).to be_a Capybara::CapybaraError
+        expect(e.cause.message).to match /Your application server raised an error/
+      end
+    end
+  end
+
   def be_an_invalid_element_error(session)
     satisfy { |error| session.driver.invalid_element_errors.any? { |e| error.is_a? e } }
   end

data/lib/capybara/spec/session/reset_session_spec.rb

@@ -46,6 +46,13 @@ Capybara::SpecHelper.spec '#reset_session!' do
     expect(@session).to have_no_selector :xpath, "/html/body/*", wait: false
   end
 
+  it "handles already open modals" do
+    @session.visit('/with_unload_alert')
+    @session.click_link('Go away')
+    expect { @session.reset_session! }.not_to raise_error
+    expect(@session).to have_no_selector :xpath, "/html/body/*", wait: false
+  end
+
   it "raises any standard errors caught inside the server", :requires => [:server] do
     quietly { @session.visit("/error") }
     expect do

data/lib/capybara/spec/session/selectors_spec.rb

@@ -32,4 +32,18 @@ Capybara::SpecHelper.spec Capybara::Selector do
       end
     end
   end
+
+  describe "locate_field selectors" do
+    it "can find specifically by id" do
+      expect(@session.find(:field, id: 'customer_email').value).to eq "ben@ben.com"
+    end
+
+    it "can find specifically by name" do
+      expect(@session.find(:field, name: 'form[other_title]')['id']).to eq "form_other_title"
+    end
+
+    it "can find specifically by placeholder" do
+      expect(@session.find(:field, placeholder: 'FirstName')['id']).to eq "form_first_name"
+    end
+  end
 end

data/lib/capybara/spec/session/uncheck_spec.rb

@@ -38,4 +38,43 @@ Capybara::SpecHelper.spec "#uncheck" do
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
+
+  context "when checkbox hidden" do
+    context "with Capybara.automatic_label_click == true" do
+      around do |spec|
+        old_click_label, Capybara.automatic_label_click = Capybara.automatic_label_click, true
+        spec.run
+        Capybara.automatic_label_click = old_click_label
+      end
+
+      it "should uncheck via clicking the label with :for attribute if possible" do
+        expect(@session.find(:checkbox, 'form_cars_jaguar', checked: true, visible: :hidden)).to be
+        @session.uncheck('form_cars_jaguar')
+        @session.click_button('awesome')
+        expect(extract_results(@session)['cars']).not_to include('jaguar')
+      end
+
+      it "should uncheck via clicking the wrapping label if possible" do
+        expect(@session.find(:checkbox, 'form_cars_koenigsegg', checked: true, visible: :hidden)).to be
+        @session.uncheck('form_cars_koenigsegg')
+        @session.click_button('awesome')
+        expect(extract_results(@session)['cars']).not_to include('koenigsegg')
+      end
+
+      it "should not click the label if unneeded" do
+        expect(@session.find(:checkbox, 'form_cars_tesla', unchecked: true, visible: :hidden)).to be
+        @session.uncheck('form_cars_tesla')
+        @session.click_button('awesome')
+        expect(extract_results(@session)['cars']).not_to include('tesla')
+      end
+
+      it "should raise original error when no label available" do
+        expect { @session.uncheck('form_cars_ariel') }.to raise_error(Capybara::ElementNotFound, 'Unable to find checkbox "form_cars_ariel"')
+      end
+
+      it "should raise error if not allowed to click label" do
+        expect{@session.uncheck('form_cars_jaguar', allow_label_click: false)}.to raise_error(Capybara::ElementNotFound, 'Unable to find checkbox "form_cars_jaguar"')
+      end
+    end
+  end
 end

data/lib/capybara/spec/session/window/switch_to_window_spec.rb

@@ -3,7 +3,9 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
   before(:each) do
     @window = @session.current_window
     @session.visit('/with_windows')
+    expect(@session).to have_css('body.loaded')
   end
+
   after(:each) do
     (@session.windows - [@window]).each do |w|
       @session.switch_to_window w
@@ -47,7 +49,7 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
   context "with block" do
     before(:each) do
       @session.find(:css, '#openTwoWindows').click
-      sleep(0.2) # wait for the windows to open
+      sleep(1) # wait for the windows to open
     end
 
     it "should be able to switch to current window" do
@@ -117,7 +119,7 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
   it "should wait for window to appear" do
     @session.find(:css, '#openWindowWithTimeout').click
     expect do
-      @session.switch_to_window { @session.title == 'Title of the first popup'}
+      @session.switch_to_window(wait: 5) { @session.title == 'Title of the first popup'}
     end.not_to raise_error
   end
 end

data/lib/capybara/spec/session/window/window_opened_by_spec.rb

@@ -3,6 +3,7 @@ Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
   before(:each) do
     @window = @session.current_window
     @session.visit('/with_windows')
+    expect(@session).to have_css('body.loaded')
   end
   after(:each) do
     (@session.windows - [@window]).each do |w|
@@ -73,7 +74,7 @@ Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
     expect do
       @session.window_opened_by do
         button.click
-        sleep 0.1 # It's possible for window_opened_by to be fullfilled before the second window opens
+        sleep 1 # It's possible for window_opened_by to be fullfilled before the second window opens
       end
     end.to raise_error(Capybara::WindowError, two_windows_message)
     @session.document.synchronize(2, errors: [Capybara::CapybaraError]) do

data/lib/capybara/spec/session/window/window_spec.rb

@@ -86,18 +86,22 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
   end
 
   describe '#size' do
+    def win_size
+      @session.evaluate_script("[window.outerWidth || window.innerWidth, window.outerHeight || window.innerHeight]")
+    end
+
     it 'should return size of whole window', requires: [:windows, :js] do
-      expect(@session.current_window.size).to eq @session.evaluate_script("[window.outerWidth, window.outerHeight];")
+      expect(@session.current_window.size).to eq win_size
     end
 
     it 'should switch to original window if invoked not for current window' do
       @other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
-      size =
-        @session.within_window @other_window do
-          @session.evaluate_script("[window.outerWidth, window.outerHeight];")
-        end
+      sleep 1
+      size = @session.within_window(@other_window) do
+        win_size
+      end
       expect(@other_window.size).to eq(size)
       expect(@session.current_window).to eq(@window)
     end
@@ -105,10 +109,10 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
 
   describe '#resize_to' do
     it 'should be able to resize window', requires: [:windows, :js] do
-
-      width, height = @session.evaluate_script("[window.outerWidth, window.outerHeight];")
-      @session.current_window.resize_to(width-10, height-10)
-      expect(@session.evaluate_script("[window.outerWidth, window.outerHeight];")).to eq([width-10, height-10])
+      width, height = @session.current_window.size
+      @session.current_window.resize_to(width-100, height-100)
+      sleep 1
+      expect(@session.current_window.size).to eq([width-100, height-100])
     end
 
     it 'should stay on current window if invoked not for current window', requires: [:windows, :js] do
@@ -120,36 +124,46 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
       expect(@session.current_window).to eq(@window)
 
       # #size returns values larger than availWidth, availHeight with Chromedriver
-      # expect(@other_window.size).to eq([400, 300])
       @session.within_window(@other_window) do
-        expect(@session.evaluate_script("[window.outerWidth, window.outerHeight]")).to eq([400,300])
+        expect(@session.current_window.size).to eq([400,300])
+        # expect(@session.evaluate_script("[window.outerWidth, window.outerHeight]")).to eq([400,300])
       end
     end
   end
 
   describe '#maximize' do
     it 'should be able to maximize window', requires: [:windows, :js] do
-      screen_width, screen_height = @session.evaluate_script("[window.screen.availWidth, window.screen.availHeight];")
-      window = @session.current_window
-      window.resize_to(screen_width-100, screen_height-100)
-      expect(@session.evaluate_script("[window.outerWidth, window.outerHeight];")).to eq([screen_width-100, screen_height-100])
-      window.maximize
+      start_width, start_height = 400, 300
+      @session.current_window.resize_to(start_width, start_height)
+      sleep 0.5
+
+      @session.current_window.maximize
       sleep 0.5  # The timing on maximize is finicky on Travis -- wait a bit for maximize to occur
-      expect(@session.evaluate_script("[window.outerWidth, window.outerHeight];")).to eq([screen_width, screen_height])
+
+      max_width, max_height = @session.current_window.size
+
+      #maximize behavior is window manage dependant, so just make sure it increases in size
+      expect(max_width).to be > start_width
+      expect(max_height).to be > start_height
     end
 
     it 'should stay on current window if invoked not for current window', requires: [:windows, :js] do
+      cur_window_size = @session.current_window.size
       @other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
+
+      @other_window.resize_to(400,300)
+      sleep 0.5
       @other_window.maximize
       sleep 0.5 # The timing on maximize is finicky on Travis -- wait a bit for maximize to occur
+
       expect(@session.current_window).to eq(@window)
-      # #size returns values larger than availWidth, availHeight with Chromedriver
-      # expect(@other_window.size).to eq(@session.evaluate_script("[window.screen.availWidth, window.screen.availHeight];"))
-      @session.within_window(@other_window) do
-        expect(@session.evaluate_script("[window.outerWidth, window.outerHeight]")).to eq(@session.evaluate_script("[window.screen.availWidth, window.screen.availHeight];"))
-      end
+      expect(@session.current_window.size).to eq(cur_window_size)
+
+      ow_width, ow_height = @other_window.size
+      expect(ow_width).to be > 400
+      expect(ow_height).to be > 300
     end
   end
 end