capybara 2.4.4 → 2.5.0

data/lib/capybara/spec/session/click_link_spec.rb

@@ -84,6 +84,28 @@ Capybara::SpecHelper.spec '#click_link' do
     end
   end
 
+  context "with a regex :href option given"  do
+    it "should find a link matching an all-matching regex pattern" do
+      @session.click_link('labore', :href => /.+/)
+      expect(@session).to have_content('Bar')
+    end
+
+    it "should find a link matching an exact regex pattern" do
+      @session.click_link('labore', :href => /\/with_simple_html/)
+      expect(@session).to have_content('Bar')
+    end
+
+    it "should find a link matching a partial regex pattern" do
+      @session.click_link('labore', :href => /\/with_simple/)
+      expect(@session).to have_content('Bar')
+    end
+
+    it "should raise an error if no link's href matched the pattern" do
+      expect { @session.click_link('labore', :href => /invalid_pattern/) }.to raise_error(Capybara::ElementNotFound)
+      expect { @session.click_link('labore', :href => /.+d+/) }.to raise_error(Capybara::ElementNotFound)
+    end
+  end
+
   it "should follow relative links" do
     @session.visit('/')
     @session.click_link('Relative')
@@ -100,8 +122,9 @@ Capybara::SpecHelper.spec '#click_link' do
     expect(@session).to have_content('You landed')
   end
 
-  it "should follow redirects" do
+  it "should follow redirects back to itself" do
     @session.click_link('BackToMyself')
+    expect(@session).to have_css('#referrer', text: /\/with_html$/)
     expect(@session).to have_content('This is a test')
   end
 
@@ -116,6 +139,8 @@ Capybara::SpecHelper.spec '#click_link' do
     expect(@session.find_field("test_field").value).to eq('blah')
     @session.click_link('Blank Anchor')
     expect(@session.find_field("test_field").value).to eq('blah')
+    @session.click_link('Blank JS Anchor')
+    expect(@session.find_field("test_field").value).to eq('blah')
   end
 
   it "should do nothing on URL+anchor links for the same page" do
@@ -129,6 +154,12 @@ Capybara::SpecHelper.spec '#click_link' do
     expect(@session).to have_content('Bar')
   end
 
+  it "should follow link on anchor if the path has regex special characters" do
+    @session.visit('/with.*html')
+    @session.click_link('Anchor on different page')
+    expect(@session).to have_content('Bar')
+  end
+
   it "raise an error with links with no href" do
     expect do
       @session.click_link('No Href')

data/lib/capybara/spec/session/current_url_spec.rb

@@ -1,3 +1,5 @@
+require "capybara/spec/test_app"
+
 Capybara::SpecHelper.spec '#current_url, #current_path, #current_host' do
   before :all do
     @servers = 2.times.map { Capybara::Server.new(TestApp.clone).boot }
@@ -11,6 +13,9 @@ Capybara::SpecHelper.spec '#current_url, #current_path, #current_host' do
   end
 
   def should_be_on server_index, path="/host", scheme="http"
+    #This delay is to give fully async drivers (selenium w/chromedriver) time for the browser
+    #to get to its destination - should be removed when we have a waiting current_url matcher
+    sleep 0.1  # remove and adjust tests when a waiting current_url/path matcher is implemented
     # Check that we are on /host on the given server
     s = @servers[server_index]
     expect(@session.current_url.chomp('?')).to eq("#{scheme}://#{s.host}:#{s.port}#{path}")

data/lib/capybara/spec/session/fill_in_spec.rb

@@ -100,7 +100,7 @@ Capybara::SpecHelper.spec "#fill_in" do
   end
 
   it "should throw an exception if a hash containing 'with' is not provided" do
-    expect {@session.fill_in 'Name', 'ignu'}.to raise_error
+    expect {@session.fill_in 'Name', 'ignu'}.to raise_error(RuntimeError, /with/)
   end
 
   it "should wait for asynchronous load", :requires => [:js] do

data/lib/capybara/spec/session/find_field_spec.rb

@@ -61,4 +61,21 @@ Capybara::SpecHelper.spec '#find_field' do
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
+
+
+  context 'with :readonly option' do
+    it "should find readonly fields when true" do
+      expect(@session.find_field('form[readonly_test]', readonly: true)[:id]).to eq 'readonly'
+    end
+
+    it "should not find readonly fields when false" do
+      expect(@session.find_field('form[readonly_test]', readonly: false)[:id]).to eq 'not_readonly'
+    end
+
+    it "should ignore readonly by default" do
+      expect do
+        @session.find_field('form[readonly_test]')
+      end.to raise_error(Capybara::Ambiguous, /found 2 elements/)
+    end
+  end
 end

data/lib/capybara/spec/session/find_spec.rb

@@ -58,11 +58,20 @@ Capybara::SpecHelper.spec '#find' do
   end
 
   context "with frozen time", :requires => [:js] do
-    it "raises an error suggesting that Capybara is stuck in time" do
-      @session.visit('/with_js')
-      now = Time.now
-      allow(Time).to receive(:now).and_return(now)
-      expect { @session.find('//isnotthere') }.to raise_error(Capybara::FrozenInTime)
+    if defined?(Process::CLOCK_MONOTONIC)
+      it "will time out even if time is frozen" do
+        @session.visit('/with_js')
+        now = Time.now
+        allow(Time).to receive(:now).and_return(now)
+        expect { @session.find('//isnotthere') }.to raise_error(Capybara::ElementNotFound)
+      end
+    else
+      it "raises an error suggesting that Capybara is stuck in time" do
+        @session.visit('/with_js')
+        now = Time.now
+        allow(Time).to receive(:now).and_return(now)
+        expect { @session.find('//isnotthere') }.to raise_error(Capybara::FrozenInTime)
+      end
     end
   end
 

data/lib/capybara/spec/session/first_spec.rb

@@ -85,4 +85,28 @@ Capybara::SpecHelper.spec '#first' do
       end
     end
   end
+
+  context "with Capybara.wait_on_first_by_default", requires: [:js] do
+    before do
+      @session.visit('/with_js')
+    end
+
+    it "should not wait if false" do
+      Capybara.wait_on_first_by_default = false
+      @session.click_link('clickable')
+      expect(@session.first(:css, 'a#has-been-clicked')).to be_nil
+    end
+
+    it "should wait for at least one match if true" do
+      Capybara.wait_on_first_by_default = true
+      @session.click_link('clickable')
+      expect(@session.first(:css, 'a#has-been-clicked')).not_to be_nil
+    end
+
+    it "should return nil after waiting if no match" do
+      Capybara.wait_on_first_by_default = true
+      @session.click_link('clickable')
+      expect(@session.first(:css, 'a#not-a-real-link')).to be_nil
+    end
+  end
 end

data/lib/capybara/spec/session/has_current_path_spec.rb

@@ -0,0 +1,68 @@
+Capybara::SpecHelper.spec '#has_current_path?' do
+  before do
+    @session.visit('/with_js')
+  end
+
+  it "should be true if the page has the given current path" do
+    expect(@session).to have_current_path('/with_js')
+  end
+
+  it "should allow regexp matches" do
+    expect(@session).to have_current_path(/w[a-z]{3}_js/)
+    expect(@session).not_to have_current_path(/monkey/)
+  end
+
+  it "should wait for current_path", :requires => [:js] do
+    @session.click_link("Change page")
+    expect(@session).to have_current_path("/with_html")
+  end
+
+  it "should be false if the page has not the given current_path" do
+    expect(@session).not_to have_current_path('/with_html')
+  end
+
+  it "should check query options" do
+    @session.visit('/with_js?test=test')
+    expect(@session).to have_current_path('/with_js?test=test')
+  end
+
+  it "should compare the full url" do
+    expect(@session).to have_current_path(%r{\Ahttp://[^/]*/with_js\Z}, url: true)
+  end
+
+  it "should ignore the query" do
+    @session.visit('/with_js?test=test')
+    expect(@session).to have_current_path('/with_js?test=test')
+    expect(@session).to have_current_path('/with_js', only_path: true)
+  end
+
+  it "should not allow url and only_path at the same time" do
+    expect {
+      expect(@session).to have_current_path('/with_js', url: true, only_path: true)
+      }. to raise_error ArgumentError
+  end
+end
+
+Capybara::SpecHelper.spec '#has_no_current_path?' do
+  before do
+    @session.visit('/with_js')
+  end
+
+  it "should be false if the page has the given current_path" do
+    expect(@session).not_to have_no_current_path('/with_js')
+  end
+
+  it "should allow regexp matches" do
+    expect(@session).not_to have_no_current_path(/w[a-z]{3}_js/)
+    expect(@session).to have_no_current_path(/monkey/)
+  end
+
+  it "should wait for current_path to disappear", :requires => [:js] do
+    @session.click_link("Change page")
+    expect(@session).to have_no_current_path('/with_js')
+  end
+
+  it "should be true if the page has not the given current_path" do
+    expect(@session).to have_no_current_path('/with_html')
+  end
+end

data/lib/capybara/spec/session/has_link_spec.rb

@@ -8,11 +8,13 @@ Capybara::SpecHelper.spec '#has_link?' do
     expect(@session).to have_link('awesome title')
     expect(@session).to have_link('A link', :href => '/with_simple_html')
     expect(@session).to have_link(:'A link', :href => :'/with_simple_html')
+    expect(@session).to have_link('A link', :href => /\/with_simple_html/)
   end
 
   it "should be false if the given link is not on the page" do
     expect(@session).not_to have_link('monkey')
     expect(@session).not_to have_link('A link', :href => '/non-existant-href')
+    expect(@session).not_to have_link('A link', :href => /non-existant/)
   end
 end
 
@@ -30,5 +32,6 @@ Capybara::SpecHelper.spec '#has_no_link?' do
   it "should be true if the given link is not on the page" do
     expect(@session).to have_no_link('monkey')
     expect(@session).to have_no_link('A link', :href => '/non-existant-href')
+    expect(@session).to have_no_link('A link', :href => /\/non-existant-href/)
   end
 end

data/lib/capybara/spec/session/has_text_spec.rb

@@ -200,6 +200,13 @@ Capybara::SpecHelper.spec '#has_text?' do
       end
     end
   end
+
+  it "should raise an error if an invalid option is passed" do
+    @session.visit('/with_html')
+    expect do
+      expect(@session).to have_text('Lorem', exact: true)
+    end.to raise_error(ArgumentError)
+  end
 end
 
 Capybara::SpecHelper.spec '#has_no_text?' do

data/lib/capybara/spec/session/node_spec.rb

@@ -67,7 +67,7 @@ Capybara::SpecHelper.spec "node" do
       @session.find('//textarea[1]').set("some <em>html</em> here")
       expect(@session.find('//textarea[1]').value).to eq("some <em>html</em> here")
     end
-    
+
     it "defaults to 'on' for checkbox" do
       @session.visit('/form')
       expect(@session.find('//input[@id="valueless_checkbox"]').value).to eq('on')
@@ -76,7 +76,7 @@ Capybara::SpecHelper.spec "node" do
     it "defaults to 'on' for radio buttons" do
       @session.visit('/form')
       expect(@session.find('//input[@id="valueless_radio"]').value).to eq('on')
-    end    
+    end
   end
 
   describe "#set" do
@@ -97,7 +97,7 @@ Capybara::SpecHelper.spec "node" do
       @session.first('//input[@readonly]').set('changed')
       expect(@session.first('//input[@readonly]').value).to eq('should not change')
     end
-    
+
     it "should raise if the text field is readonly" do
       expect(@session.first('//input[@readonly]').set('changed')).to raise_error(Capybara::ReadOnlyElementError)
     end if Capybara::VERSION.to_f > 3.0
@@ -202,6 +202,19 @@ Capybara::SpecHelper.spec "node" do
     end
   end
 
+  describe "#path" do
+    # Testing for specific XPaths here doesn't make sense since there
+    # are many that can refer to the same element
+    before :each do
+      @session.visit('/path')
+    end
+
+    it "returns xpath which points to itself" do
+      element = @session.find(:link, 'Second Link')
+      expect(@session.find(:xpath, element.path)).to eq(element)
+    end
+  end
+
   describe "#trigger", :requires => [:js, :trigger] do
     it "should allow triggering of custom JS events" do
       @session.visit('/with_js')
@@ -228,14 +241,14 @@ Capybara::SpecHelper.spec "node" do
       expect(@session.find(:css, '.hidden_until_hover', :visible => false)).to be_visible
     end
   end
-  
+
   describe '#click' do
     it "should not follow a link if no href" do
       @session.find(:css, '#link_placeholder').click
       expect(@session.current_url).to match(%r{/with_html$})
     end
   end
-  
+
   describe '#double_click', :requires => [:js] do
     it "should double click an element" do
       @session.visit('/with_js')
@@ -250,7 +263,33 @@ Capybara::SpecHelper.spec "node" do
       @session.find(:css, '#click-test').right_click
       expect(@session.find(:css, '#has-been-right-clicked')).to be
     end
-  end  
+  end
+
+  describe '#send_keys', requires: [:send_keys] do
+    it "should send a string of keys to an element" do
+      @session.visit('/form')
+      @session.find(:css, '#address1_city').send_keys('Oceanside')
+      expect(@session.find(:css, '#address1_city').value).to eq 'Oceanside'
+    end
+
+    it "should send special characters" do
+      @session.visit('/form')
+      @session.find(:css, '#address1_city').send_keys('Ocean', :space, 'sie', :left, 'd')
+      expect(@session.find(:css, '#address1_city').value).to eq 'Ocean side'
+    end
+
+    it "should allow for multiple simultaneous keys" do
+      @session.visit('/form')
+      @session.find(:css, '#address1_city').send_keys([:shift, 'o'], 'ceanside')
+      expect(@session.find(:css, '#address1_city').value).to eq 'Oceanside'
+    end
+
+    it "should generate key events", requires: [:send_keys, :js] do
+      @session.visit('/with_js')
+      @session.find(:css, '#with-key-events').send_keys([:shift,'t'], [:shift,'w'])
+      expect(@session.find(:css, '#key-events-output')).to have_text('keydown:16 keydown:84 keydown:16 keydown:87')
+    end
+  end
 
   describe '#reload', :requires => [:js] do
     context "without automatic reload" do

data/lib/capybara/spec/session/reset_session_spec.rb

@@ -37,7 +37,7 @@ Capybara::SpecHelper.spec '#reset_session!' do
     expect(@session).to have_no_selector :xpath, "/html/body/*", wait: false
   end
 
-  it "raises any errors caught inside the server", :requires => [:server] do
+  it "raises any standard errors caught inside the server", :requires => [:server] do
     quietly { @session.visit("/error") }
     expect do
       @session.reset_session!
@@ -46,6 +46,23 @@ Capybara::SpecHelper.spec '#reset_session!' do
     expect(@session.current_path).to eq("/")
   end
 
+  it "raises configured errors caught inside the server", :requires => [:server] do
+    prev_errors = Capybara.server_errors
+
+    Capybara.server_errors = [LoadError]
+    quietly { @session.visit("/error") }
+    expect do
+      @session.reset_session!
+    end.not_to raise_error
+
+    quietly { @session.visit("/load_error") }
+    expect do
+      @session.reset_session!
+    end.to raise_error(LoadError)
+
+    Capybara.server_errors = prev_errors
+  end
+
   it "ignores server errors when `Capybara.raise_server_errors = false`", :requires => [:server] do
     Capybara.raise_server_errors = false
     quietly { @session.visit("/error") }

data/lib/capybara/spec/session/save_and_open_page_spec.rb

@@ -0,0 +1,19 @@
+require 'launchy'
+
+Capybara::SpecHelper.spec '#save_and_open_page' do
+  before do
+    @session.visit '/foo'
+  end
+
+  after do
+    Dir.glob("capybara-*.html").each do |file|
+      FileUtils.rm(file)
+    end
+  end
+
+  it "sends open method to launchy" do
+    allow(Launchy).to receive(:open)
+    @session.save_and_open_page
+    expect(Launchy).to have_received(:open).with(/capybara-\d+\.html/)
+  end
+end

data/lib/capybara/spec/session/save_page_spec.rb

@@ -20,9 +20,8 @@ Capybara::SpecHelper.spec '#save_page' do
 
   it "generates a sensible filename" do
     @session.save_page
-    path = Dir.glob("capybara-*.html").first
-    filename = path.split("/").last
-    expect(filename).to match /^capybara-\d+\.html$/
+    filename = Dir.glob("capybara-*.html").first
+    expect(filename).to match(/^capybara-\d+\.html$/)
   end
 
   it "can store files in a specified directory" do
@@ -68,6 +67,7 @@ Capybara::SpecHelper.spec '#save_page' do
       path = @session.save_page
 
       result = File.read(path)
+      expect(result).to include('<html')
       expect(result).not_to include("http://example.com")
     end
 
@@ -76,7 +76,16 @@ Capybara::SpecHelper.spec '#save_page' do
       path = @session.save_page
 
       result = File.read(path)
+      expect(result).to include('<html')
       expect(result).not_to include("http://example.com")
     end
+
+    it "executes successfully even if the page is missing a <head>" do
+      @session.visit("/with_simple_html")
+      path = @session.save_page
+
+      result = File.read(path)
+      expect(result).to include("Bar")
+    end
   end
 end