capybara 2.2.1 → 2.3.0

data/lib/capybara/spec/session/uncheck_spec.rb

@@ -6,29 +6,29 @@ Capybara::SpecHelper.spec "#uncheck" do
   it "should uncheck a checkbox by id" do
     @session.uncheck("form_pets_hamster")
     @session.click_button('awesome')
-    extract_results(@session)['pets'].should include('dog')
-    extract_results(@session)['pets'].should_not include('hamster')
+    expect(extract_results(@session)['pets']).to include('dog')
+    expect(extract_results(@session)['pets']).not_to include('hamster')
   end
 
   it "should uncheck a checkbox by label" do
     @session.uncheck("Hamster")
     @session.click_button('awesome')
-    extract_results(@session)['pets'].should include('dog')
-    extract_results(@session)['pets'].should_not include('hamster')
+    expect(extract_results(@session)['pets']).to include('dog')
+    expect(extract_results(@session)['pets']).not_to include('hamster')
   end
 
   it "casts to string" do
     @session.uncheck(:"form_pets_hamster")
     @session.click_button('awesome')
-    extract_results(@session)['pets'].should include('dog')
-    extract_results(@session)['pets'].should_not include('hamster')
+    expect(extract_results(@session)['pets']).to include('dog')
+    expect(extract_results(@session)['pets']).not_to include('hamster')
   end
 
   context "with :exact option" do
     it "should accept partial matches when false" do
       @session.uncheck('Ham', :exact => false)
       @session.click_button('awesome')
-      extract_results(@session)['pets'].should_not include('hamster')
+      expect(extract_results(@session)['pets']).not_to include('hamster')
     end
 
     it "should not accept partial matches when true" do

data/lib/capybara/spec/session/unselect_spec.rb

@@ -7,42 +7,42 @@ Capybara::SpecHelper.spec "#unselect" do
     it "should unselect an option from a select box by id" do
       @session.unselect('Commando', :from => 'form_underwear')
       @session.click_button('awesome')
-      extract_results(@session)['underwear'].should include('Briefs', 'Boxerbriefs')
-      extract_results(@session)['underwear'].should_not include('Commando')
+      expect(extract_results(@session)['underwear']).to include('Briefs', 'Boxerbriefs')
+      expect(extract_results(@session)['underwear']).not_to include('Commando')
     end
 
     it "should unselect an option without a select box" do
       @session.unselect('Commando')
       @session.click_button('awesome')
-      extract_results(@session)['underwear'].should include('Briefs', 'Boxerbriefs')
-      extract_results(@session)['underwear'].should_not include('Commando')
+      expect(extract_results(@session)['underwear']).to include('Briefs', 'Boxerbriefs')
+      expect(extract_results(@session)['underwear']).not_to include('Commando')
     end
 
     it "should unselect an option from a select box by label" do
       @session.unselect('Commando', :from => 'Underwear')
       @session.click_button('awesome')
-      extract_results(@session)['underwear'].should include('Briefs', 'Boxerbriefs')
-      extract_results(@session)['underwear'].should_not include('Commando')
+      expect(extract_results(@session)['underwear']).to include('Briefs', 'Boxerbriefs')
+      expect(extract_results(@session)['underwear']).not_to include('Commando')
     end
 
     it "should favour exact matches to option labels" do
       @session.unselect("Briefs", :from => 'Underwear')
       @session.click_button('awesome')
-      extract_results(@session)['underwear'].should include('Commando', 'Boxerbriefs')
-      extract_results(@session)['underwear'].should_not include('Briefs')
+      expect(extract_results(@session)['underwear']).to include('Commando', 'Boxerbriefs')
+      expect(extract_results(@session)['underwear']).not_to include('Briefs')
     end
 
     it "should escape quotes" do
       @session.unselect("Frenchman's Pantalons", :from => 'Underwear')
       @session.click_button('awesome')
-      extract_results(@session)['underwear'].should_not include("Frenchman's Pantalons")
+      expect(extract_results(@session)['underwear']).not_to include("Frenchman's Pantalons")
     end
 
     it "casts to string" do
       @session.unselect(:"Briefs", :from => :'Underwear')
       @session.click_button('awesome')
-      extract_results(@session)['underwear'].should include('Commando', 'Boxerbriefs')
-      extract_results(@session)['underwear'].should_not include('Briefs')
+      expect(extract_results(@session)['underwear']).to include('Commando', 'Boxerbriefs')
+      expect(extract_results(@session)['underwear']).not_to include('Briefs')
     end
   end
 
@@ -75,19 +75,19 @@ Capybara::SpecHelper.spec "#unselect" do
       it "can match select box approximately" do
         @session.unselect("Boxerbriefs", :from => "Under", :exact => false)
         @session.click_button("awesome")
-        extract_results(@session)["underwear"].should_not include("Boxerbriefs")
+        expect(extract_results(@session)["underwear"]).not_to include("Boxerbriefs")
       end
 
       it "can match option approximately" do
         @session.unselect("Boxerbr", :from => "Underwear", :exact => false)
         @session.click_button("awesome")
-        extract_results(@session)["underwear"].should_not include("Boxerbriefs")
+        expect(extract_results(@session)["underwear"]).not_to include("Boxerbriefs")
       end
 
       it "can match option approximately when :from not given" do
         @session.unselect("Boxerbr", :exact => false)
         @session.click_button("awesome")
-        extract_results(@session)["underwear"].should_not include("Boxerbriefs")
+        expect(extract_results(@session)["underwear"]).not_to include("Boxerbriefs")
       end
     end
 

data/lib/capybara/spec/session/visit_spec.rb

@@ -1,9 +1,9 @@
 Capybara::SpecHelper.spec '#visit' do
   it "should fetch a response from the driver with a relative url" do
     @session.visit('/')
-    @session.should have_content('Hello world!')
+    expect(@session).to have_content('Hello world!')
     @session.visit('/foo')
-    @session.should have_content('Another World')
+    expect(@session).to have_content('Another World')
   end
 
   it "should fetch a response from the driver with an absolute url with a port" do
@@ -12,9 +12,9 @@ Capybara::SpecHelper.spec '#visit' do
     root_uri = URI.parse(@session.current_url)
 
     @session.visit("http://#{root_uri.host}:#{root_uri.port}/")
-    @session.should have_content('Hello world!')
+    expect(@session).to have_content('Hello world!')
     @session.visit("http://#{root_uri.host}:#{root_uri.port}/foo")
-    @session.should have_content('Another World')
+    expect(@session).to have_content('Another World')
   end
 
   it "should fetch a response when absolute URI doesn't have a trailing slash" do
@@ -23,7 +23,14 @@ Capybara::SpecHelper.spec '#visit' do
     root_uri = URI.parse(@session.current_url)
 
     @session.visit("http://localhost:#{root_uri.port}")
-    @session.should have_content('Hello world!')
+    expect(@session).to have_content('Hello world!')
+  end
+
+  it "raises any errors caught inside the server", :requires => [:server] do
+    quietly { @session.visit("/error") }
+    expect do
+      @session.visit("/")
+    end.to raise_error(TestApp::TestAppError)
   end
 
   context "when Capybara.always_include_port is true" do
@@ -43,12 +50,12 @@ Capybara::SpecHelper.spec '#visit' do
 
     it "should fetch a response from the driver with an absolute url without a port" do
       @session.visit("http://#{root_uri.host}/")
-      URI.parse(@session.current_url).port.should == root_uri.port
-      @session.should have_content('Hello world!')
+      expect(URI.parse(@session.current_url).port).to eq(root_uri.port)
+      expect(@session).to have_content('Hello world!')
 
       @session.visit("http://#{root_uri.host}/foo")
-      URI.parse(@session.current_url).port.should == root_uri.port
-      @session.should have_content('Another World')
+      expect(URI.parse(@session.current_url).port).to eq(root_uri.port)
+      expect(@session).to have_content('Another World')
     end
   end
 
@@ -57,49 +64,49 @@ Capybara::SpecHelper.spec '#visit' do
       serverless_session = Capybara::Session.new(@session.mode, nil)
       Capybara.app_host = "http://#{@session.server.host}:#{@session.server.port}"
       serverless_session.visit("/foo")
-      serverless_session.should have_content("Another World")
+      expect(serverless_session).to have_content("Another World")
     end
 
     it "should visit a fully qualified URL" do
       serverless_session = Capybara::Session.new(@session.mode, nil)
       serverless_session.visit("http://#{@session.server.host}:#{@session.server.port}/foo")
-      serverless_session.should have_content("Another World")
+      expect(serverless_session).to have_content("Another World")
     end
   end
 
   it "should send no referer when visiting a page" do
     @session.visit '/get_referer'
-    @session.should have_content 'No referer'
+    expect(@session).to have_content 'No referer'
   end
 
   it "should send no referer when visiting a second page" do
     @session.visit '/get_referer'
     @session.visit '/get_referer'
-    @session.should have_content 'No referer'
+    expect(@session).to have_content 'No referer'
   end
 
   it "should send a referer when following a link" do
     @session.visit '/referer_base'
     @session.find('//a[@href="/get_referer"]').click
-    @session.should have_content %r{http://.*/referer_base}
+    expect(@session).to have_content %r{http://.*/referer_base}
   end
 
   it "should preserve the original referer URL when following a redirect" do
     @session.visit('/referer_base')
     @session.find('//a[@href="/redirect_to_get_referer"]').click
-    @session.should have_content %r{http://.*/referer_base}
+    expect(@session).to have_content %r{http://.*/referer_base}
   end
 
   it "should send a referer when submitting a form" do
     @session.visit '/referer_base'
     @session.find('//input').click
-    @session.should have_content %r{http://.*/referer_base}
+    expect(@session).to have_content %r{http://.*/referer_base}
   end
 
   it "can set cookie if a blank path is specified" do
     @session.visit("")
     @session.visit('/get_cookie')
-    @session.should have_content('root cookie')
+    expect(@session).to have_content('root cookie')
   end
 
 end

data/lib/capybara/spec/session/window/become_closed_spec.rb

@@ -0,0 +1,84 @@
+Capybara::SpecHelper.spec '#become_closed', requires: [:windows, :js] do
+  before(:each) do
+    @window = @session.current_window
+    @session.visit('/with_windows')
+    @other_window = @session.window_opened_by do
+      @session.find(:css, '#openWindow').click
+    end
+  end
+
+  after(:each) do
+    @session.document.synchronize(3, errors: [Capybara::CapybaraError]) do
+      raise Capybara::CapybaraError if @session.windows.size != 1
+    end
+    @session.switch_to_window(@window)
+  end
+
+  context 'with :wait option' do
+    it 'should wait if value of :wait is more than timeout' do
+      @session.within_window @other_window do
+        @session.execute_script('setTimeout(function(){ window.close(); }, 500);')
+      end
+      Capybara.using_wait_time 0.1 do
+        expect(@other_window).to become_closed(wait: 0.7)
+      end
+    end
+
+    it 'should raise error if value of :wait is less than timeout' do
+      @session.within_window @other_window do
+        @session.execute_script('setTimeout(function(){ window.close(); }, 700);')
+      end
+      Capybara.using_wait_time 2 do
+        expect do
+          expect(@other_window).to become_closed(wait: 0.4)
+        end.to raise_error(RSpec::Expectations::ExpectationNotMetError, /\Aexpected #<Window @handle=".+"> to become closed after 0.4 seconds\Z/)
+      end
+    end
+  end
+
+  context 'without :wait option' do
+    it 'should wait if value of default_wait_time is more than timeout' do
+      @session.within_window @other_window do
+        @session.execute_script('setTimeout(function(){ window.close(); }, 500);')
+      end
+      Capybara.using_wait_time 0.7 do
+        expect(@other_window).to become_closed
+      end
+    end
+
+    it 'should raise error if value of default_wait_time is less than timeout' do
+      @session.within_window @other_window do
+        @session.execute_script('setTimeout(function(){ window.close(); }, 900);')
+      end
+      Capybara.using_wait_time 0.4 do
+        expect do
+          expect(@other_window).to become_closed
+        end.to raise_error(RSpec::Expectations::ExpectationNotMetError, /\Aexpected #<Window @handle=".+"> to become closed after 0.4 seconds\Z/)
+      end
+    end
+  end
+
+  context 'with not_to' do
+    it 'should raise error if default_wait_time is more than timeout' do
+      @session.within_window @other_window do
+        @session.execute_script('setTimeout(function(){ window.close(); }, 700);')
+      end
+      Capybara.using_wait_time 0.4 do
+        expect do
+          expect(@other_window).not_to become_closed
+        end
+      end
+    end
+
+    it 'should raise error if default_wait_time is more than timeout' do
+      @session.within_window @other_window do
+        @session.execute_script('setTimeout(function(){ window.close(); }, 700);')
+      end
+      Capybara.using_wait_time 1.1 do
+        expect do
+          expect(@other_window).not_to become_closed
+        end.to raise_error(RSpec::Expectations::ExpectationNotMetError, /\Aexpected #<Window @handle=".+"> not to become closed after 1.1 seconds\Z/)
+      end
+    end
+  end
+end

data/lib/capybara/spec/session/window/current_window_spec.rb

@@ -0,0 +1,25 @@
+Capybara::SpecHelper.spec '#current_window', requires: [:windows] do
+  before(:each) do
+    @window = @session.current_window
+    @session.visit('/with_windows')
+  end
+  after(:each) do
+    (@session.windows - [@window]).each do |w|
+      @session.switch_to_window w
+      w.close
+    end
+    @session.switch_to_window(@window)
+  end
+
+  it 'should return window' do
+    expect(@session.current_window).to be_instance_of(Capybara::Window)
+  end
+
+  it "should be modified by switching to another window" do
+    window = @session.window_opened_by { @session.find(:css, '#openWindow').click }
+
+    expect do
+      @session.switch_to_window(window)
+    end.to change { @session.current_window }.from(@window).to(window)
+  end
+end

data/lib/capybara/spec/session/window/open_new_window_spec.rb

@@ -0,0 +1,28 @@
+Capybara::SpecHelper.spec '#open_new_window', requires: [:windows] do
+  before(:each) do
+    @window = @session.current_window
+    @session.visit('/with_windows')
+  end
+  after(:each) do
+    (@session.windows - [@window]).each do |w|
+      @session.switch_to_window w
+      w.close
+    end
+    @session.switch_to_window(@window)
+  end
+
+  it 'should open new window with blank url and title' do
+    window = @session.open_new_window
+    @session.switch_to_window(window)
+    expect(['', 'about:blank']).to include(@session.title)
+    expect(@session.current_url).to eq('about:blank')
+  end
+
+  it 'should open window with changeable content' do
+    window = @session.open_new_window
+    @session.within_window window do
+      @session.visit '/with_html'
+      expect(@session).to have_css('#first')
+    end
+  end
+end

data/lib/capybara/spec/session/window/switch_to_window_spec.rb

@@ -0,0 +1,114 @@
+Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
+  before(:each) do
+    @window = @session.current_window
+    @session.visit('/with_windows')
+  end
+  after(:each) do
+    (@session.windows - [@window]).each do |w|
+      @session.switch_to_window w
+      w.close
+    end
+    @session.switch_to_window(@window)
+  end
+
+  it "should raise error when invoked without args" do
+    expect do
+      @session.switch_to_window
+    end.to raise_error(ArgumentError, "`switch_to_window`: either window or block should be provided")
+  end
+
+  it "should raise error when invoked with window and block" do
+    expect do
+      @session.switch_to_window(@window) { @session.title == 'Title of the first popup' }
+    end.to raise_error(ArgumentError, "`switch_to_window` can take either a block or a window, not both")
+  end
+
+  context "with an instance of Capybara::Window" do
+    it "should be able to switch to window" do
+      window = @session.open_new_window
+      expect(@session.title).to eq('With Windows')
+      @session.switch_to_window(window)
+      expect(['', 'about:blank']).to include(@session.title)
+    end
+
+    it "should raise error when closed window is passed" do
+      original_window = @session.current_window
+      new_window = @session.open_new_window
+      @session.switch_to_window(new_window)
+      new_window.close
+      @session.switch_to_window(original_window)
+      expect do
+        @session.switch_to_window(new_window)
+      end.to raise_error(@session.driver.no_such_window_error)
+    end
+  end
+
+  context "with block" do
+    before(:each) do
+      @session.find(:css, '#openTwoWindows').click
+    end
+
+    it "should be able to switch to current window" do
+      @session.switch_to_window { @session.title == 'With Windows' }
+      expect(@session).to have_css('#openTwoWindows')
+    end
+
+    it "should find the div in another window" do
+      @session.switch_to_window { @session.title == 'Title of popup two' }
+      expect(@session).to have_css('#divInPopupTwo')
+    end
+
+    it "should be able to switch multiple times" do
+      @session.switch_to_window { @session.title == 'Title of the first popup' }
+      expect(@session).to have_css('#divInPopupOne')
+      @session.switch_to_window { @session.title == 'Title of popup two' }
+      expect(@session).to have_css('#divInPopupTwo')
+    end
+
+    it "should return window" do
+      window = @session.switch_to_window { @session.title == 'Title of popup two' }
+      expect((@session.windows - [@window])).to include(window)
+    end
+
+    it "should raise error when invoked inside `within` as it's nonsense" do
+      expect do
+        @session.within(:css, '#doesNotOpenWindows') do
+          @session.switch_to_window { @session.title == 'With Windows' }
+        end
+      end.to raise_error(Capybara::ScopeError, "`switch_to_window` is not supposed to be invoked from `within`'s, `within_frame`'s' or `within_window`'s' block.")
+    end
+
+    it "should raise error when invoked inside `within_frame` as it's nonsense" do
+      expect do
+        @session.within_frame('frameOne') do
+          @session.switch_to_window { @session.title == 'With Windows' }
+        end
+      end.to raise_error(Capybara::ScopeError, "`switch_to_window` is not supposed to be invoked from `within`'s, `within_frame`'s' or `within_window`'s' block.")
+    end
+
+    it "should raise error when invoked inside `within_window` as it's nonsense" do
+      window = (@session.windows - [@window]).first
+      expect do
+        @session.within_window window do
+          @session.switch_to_window { @session.title == 'With Windows' }
+        end
+      end.to raise_error(Capybara::ScopeError, "`switch_to_window` is not supposed to be invoked from `within`'s, `within_frame`'s' or `within_window`'s' block.")
+    end
+
+    it "should raise error if window matching block wasn't found" do
+      original = @session.current_window
+      expect do
+        @session.switch_to_window { @session.title == 'A title' }
+      end.to raise_error(Capybara::WindowError, "Could not find a window matching block/lambda")
+      expect(@session.current_window).to eq(original)
+    end
+
+    it "should switch to original window if error is raised inside block" do
+      original = @session.switch_to_window(@session.windows[1])
+      expect do
+        @session.switch_to_window { raise 'error' }
+      end.to raise_error(StandardError, 'error')
+      expect(@session.current_window).to eq(original)
+    end
+  end
+end