capybara 2.18.0 → 3.38.0

data/spec/minitest_spec_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 require 'capybara/minitest'
 require 'capybara/minitest/spec'
@@ -10,109 +11,135 @@ class MinitestSpecTest < Minitest::Spec
   before do
     visit('/form')
   end
+
   after do
     Capybara.reset_sessions!
   end
 
-  it "supports text expectations" do
-    page.must_have_text('Form', minimum: 1)
-    page.wont_have_text('Not a form')
+  def self.test_order
+    :sorted
+  end
+
+  it 'supports text expectations' do
+    _(page).must_have_text('Form', minimum: 1)
+    _(page).wont_have_text('Not a form')
     form = find(:css, 'form', text: 'Title')
-    form.must_have_text('Customer Email')
-    form.wont_have_text('Some other email')
+    _(form).must_have_text('Customer Email')
+    _(form).wont_have_text('Some other email')
   end
 
-  it "supports current_path expectations" do
-    page.must_have_current_path('/form')
-    page.wont_have_current_path('/form2')
+  it 'supports current_path expectations' do
+    _(page).must_have_current_path('/form')
+    _(page).wont_have_current_path('/form2')
   end
 
-  it "supports title expectations" do
+  it 'supports title expectations' do
     visit('/with_title')
-    page.must_have_title('Test Title')
-    page.wont_have_title('Not the title')
+    _(page).must_have_title('Test Title')
+    _(page).wont_have_title('Not the title')
   end
 
-  it "supports xpath expectations" do
-    page.must_have_xpath('.//input[@id="customer_email"]')
-    page.wont_have_xpath('.//select[@id="not_form_title"]')
-    page.wont_have_xpath('.//input[@id="customer_email"]') { |el| el[:id] == "not_customer_email" }
+  it 'supports xpath expectations' do
+    _(page).must_have_xpath('.//input[@id="customer_email"]')
+    _(page).wont_have_xpath('.//select[@id="not_form_title"]')
+    _(page).wont_have_xpath('.//input[@id="customer_email"]') { |el| el[:id] == 'not_customer_email' }
     select = find(:select, 'form_title')
-    select.must_have_xpath('.//option[@class="title"]')
-    select.must_have_xpath('.//option', count: 1) { |option| option[:class] != 'title' && !option.disabled?}
-    select.wont_have_xpath('.//input[@id="customer_email"]')
+    _(select).must_have_xpath('.//option[@class="title"]')
+    _(select).must_have_xpath('.//option', count: 1) { |option| option[:class] != 'title' && !option.disabled? }
+    _(select).wont_have_xpath('.//input[@id="customer_email"]')
   end
 
-  it "support css expectations" do
-    page.must_have_css('input#customer_email')
-    page.wont_have_css('select#not_form_title')
+  it 'support css expectations' do
+    _(page).must_have_css('input#customer_email')
+    _(page).wont_have_css('select#not_form_title')
     el = find(:select, 'form_title')
-    el.must_have_css('option.title')
-    el.wont_have_css('input#customer_email')
+    _(el).must_have_css('option.title')
+    _(el).wont_have_css('input#customer_email')
   end
 
-  it "supports link expectations" do
+  it 'supports link expectations' do
     visit('/with_html')
-    page.must_have_link('A link')
-    page.wont_have_link('Not on page')
+    _(page).must_have_link('A link')
+    _(page).wont_have_link('Not on page')
   end
 
-  it "supports button expectations" do
-    page.must_have_button('fresh_btn')
-    page.wont_have_button('not_btn')
+  it 'supports button expectations' do
+    _(page).must_have_button('fresh_btn')
+    _(page).wont_have_button('not_btn')
   end
 
-  it "supports field expectations" do
-    page.must_have_field('customer_email')
-    page.wont_have_field('not_on_the_form')
+  it 'supports field expectations' do
+    _(page).must_have_field('customer_email')
+    _(page).wont_have_field('not_on_the_form')
   end
 
-  it "supports select expectations" do
-    page.must_have_select('form_title')
-    page.wont_have_select('not_form_title')
+  it 'supports select expectations' do
+    _(page).must_have_select('form_title')
+    _(page).wont_have_select('not_form_title')
   end
 
-  it "supports checked_field expectations" do
-    page.must_have_checked_field('form_pets_dog')
-    page.wont_have_checked_field('form_pets_cat')
+  it 'supports checked_field expectations' do
+    _(page).must_have_checked_field('form_pets_dog')
+    _(page).wont_have_checked_field('form_pets_cat')
   end
 
-  it "supports unchecked_field expectations" do
-    page.must_have_unchecked_field('form_pets_cat')
-    page.wont_have_unchecked_field('form_pets_dog')
+  it 'supports unchecked_field expectations' do
+    _(page).must_have_unchecked_field('form_pets_cat')
+    _(page).wont_have_unchecked_field('form_pets_dog')
   end
 
-  it "supports table expectations" do
+  it 'supports table expectations' do
     visit('/tables')
-    page.must_have_table('agent_table')
-    page.wont_have_table('not_on_form')
+    _(page).must_have_table('agent_table')
+    _(page).wont_have_table('not_on_form')
+  end
+
+  it 'supports all_of_selectors expectations' do
+    _(page).must_have_all_of_selectors(:css, 'select#form_other_title', 'input#form_last_name')
+  end
+
+  it 'supports none_of_selectors expectations' do
+    _(page).must_have_none_of_selectors(:css, 'input#not_on_page', 'input#also_not_on_page')
   end
 
-  it "supports all_of_selectors expectations" do
-    page.must_have_all_of_selectors(:css, 'select#form_other_title', 'input#form_last_name')
+  it 'supports any_of_selectors expectations' do
+    _(page).must_have_any_of_selectors(:css, 'select#form_other_title', 'input#not_on_page')
   end
 
-  it "supports none_of_selectors expectations" do
-    page.must_have_none_of_selectors(:css, 'input#not_on_page', 'input#also_not_on_page')
+  it 'supports match_selector expectations' do
+    _(find(:field, 'customer_email')).must_match_selector(:field, 'customer_email')
+    _(find(:select, 'form_title')).wont_match_selector(:field, 'customer_email')
   end
 
-  it "supports match_selector expectations" do
-    find(:field, 'customer_email').must_match_selector(:field, 'customer_email')
-    find(:select, 'form_title').wont_match_selector(:field, 'customer_email')
+  it 'supports match_css expectations' do
+    _(find(:select, 'form_title')).must_match_css('select#form_title')
+    _(find(:select, 'form_title')).wont_match_css('select#form_other_title')
   end
 
-  it "supports match_css expectations" do
-    find(:select, 'form_title').must_match_css('select#form_title')
-    find(:select, 'form_title').wont_match_css('select#form_other_title')
+  it 'supports match_xpath expectations' do
+    _(find(:select, 'form_title')).must_match_xpath('.//select[@id="form_title"]')
+    _(find(:select, 'form_title')).wont_match_xpath('.//select[@id="not_on_page"]')
   end
 
-  it "supports match_xpath expectations" do
-    find(:select, 'form_title').must_match_xpath('.//select[@id="form_title"]')
-    find(:select, 'form_title').wont_match_xpath('.//select[@id="not_on_page"]')
+  it 'handles failures' do
+    _(page).must_have_select('non_existing_form_title')
   end
 
-  it "handles failures" do
-    page.must_have_select('non_existing_form_title')
+  it 'supports style expectations' do
+    skip "Rack test doesn't support style" if Capybara.current_driver == :rack_test
+    visit('/with_html')
+    _(find(:css, '#second')).must_have_style('display' => 'inline') # deprecated
+    _(find(:css, '#second')).must_match_style('display' => 'inline')
+  end
+
+  it 'supports ancestor expectations' do
+    option = find(:option, 'Finnish')
+    _(option).must_have_ancestor(:css, '#form_locale')
+  end
+
+  it 'supports sibling expectations' do
+    option = find(:css, '#form_title').find(:option, 'Mrs')
+    _(option).must_have_sibling(:option, 'Mr')
   end
 end
 
@@ -122,14 +149,18 @@ RSpec.describe 'capybara/minitest/spec' do
     Capybara.app = TestApp
   end
 
-  it "should support minitest spec" do
+  after do
+    Capybara.use_default_driver
+  end
+
+  it 'should support minitest spec' do
     output = StringIO.new
     reporter = Minitest::SummaryReporter.new(output)
     reporter.start
     MinitestSpecTest.run reporter, {}
     reporter.report
-    expect(output.string).to include("18 runs, 41 assertions, 1 failures, 0 errors, 0 skips")
-    #Make sure error messages are displayed
-    expect(output.string).to include('expected to find visible select box "non_existing_form_title" that is not disabled but there were no matches')
+    expect(output.string).to include('22 runs, 44 assertions, 1 failures, 0 errors, 1 skips')
+    # Make sure error messages are displayed
+    expect(output.string).to match(/expected to find select box "non_existing_form_title" .*but there were no matches/)
   end
 end

data/spec/per_session_config_spec.rb

@@ -1,24 +1,25 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 require 'capybara/dsl'
 
 RSpec.describe Capybara::SessionConfig do
-  describe "threadsafe" do
-    it "defaults to global session options" do
+  describe 'threadsafe' do
+    it 'defaults to global session options' do
       Capybara.threadsafe = true
       session = Capybara::Session.new(:rack_test, TestApp)
-      [:default_host, :app_host, :save_and_open_page_path,
-       :always_include_port, :run_server, :default_selector, :default_max_wait_time, :ignore_hidden_elements,
-       :automatic_reload, :match, :exact, :raise_server_errors, :visible_text_only, :wait_on_first_by_default,
-       :automatic_label_click, :enable_aria_label,
-       :save_path, :exact_options, :asset_host].each do |m|
-         expect(session.config.public_send(m)).to eq Capybara.public_send(m)
-       end
+      %i[default_host app_host always_include_port run_server
+         default_selector default_max_wait_time ignore_hidden_elements
+         automatic_reload match exact raise_server_errors visible_text_only
+         automatic_label_click enable_aria_label save_path
+         asset_host default_retry_interval].each do |m|
+           expect(session.config.public_send(m)).to eq Capybara.public_send(m)
+         end
     end
 
     it "doesn't change global session when changed" do
       Capybara.threadsafe = true
-      host = "http://my.example.com"
+      host = 'http://my.example.com'
       session = Capybara::Session.new(:rack_test, TestApp) do |config|
         config.default_host = host
         config.automatic_label_click = !config.automatic_label_click
@@ -34,7 +35,7 @@ RSpec.describe Capybara::SessionConfig do
       Capybara.threadsafe = false
       expect do
         Capybara::Session.new(:rack_test, TestApp) { |config| }
-      end.to raise_error "A configuration block is only accepted when Capybara.threadsafe == true"
+      end.to raise_error 'A configuration block is only accepted when Capybara.threadsafe == true'
     end
 
     it "doesn't allow session config when false" do
@@ -48,7 +49,7 @@ RSpec.describe Capybara::SessionConfig do
       end.to raise_error(/Session configuration is only supported when Capybara.threadsafe == true/)
     end
 
-    it "uses the config from the session" do
+    it 'uses the config from the session' do
       Capybara.threadsafe = true
       session = Capybara::Session.new(:rack_test, TestApp) do |config|
         config.default_selector = :link
@@ -64,4 +65,4 @@ RSpec.describe Capybara::SessionConfig do
       expect { Capybara.threadsafe = true }.to raise_error(/Threadsafe setting cannot be changed once a session is created/)
     end
   end
-end
+end