capybara 2.18.0 → 3.0.0

data/spec/selenium_spec_ie.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require "selenium-webdriver"
+require 'shared_selenium_session'
+require 'rspec/shared_spec_matchers'
+
+Capybara.register_driver :selenium_ie do |app|
+  # ::Selenium::WebDriver.logger.level = "debug"
+  Capybara::Selenium::Driver.new(
+    app,
+    browser: :ie,
+    desired_capabilities: ::Selenium::WebDriver::Remote::Capabilities.ie('requireWindowFocus': true)
+  )
+end
+
+module TestSessions
+  SeleniumIE = Capybara::Session.new(:selenium_ie, TestApp)
+end
+
+skipped_tests = %i[response_headers status_code trigger modals hover form_attribute windows]
+
+$stdout.puts `#{Selenium::WebDriver::IE.driver_path} --version` if ENV['CI']
+
+Capybara::SpecHelper.run_specs TestSessions::SeleniumIE, "selenium", capybara_skip: skipped_tests
+
+RSpec.describe "Capybara::Session with Internet Explorer", capybara_skip: skipped_tests do
+  include Capybara::SpecHelper
+  include_examples "Capybara::Session", TestSessions::SeleniumIE, :selenium_ie
+  include_examples Capybara::RSpecMatchers, TestSessions::SeleniumIE, :selenium_ie
+end

data/spec/selenium_spec_marionette.rb

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 require "selenium-webdriver"
 require 'shared_selenium_session'
 require 'rspec/shared_spec_matchers'
 
-browser_options = ::Selenium::WebDriver::Firefox::Options.new()
+browser_options = ::Selenium::WebDriver::Firefox::Options.new
 browser_options.args << '--headless' if ENV['HEADLESS']
 browser_options.add_preference 'dom.file.createInChild', true
 # browser_options.add_option("log", {"level": "trace"})
@@ -14,7 +15,7 @@ Capybara.register_driver :selenium_marionette do |app|
   Capybara::Selenium::Driver.new(
     app,
     browser: :firefox,
-    desired_capabilities: {marionette: true, 'moz:webdriverClick': true},
+    desired_capabilities: { marionette: true, 'moz:webdriverClick': true },
     options: browser_options
     # Get a trace level log from geckodriver
     # :driver_opts => { args: ['-vv'] }
@@ -25,26 +26,22 @@ Capybara.register_driver :selenium_marionette_clear_storage do |app|
   Capybara::Selenium::Driver.new(
     app,
     browser: :firefox,
-    desired_capabilities: {marionette: true},
+    desired_capabilities: { marionette: true },
     clear_local_storage: true,
     clear_session_storage: true,
     options: browser_options
   )
 end
 
-
-
 module TestSessions
   SeleniumMarionette = Capybara::Session.new(:selenium_marionette, TestApp)
 end
 
-skipped_tests = [
-  :response_headers,
-  :status_code,
-  :trigger
-]
+skipped_tests = %i[response_headers status_code trigger]
 skipped_tests << :windows if ENV['TRAVIS'] && ENV['SKIP_WINDOW']
 
+$stdout.puts `#{Selenium::WebDriver::Firefox.driver_path} --version` if ENV['CI']
+
 Capybara::SpecHelper.run_specs TestSessions::SeleniumMarionette, "selenium", capybara_skip: skipped_tests
 
 RSpec.describe "Capybara::Session with firefox" do
@@ -62,7 +59,7 @@ RSpec.describe Capybara::Selenium::Driver do
     it "should reset browser when quit" do
       expect(@driver.browser).to be
       @driver.quit
-      #access instance variable directly so we don't create a new browser instance
+      # access instance variable directly so we don't create a new browser instance
       expect(@driver.instance_variable_get(:@browser)).to be_nil
     end
 
@@ -123,5 +120,24 @@ RSpec.describe Capybara::Selenium::Driver do
       end
     end
   end
-end
 
+  context "#refresh" do
+    def extract_results(session)
+      expect(session).to have_xpath("//pre[@id='results']")
+      YAML.load Nokogiri::HTML(session.body).xpath("//pre[@id='results']").first.inner_html.lstrip
+    end
+
+    it "can repost by accepting confirm" do
+      @session = TestSessions::SeleniumMarionette
+      @session.visit('/form')
+      @session.select('Sweden', from: 'form_region')
+      @session.click_button('awesome')
+      expect do
+        @session.accept_confirm(wait: 0.1) do
+          @session.refresh
+          sleep 2
+        end
+      end.to change { extract_results(@session)['post_count'] }.by(1)
+    end
+  end
+end

data/spec/server_spec.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe Capybara::Server do
-
   it "should spool up a rack server" do
-    @app = proc { |env| [200, {}, ["Hello Server!"]]}
+    @app = proc { |_env| [200, {}, ["Hello Server!"]] }
     @server = Capybara::Server.new(@app).boot
 
     @res = Net::HTTP.start(@server.host, @server.port) { |http| http.get('/') }
@@ -19,8 +19,9 @@ RSpec.describe Capybara::Server do
   end
 
   it "should bind to the specified host" do
+    # TODO: travis with jruby in container mode has an issue with this test
     begin
-      app = proc { |env| [200, {}, ['Hello Server!']] }
+      app = proc { |_env| [200, {}, ['Hello Server!']] }
 
       Capybara.server_host = '127.0.0.1'
       server = Capybara::Server.new(app).boot
@@ -34,12 +35,12 @@ RSpec.describe Capybara::Server do
     ensure
       Capybara.server_host = nil
     end
-  end unless ENV['TRAVIS'] and (RUBY_ENGINE == 'jruby') #TODO travis with jruby in container mode has an issue with this test
+  end unless ENV['TRAVIS'] && (RUBY_ENGINE == 'jruby') or Gem.win_platform?
 
   it "should use specified port" do
     Capybara.server_port = 22789
 
-    @app = proc { |env| [200, {}, ["Hello Server!"]]}
+    @app = proc { |_env| [200, {}, ["Hello Server!"]] }
     @server = Capybara::Server.new(@app).boot
 
     @res = Net::HTTP.start(@server.host, 22789) { |http| http.get('/') }
@@ -49,7 +50,7 @@ RSpec.describe Capybara::Server do
   end
 
   it "should use given port" do
-    @app = proc { |env| [200, {}, ["Hello Server!"]]}
+    @app = proc { |_env| [200, {}, ["Hello Server!"]] }
     @server = Capybara::Server.new(@app, 22790).boot
 
     @res = Net::HTTP.start(@server.host, 22790) { |http| http.get('/') }
@@ -59,8 +60,8 @@ RSpec.describe Capybara::Server do
   end
 
   it "should find an available port" do
-    @app1 = proc { |env| [200, {}, ["Hello Server!"]]}
-    @app2 = proc { |env| [200, {}, ["Hello Second Server!"]]}
+    @app1 = proc { |_env| [200, {}, ["Hello Server!"]] }
+    @app2 = proc { |_env| [200, {}, ["Hello Second Server!"]] }
 
     @server1 = Capybara::Server.new(@app1).boot
     @server2 = Capybara::Server.new(@app2).boot
@@ -83,7 +84,7 @@ RSpec.describe Capybara::Server do
     end
 
     it "should use the existing server if it already running" do
-      @app = proc { |env| [200, {}, ["Hello Server!"]]}
+      @app = proc { |_env| [200, {}, ["Hello Server!"]] }
 
       @server1 = Capybara::Server.new(@app).boot
       @server2 = Capybara::Server.new(@app).boot
@@ -98,27 +99,25 @@ RSpec.describe Capybara::Server do
     end
 
     it "detects and waits for all reused server sessions pending requests" do
-      done = false
+      done = 0
 
       app = proc do |env|
         request = Rack::Request.new(env)
         sleep request.params['wait_time'].to_f
-        done = true
+        done += 1
         [200, {}, ["Hello Server!"]]
       end
 
       server1 = Capybara::Server.new(app).boot
       server2 = Capybara::Server.new(app).boot
 
-      start_request(server1, 0.5)
-      start_request(server2, 1.0)
-
-      expect {
+      expect do
+        start_request(server1, 1.0)
+        start_request(server2, 3.0)
         server1.wait_for_pending_requests
-      }.to change{done}.from(false).to(true)
+      end.to change { done }.from(0).to(2)
       expect(server2.send(:pending_requests?)).to eq(false)
     end
-
   end
 
   context "When Capybara.reuse_server is false" do
@@ -132,7 +131,7 @@ RSpec.describe Capybara::Server do
     end
 
     it "should not reuse an already running server" do
-      @app = proc { |env| [200, {}, ["Hello Server!"]]}
+      @app = proc { |_env| [200, {}, ["Hello Server!"]] }
 
       @server1 = Capybara::Server.new(@app).boot
       @server2 = Capybara::Server.new(@app).boot
@@ -147,48 +146,48 @@ RSpec.describe Capybara::Server do
     end
 
     it "detects and waits for only one sessions pending requests" do
-      done = false
+      done = 0
 
       app = proc do |env|
         request = Rack::Request.new(env)
         sleep request.params['wait_time'].to_f
-        done = true
+        done += 1
         [200, {}, ["Hello Server!"]]
       end
 
       server1 = Capybara::Server.new(app).boot
       server2 = Capybara::Server.new(app).boot
 
-      start_request(server1, 0.5)
-      start_request(server2, 1.0)
-
-      expect {
+      expect do
+        start_request(server1, 1.0)
+        start_request(server2, 3.0)
         server1.wait_for_pending_requests
-      }.to change{done}.from(false).to(true)
+      end.to change { done }.from(0).to(1)
       expect(server2.send(:pending_requests?)).to eq(true)
+      expect do
+        server2.wait_for_pending_requests
+      end.to change { done }.from(1).to(2)
     end
-
   end
 
   it "should raise server errors when the server errors before the timeout" do
     begin
-      Capybara.server do
+      Capybara.register_server :kaboom do
         sleep 0.1
         raise 'kaboom'
       end
+      Capybara.server = :kaboom
 
       expect do
-        Capybara::Server.new(proc {|e|}).boot
+        Capybara::Server.new(proc { |e| }).boot
       end.to raise_error(RuntimeError, 'kaboom')
     ensure
-      # TODO refactor out the defaults so it's reliant on unset state instead of
-      # a one-time call in capybara.rb
-      Capybara.server {|app, port| Capybara.run_default_server(app, port)}
+      Capybara.server = :default
     end
   end
 
   it "is not #responsive? when Net::HTTP raises a SystemCallError" do
-    app = lambda { [200, {}, ['Hello, world']] }
+    app = -> { [200, {}, ['Hello, world']] }
     server = Capybara::Server.new(app)
     expect(Net::HTTP).to receive(:start).and_raise(SystemCallError.allocate)
     expect(server.responsive?).to eq false
@@ -197,7 +196,8 @@ RSpec.describe Capybara::Server do
   def start_request(server, wait_time)
     # Start request, but don't wait for it to finish
     socket = TCPSocket.new(server.host, server.port)
-    socket.write "GET /?wait_time=#{wait_time.to_s} HTTP/1.0\r\n\r\n"
+    socket.write "GET /?wait_time=#{wait_time} HTTP/1.0\r\n\r\n"
+    sleep 0.1
     socket.close
     sleep 0.1
   end

data/spec/session_spec.rb

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe Capybara::Session do
   it "verifies a passed app is a rack app" do
     expect do
-      Capybara::Session.new(:unknown, { random: "hash"})
+      Capybara::Session.new(:unknown, random: "hash")
     end.to raise_error TypeError, "The second parameter to Session::new should be a rack app if passed."
   end
 

data/spec/shared_selenium_session.rb

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 require "selenium-webdriver"
 
 RSpec.shared_examples "Capybara::Session" do |session, mode|
-  let(:session) {session}
+  let(:session) { session }
 
   context 'with selenium driver' do
     before do
@@ -35,7 +36,6 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
         @current_dir = Dir.getwd
         Dir.chdir(File.join(File.dirname(__FILE__), '..'))
         @env = { 'SELENIUM_BROWSER' => @session.driver.options[:browser].to_s }
-        @env['LEGACY_FIREFOX'] = 'TRUE' if mode == :selenium_firefox
       end
 
       after do
@@ -45,22 +45,22 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
       it "should have return code 1 when running selenium_driver_rspec_failure.rb" do
         skip if ENV['HEADLESS']
         system(@env, 'rspec spec/fixtures/selenium_driver_rspec_failure.rb', out: File::NULL, err: File::NULL)
-        expect($?.exitstatus).to eq(1)
+        expect($CHILD_STATUS.exitstatus).to eq(1)
       end
 
       it "should have return code 0 when running selenium_driver_rspec_success.rb" do
         skip if ENV['HEADLESS']
         system(@env, 'rspec spec/fixtures/selenium_driver_rspec_success.rb', out: File::NULL, err: File::NULL)
-        expect($?.exitstatus).to eq(0)
+        expect($CHILD_STATUS.exitstatus).to eq(0)
       end
     end
 
-    describe "#accept_alert" do
+    describe "#accept_alert", requires: [:modals] do
       it "supports a blockless mode" do
         @session.visit('/with_js')
         @session.click_link('Open alert')
         @session.accept_alert
-        expect{@session.driver.browser.switch_to.alert}.to raise_error(@session.driver.send(:modal_error))
+        expect { @session.driver.browser.switch_to.alert }.to raise_error(@session.driver.send(:modal_error))
       end
 
       it "can be called before visiting" do
@@ -84,15 +84,17 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
     context "#fill_in with { :clear => :backspace } fill_option", requires: [:js] do
       it 'should fill in a field, replacing an existing value' do
         @session.visit('/form')
-        @session.fill_in('form_first_name', with: 'Harry',
-                          fill_options: { clear: :backspace} )
+        @session.fill_in('form_first_name',
+                         with: 'Harry',
+                         fill_options: { clear: :backspace })
         expect(@session.find(:fillable_field, 'form_first_name').value).to eq('Harry')
       end
 
       it 'should only trigger onchange once' do
         @session.visit('/with_js')
-        @session.fill_in('with_change_event', with: 'some value',
-                         fill_options: { :clear => :backspace })
+        @session.fill_in('with_change_event',
+                         with: 'some value',
+                         fill_options: { clear: :backspace })
         # click outside the field to trigger the change event
         @session.find(:css, 'body').click
         expect(@session.find(:css, '.change_event_triggered', match: :one)).to have_text 'some value'
@@ -100,8 +102,9 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
 
       it 'should trigger change when clearing field' do
         @session.visit('/with_js')
-        @session.fill_in('with_change_event', with: '',
-                         fill_options: { :clear => :backspace })
+        @session.fill_in('with_change_event',
+                         with: '',
+                         fill_options: { clear: :backspace })
         # click outside the field to trigger the change event
         @session.find(:css, 'body').click
         expect(@session).to have_selector(:css, '.change_event_triggered', match: :one)
@@ -109,8 +112,9 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
 
       it 'should trigger input event field_value.length times' do
         @session.visit('/with_js')
-        @session.fill_in('with_change_event', with: '',
-                         fill_options: { :clear => :backspace })
+        @session.fill_in('with_change_event',
+                         with: '',
+                         fill_options: { clear: :backspace })
         # click outside the field to trigger the change event
         @session.find(:css, 'body').click
         expect(@session).to have_xpath('//p[@class="input_event_triggered"]', count: 13)
@@ -120,8 +124,9 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
     context "#fill_in with { clear: :none } fill_options" do
       it 'should append to content in a field' do
         @session.visit('/form')
-        @session.fill_in('form_first_name', with: 'Harry',
-                          fill_options: { clear: :none} )
+        @session.fill_in('form_first_name',
+                         with: 'Harry',
+                         fill_options: { clear: :none })
         expect(@session.find(:fillable_field, 'form_first_name').value).to eq('JohnHarry')
       end
     end
@@ -129,10 +134,11 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
     context "#fill_in with { clear: Array } fill_options" do
       it 'should pass the array through to the element' do
         pending "selenium-webdriver/geckodriver doesn't support complex sets of characters" if marionette?(@session)
-        #this is mainly for use with [[:control, 'a'], :backspace] - however since that is platform dependant I'm testing with something less useful
+        # this is mainly for use with [[:control, 'a'], :backspace] - however since that is platform dependant I'm testing with something less useful
         @session.visit('/form')
-        @session.fill_in('form_first_name', with: 'Harry',
-                          fill_options: { clear: [[:shift, 'abc'], :backspace] } )
+        @session.fill_in('form_first_name',
+                         with: 'Harry',
+                         fill_options: { clear: [[:shift, 'abc'], :backspace] })
         expect(@session.find(:fillable_field, 'form_first_name').value).to eq('JohnABHarry')
       end
     end
@@ -149,7 +155,7 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
     describe "all with disappearing elements" do
       it "ignores stale elements in results" do
         @session.visit('/path')
-        elements = @session.all(:link) { |node| raise Selenium::WebDriver::Error::StaleElementReferenceError }
+        elements = @session.all(:link) { |_node| raise Selenium::WebDriver::Error::StaleElementReferenceError }
         expect(elements.size).to eq 0
       end
     end
@@ -173,12 +179,12 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
       it "can return hashes with elements" do
         @session.visit('/form')
         result = @session.evaluate_script("{ a: document.getElementById('form_title'), b: {c: document.querySelectorAll('#form_city option')}}")
-        expect(result).to eq({
+        expect(result).to eq(
           'a' => @session.find(:id, 'form_title'),
           'b' => {
             'c' => @session.find(:css, '#form_city').all(:css, 'option').to_a
           }
-        })
+        )
       end
 
       describe "#evaluate_async_script" do
@@ -211,5 +217,13 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
         expect(@session).to have_current_path('/')
       end
     end
+
+    context "Windows" do
+      it "can't close the primary window" do
+        expect do
+          @session.current_window.close
+        end.to raise_error(ArgumentError, 'Not allowed to close the primary window')
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,14 +1,11 @@
 # frozen_string_literal: true
+
 require 'rspec/expectations'
 require "capybara/spec/spec_helper"
-require "pry"
+require 'webdrivers' if ENV['CI']
 
 RSpec.configure do |config|
   Capybara::SpecHelper.configure(config)
-  config.filter_run_including focus_: true unless ENV['TRAVIS']
+  config.filter_run_including focus_: true unless ENV['CI']
   config.run_all_when_everything_filtered = true
 end
-
-def rspec2?
-  !defined?(::RSpec::Expectations::Version) || (Gem::Version.new(RSpec::Expectations::Version::STRING) < Gem::Version.new('3.0'))
-end