capybara 2.18.0 → 3.0.0.rc1

data/lib/capybara/spec/session/save_page_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#save_page' do
   let(:alternative_path) { File.join(Dir.pwd, "save_and_open_page_tmp") }
   before do
@@ -6,7 +7,6 @@ Capybara::SpecHelper.spec '#save_page' do
   end
 
   after do
-    Capybara.save_and_open_page_path = nil
     Capybara.save_path = nil
     Dir.glob("capybara-*.html").each do |file|
       FileUtils.rm(file)
@@ -104,20 +104,4 @@ Capybara::SpecHelper.spec '#save_page' do
       expect(result).to include("Bar")
     end
   end
-
-  context "with deprecated save_and_open_page_path" do
-    it "can store files in a specified directory" do
-      Capybara.save_and_open_page_path = alternative_path
-      @session.save_page
-      path = Dir.glob(alternative_path + "/capybara-*.html").first
-      expect(File.read(path)).to include("Another World")
-    end
-
-    it "returns an absolute path in given directory" do
-      Capybara.save_and_open_page_path = alternative_path
-      result = @session.save_page
-      path = File.expand_path(Dir.glob(alternative_path + "/capybara-*.html").first, alternative_path)
-      expect(result).to eq(path)
-    end
-  end
 end

data/lib/capybara/spec/session/save_screenshot_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#save_screenshot', requires: [:screenshot] do
   let(:alternative_path) { File.join(Dir.pwd, "save_screenshot_tmp") }
   before do
@@ -6,7 +7,6 @@ Capybara::SpecHelper.spec '#save_screenshot', requires: [:screenshot] do
   end
 
   after do
-    Capybara.save_and_open_page_path = nil
     Capybara.save_path = nil
     FileUtils.rm_rf alternative_path
   end

data/lib/capybara/spec/session/select_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec "#select" do
   before do
     @session.visit('/form')
@@ -13,25 +14,24 @@ Capybara::SpecHelper.spec "#select" do
     expect(@session.find_field('Title').value).to eq('Miss')
   end
 
-  it "should allow selecting options where there are inexact matches" do
+  it "should allow selecting exact options where there are inexact matches", :exact_false do
     @session.select("Mr", from: 'Title')
     expect(@session.find_field('Title').value).to eq('Mr')
   end
 
-  it "should allow selecting options where they are the only inexact match" do
+  it "should allow selecting options where they are the only inexact match", :exact_false do
     @session.select("Mis", from: 'Title')
     expect(@session.find_field('Title').value).to eq('Miss')
   end
 
-  it "should not allow selecting options where they are the only inexact match if `Capybara.exact_options = true`" do
-    expect_any_instance_of(Kernel).to receive(:warn).with(/^DEPRECATED:/)
-    Capybara.exact_options = true
+  it "should not allow selecting options where they are the only inexact match if `exact: true` is specified" do
+    sel = @session.find(:select, 'Title')
     expect do
-      @session.select("Mis", from: 'Title')
+      sel.select("Mis", exact: true)
     end.to raise_error(Capybara::ElementNotFound)
   end
 
-  it "should not allow selecting an option if the match is ambiguous" do
+  it "should not allow selecting an option if the match is ambiguous", :exact_false do
     expect do
       @session.select("M", from: 'Title')
     end.to raise_error(Capybara::Ambiguous)
@@ -80,7 +80,7 @@ Capybara::SpecHelper.spec "#select" do
   end
 
   it "casts to string" do
-    @session.select(:"Miss", from: :'Title')
+    @session.select(:Miss, from: :Title)
     expect(@session.find_field('Title').value).to eq('Miss')
   end
 
@@ -124,32 +124,32 @@ Capybara::SpecHelper.spec "#select" do
 
   context "with multiple select" do
     it "should return an empty value" do
-      expect(@session.find_field('Language').value).to eq([])
+      expect(@session.find_field('Languages').value).to eq([])
     end
 
     it "should return value of the selected options" do
-      @session.select("Ruby",       from: 'Language')
-      @session.select("Javascript", from: 'Language')
-      expect(@session.find_field('Language').value).to include('Ruby', 'Javascript')
+      @session.select("Ruby",       from: 'Languages')
+      @session.select("Javascript", from: 'Languages')
+      expect(@session.find_field('Languages').value).to include('Ruby', 'Javascript')
     end
 
     it "should select one option" do
-      @session.select("Ruby", from: 'Language')
+      @session.select("Ruby", from: 'Languages')
       @session.click_button('awesome')
       expect(extract_results(@session)['languages']).to eq(['Ruby'])
     end
 
     it "should select multiple options" do
-      @session.select("Ruby",       from: 'Language')
-      @session.select("Javascript", from: 'Language')
+      @session.select("Ruby",       from: 'Languages')
+      @session.select("Javascript", from: 'Languages')
       @session.click_button('awesome')
       expect(extract_results(@session)['languages']).to include('Ruby', 'Javascript')
     end
 
     it "should remain selected if already selected" do
-      @session.select("Ruby",       from: 'Language')
-      @session.select("Javascript", from: 'Language')
-      @session.select("Ruby",       from: 'Language')
+      @session.select("Ruby",       from: 'Languages')
+      @session.select("Javascript", from: 'Languages')
+      @session.select("Ruby",       from: 'Languages')
       @session.click_button('awesome')
       expect(extract_results(@session)['languages']).to include('Ruby', 'Javascript')
     end
@@ -162,7 +162,7 @@ Capybara::SpecHelper.spec "#select" do
   context "with :exact option" do
     context "when `false`" do
       it "can match select box approximately" do
-        @session.select("Finish", from: "Loc", exact:  false)
+        @session.select("Finish", from: "Loc", exact: false)
         @session.click_button("awesome")
         expect(extract_results(@session)["locale"]).to eq("fi")
       end
@@ -195,7 +195,7 @@ Capybara::SpecHelper.spec "#select" do
 
       it "can match option approximately when :from not given" do
         expect do
-          @session.select("made-up language", exact:  true)
+          @session.select("made-up language", exact: true)
         end.to raise_error(Capybara::ElementNotFound)
       end
     end

data/lib/capybara/spec/session/selectors_spec.rb

@@ -59,7 +59,7 @@ Capybara::SpecHelper.spec Capybara::Selector do
     it "can find by class" do
       expect(@session.find(:field, class: 'confusion-checkbox')['id']).to eq 'confusion_checkbox'
       expect(@session).to have_selector(:field, class: 'confusion', count: 3)
-      expect(@session.find(:field, class: ['confusion','confusion-textarea'])['id']).to eq 'confusion_textarea'
+      expect(@session.find(:field, class: ['confusion', 'confusion-textarea'])['id']).to eq 'confusion_textarea'
     end
   end
-end
+end

data/lib/capybara/spec/session/sibling_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#sibling' do
   before do
     @session.visit('/with_html')
@@ -42,7 +43,6 @@ Capybara::SpecHelper.spec '#sibling' do
     end
   end
 
-
   it "should raise ElementNotFound with a useful default message if nothing was found" do
     el = @session.find(:css, '#child')
     expect do

data/lib/capybara/spec/session/text_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#text' do
   it "should print the text of the page" do
     @session.visit('/with_simple_html')

data/lib/capybara/spec/session/title_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
-Capybara::SpecHelper.spec '#title' do
 
+Capybara::SpecHelper.spec '#title' do
   it "should get the title of the page" do
     @session.visit('/with_title')
     expect(@session.title).to eq('Test Title')

data/lib/capybara/spec/session/uncheck_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec "#uncheck" do
   before do
     @session.visit('/form')
@@ -19,7 +20,7 @@ Capybara::SpecHelper.spec "#uncheck" do
   end
 
   it "casts to string" do
-    @session.uncheck(:"form_pets_hamster")
+    @session.uncheck(:form_pets_hamster)
     @session.click_button('awesome')
     expect(extract_results(@session)['pets']).to include('dog')
     expect(extract_results(@session)['pets']).not_to include('hamster')
@@ -69,11 +70,11 @@ Capybara::SpecHelper.spec "#uncheck" do
       end
 
       it "should raise original error when no label available" do
-        expect { @session.uncheck('form_cars_ariel') }.to raise_error(Capybara::ElementNotFound, 'Unable to find visible checkbox "form_cars_ariel" that is not disabled')
+        expect { @session.uncheck('form_cars_porsche') }.to raise_error(Capybara::ElementNotFound, 'Unable to find visible checkbox "form_cars_porsche" that is not disabled')
       end
 
       it "should raise error if not allowed to click label" do
-        expect{@session.uncheck('form_cars_jaguar', allow_label_click: false)}.to raise_error(Capybara::ElementNotFound, 'Unable to find visible checkbox "form_cars_jaguar" that is not disabled')
+        expect { @session.uncheck('form_cars_jaguar', allow_label_click: false) }.to raise_error(Capybara::ElementNotFound, 'Unable to find visible checkbox "form_cars_jaguar" that is not disabled')
       end
     end
   end

data/lib/capybara/spec/session/unselect_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec "#unselect" do
   before do
     @session.visit('/form')
@@ -40,7 +41,7 @@ Capybara::SpecHelper.spec "#unselect" do
     end
 
     it "casts to string" do
-      @session.unselect(:"Briefs", from: :'Underwear')
+      @session.unselect(:Briefs, from: :Underwear)
       @session.click_button('awesome')
       expect(extract_results(@session)['underwear']).to include('Commando', 'Boxerbriefs')
       expect(extract_results(@session)['underwear']).not_to include('Briefs')
@@ -74,19 +75,19 @@ Capybara::SpecHelper.spec "#unselect" do
   context "with :exact option" do
     context "when `false`" do
       it "can match select box approximately" do
-        @session.unselect("Boxerbriefs", from: "Under", exact:  false)
+        @session.unselect("Boxerbriefs", from: "Under", exact: false)
         @session.click_button("awesome")
         expect(extract_results(@session)["underwear"]).not_to include("Boxerbriefs")
       end
 
       it "can match option approximately" do
-        @session.unselect("Boxerbr", from: "Underwear", exact:  false)
+        @session.unselect("Boxerbr", from: "Underwear", exact: false)
         @session.click_button("awesome")
         expect(extract_results(@session)["underwear"]).not_to include("Boxerbriefs")
       end
 
       it "can match option approximately when :from not given" do
-        @session.unselect("Boxerbr", exact:  false)
+        @session.unselect("Boxerbr", exact: false)
         @session.click_button("awesome")
         expect(extract_results(@session)["underwear"]).not_to include("Boxerbriefs")
       end
@@ -107,7 +108,7 @@ Capybara::SpecHelper.spec "#unselect" do
 
       it "can match option approximately when :from not given" do
         expect do
-          @session.unselect("Boxerbr", exact:  true)
+          @session.unselect("Boxerbr", exact: true)
         end.to raise_error(Capybara::ElementNotFound)
       end
     end

data/lib/capybara/spec/session/visit_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#visit' do
   it "should fetch a response from the driver with a relative url" do
     @session.visit('/')
@@ -27,6 +28,14 @@ Capybara::SpecHelper.spec '#visit' do
     expect(@session).to have_content('Hello world!')
   end
 
+  it "should fetch a response when sequentially visiting same destination with a target" do
+    skip "Chrome/chromedriver has an issue visiting URL with target after visiting same URL without target" if chrome_lt?(65.0, @session)
+    @session.visit('/form')
+    expect(@session).to have_css('#form_title')
+    @session.visit('/form#form_title')
+    expect(@session).to have_css('#form_title')
+  end
+
   it "raises any errors caught inside the server", requires: [:server] do
     quietly { @session.visit("/error") }
     expect do
@@ -40,7 +49,6 @@ Capybara::SpecHelper.spec '#visit' do
   end
 
   context "when Capybara.always_include_port is true" do
-
     let(:root_uri) do
       @session.visit('/')
       URI.parse(@session.current_url)
@@ -114,7 +122,6 @@ Capybara::SpecHelper.spec '#visit' do
     end
   end
 
-
   context "without a server", requires: [:server] do
     it "should respect `app_host`" do
       serverless_session = Capybara::Session.new(@session.mode, nil)
@@ -188,5 +195,4 @@ Capybara::SpecHelper.spec '#visit' do
     @session.visit('/get_cookie')
     expect(@session).to have_content('root cookie')
   end
-
 end

data/lib/capybara/spec/session/window/become_closed_spec.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
-Capybara::SpecHelper.spec '#become_closed', requires: [:windows, :js] do
+
+Capybara::SpecHelper.spec '#become_closed', requires: %i[windows js] do
   before(:each) do
     @window = @session.current_window
     @session.visit('/with_windows')

data/lib/capybara/spec/session/window/current_window_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#current_window', requires: [:windows] do
   before(:each) do
     @window = @session.current_window

data/lib/capybara/spec/session/window/open_new_window_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#open_new_window', requires: [:windows] do
   before(:each) do
     @window = @session.current_window

data/lib/capybara/spec/session/window/switch_to_window_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
   before(:each) do
     @window = @session.current_window
@@ -121,7 +122,7 @@ Capybara::SpecHelper.spec '#switch_to_window', requires: [:windows] do
   it "should wait for window to appear" do
     @session.find(:css, '#openWindowWithTimeout').click
     expect do
-      @session.switch_to_window(wait: 5) { @session.title == 'Title of the first popup'}
+      @session.switch_to_window(wait: 5) { @session.title == 'Title of the first popup' }
     end.not_to raise_error
   end
 end

data/lib/capybara/spec/session/window/window_opened_by_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
   before(:each) do
     @window = @session.current_window
@@ -20,7 +21,7 @@ Capybara::SpecHelper.spec '#window_opened_by', requires: [:windows] do
     it 'should raise error if value of :wait is less than timeout' do
       # So large value is used as `driver.window_handles` takes up to 800 ms on Travis
       Capybara.using_wait_time 2 do
-        button=@session.find(:css, '#openWindowWithLongerTimeout')
+        button = @session.find(:css, '#openWindowWithLongerTimeout')
         expect do
           @session.window_opened_by(wait: 0.3) do
             button.click

data/lib/capybara/spec/session/window/window_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
   before(:each) do
     @window = @session.current_window
@@ -90,7 +91,7 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
       @session.evaluate_script("[window.outerWidth || window.innerWidth, window.outerHeight || window.innerHeight]")
     end
 
-    it 'should return size of whole window', requires: [:windows, :js] do
+    it 'should return size of whole window', requires: %i[windows js] do
       expect(@session.current_window.size).to eq win_size
     end
 
@@ -108,15 +109,14 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
   end
 
   describe '#resize_to' do
-    it 'should be able to resize window', requires: [:windows, :js] do
+    it 'should be able to resize window', requires: %i[windows js] do
       width, height = @session.current_window.size
-      @session.current_window.resize_to(width-100, height-100)
+      @session.current_window.resize_to(width - 100, height - 100)
       sleep 1
-      expect(@session.current_window.size).to eq([width-100, height-100])
+      expect(@session.current_window.size).to eq([width - 100, height - 100])
     end
 
-    it 'should stay on current window if invoked not for current window', requires: [:windows, :js] do
-
+    it 'should stay on current window if invoked not for current window', requires: %i[windows js] do
       @other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
@@ -125,35 +125,35 @@ Capybara::SpecHelper.spec Capybara::Window, requires: [:windows] do
 
       # #size returns values larger than availWidth, availHeight with Chromedriver
       @session.within_window(@other_window) do
-        expect(@session.current_window.size).to eq([400,300])
+        expect(@session.current_window.size).to eq([400, 300])
         # expect(@session.evaluate_script("[window.outerWidth, window.outerHeight]")).to eq([400,300])
       end
     end
   end
 
   describe '#maximize' do
-    it 'should be able to maximize window', requires: [:windows, :js] do
+    it 'should be able to maximize window', requires: %i[windows js] do
       start_width, start_height = 400, 300
       @session.current_window.resize_to(start_width, start_height)
       sleep 0.5
 
       @session.current_window.maximize
-      sleep 0.5  # The timing on maximize is finicky on Travis -- wait a bit for maximize to occur
+      sleep 0.5 # The timing on maximize is finicky on Travis -- wait a bit for maximize to occur
 
       max_width, max_height = @session.current_window.size
 
-      #maximize behavior is window manage dependant, so just make sure it increases in size
+      # maximize behavior is window manage dependant, so just make sure it increases in size
       expect(max_width).to be > start_width
       expect(max_height).to be > start_height
     end
 
-    it 'should stay on current window if invoked not for current window', requires: [:windows, :js] do
+    it 'should stay on current window if invoked not for current window', requires: %i[windows js] do
       cur_window_size = @session.current_window.size
       @other_window = @session.window_opened_by do
         @session.find(:css, '#openWindow').click
       end
 
-      @other_window.resize_to(400,300)
+      @other_window.resize_to(400, 300)
       sleep 0.5
       @other_window.maximize
       sleep 0.5 # The timing on maximize is finicky on Travis -- wait a bit for maximize to occur

data/lib/capybara/spec/session/window/windows_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#windows', requires: [:windows] do
   before(:each) do
     @window = @session.current_window
@@ -25,8 +26,6 @@ Capybara::SpecHelper.spec '#windows', requires: [:windows] do
     titles = @session.windows.map do |window|
       @session.within_window(window) { @session.title }
     end
-    expect(titles).to match_array([
-      'With Windows', 'Title of the first popup', 'Title of popup two'
-    ])
+    expect(titles).to match_array(['With Windows', 'Title of the first popup', 'Title of popup two'])
   end
 end