RubyGems - capybara - Versions diffs - 2.15.1 → 3.35.3 - Mend

capybara 2.15.1 → 3.35.3

Files changed (298) hide show

checksums.yaml +5 -5
data/.yardopts +1 -1
data/History.md +871 -9
data/License.txt +1 -1
data/README.md +99 -75
data/lib/capybara/config.rb +20 -59
data/lib/capybara/cucumber.rb +2 -3
data/lib/capybara/driver/base.rb +35 -18
data/lib/capybara/driver/node.rb +35 -9
data/lib/capybara/dsl.rb +15 -6
data/lib/capybara/helpers.rb +72 -28
data/lib/capybara/minitest/spec.rb +173 -81
data/lib/capybara/minitest.rb +220 -111
data/lib/capybara/node/actions.rb +270 -172
data/lib/capybara/node/base.rb +41 -34
data/lib/capybara/node/document.rb +15 -3
data/lib/capybara/node/document_matchers.rb +19 -21
data/lib/capybara/node/element.rb +353 -137
data/lib/capybara/node/finders.rb +144 -138
data/lib/capybara/node/matchers.rb +369 -209
data/lib/capybara/node/simple.rb +55 -26
data/lib/capybara/queries/ancestor_query.rb +11 -9
data/lib/capybara/queries/base_query.rb +39 -28
data/lib/capybara/queries/current_path_query.rb +22 -25
data/lib/capybara/queries/match_query.rb +14 -7
data/lib/capybara/queries/selector_query.rb +633 -145
data/lib/capybara/queries/sibling_query.rb +10 -9
data/lib/capybara/queries/style_query.rb +45 -0
data/lib/capybara/queries/text_query.rb +56 -38
data/lib/capybara/queries/title_query.rb +8 -11
data/lib/capybara/rack_test/browser.rb +57 -41
data/lib/capybara/rack_test/css_handlers.rb +6 -4
data/lib/capybara/rack_test/driver.rb +18 -13
data/lib/capybara/rack_test/errors.rb +6 -0
data/lib/capybara/rack_test/form.rb +73 -58
data/lib/capybara/rack_test/node.rb +182 -78
data/lib/capybara/rails.rb +3 -7
data/lib/capybara/registration_container.rb +44 -0
data/lib/capybara/registrations/drivers.rb +42 -0
data/lib/capybara/registrations/patches/puma_ssl.rb +29 -0
data/lib/capybara/registrations/servers.rb +45 -0
data/lib/capybara/result.rb +96 -62
data/lib/capybara/rspec/features.rb +17 -50
data/lib/capybara/rspec/matcher_proxies.rb +51 -14
data/lib/capybara/rspec/matchers/base.rb +111 -0
data/lib/capybara/rspec/matchers/become_closed.rb +33 -0
data/lib/capybara/rspec/matchers/compound.rb +88 -0
data/lib/capybara/rspec/matchers/count_sugar.rb +37 -0
data/lib/capybara/rspec/matchers/have_ancestor.rb +28 -0
data/lib/capybara/rspec/matchers/have_current_path.rb +29 -0
data/lib/capybara/rspec/matchers/have_selector.rb +77 -0
data/lib/capybara/rspec/matchers/have_sibling.rb +27 -0
data/lib/capybara/rspec/matchers/have_text.rb +33 -0
data/lib/capybara/rspec/matchers/have_title.rb +29 -0
data/lib/capybara/rspec/matchers/match_selector.rb +27 -0
data/lib/capybara/rspec/matchers/match_style.rb +43 -0
data/lib/capybara/rspec/matchers/spatial_sugar.rb +39 -0
data/lib/capybara/rspec/matchers.rb +144 -264
data/lib/capybara/rspec.rb +7 -11
data/lib/capybara/selector/builders/css_builder.rb +84 -0
data/lib/capybara/selector/builders/xpath_builder.rb +71 -0
data/lib/capybara/selector/css.rb +89 -17
data/lib/capybara/selector/definition/button.rb +63 -0
data/lib/capybara/selector/definition/checkbox.rb +26 -0
data/lib/capybara/selector/definition/css.rb +10 -0
data/lib/capybara/selector/definition/datalist_input.rb +35 -0
data/lib/capybara/selector/definition/datalist_option.rb +25 -0
data/lib/capybara/selector/definition/element.rb +28 -0
data/lib/capybara/selector/definition/field.rb +40 -0
data/lib/capybara/selector/definition/fieldset.rb +14 -0
data/lib/capybara/selector/definition/file_field.rb +13 -0
data/lib/capybara/selector/definition/fillable_field.rb +33 -0
data/lib/capybara/selector/definition/frame.rb +17 -0
data/lib/capybara/selector/definition/id.rb +6 -0
data/lib/capybara/selector/definition/label.rb +62 -0
data/lib/capybara/selector/definition/link.rb +54 -0
data/lib/capybara/selector/definition/link_or_button.rb +16 -0
data/lib/capybara/selector/definition/option.rb +27 -0
data/lib/capybara/selector/definition/radio_button.rb +27 -0
data/lib/capybara/selector/definition/select.rb +81 -0
data/lib/capybara/selector/definition/table.rb +109 -0
data/lib/capybara/selector/definition/table_row.rb +21 -0
data/lib/capybara/selector/definition/xpath.rb +5 -0
data/lib/capybara/selector/definition.rb +278 -0
data/lib/capybara/selector/filter.rb +2 -17
data/lib/capybara/selector/filter_set.rb +83 -33
data/lib/capybara/selector/filters/base.rb +50 -6
data/lib/capybara/selector/filters/expression_filter.rb +8 -26
data/lib/capybara/selector/filters/locator_filter.rb +29 -0
data/lib/capybara/selector/filters/node_filter.rb +16 -12
data/lib/capybara/selector/regexp_disassembler.rb +214 -0
data/lib/capybara/selector/selector.rb +89 -210
data/lib/capybara/selector/xpath_extensions.rb +17 -0
data/lib/capybara/selector.rb +226 -526
data/lib/capybara/selenium/atoms/getAttribute.min.js +1 -0
data/lib/capybara/selenium/atoms/isDisplayed.min.js +1 -0
data/lib/capybara/selenium/atoms/src/getAttribute.js +161 -0
data/lib/capybara/selenium/atoms/src/isDisplayed.js +454 -0
data/lib/capybara/selenium/driver.rb +334 -277
data/lib/capybara/selenium/driver_specializations/chrome_driver.rb +117 -0
data/lib/capybara/selenium/driver_specializations/edge_driver.rb +124 -0
data/lib/capybara/selenium/driver_specializations/firefox_driver.rb +89 -0
data/lib/capybara/selenium/driver_specializations/internet_explorer_driver.rb +26 -0
data/lib/capybara/selenium/driver_specializations/safari_driver.rb +24 -0
data/lib/capybara/selenium/extensions/file_input_click_emulation.rb +34 -0
data/lib/capybara/selenium/extensions/find.rb +110 -0
data/lib/capybara/selenium/extensions/html5_drag.rb +228 -0
data/lib/capybara/selenium/extensions/modifier_keys_stack.rb +28 -0
data/lib/capybara/selenium/extensions/scroll.rb +76 -0
data/lib/capybara/selenium/logger_suppressor.rb +40 -0
data/lib/capybara/selenium/node.rb +506 -124
data/lib/capybara/selenium/nodes/chrome_node.rb +137 -0
data/lib/capybara/selenium/nodes/edge_node.rb +104 -0
data/lib/capybara/selenium/nodes/firefox_node.rb +136 -0
data/lib/capybara/selenium/nodes/ie_node.rb +22 -0
data/lib/capybara/selenium/nodes/safari_node.rb +118 -0
data/lib/capybara/selenium/patches/action_pauser.rb +26 -0
data/lib/capybara/selenium/patches/atoms.rb +18 -0
data/lib/capybara/selenium/patches/is_displayed.rb +16 -0
data/lib/capybara/selenium/patches/logs.rb +45 -0
data/lib/capybara/selenium/patches/pause_duration_fix.rb +9 -0
data/lib/capybara/selenium/patches/persistent_client.rb +20 -0
data/lib/capybara/server/animation_disabler.rb +63 -0
data/lib/capybara/server/checker.rb +44 -0
data/lib/capybara/server/middleware.rb +71 -0
data/lib/capybara/server.rb +59 -67
data/lib/capybara/session/config.rb +79 -59
data/lib/capybara/session/matchers.rb +41 -25
data/lib/capybara/session.rb +360 -356
data/lib/capybara/spec/public/jquery.js +5 -5
data/lib/capybara/spec/public/offset.js +6 -0
data/lib/capybara/spec/public/test.js +159 -13
data/lib/capybara/spec/session/accept_alert_spec.rb +12 -11
data/lib/capybara/spec/session/accept_confirm_spec.rb +6 -5
data/lib/capybara/spec/session/accept_prompt_spec.rb +34 -6
data/lib/capybara/spec/session/all_spec.rb +163 -55
data/lib/capybara/spec/session/ancestor_spec.rb +27 -24
data/lib/capybara/spec/session/assert_all_of_selectors_spec.rb +68 -38
data/lib/capybara/spec/session/assert_current_path_spec.rb +75 -0
data/lib/capybara/spec/session/assert_selector_spec.rb +143 -0
data/lib/capybara/spec/session/assert_style_spec.rb +26 -0
data/lib/capybara/spec/session/{assert_text.rb → assert_text_spec.rb} +91 -59
data/lib/capybara/spec/session/{assert_title.rb → assert_title_spec.rb} +22 -12
data/lib/capybara/spec/session/attach_file_spec.rb +138 -69
data/lib/capybara/spec/session/body_spec.rb +12 -13
data/lib/capybara/spec/session/check_spec.rb +107 -55
data/lib/capybara/spec/session/choose_spec.rb +58 -31
data/lib/capybara/spec/session/click_button_spec.rb +231 -173
data/lib/capybara/spec/session/click_link_or_button_spec.rb +55 -35
data/lib/capybara/spec/session/click_link_spec.rb +82 -58
data/lib/capybara/spec/session/current_scope_spec.rb +11 -10
data/lib/capybara/spec/session/current_url_spec.rb +57 -39
data/lib/capybara/spec/session/dismiss_confirm_spec.rb +4 -4
data/lib/capybara/spec/session/dismiss_prompt_spec.rb +3 -2
data/lib/capybara/spec/session/element/{assert_match_selector.rb → assert_match_selector_spec.rb} +11 -9
data/lib/capybara/spec/session/element/match_css_spec.rb +18 -10
data/lib/capybara/spec/session/element/match_xpath_spec.rb +9 -7
data/lib/capybara/spec/session/element/matches_selector_spec.rb +71 -57
data/lib/capybara/spec/session/evaluate_async_script_spec.rb +23 -0
data/lib/capybara/spec/session/evaluate_script_spec.rb +30 -9
data/lib/capybara/spec/session/execute_script_spec.rb +10 -8
data/lib/capybara/spec/session/fill_in_spec.rb +128 -43
data/lib/capybara/spec/session/find_button_spec.rb +25 -24
data/lib/capybara/spec/session/find_by_id_spec.rb +10 -9
data/lib/capybara/spec/session/find_field_spec.rb +37 -41
data/lib/capybara/spec/session/find_link_spec.rb +36 -17
data/lib/capybara/spec/session/find_spec.rb +245 -144
data/lib/capybara/spec/session/first_spec.rb +79 -51
data/lib/capybara/spec/session/frame/frame_title_spec.rb +23 -0
data/lib/capybara/spec/session/frame/frame_url_spec.rb +23 -0
data/lib/capybara/spec/session/frame/switch_to_frame_spec.rb +33 -20
data/lib/capybara/spec/session/frame/within_frame_spec.rb +50 -32
data/lib/capybara/spec/session/go_back_spec.rb +2 -1
data/lib/capybara/spec/session/go_forward_spec.rb +2 -1
data/lib/capybara/spec/session/has_all_selectors_spec.rb +69 -0
data/lib/capybara/spec/session/has_ancestor_spec.rb +46 -0
data/lib/capybara/spec/session/has_any_selectors_spec.rb +25 -0
data/lib/capybara/spec/session/has_button_spec.rb +70 -13
data/lib/capybara/spec/session/has_css_spec.rb +272 -137
data/lib/capybara/spec/session/has_current_path_spec.rb +87 -45
data/lib/capybara/spec/session/has_field_spec.rb +115 -59
data/lib/capybara/spec/session/has_link_spec.rb +10 -9
data/lib/capybara/spec/session/has_none_selectors_spec.rb +78 -0
data/lib/capybara/spec/session/has_select_spec.rb +103 -74
data/lib/capybara/spec/session/has_selector_spec.rb +105 -71
data/lib/capybara/spec/session/has_sibling_spec.rb +50 -0
data/lib/capybara/spec/session/has_table_spec.rb +172 -5
data/lib/capybara/spec/session/has_text_spec.rb +113 -61
data/lib/capybara/spec/session/has_title_spec.rb +20 -14
data/lib/capybara/spec/session/has_xpath_spec.rb +57 -38
data/lib/capybara/spec/session/{headers.rb → headers_spec.rb} +3 -2
data/lib/capybara/spec/session/html_spec.rb +14 -6
data/lib/capybara/spec/session/matches_style_spec.rb +35 -0
data/lib/capybara/spec/session/node_spec.rb +950 -152
data/lib/capybara/spec/session/node_wrapper_spec.rb +39 -0
data/lib/capybara/spec/session/refresh_spec.rb +12 -6
data/lib/capybara/spec/session/reset_session_spec.rb +69 -35
data/lib/capybara/spec/session/{response_code.rb → response_code_spec.rb} +2 -1
data/lib/capybara/spec/session/save_and_open_page_spec.rb +3 -2
data/lib/capybara/spec/session/save_and_open_screenshot_spec.rb +8 -12
data/lib/capybara/spec/session/save_page_spec.rb +42 -55
data/lib/capybara/spec/session/save_screenshot_spec.rb +16 -14
data/lib/capybara/spec/session/screenshot_spec.rb +2 -2
data/lib/capybara/spec/session/scroll_spec.rb +117 -0
data/lib/capybara/spec/session/select_spec.rb +107 -80
data/lib/capybara/spec/session/selectors_spec.rb +52 -19
data/lib/capybara/spec/session/sibling_spec.rb +10 -10
data/lib/capybara/spec/session/text_spec.rb +37 -21
data/lib/capybara/spec/session/title_spec.rb +17 -5
data/lib/capybara/spec/session/uncheck_spec.rb +42 -22
data/lib/capybara/spec/session/unselect_spec.rb +39 -38
data/lib/capybara/spec/session/visit_spec.rb +99 -32
data/lib/capybara/spec/session/window/become_closed_spec.rb +24 -20
data/lib/capybara/spec/session/window/current_window_spec.rb +5 -3
data/lib/capybara/spec/session/window/open_new_window_spec.rb +5 -3
data/lib/capybara/spec/session/window/switch_to_window_spec.rb +27 -22
data/lib/capybara/spec/session/window/window_opened_by_spec.rb +12 -6
data/lib/capybara/spec/session/window/window_spec.rb +97 -63
data/lib/capybara/spec/session/window/windows_spec.rb +12 -10
data/lib/capybara/spec/session/window/within_window_spec.rb +31 -86
data/lib/capybara/spec/session/within_spec.rb +70 -44
data/lib/capybara/spec/spec_helper.rb +48 -43
data/lib/capybara/spec/test_app.rb +78 -40
data/lib/capybara/spec/views/animated.erb +49 -0
data/lib/capybara/spec/views/form.erb +130 -39
data/lib/capybara/spec/views/frame_child.erb +3 -2
data/lib/capybara/spec/views/frame_one.erb +1 -0
data/lib/capybara/spec/views/initial_alert.erb +10 -0
data/lib/capybara/spec/views/obscured.erb +47 -0
data/lib/capybara/spec/views/offset.erb +32 -0
data/lib/capybara/spec/views/react.erb +45 -0
data/lib/capybara/spec/views/scroll.erb +20 -0
data/lib/capybara/spec/views/spatial.erb +31 -0
data/lib/capybara/spec/views/tables.erb +68 -1
data/lib/capybara/spec/views/with_animation.erb +82 -0
data/lib/capybara/spec/views/with_dragula.erb +24 -0
data/lib/capybara/spec/views/with_fixed_header_footer.erb +17 -0
data/lib/capybara/spec/views/with_hover.erb +6 -0
data/lib/capybara/spec/views/with_hover1.erb +10 -0
data/lib/capybara/spec/views/with_html.erb +69 -10
data/lib/capybara/spec/views/with_html5_svg.erb +20 -0
data/lib/capybara/spec/views/with_jquery_animation.erb +24 -0
data/lib/capybara/spec/views/with_js.erb +37 -0
data/lib/capybara/spec/views/with_jstree.erb +26 -0
data/lib/capybara/spec/views/with_namespace.erb +20 -0
data/lib/capybara/spec/views/with_scope_other.erb +6 -0
data/lib/capybara/spec/views/with_sortable_js.erb +21 -0
data/lib/capybara/spec/views/within_frames.erb +4 -1
data/lib/capybara/version.rb +2 -1
data/lib/capybara/window.rb +35 -33
data/lib/capybara.rb +131 -104
data/spec/basic_node_spec.rb +47 -34
data/spec/capybara_spec.rb +53 -104
data/spec/css_builder_spec.rb +101 -0
data/spec/css_splitter_spec.rb +38 -0
data/spec/dsl_spec.rb +81 -62
data/spec/filter_set_spec.rb +27 -9
data/spec/fixtures/certificate.pem +25 -0
data/spec/fixtures/key.pem +27 -0
data/spec/fixtures/selenium_driver_rspec_failure.rb +5 -4
data/spec/fixtures/selenium_driver_rspec_success.rb +5 -4
data/spec/minitest_spec.rb +49 -7
data/spec/minitest_spec_spec.rb +94 -59
data/spec/per_session_config_spec.rb +14 -13
data/spec/rack_test_spec.rb +176 -125
data/spec/regexp_dissassembler_spec.rb +250 -0
data/spec/result_spec.rb +101 -46
data/spec/rspec/features_spec.rb +37 -31
data/spec/rspec/scenarios_spec.rb +9 -7
data/spec/rspec/shared_spec_matchers.rb +448 -421
data/spec/rspec/views_spec.rb +5 -3
data/spec/rspec_matchers_spec.rb +27 -11
data/spec/rspec_spec.rb +109 -89
data/spec/sauce_spec_chrome.rb +43 -0
data/spec/selector_spec.rb +396 -67
data/spec/selenium_spec_chrome.rb +184 -35
data/spec/selenium_spec_chrome_remote.rb +100 -0
data/spec/selenium_spec_edge.rb +47 -0
data/spec/selenium_spec_firefox.rb +183 -41
data/spec/selenium_spec_firefox_remote.rb +80 -0
data/spec/selenium_spec_ie.rb +150 -0
data/spec/selenium_spec_safari.rb +148 -0
data/spec/server_spec.rb +198 -99
data/spec/session_spec.rb +53 -16
data/spec/shared_selenium_node.rb +83 -0
data/spec/shared_selenium_session.rb +486 -97
data/spec/spec_helper.rb +93 -7
data/spec/xpath_builder_spec.rb +93 -0
metadata +338 -64
data/.yard/templates_custom/default/class/html/selectors.erb +0 -38
data/.yard/templates_custom/default/class/html/setup.rb +0 -17
data/.yard/yard_extensions.rb +0 -78
data/lib/capybara/query.rb +0 -7
data/lib/capybara/rspec/compound.rb +0 -95
data/lib/capybara/spec/session/assert_current_path.rb +0 -72
data/lib/capybara/spec/session/assert_selector.rb +0 -148
data/lib/capybara/spec/session/source_spec.rb +0 -0
data/spec/selenium_spec_marionette.rb +0 -117

data/spec/basic_node_spec.rb CHANGED Viewed

@@ -1,10 +1,12 @@
 # frozen_string_literal: true
 require 'spec_helper'
 RSpec.describe Capybara do
+  include Capybara::RSpecMatchers
   describe '.string' do
     let :string do
-      Capybara.string <<-STRING
+      described_class.string <<-STRING
         <html>
           <head>
             <title>simple_node</title>
@@ -45,97 +47,108 @@ RSpec.describe Capybara do
       STRING
     end
-    it "allows using matchers" do
+    it 'allows using matchers' do
       expect(string).to have_css('#page')
       expect(string).not_to have_css('#does-not-exist')
     end
-    it "allows using custom matchers" do
-      Capybara.add_selector :lifeform do
+    it 'allows using custom matchers' do
+      described_class.add_selector :lifeform do
         xpath { |name| ".//option[contains(.,'#{name}')]" }
       end
-      expect(string).to have_selector(:id, "page")
+      expect(string).to have_selector(:id, 'page')
       expect(string).not_to have_selector(:id, 'does-not-exist')
-      expect(string).to have_selector(:lifeform, "Monkey")
-      expect(string).not_to have_selector(:lifeform, "Gorilla")
+      expect(string).to have_selector(:lifeform, 'Monkey')
+      expect(string).not_to have_selector(:lifeform, 'Gorilla')
     end
     it 'allows custom matcher using css' do
-      Capybara.add_selector :section do
+      described_class.add_selector :section do
         css { |css_class| "section .#{css_class}" }
       end
       expect(string).to     have_selector(:section, 'subsection')
       expect(string).not_to have_selector(:section, 'section_8')
     end
-    it "allows using matchers with text option" do
+    it 'allows using matchers with text option' do
       expect(string).to have_css('h1', text: 'Totally awesome')
       expect(string).not_to have_css('h1', text: 'Not so awesome')
     end
-    it "allows finding only visible nodes" do
+    it 'allows finding only visible nodes' do
       expect(string.all(:css, '#secret', visible: true)).to be_empty
       expect(string.all(:css, '#secret', visible: false).size).to eq(1)
     end
-    it "allows finding elements and extracting text from them" do
+    it 'allows finding elements and extracting text from them' do
       expect(string.find('//h1').text).to eq('Totally awesome')
     end
-    it "allows finding elements and extracting attributes from them" do
+    it 'allows finding elements and extracting attributes from them' do
       expect(string.find('//h1')[:data]).to eq('fantastic')
     end
-    it "allows finding elements and extracting the tag name from them" do
+    it 'allows finding elements and extracting the tag name from them' do
       expect(string.find('//h1').tag_name).to eq('h1')
     end
-    it "allows finding elements and extracting the path" do
+    it 'allows finding elements and extracting the path' do
       expect(string.find('//h1').path).to eq('/html/body/div/div[1]/h1')
     end
-    it "allows finding elements and extracting the path" do
+    it 'allows finding elements and extracting the value' do
       expect(string.find('//div/input').value).to eq('bar')
       expect(string.find('//select').value).to eq('Capybara')
     end
-    it "allows finding elements and checking if they are visible" do
+    it 'allows finding elements and checking if they are visible' do
       expect(string.find('//h1')).to be_visible
-      expect(string.find(:css, "#secret", visible: false)).not_to be_visible
+      expect(string.find(:css, '#secret', visible: false)).not_to be_visible
     end
-    it "allows finding elements and checking if they are disabled" do
+    it 'allows finding elements and checking if they are disabled' do
       expect(string.find('//form/input[@name="bleh"]')).to be_disabled
       expect(string.find('//form/input[@name="meh"]')).not_to be_disabled
     end
-    describe "#title" do
-      it "returns the page title" do
-        expect(string.title).to eq("simple_node")
+    it 'drops illegal fragments when using gumbo' do
+      skip 'libxml is less strict than Gumbo' unless Nokogiri.respond_to?(:HTML5)
+      expect(described_class.string('<td>1</td>')).not_to have_css('td')
+    end
+    it 'can disable use of gumbo' do
+      skip "Test doesn't make sense unlesss nokogumbo is loaded" unless Nokogiri.respond_to?(:HTML5)
+      described_class.allow_gumbo = false
+      expect(described_class.string('<td>1</td>')).to have_css('td')
+    end
+    describe '#title' do
+      it 'returns the page title' do
+        expect(string.title).to eq('simple_node')
       end
     end
-    describe "#has_title?" do
-      it "returns whether the page has the given title" do
-        expect(string.has_title?('simple_node')).to be_truthy
-        expect(string.has_title?('monkey')).to be_falsey
+    describe '#has_title?' do
+      it 'returns whether the page has the given title' do
+        expect(string.has_title?('simple_node')).to be true
+        expect(string.has_title?('monkey')).to be false
       end
-      it "allows regexp matches" do
-        expect(string.has_title?(/s[a-z]+_node/)).to be_truthy
-        expect(string.has_title?(/monkey/)).to be_falsey
+      it 'allows regexp matches' do
+        expect(string.has_title?(/s[a-z]+_node/)).to be true
+        expect(string.has_title?(/monkey/)).to be false
       end
     end
     describe '#has_no_title?' do
-      it "returns whether the page does not have the given title" do
-        expect(string.has_no_title?('simple_node')).to be_falsey
-        expect(string.has_no_title?('monkey')).to be_truthy
+      it 'returns whether the page does not have the given title' do
+        expect(string.has_no_title?('simple_node')).to be false
+        expect(string.has_no_title?('monkey')).to be true
       end
-      it "allows regexp matches" do
-        expect(string.has_no_title?(/s[a-z]+_node/)).to be_falsey
-        expect(string.has_no_title?(/monkey/)).to be_truthy
+      it 'allows regexp matches' do
+        expect(string.has_no_title?(/s[a-z]+_node/)).to be false
+        expect(string.has_no_title?(/monkey/)).to be true
       end
     end
   end

data/spec/capybara_spec.rb CHANGED Viewed

@@ -1,163 +1,112 @@
 # frozen_string_literal: true
 require 'spec_helper'
 RSpec.describe Capybara do
   describe 'default_max_wait_time' do
-    after do
-      Capybara.default_max_wait_time = @previous_default_time
-    end
+    before { @previous_default_time = described_class.default_max_wait_time }
-    it "should be changeable" do
-      @previous_default_time = Capybara.default_max_wait_time
-      Capybara.default_max_wait_time = 5
-      expect(Capybara.default_max_wait_time).to eq(5)
-    end
+    after { described_class.default_max_wait_time = @previous_default_time } # rubocop:disable RSpec/InstanceVariable
-    it "should be accesible as the deprecated default_wait_time" do
-      expect(Capybara.send(:config)).to receive(:warn).ordered.with('DEPRECATED: #default_wait_time= is deprecated, please use #default_max_wait_time= instead')
-      expect(Capybara.send(:config)).to receive(:warn).ordered.with('DEPRECATED: #default_wait_time is deprecated, please use #default_max_wait_time instead')
-      @previous_default_time = Capybara.default_max_wait_time
-      Capybara.default_wait_time = 5
-      expect(Capybara.default_wait_time).to eq(5)
-      expect(Capybara.default_max_wait_time).to eq(5)
+    it 'should be changeable' do
+      expect(described_class.default_max_wait_time).not_to eq(5)
+      described_class.default_max_wait_time = 5
+      expect(described_class.default_max_wait_time).to eq(5)
     end
   end
   describe '.register_driver' do
-    it "should add a new driver" do
-      Capybara.register_driver :schmoo do |app|
+    it 'should add a new driver' do
+      described_class.register_driver :schmoo do |app|
         Capybara::RackTest::Driver.new(app)
       end
       session = Capybara::Session.new(:schmoo, TestApp)
       session.visit('/')
-      expect(session.body).to include("Hello world!")
+      expect(session.body).to include('Hello world!')
     end
   end
   describe '.register_server' do
-    before do
-      Capybara.reuse_server = false
-      @old_server = Capybara.server
-    end
-    after do
-      Capybara.server(&@old_server)
-      Capybara.reuse_server = true
-    end
-    it "should add a new server" do
-      skip "JRuby fails this because of path issues to geckodriver I think. Its tested in other runs - not worth figuring out at this time" if RUBY_PLATFORM == 'java'
-      require 'rack/handler/webrick'
-      Capybara.register_server :blob do |app, port, host|
-        Rack::Handler::WEBrick.run(app, Host: host, Port: port, AccessLog: [], Logger: WEBrick::Log::new(nil, 0))
+    it 'should add a new server' do
+      described_class.register_server :blob do |_app, _port, _host|
+        # do nothing
       end
-      Capybara.server = :blob
-      session = Capybara::Session.new(:selenium, TestApp.new)
-      session.visit('/')
-      expect(session.body).to include("Hello world!")
+      expect(described_class.servers[:blob]).to be_truthy
     end
   end
-  describe ".server" do
-    before do
-      @old_server = Capybara.server
+  describe '.server' do
+    after do
+      described_class.server = :default
     end
-    after do
-      Capybara.server(&@old_server)
+    it 'should default to a proc that calls run_default_server' do
+      mock_app = Object.new
+      allow(described_class).to receive(:run_default_server).and_return(true)
+      described_class.server.call(mock_app, 8000)
+      expect(described_class).to have_received(:run_default_server).with(mock_app, 8000)
     end
-    it "should default to a proc that calls run_default_server" do
-      mock_app = double('app')
-      expect(Capybara).to receive(:run_default_server).with(mock_app, 8000)
-      Capybara.server.call(mock_app, 8000)
+    it 'should return a custom server proc' do
+      server = ->(_app, _port) {}
+      described_class.register_server :custom, &server
+      described_class.server = :custom
+      expect(described_class.server).to eq(server)
     end
-    it "should return a custom server proc" do
-      server = lambda {|app, port|}
-      Capybara.server(&server)
-      expect(Capybara.server).to eq(server)
+    it 'should have :webrick registered' do
+      expect(described_class.servers[:webrick]).not_to be_nil
     end
-    it "should have :webrick registered" do
-      require 'rack/handler/webrick'
-      mock_app = double('app')
-      Capybara.server = :webrick
-      expect(Rack::Handler::WEBrick).to receive(:run)
-      Capybara.server.call(mock_app, 8000)
+    it 'should have :puma registered' do
+      expect(described_class.servers[:puma]).not_to be_nil
     end
+  end
-    it "should have :puma registered" do
-      require 'rack/handler/puma'
-      mock_app = double('app')
-      Capybara.server = :puma
-      expect(Rack::Handler::Puma).to receive(:run).with(mock_app, hash_including(Host: nil, Port: 8000))
-      Capybara.server.call(mock_app, 8000)
+  describe 'server=' do
+    after do
+      described_class.server = :default
     end
-    it "should pass options to server" do
-      require 'rack/handler/puma'
-      mock_app = double('app')
-      Capybara.server = :puma, { Silent: true }
-      expect(Rack::Handler::Puma).to receive(:run).with(mock_app, hash_including(Host: nil, Port: 9000, Silent: true))
-      Capybara.server.call(mock_app, 9000)
+    it 'accepts a proc' do
+      server = ->(_app, _port) {}
+      described_class.server = server
+      expect(described_class.server).to eq server
     end
   end
   describe 'app_host' do
     after do
-      Capybara.app_host = nil
+      described_class.app_host = nil
     end
-    it "should warn if not a valid URL" do
-      expect { Capybara.app_host = "www.example.com" }.to raise_error(ArgumentError, /Capybara\.app_host should be set to a url/)
+    it 'should warn if not a valid URL' do
+      expect { described_class.app_host = 'www.example.com' }.to raise_error(ArgumentError, /Capybara\.app_host should be set to a url/)
     end
-    it "should not warn if a valid URL" do
-      expect { Capybara.app_host = "http://www.example.com" }.not_to raise_error
+    it 'should not warn if a valid URL' do
+      expect { described_class.app_host = 'http://www.example.com' }.not_to raise_error
     end
-    it "should not warn if nil" do
-      expect { Capybara.app_host = nil }.not_to raise_error
+    it 'should not warn if nil' do
+      expect { described_class.app_host = nil }.not_to raise_error
     end
   end
   describe 'default_host' do
     around do |test|
-      old_default = Capybara.default_host
+      old_default = described_class.default_host
       test.run
-      Capybara.default_host = old_default
-    end
-    it "should warn if not a valid URL" do
-      expect { Capybara.default_host = "www.example.com" }.to raise_error(ArgumentError, /Capybara\.default_host should be set to a url/)
+      described_class.default_host = old_default
     end
-    it "should not warn if a valid URL" do
-      expect { Capybara.default_host = "http://www.example.com" }.not_to raise_error
+    it 'should raise if not a valid URL' do
+      expect { described_class.default_host = 'www.example.com' }.to raise_error(ArgumentError, /Capybara\.default_host should be set to a url/)
     end
-  end
-  describe "configure" do
-    it 'deprecates calling non configuration option methods in configure' do
-      expect_any_instance_of(Kernel).to receive(:warn).
-        with('Calling register_driver from Capybara.configure is deprecated - please call it on Capybara directly ( Capybara.register_driver(...) )')
-      Capybara.configure do |config|
-        config.register_driver(:random_name) do
-          #just a random block
-        end
-      end
-    end
-  end
-end
-RSpec.describe Capybara::Session do
-  context 'with non-existant driver' do
-    it "should raise an error" do
-      expect {
-        Capybara::Session.new(:quox, TestApp).driver
-      }.to raise_error(Capybara::DriverNotFoundError)
+    it 'should not warn if a valid URL' do
+      expect { described_class.default_host = 'http://www.example.com' }.not_to raise_error
     end
   end
 end

data/spec/css_builder_spec.rb ADDED Viewed

@@ -0,0 +1,101 @@
+# frozen_string_literal: true
+require 'spec_helper'
+# rubocop:disable RSpec/InstanceVariable
+RSpec.describe Capybara::Selector::CSSBuilder do
+  let :builder do
+    ::Capybara::Selector::CSSBuilder.new(@css)
+  end
+  context 'add_attribute_conditions' do
+    it 'adds a single string condition to a single selector' do
+      @css = 'div'
+      selector = builder.add_attribute_conditions(random: 'abc')
+      expect(selector).to eq %(div[random='abc'])
+    end
+    it 'adds multiple string conditions to a single selector' do
+      @css = 'div'
+      selector = builder.add_attribute_conditions(random: 'abc', other: 'def')
+      expect(selector).to eq %(div[random='abc'][other='def'])
+    end
+    it 'adds a single string condition to a multiple selector' do
+      @css = 'div, ul'
+      selector = builder.add_attribute_conditions(random: 'abc')
+      expect(selector).to eq %(div[random='abc'], ul[random='abc'])
+    end
+    it 'adds multiple string conditions to a multiple selector' do
+      @css = 'div, ul'
+      selector = builder.add_attribute_conditions(random: 'abc', other: 'def')
+      expect(selector).to eq %(div[random='abc'][other='def'], ul[random='abc'][other='def'])
+    end
+    it 'adds simple regexp conditions to a single selector' do
+      @css = 'div'
+      selector = builder.add_attribute_conditions(random: /abc/, other: /def/)
+      expect(selector).to eq %(div[random*='abc'][other*='def'])
+    end
+    it 'adds wildcard regexp conditions to a single selector' do
+      @css = 'div'
+      selector = builder.add_attribute_conditions(random: /abc.*def/, other: /def.*ghi/)
+      expect(selector).to eq %(div[random*='abc'][random*='def'][other*='def'][other*='ghi'])
+    end
+    it 'adds alternated regexp conditions to a single selector' do
+      @css = 'div'
+      selector = builder.add_attribute_conditions(random: /abc|def/, other: /def|ghi/)
+      expect(selector).to eq %(div[random*='abc'][other*='def'], div[random*='abc'][other*='ghi'], div[random*='def'][other*='def'], div[random*='def'][other*='ghi'])
+    end
+    it 'adds alternated regexp conditions to a multiple selector' do
+      @css = 'div,ul'
+      selector = builder.add_attribute_conditions(other: /def.*ghi|jkl/)
+      expect(selector).to eq %(div[other*='def'][other*='ghi'], div[other*='jkl'], ul[other*='def'][other*='ghi'], ul[other*='jkl'])
+    end
+    it "returns original selector when regexp can't be substringed" do
+      @css = 'div'
+      selector = builder.add_attribute_conditions(other: /.+/)
+      expect(selector).to eq 'div'
+    end
+    context ':class' do
+      it 'handles string with CSS .' do
+        @css = 'a'
+        selector = builder.add_attribute_conditions(class: 'my_class')
+        expect(selector).to eq 'a.my_class'
+      end
+      it 'handles negated string with CSS .' do
+        @css = 'a'
+        selector = builder.add_attribute_conditions(class: '!my_class')
+        expect(selector).to eq 'a:not(.my_class)'
+      end
+      it 'handles array of string with CSS .' do
+        @css = 'a'
+        selector = builder.add_attribute_conditions(class: %w[my_class my_other_class])
+        expect(selector).to eq 'a.my_class.my_other_class'
+      end
+      it 'handles array of string with CSS . when negated included' do
+        @css = 'a'
+        selector = builder.add_attribute_conditions(class: %w[my_class !my_other_class])
+        expect(selector).to eq 'a.my_class:not(.my_other_class)'
+      end
+    end
+    context ':id' do
+      it 'handles string with CSS #' do
+        @css = 'ul'
+        selector = builder.add_attribute_conditions(id: 'my_id')
+        expect(selector).to eq 'ul#my_id'
+      end
+    end
+  end
+end
+# rubocop:enable RSpec/InstanceVariable