capybara 2.14.2 → 2.14.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2dc6b7471732df96709e856d00f104f1e2f43aac
-  data.tar.gz: 7c8e722e733587c8f3854e461f7e5ab168a93c26
+  metadata.gz: 02dc31ca457043556ca668229aa313e59b198363
+  data.tar.gz: 13528d46037d76c4deabfdfd57d2da09e45b7f01
 SHA512:
-  metadata.gz: 18629cb7fd46d4d80ee6de85508ebd7349ee9544cf0653b421c4184e13a289edad3da27a5ba7eeca44a3921c7b0db24de9d7440c56955a97d8b9dfa4d7b8ac0e
-  data.tar.gz: 81ec7b11745dfc178f4c1c9c57d7b6dbc0f56b1f5ec68bde85ed3375fee04fcd9ed7f4c6a19a040b13556400933e67a4c246bc0873e7b02370ec17ea251cf1f3
+  metadata.gz: 0a98665ce0452986b3f6a138b29a53fadaf3f2fc0ada1332005062845585ced403c0ea352facaf34c8b80915581e3122b51fa53b158f7348d05afef47ca4a17e
+  data.tar.gz: 2a24b9da7fda6168106dedc1d621ab9184fa16ec391003199c85a3468b17535de939e9a044c715ac1c42b4cc9d907f41f3db8af808ffbb1256bb3d5a06c078f6

data/History.md

@@ -1,3 +1,12 @@
+# Version 2.14.3
+
+Release date: 2017-06-15
+
+### Fixed
+
+* Minitest assertions now raise the correct error type - Issue #1879 [Thomas Walpole]
+* Improve flexibility of detecting Chrome headless mode [Thomas Walpole]
+
 # Version 2.14.2
 
 Release date: 2017-06-09

data/lib/capybara/minitest.rb

@@ -49,7 +49,7 @@ module Capybara
             subject, *args = determine_subject(args)
             subject.#{assertion_name}(*args)
           rescue Capybara::ExpectationNotMet => e
-            raise ::Minitest::Assertions, e.message
+            raise ::Minitest::Assertion, e.message
           end
         EOM
       end
@@ -88,7 +88,7 @@ module Capybara
             subject, *args = determine_subject(args)
             subject.#{assertion_name}(*args, &optional_filter_block)
           rescue Capybara::ExpectationNotMet => e
-            raise ::Minitest::Assertions, e.message
+            raise ::Minitest::Assertion, e.message
           end
         EOM
       end

data/lib/capybara/selenium/driver.rb

@@ -308,9 +308,16 @@ class Capybara::Selenium::Driver < Capybara::Driver::Base
 
   # @api private
   def headless_chrome?
-    chrome? && ((@processed_options[:desired_capabilities][:chrome_options] || {})['args'] || []).include?("headless")
+    if chrome?
+      caps = @processed_options[:desired_capabilities]
+      chrome_options = caps[:chrome_options] || caps[:chromeOptions] || {}
+      args = chrome_options['args'] || chrome_options[:args] || []
+      return args.include?("headless")
+    end
+    return false
   end
 
+
   # @deprecated This method is being removed
   def browser_initialized?
     super && !@browser.nil?

data/lib/capybara/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Capybara
-  VERSION = '2.14.2'
+  VERSION = '2.14.3'
 end

data/spec/minitest_spec_spec.rb

@@ -102,6 +102,10 @@ class MinitestSpecTest < Minitest::Spec
     find(:select, 'form_title').must_match_xpath('.//select[@id="form_title"]')
     find(:select, 'form_title').wont_match_xpath('.//select[@id="not_on_page"]')
   end
+
+  it "handles failures" do
+    page.must_have_select('non_existing_form_title')
+  end
 end
 
 RSpec.describe 'capybara/minitest/spec' do
@@ -116,6 +120,8 @@ RSpec.describe 'capybara/minitest/spec' do
     reporter.start
     MinitestSpecTest.run reporter, {}
     reporter.report
-    expect(output.string).to include("15 runs, 38 assertions, 0 failures, 0 errors, 0 skips")
+    expect(output.string).to include("16 runs, 39 assertions, 1 failures, 0 errors, 0 skips")
+    #Make sure error messages are displayed
+    expect(output.string).to include('expected to find select box "non_existing_form_title" but there were no matches')
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara
 version: !ruby/object:Gem::Version
-  version: 2.14.2
+  version: 2.14.3
 platform: ruby
 authors:
 - Thomas Walpole
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain:
 - gem-public_cert.pem
-date: 2017-06-09 00:00:00.000000000 Z
+date: 2017-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -106,6 +106,9 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 3.4.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -116,6 +119,9 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 3.4.1
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement