capybara 2.13.0 → 2.18.0

data/spec/rspec_spec.rb

@@ -7,6 +7,10 @@ RSpec.describe 'capybara/rspec', :type => :feature do
     expect(page.body).to include('Another World')
   end
 
+  it "should include RSpec matcher proxies" do
+    expect(self.class.ancestors).to include Capybara::RSpecMatcherProxies
+  end
+
   context "resetting session" do
     it "sets a cookie in one example..." do
       visit('/set_cookie')
@@ -36,6 +40,79 @@ RSpec.describe 'capybara/rspec', :type => :feature do
   it "switches to the given driver when giving it as metadata", :driver => :culerity do
     expect(Capybara.current_driver).to eq(:culerity)
   end
+
+  context "#all" do
+    it "allows access to the Capybara finder" do
+      visit('/with_html')
+      expect(all(:css, 'h2.head').size).to eq(5)
+    end
+
+    it "allows access to the RSpec matcher" do
+      skip "RSpec < 3 doesn't have an `all` matcher" if rspec2?
+
+      visit('/with_html')
+      expect(["test1", "test2"]).to all(be_a(String))
+    end
+  end
+
+  context "#within" do
+    it "allows access to the Capybara scoper" do
+      visit('/with_html')
+      expect do
+        within(:css, "#does_not_exist") { click_link "Go to simple" }
+      end.to raise_error(Capybara::ElementNotFound)
+    end
+
+    it "allows access to the RSpec matcher" do
+      skip "RSpec version doesn't have a 'within' matcher" unless ::RSpec::Matchers.instance_methods.include?(:within)
+      visit('/with_html')
+      # This reads terribly, but must call #within
+      expect(find(:css, 'span.number').text.to_i).to within(1).of(41)
+    end
+  end
+end
+
+RSpec.describe 'capybara/rspec', :type => :other do
+  context "when RSpec::Matchers is included after Capybara::DSL" do
+    before do
+      class DSL_MatchersTest
+        include Capybara::DSL
+        include RSpec::Matchers
+      end
+
+      @test_class_instance = DSL_MatchersTest.new
+    end
+
+    context "#all" do
+      it "allows access to the Capybara finder" do
+        @test_class_instance.visit('/with_html')
+        expect(@test_class_instance.all(:css, 'h2.head').size).to eq(5)
+      end
+
+      it "allows access to the RSpec matcher" do
+        skip "RSpec < 3 doesn't have an `all` matcher" if rspec2?
+
+        @test_class_instance.visit('/with_html')
+        expect(["test1", "test2"]).to @test_class_instance.all(be_a(String))
+      end
+    end
+
+    context "#within" do
+      it "allows access to the Capybara scoper" do
+        @test_class_instance.visit('/with_html')
+        expect do
+          @test_class_instance.within(:css, "#does_not_exist") { @test_class_instance.click_link "Go to simple" }
+        end.to raise_error(Capybara::ElementNotFound)
+      end
+
+      it "allows access to the RSpec matcher" do
+        skip "RSpec version doesn't have a 'within' matcher" unless ::RSpec::Matchers.instance_methods.include?(:within)
+        @test_class_instance.visit('/with_html')
+        # This reads terribly, but must call #within
+        expect(@test_class_instance.find(:css, 'span.number').text.to_i).to @test_class_instance.within(1).of(41)
+      end
+    end
+  end
 end
 
 RSpec.describe 'capybara/rspec', :type => :other do

data/spec/selector_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe Capybara do
             <input type="hidden" id="hidden_field" value="this is hidden"/>
             <a href="#">link</a>
             <fieldset></fieldset>
-            <select>
+            <select id="select">
               <option value="a">A</option>
               <option value="b" disabled>B</option>
               <option value="c" selected>C</option>
@@ -177,6 +177,7 @@ RSpec.describe Capybara do
 
         it "finds by type" do
           expect(string.find(:field, type: 'file')[:id]).to eq 'file'
+          expect(string.find(:field, type: 'select')[:id]).to eq 'select'
         end
       end
 

data/spec/selenium_spec_chrome.rb

@@ -3,30 +3,34 @@ require 'spec_helper'
 require 'selenium-webdriver'
 require 'shared_selenium_session'
 
-Capybara.register_driver :selenium_chrome do |app|
-  args = ENV['TRAVIS'] ? ['no-sandbox' ] : []
-  Capybara::Selenium::Driver.new(app, :browser => :chrome, :args => args)
-end
+CHROME_DRIVER = if ENV['HEADLESS'] then :selenium_chrome_headless else :selenium_chrome end
+
+# if ENV['HEADLESS'] && ENV['TRAVIS']
+#   Selenium::WebDriver::Chrome.path='/usr/bin/google-chrome-beta'
+# end
 
 Capybara.register_driver :selenium_chrome_clear_storage do |app|
-  args = ENV['TRAVIS'] ? ['no-sandbox' ] : []
-  Capybara::Selenium::Driver.new(app, :browser => :chrome,
-                                      :args => args,
-                                      clear_local_storage: true,
-                                      clear_session_storage: true)
+  chrome_options = {
+    browser: :chrome,
+    options: ::Selenium::WebDriver::Chrome::Options.new()
+  }
+  chrome_options[:options].args << 'headless' if ENV['HEADLESS']
+  Capybara::Selenium::Driver.new(app, chrome_options.merge(clear_local_storage: true, clear_session_storage: true))
 end
 
 module TestSessions
-  Chrome = Capybara::Session.new(:selenium_chrome, TestApp)
+  Chrome = Capybara::Session.new(CHROME_DRIVER, TestApp)
 end
 
 skipped_tests = [:response_headers, :status_code, :trigger]
-skipped_tests << :windows if ENV['TRAVIS'] && !ENV['WINDOW_TEST']
+# skip window tests when headless for now - closing a window not supported by chromedriver/chrome
+skipped_tests << :windows if ENV['TRAVIS']  && (ENV['SKIP_WINDOW'] || ENV['HEADLESS'])
 
-Capybara::SpecHelper.run_specs TestSessions::Chrome, "selenium_chrome", capybara_skip: skipped_tests
+Capybara::SpecHelper.run_specs TestSessions::Chrome, CHROME_DRIVER.to_s, capybara_skip: skipped_tests
 
 RSpec.describe "Capybara::Session with chrome" do
-  include_examples  "Capybara::Session", TestSessions::Chrome, :selenium_chrome
+  include Capybara::SpecHelper
+  include_examples  "Capybara::Session", TestSessions::Chrome, CHROME_DRIVER
 
   context "storage" do
     describe "#reset!" do
@@ -36,8 +40,10 @@ RSpec.describe "Capybara::Session with chrome" do
         @session.find(:css, '#set-storage').click
         @session.reset!
         @session.visit('/with_js')
-        expect(@session.driver.browser.local_storage.keys).not_to be_empty
-        expect(@session.driver.browser.session_storage.keys).not_to be_empty
+        # expect(@session.driver.browser.local_storage.keys).not_to be_empty
+        # expect(@session.driver.browser.session_storage.keys).not_to be_empty
+        expect(@session.evaluate_script('Object.keys(localStorage)')).not_to be_empty
+        expect(@session.evaluate_script('Object.keys(sessionStorage)')).not_to be_empty
       end
 
       it "clears storage when set" do
@@ -46,8 +52,10 @@ RSpec.describe "Capybara::Session with chrome" do
         @session.find(:css, '#set-storage').click
         @session.reset!
         @session.visit('/with_js')
-        expect(@session.driver.browser.local_storage.keys).to be_empty
-        expect(@session.driver.browser.session_storage.keys).to be_empty
+        # expect(@session.driver.browser.local_storage.keys).to be_empty
+        # expect(@session.driver.browser.session_storage.keys).to be_empty
+        expect(@session.evaluate_script('Object.keys(localStorage)')).to be_empty
+        expect(@session.evaluate_script('Object.keys(sessionStorage)')).to be_empty
       end
     end
   end

data/spec/selenium_spec_firefox.rb

@@ -31,11 +31,12 @@ skipped_tests = [
   :status_code,
   :trigger
 ]
-skipped_tests << :windows if ENV['TRAVIS'] && !ENV['WINDOW_TEST']
+skipped_tests << :windows if ENV['TRAVIS'] && ENV['SKIP_WINDOW']
 
 Capybara::SpecHelper.run_specs TestSessions::Selenium, "selenium", capybara_skip: skipped_tests
 
 RSpec.describe "Capybara::Session with legacy firefox" do
+  include Capybara::SpecHelper
   include_examples  "Capybara::Session", TestSessions::Selenium, :selenium_firefox
   include_examples  Capybara::RSpecMatchers, TestSessions::Selenium, :selenium_firefox
 

data/spec/selenium_spec_marionette.rb

@@ -4,11 +4,20 @@ require "selenium-webdriver"
 require 'shared_selenium_session'
 require 'rspec/shared_spec_matchers'
 
+browser_options = ::Selenium::WebDriver::Firefox::Options.new()
+browser_options.args << '--headless' if ENV['HEADLESS']
+browser_options.add_preference 'dom.file.createInChild', true
+# browser_options.add_option("log", {"level": "trace"})
+
 Capybara.register_driver :selenium_marionette do |app|
+  # ::Selenium::WebDriver.logger.level = "debug"
   Capybara::Selenium::Driver.new(
     app,
     browser: :firefox,
-    desired_capabilities: Selenium::WebDriver::Remote::Capabilities.firefox(marionette: true)
+    desired_capabilities: {marionette: true, 'moz:webdriverClick': true},
+    options: browser_options
+    # Get a trace level log from geckodriver
+    # :driver_opts => { args: ['-vv'] }
   )
 end
 
@@ -16,12 +25,15 @@ Capybara.register_driver :selenium_marionette_clear_storage do |app|
   Capybara::Selenium::Driver.new(
     app,
     browser: :firefox,
-    desired_capabilities: Selenium::WebDriver::Remote::Capabilities.firefox(marionette: true),
+    desired_capabilities: {marionette: true},
     clear_local_storage: true,
-    clear_session_storage: true
+    clear_session_storage: true,
+    options: browser_options
   )
 end
 
+
+
 module TestSessions
   SeleniumMarionette = Capybara::Session.new(:selenium_marionette, TestApp)
 end
@@ -31,18 +43,19 @@ skipped_tests = [
   :status_code,
   :trigger
 ]
-skipped_tests << :windows if ENV['TRAVIS'] && !ENV['WINDOW_TEST']
+skipped_tests << :windows if ENV['TRAVIS'] && ENV['SKIP_WINDOW']
 
 Capybara::SpecHelper.run_specs TestSessions::SeleniumMarionette, "selenium", capybara_skip: skipped_tests
 
 RSpec.describe "Capybara::Session with firefox" do
+  include Capybara::SpecHelper
   include_examples  "Capybara::Session", TestSessions::SeleniumMarionette, :selenium_marionette
   include_examples  Capybara::RSpecMatchers, TestSessions::SeleniumMarionette, :selenium_marionette
 end
 
 RSpec.describe Capybara::Selenium::Driver do
   before do
-    @driver = Capybara::Selenium::Driver.new(TestApp, browser: :firefox)
+    @driver = Capybara::Selenium::Driver.new(TestApp, browser: :firefox, options: browser_options)
   end
 
   describe '#quit' do

data/spec/session_spec.rb

@@ -7,4 +7,48 @@ RSpec.describe Capybara::Session do
       Capybara::Session.new(:unknown, { random: "hash"})
     end.to raise_error TypeError, "The second parameter to Session::new should be a rack app if passed."
   end
+
+  context "current_driver" do
+    it "is global when threadsafe false" do
+      Capybara.threadsafe = false
+      Capybara.current_driver = :selenium
+      thread = Thread.new do
+        Capybara.current_driver = :random
+      end
+      thread.join
+      expect(Capybara.current_driver).to eq :random
+    end
+
+    it "is thread specific threadsafe true" do
+      Capybara.threadsafe = true
+      Capybara.current_driver = :selenium
+      thread = Thread.new do
+        Capybara.current_driver = :random
+      end
+      thread.join
+      expect(Capybara.current_driver).to eq :selenium
+    end
+  end
+
+  context "session_name" do
+    it "is global when threadsafe false" do
+      Capybara.threadsafe = false
+      Capybara.session_name = "sess1"
+      thread = Thread.new do
+        Capybara.session_name = "sess2"
+      end
+      thread.join
+      expect(Capybara.session_name).to eq "sess2"
+    end
+
+    it "is thread specific when threadsafe true" do
+      Capybara.threadsafe = true
+      Capybara.session_name = "sess1"
+      thread = Thread.new do
+        Capybara.session_name = "sess2"
+      end
+      thread.join
+      expect(Capybara.session_name).to eq "sess1"
+    end
+  end
 end

data/spec/shared_selenium_session.rb

@@ -34,6 +34,8 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
       before do
         @current_dir = Dir.getwd
         Dir.chdir(File.join(File.dirname(__FILE__), '..'))
+        @env = { 'SELENIUM_BROWSER' => @session.driver.options[:browser].to_s }
+        @env['LEGACY_FIREFOX'] = 'TRUE' if mode == :selenium_firefox
       end
 
       after do
@@ -41,16 +43,14 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
       end
 
       it "should have return code 1 when running selenium_driver_rspec_failure.rb" do
-        env = { 'SELENIUM_BROWSER' => @session.driver.options[:browser].to_s,
-                'LEGACY_FIREFOX' => (mode == :selenium_firefox ? 'TRUE' : nil) }
-        system(env, 'rspec spec/fixtures/selenium_driver_rspec_failure.rb', out: File::NULL, err: File::NULL)
+        skip if ENV['HEADLESS']
+        system(@env, 'rspec spec/fixtures/selenium_driver_rspec_failure.rb', out: File::NULL, err: File::NULL)
         expect($?.exitstatus).to eq(1)
       end
 
       it "should have return code 0 when running selenium_driver_rspec_success.rb" do
-        env = { 'SELENIUM_BROWSER' => @session.driver.options[:browser].to_s,
-                'LEGACY_FIREFOX' => (mode == :selenium_firefox ? 'TRUE' : nil) }
-        system(env, 'rspec spec/fixtures/selenium_driver_rspec_success.rb', out: File::NULL, err: File::NULL)
+        skip if ENV['HEADLESS']
+        system(@env, 'rspec spec/fixtures/selenium_driver_rspec_success.rb', out: File::NULL, err: File::NULL)
         expect($?.exitstatus).to eq(0)
       end
     end
@@ -60,7 +60,24 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
         @session.visit('/with_js')
         @session.click_link('Open alert')
         @session.accept_alert
-        expect{@session.driver.browser.switch_to.alert}.to raise_error(Selenium::WebDriver::Error::NoAlertPresentError)
+        expect{@session.driver.browser.switch_to.alert}.to raise_error(@session.driver.send(:modal_error))
+      end
+
+      it "can be called before visiting" do
+        @session.accept_alert "Initial alert" do
+          @session.visit('/initial_alert')
+        end
+        expect(@session).to have_text('Initial alert page')
+      end
+    end
+
+    context '#fill_in_with empty string and no options' do
+      it 'should trigger change when clearing a field' do
+        @session.visit('/with_js')
+        @session.fill_in('with_change_event', with: '')
+        # click outside the field to trigger the change event
+        @session.find(:css, 'body').click
+        expect(@session).to have_selector(:css, '.change_event_triggered', match: :one)
       end
     end
 
@@ -89,6 +106,15 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
         @session.find(:css, 'body').click
         expect(@session).to have_selector(:css, '.change_event_triggered', match: :one)
       end
+
+      it 'should trigger input event field_value.length times' do
+        @session.visit('/with_js')
+        @session.fill_in('with_change_event', with: '',
+                         fill_options: { :clear => :backspace })
+        # click outside the field to trigger the change event
+        @session.find(:css, 'body').click
+        expect(@session).to have_xpath('//p[@class="input_event_triggered"]', count: 13)
+      end
     end
 
     context "#fill_in with { clear: :none } fill_options" do
@@ -102,7 +128,7 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
 
     context "#fill_in with { clear: Array } fill_options" do
       it 'should pass the array through to the element' do
-        pending "selenium-webdriver/geckodriver doesn't support complex sets of characters" if @session.driver.marionette?
+        pending "selenium-webdriver/geckodriver doesn't support complex sets of characters" if marionette?(@session)
         #this is mainly for use with [[:control, 'a'], :backspace] - however since that is platform dependant I'm testing with something less useful
         @session.visit('/form')
         @session.fill_in('form_first_name', with: 'Harry',
@@ -120,6 +146,14 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
       end
     end
 
+    describe "all with disappearing elements" do
+      it "ignores stale elements in results" do
+        @session.visit('/path')
+        elements = @session.all(:link) { |node| raise Selenium::WebDriver::Error::StaleElementReferenceError }
+        expect(elements.size).to eq 0
+      end
+    end
+
     describe "#evaluate_script" do
       it "can return an element" do
         @session.visit('/form')
@@ -146,6 +180,36 @@ RSpec.shared_examples "Capybara::Session" do |session, mode|
           }
         })
       end
+
+      describe "#evaluate_async_script" do
+        it "will timeout if the script takes too long" do
+          @session.visit('/with_js')
+          expect do
+            @session.using_wait_time(1) do
+              @session.evaluate_async_script("var cb = arguments[0]; setTimeout(function(){ cb(null) }, 3000)")
+            end
+          end.to raise_error Selenium::WebDriver::Error::ScriptTimeoutError
+        end
+      end
+    end
+
+    describe "Element#inspect" do
+      it "outputs obsolete elements" do
+        @session.visit('/form')
+        el = @session.find(:button, 'Click me!').click
+        expect(@session).to have_no_button('Click me!')
+        expect(el).not_to receive(:synchronize)
+        expect(el.inspect).to eq "Obsolete #<Capybara::Node::Element>"
+      end
+    end
+
+    describe "Element#click" do
+      it "should handle fixed headers/footers" do
+        @session.visit('/with_fixed_header_footer')
+        # @session.click_link('Go to root')
+        @session.find(:link, 'Go to root').click
+        expect(@session).to have_current_path('/')
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -8,3 +8,7 @@ RSpec.configure do |config|
   config.filter_run_including focus_: true unless ENV['TRAVIS']
   config.run_all_when_everything_filtered = true
 end
+
+def rspec2?
+  !defined?(::RSpec::Expectations::Version) || (Gem::Version.new(RSpec::Expectations::Version::STRING) < Gem::Version.new('3.0'))
+end