capybara 2.11.0 → 2.12.0

data/lib/capybara/spec/session/assert_current_path.rb

@@ -34,6 +34,12 @@ Capybara::SpecHelper.spec '#assert_current_path' do
     @session.visit('/with_js?test=test')
     expect{@session.assert_current_path('/with_js', only_path: true)}.not_to raise_error
   end
+
+  it "should not cause an exception when current_url is nil" do
+    allow_any_instance_of(Capybara::Session).to receive(:current_url) { nil }
+
+    expect{@session.assert_current_path(nil)}.not_to raise_error
+  end
 end
 
 Capybara::SpecHelper.spec '#assert_no_current_path?' do
@@ -57,4 +63,10 @@ Capybara::SpecHelper.spec '#assert_no_current_path?' do
   it "should not raise if the page has not the given current_path" do
     expect{@session.assert_no_current_path('/with_html')}.not_to raise_error
   end
+
+  it "should not cause an exception when current_url is nil" do
+    allow_any_instance_of(Capybara::Session).to receive(:current_url) { nil }
+
+    expect{@session.assert_no_current_path('/with_html')}.not_to raise_error
+  end
 end

data/lib/capybara/spec/session/attach_file_spec.rb

@@ -107,4 +107,34 @@ Capybara::SpecHelper.spec "#attach_file" do
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
+
+  context "with :make_visible option", requires: [:js, :es_args] do
+    it "applies a default style change when true" do
+      @session.visit('/with_js')
+      expect { @session.attach_file("hidden_file", __FILE__) }.to raise_error Capybara::ElementNotFound
+      expect {
+        @session.attach_file("hidden_file", __FILE__, make_visible: true)
+      }.not_to raise_error
+    end
+
+    it "accepts a hash of styles to be applied" do
+      @session.visit('/with_js')
+      expect {
+        @session.attach_file("hidden_file", __FILE__, make_visible: { opacity: 1, display: 'block' })
+      }.not_to raise_error
+    end
+
+    it "raises an error when the file input is not made visible" do
+      @session.visit('/with_js')
+      expect {
+        @session.attach_file("hidden_file", __FILE__, make_visible: { color: 'red' })
+      }.to raise_error(Capybara::ExpectationNotMet)
+    end
+
+    it "resets the style when done" do
+      @session.visit('/with_js')
+      @session.attach_file("hidden_file", __FILE__, make_visible: true)
+      expect(@session.evaluate_script("arguments[0].style.display", @session.find(:css, '#hidden_file', visible: :all))).to eq 'none'
+    end
+  end
 end

data/lib/capybara/spec/session/click_link_spec.rb

@@ -105,6 +105,17 @@ Capybara::SpecHelper.spec '#click_link' do
       expect { @session.click_link('labore', href: /invalid_pattern/) }.to raise_error(Capybara::ElementNotFound)
       expect { @session.click_link('labore', href: /.+d+/) }.to raise_error(Capybara::ElementNotFound)
     end
+
+    context 'href: nil' do
+      it "should not raise an error on links with no href attribute" do
+        expect { @session.click_link('No Href', href: nil) }.not_to raise_error
+      end
+
+      it "should raise an error if href attribute exists" do
+        expect { @session.click_link('Blank Href', href: nil) }.to raise_error(Capybara::ElementNotFound)
+        expect { @session.click_link('Normal Anchor', href: nil) }.to raise_error(Capybara::ElementNotFound)
+      end
+    end
   end
 
   it "should follow relative links" do
@@ -161,7 +172,7 @@ Capybara::SpecHelper.spec '#click_link' do
     expect(@session).to have_content('Bar')
   end
 
-  it "raise an error with links with no href" do
+  it "should raise an error with links with no href" do
     expect do
       @session.click_link('No Href')
     end.to raise_error(Capybara::ElementNotFound)

data/lib/capybara/spec/session/current_url_spec.rb

@@ -96,4 +96,12 @@ Capybara::SpecHelper.spec '#current_url, #current_path, #current_host' do
     @session.execute_script("window.history.replaceState({}, '', '/replaced')")
     expect(@session.current_path).to eq("/replaced")
   end
+
+  it "doesn't raise exception on a nil current_url" do
+    @session.visit("/")
+    allow_any_instance_of(Capybara::Session).to receive(:current_url) { nil }
+
+    expect { @session.current_url }.not_to raise_exception
+    expect { @session.current_path }.not_to raise_exception
+  end
 end

data/lib/capybara/spec/session/evaluate_script_spec.rb

@@ -4,4 +4,18 @@ Capybara::SpecHelper.spec "#evaluate_script", requires: [:js] do
     @session.visit('/with_js')
     expect(@session.evaluate_script("1+3")).to eq(4)
   end
+
+  it "should pass arguments to the script", requires: [:js, :es_args] do
+    @session.visit('/with_js')
+    @session.evaluate_script("document.getElementById('change').textContent = arguments[0]", "Doodle Funk")
+    expect(@session).to have_css('#change', text: 'Doodle Funk')
+  end
+
+  it "should support passing elements as arguments to the script", requires: [:js, :es_args] do
+    @session.visit('/with_js')
+    el = @session.find(:css, '#change')
+    @session.evaluate_script("arguments[0].textContent = arguments[1]", el, "Doodle Funk")
+    expect(@session).to have_css('#change', text: 'Doodle Funk')
+  end
+
 end

data/lib/capybara/spec/session/execute_script_spec.rb

@@ -10,4 +10,17 @@ Capybara::SpecHelper.spec "#execute_script", requires: [:js] do
     @session.visit('/with_js')
     expect{ @session.execute_script("$('#change').text('Funky Doodle')") }.not_to raise_error
   end
+
+  it "should pass arguments to the script", requires: [:js, :es_args] do
+    @session.visit('/with_js')
+    @session.execute_script("document.getElementById('change').textContent = arguments[0]", "Doodle Funk")
+    expect(@session).to have_css('#change', text: 'Doodle Funk')
+  end
+
+  it "should support passing elements as arguments to the script", requires: [:js, :es_args] do
+    @session.visit('/with_js')
+    el = @session.find(:css, '#change')
+    @session.execute_script("arguments[1].textContent = arguments[0]", "Doodle Funk", el)
+    expect(@session).to have_css('#change', text: 'Doodle Funk')
+  end
 end

data/lib/capybara/spec/session/fill_in_spec.rb

@@ -100,6 +100,12 @@ Capybara::SpecHelper.spec "#fill_in" do
     expect(extract_results(@session)['password']).to eq('supasikrit')
   end
 
+  it "should fill in a field based on current value" do
+    @session.fill_in(currently_with: 'John', with: 'Thomas')
+    @session.click_button('awesome')
+    expect(extract_results(@session)['first_name']).to eq('Thomas')
+  end
+
   it "should throw an exception if a hash containing 'with' is not provided" do
     expect {@session.fill_in 'Name', 'ignu'}.to raise_error(RuntimeError, /with/)
   end

data/lib/capybara/spec/session/find_field_spec.rb

@@ -62,6 +62,8 @@ Capybara::SpecHelper.spec '#find_field' do
   context "with :disabled option" do
     it "should find disabled fields when true" do
       expect(@session.find_field("Disabled Checkbox", disabled: true)[:name]).to eq("form[disabled_checkbox]")
+      expect(@session.find_field("form_disabled_fieldset_child", disabled: true)[:name]).to eq("form[disabled_fieldset_child]")
+      expect(@session.find_field("form_disabled_fieldset_descendant", disabled: true)[:name]).to eq("form[disabled_fieldset_descendant]")
     end
 
     it "should not find disabled fields when false" do

data/lib/capybara/spec/session/find_spec.rb

@@ -104,11 +104,11 @@ Capybara::SpecHelper.spec '#find' do
     end
   end
 
-  context "with custom selector with :for option" do
-    it "should use the selector when it matches the :for option" do
+  context "with custom selector with custom `match` block" do
+    it "should use the custom selector when locator matches the block" do
       Capybara.add_selector(:beatle) do
         xpath { |num| ".//*[contains(@class, 'beatle')][#{num}]" }
-        match { |value| value.is_a?(Fixnum) }
+        match { |value| value.is_a?(Integer) }
       end
       expect(@session.find(:beatle, '2').text).to eq('Paul')
       expect(@session.find(1).text).to eq('John')

data/lib/capybara/spec/session/frame/switch_to_frame_spec.rb

@@ -0,0 +1,103 @@
+# frozen_string_literal: true
+Capybara::SpecHelper.spec '#switch_to_frame', requires: [:frames] do
+  before(:each) do
+    @session.visit('/within_frames')
+  end
+
+  after(:each) do
+    # Ensure we clean up after the frame changes
+    @session.switch_to_frame(:top)
+  end
+
+  it "should find the div in frameOne" do
+    frame = @session.find(:frame, "frameOne")
+    @session.switch_to_frame(frame)
+    expect(@session.find("//*[@id='divInFrameOne']").text).to eql 'This is the text of divInFrameOne'
+  end
+
+  it "should find the div in FrameTwo" do
+    frame = @session.find(:frame, "frameTwo")
+    @session.switch_to_frame(frame)
+    expect(@session.find("//*[@id='divInFrameTwo']").text).to eql 'This is the text of divInFrameTwo'
+  end
+
+  it "should return to the parent frame when told to" do
+    frame = @session.find(:frame, "frameOne")
+    @session.switch_to_frame(frame)
+    @session.switch_to_frame(:parent)
+    expect(@session.find("//*[@id='divInMainWindow']").text).to eql 'This is the text for divInMainWindow'
+  end
+
+  it "should be able to switch to nested frames" do
+    frame = @session.find(:frame, "parentFrame")
+    @session.switch_to_frame frame
+    frame = @session.find(:frame, "childFrame")
+    @session.switch_to_frame frame
+    frame = @session.find(:frame, "grandchildFrame1")
+    @session.switch_to_frame frame
+    expect(@session).to have_selector(:css, '#divInFrameOne', text: 'This is the text of divInFrameOne')
+  end
+
+  it "should reset scope when changing frames" do
+    frame = @session.find(:frame, 'parentFrame')
+    @session.within(:css, '#divInMainWindow') do
+      @session.switch_to_frame(frame)
+      expect(@session.has_selector?(:css, "iframe#childFrame")).to be true
+      @session.switch_to_frame(:parent)
+    end
+  end
+
+  it "works if the frame is closed", requires: [:frames, :js] do
+    frame = @session.find(:frame, 'parentFrame')
+    @session.switch_to_frame frame
+    frame = @session.find(:frame, 'childFrame')
+    @session.switch_to_frame frame
+
+    @session.click_link 'Close Window'
+    @session.switch_to_frame :parent # Go back to parentFrame
+    expect(@session).to have_selector(:css, 'body#parentBody')
+    expect(@session).not_to have_selector(:css, '#childFrame')
+    @session.switch_to_frame :parent # Go back to top
+  end
+
+  it "can return to the top frame", requires: [:frames] do
+    frame = @session.find(:frame, "parentFrame")
+    @session.switch_to_frame frame
+    frame = @session.find(:frame, "childFrame")
+    @session.switch_to_frame frame
+    @session.switch_to_frame :top
+    expect(@session.find("//*[@id='divInMainWindow']").text).to eql 'This is the text for divInMainWindow'
+  end
+
+  it "should raise error if switching to parent unmatched inside `within` as it's nonsense" do
+    expect do
+      frame = @session.find(:frame, 'parentFrame')
+      @session.switch_to_frame(frame)
+      @session.within(:css, '#parentBody') do
+        @session.switch_to_frame(:parent)
+      end
+    end.to raise_error(Capybara::ScopeError, "`switch_to_frame(:parent)` cannot be called from inside a descendant frame's `within` block.")
+  end
+
+  it "should raise error if switching to top inside a `within` in a frame as it's nonsense" do
+    frame = @session.find(:frame, 'parentFrame')
+    @session.switch_to_frame(frame)
+    @session.within(:css, '#parentBody') do
+      expect do
+        @session.switch_to_frame(:top)
+      end.to raise_error(Capybara::ScopeError, "`switch_to_frame(:top)` cannot be called from inside a descendant frame's `within` block.")
+    end
+  end
+
+  it "should raise error if switching to top inside a nested `within` in a frame as it's nonsense" do
+    frame = @session.find(:frame, 'parentFrame')
+    @session.switch_to_frame(frame)
+    @session.within(:css, '#parentBody') do
+      @session.switch_to_frame(@session.find(:frame, "childFrame"))
+      expect do
+        @session.switch_to_frame(:top)
+      end.to raise_error(Capybara::ScopeError, "`switch_to_frame(:top)` cannot be called from inside a descendant frame's `within` block.")
+      @session.switch_to_frame(:parent)
+    end
+  end
+end

data/lib/capybara/spec/session/{within_frame_spec.rb → frame/within_frame_spec.rb}

@@ -41,6 +41,18 @@ Capybara::SpecHelper.spec '#within_frame', requires: [:frames] do
     end
   end
 
+  it "should find the div given selector and locator" do
+    @session.within_frame(:css, '#frameOne') do
+      expect(@session.find("//*[@id='divInFrameOne']").text).to eql 'This is the text of divInFrameOne'
+    end
+  end
+
+  it "should default to the :frame selector kind when only options passed" do
+    @session.within_frame(name: 'my frame one') do
+      expect(@session.find("//*[@id='divInFrameOne']").text).to eql 'This is the text of divInFrameOne'
+    end
+  end
+
   it "should find multiple nested frames" do
     @session.within_frame 'parentFrame' do
       @session.within_frame 'childFrame' do

data/lib/capybara/spec/session/has_current_path_spec.rb

@@ -52,6 +52,20 @@ Capybara::SpecHelper.spec '#has_current_path?' do
       expect(@session).to have_current_path('/with_js', url: true, only_path: true)
       }. to raise_error ArgumentError
   end
+
+  it "should not raise an exception if the current_url is nil" do
+    allow_any_instance_of(Capybara::Session).to receive(:current_url) { nil }
+
+    # Without only_path option
+    expect {
+      expect(@session).to have_current_path(nil)
+    }. not_to raise_exception
+
+    # With only_path option
+    expect {
+      expect(@session).to have_current_path(nil, only_path: true)
+    }. not_to raise_exception
+  end
 end
 
 Capybara::SpecHelper.spec '#has_no_current_path?' do
@@ -76,4 +90,18 @@ Capybara::SpecHelper.spec '#has_no_current_path?' do
   it "should be true if the page has not the given current_path" do
     expect(@session).to have_no_current_path('/with_html')
   end
+
+  it "should not raise an exception if the current_url is nil" do
+    allow_any_instance_of(Capybara::Session).to receive(:current_url) { nil }
+
+    # Without only_path option
+    expect {
+      expect(@session).not_to have_current_path('/with_js')
+    }. not_to raise_exception
+
+    # With only_path option
+    expect {
+      expect(@session).not_to have_current_path('/with_js', only_path: true)
+    }. not_to raise_exception
+  end
 end

data/lib/capybara/spec/session/has_selector_spec.rb

@@ -77,6 +77,27 @@ Capybara::SpecHelper.spec '#has_selector?' do
       expect(@session).to have_selector(:css, "p a#foo", 'extra')
     end
   end
+
+  context "with exact_text" do
+    context "string" do
+      it "should only match elements that match exactly" do
+        expect(@session).to have_selector(:id, "h2one", exact_text: "Header Class Test One")
+        expect(@session).to have_no_selector(:id, "h2one", exact_text: "Header Class Test")
+      end
+    end
+
+    context "boolean" do
+      it "should only match elements that match exactly when true" do
+        expect(@session).to have_selector(:id, "h2one", text: "Header Class Test One", exact_text: true)
+        expect(@session).to have_no_selector(:id, "h2one", text: "Header Class Test", exact_text: true)
+      end
+
+      it "should match substrings when false" do
+        expect(@session).to have_selector(:id, "h2one", text: "Header Class Test One", exact_text: false)
+        expect(@session).to have_selector(:id, "h2one", text: "Header Class Test", exact_text: false)
+      end
+    end
+  end
 end
 
 Capybara::SpecHelper.spec '#has_no_selector?' do

data/lib/capybara/spec/session/has_text_spec.rb

@@ -96,6 +96,18 @@ Capybara::SpecHelper.spec '#has_text?' do
     expect(@session).not_to have_text(/xxxxyzzz/)
   end
 
+  context "with exact: true option" do
+    it "should be true if text matches exactly" do
+      @session.visit('/with_html')
+      expect(@session.find(:id, "h2one")).to have_text("Header Class Test One", exact: true)
+    end
+
+    it "should be false if text doesn't match exactly" do
+      @session.visit('/with_html')
+      expect(@session.find(:id, "h2one")).not_to have_text("Header Class Test On", exact: true)
+    end
+  end
+
   it "should escape any characters that would have special meaning in a regexp" do
     @session.visit('/with_html')
     expect(@session).not_to have_text('.orem')
@@ -205,7 +217,7 @@ Capybara::SpecHelper.spec '#has_text?' do
   it "should raise an error if an invalid option is passed" do
     @session.visit('/with_html')
     expect do
-      expect(@session).to have_text('Lorem', exact: true)
+      expect(@session).to have_text('Lorem', invalid: true)
     end.to raise_error(ArgumentError)
   end
 end

data/lib/capybara/spec/session/has_title_spec.rb

@@ -21,6 +21,21 @@ Capybara::SpecHelper.spec '#has_title?' do
   it "should be false if the page has not the given title" do
     expect(@session).not_to have_title('monkey')
   end
+
+  it "should default to exact: false matching" do
+    expect(@session).to have_title('with_js', exact: false)
+    expect(@session).to have_title('with_', exact: false)
+  end
+
+  it "should match exactly if exact: true option passed" do
+    expect(@session).to have_title('with_js', exact: true)
+    expect(@session).not_to have_title('with_', exact: true)
+  end
+
+  it "should match partial if exact: false option passed" do
+    expect(@session).to have_title('with_js', exact: false)
+    expect(@session).to have_title('with_', exact: false)
+  end
 end
 
 Capybara::SpecHelper.spec '#has_no_title?' do

data/lib/capybara/spec/session/node_spec.rb

@@ -135,7 +135,7 @@ Capybara::SpecHelper.spec "node" do
     end
 
     it 'should allow me to change the contents of a contenteditable elements child', requires: [:js] do
-      pending "Selenium doesn't like editing nested contents"
+      pending "Selenium doesn't like editing nested contents" if @session.respond_to?(:mode) && @session.mode.to_s =~ /^selenium_/
       @session.visit('/with_js')
       @session.find(:css,'#existing_content_editable_child').set('WYSIWYG')
       expect(@session.find(:css,'#existing_content_editable_child').text).to eq('WYSIWYG')
@@ -166,9 +166,35 @@ Capybara::SpecHelper.spec "node" do
     it "should see enabled options in disabled select as disabled" do
       @session.visit('/form')
       expect(@session.find('//select[@id="form_disabled_select"]/option')).to be_disabled
+      expect(@session.find('//select[@id="form_disabled_select"]/optgroup/option')).to be_disabled
       expect(@session.find('//select[@id="form_title"]/option[1]')).not_to be_disabled
     end
 
+    it "should see enabled options in disabled optgroup as disabled" do
+      @session.visit('/form')
+      expect(@session.find('//option', text: "A.B.1")).to be_disabled
+      expect(@session.find('//option', text: "A.2")).not_to be_disabled
+    end
+
+    context "in a disabled fieldset" do
+      # https://html.spec.whatwg.org/#the-fieldset-element
+      it "should see elements not in first legend as disabled" do
+        @session.visit('/form')
+        expect(@session.find('//input[@id="form_disabled_fieldset_child"]')).to be_disabled
+        expect(@session.find('//input[@id="form_disabled_fieldset_second_legend_child"]')).to be_disabled
+        expect(@session.find('//input[@id="form_enabled_fieldset_child"]')).not_to be_disabled
+      end
+
+      it "should see elements in first legend as enabled" do
+        @session.visit('/form')
+        expect(@session.find('//input[@id="form_disabled_fieldset_legend_child"]')).not_to be_disabled
+      end
+
+      it "should sees options not in first legend as disabled" do
+        @session.visit('/form')
+        expect(@session.find('//option', text: 'Disabled Child Option')).to be_disabled
+      end
+    end
     it "should be boolean" do
       @session.visit('/form')
       expect(@session.find('//select[@id="form_disabled_select"]/option').disabled?).to be true
@@ -263,6 +289,7 @@ Capybara::SpecHelper.spec "node" do
 
   describe '#drag_to', requires: [:js, :drag] do
     it "should drag and drop an object" do
+      pending "selenium-webdriver/geckodriver doesn't support mouse move_to" if marionette?(@session)
       @session.visit('/with_js')
       element = @session.find('//div[@id="drag"]')
       target = @session.find('//div[@id="drop"]')
@@ -273,6 +300,7 @@ Capybara::SpecHelper.spec "node" do
 
   describe '#hover', requires: [:hover] do
     it "should allow hovering on an element" do
+      pending "selenium-webdriver/geckodriver doesn't support mouse move_to" if marionette?(@session)
       @session.visit('/with_hover')
       expect(@session.find(:css,'.hidden_until_hover', visible: false)).not_to be_visible
       @session.find(:css,'.wrapper').hover
@@ -289,6 +317,7 @@ Capybara::SpecHelper.spec "node" do
 
   describe '#double_click', requires: [:js] do
     it "should double click an element" do
+      pending "selenium-webdriver/geckodriver doesn't support mouse move_to" if marionette?(@session)
       @session.visit('/with_js')
       @session.find(:css, '#click-test').double_click
       expect(@session.find(:css, '#has-been-double-clicked')).to be
@@ -297,6 +326,7 @@ Capybara::SpecHelper.spec "node" do
 
   describe '#right_click', requires: [:js] do
     it "should right click an element" do
+      pending "selenium-webdriver/geckodriver doesn't support mouse move_to" if marionette?(@session)
       @session.visit('/with_js')
       @session.find(:css, '#click-test').right_click
       expect(@session.find(:css, '#has-been-right-clicked')).to be
@@ -311,18 +341,21 @@ Capybara::SpecHelper.spec "node" do
     end
 
     it "should send special characters" do
+      pending "selenium-webdriver/geckodriver doesn't support complex sets of characters" if marionette?(@session)
       @session.visit('/form')
       @session.find(:css, '#address1_city').send_keys('Ocean', :space, 'sie', :left, 'd')
       expect(@session.find(:css, '#address1_city').value).to eq 'Ocean side'
     end
 
     it "should allow for multiple simultaneous keys" do
+      pending "selenium-webdriver/geckodriver doesn't support complex sets of characters" if marionette?(@session)
       @session.visit('/form')
       @session.find(:css, '#address1_city').send_keys([:shift, 'o'], 'ceanside')
       expect(@session.find(:css, '#address1_city').value).to eq 'Oceanside'
     end
 
     it "should generate key events", requires: [:send_keys, :js] do
+      pending "selenium-webdriver/geckodriver doesn't support complex sets of characters" if marionette?(@session)
       @session.visit('/with_js')
       @session.find(:css, '#with-key-events').send_keys([:shift,'t'], [:shift,'w'])
       expect(@session.find(:css, '#key-events-output')).to have_text('keydown:16 keydown:84 keydown:16 keydown:87')