capybara 2.1.0 → 2.2.0

data/lib/capybara/spec/session/node_spec.rb

@@ -58,10 +58,25 @@ Capybara::SpecHelper.spec "node" do
       @session.find('//textarea[@id="additional_newline"]').value.should == "\nbanana"
     end
 
+    it "should not swallow leading newlines for set content in textarea" do
+      @session.find('//textarea[@id="normal"]').set("\nbanana")
+      @session.find('//textarea[@id="normal"]').value.should == "\nbanana"
+    end
+
     it "return any HTML content in textarea" do
       @session.find('//textarea[1]').set("some <em>html</em> here")
       @session.find('//textarea[1]').value.should == "some <em>html</em> here"
     end
+    
+    it "defaults to 'on' for checkbox" do
+      @session.visit('/form')
+      @session.find('//input[@id="valueless_checkbox"]').value.should == 'on'
+    end
+
+    it "defaults to 'on' for radio buttons" do
+      @session.visit('/form')
+      @session.find('//input[@id="valueless_radio"]').value.should == 'on'
+    end    
   end
 
   describe "#set" do
@@ -88,6 +103,25 @@ Capybara::SpecHelper.spec "node" do
       @session.first('//textarea[@readonly]').set('changed')
       @session.first('//textarea[@readonly]').value.should == 'textarea should not change'
     end
+
+    it 'should allow me to change the contents of a contenteditable element', :requires => [:js] do
+      @session.visit('/with_js')
+      @session.find(:css,'#existing_content_editable').set('WYSIWYG')
+      @session.find(:css,'#existing_content_editable').text.should == 'WYSIWYG'
+    end
+
+    it 'should allow me to set the contents of a contenteditable element', :requires => [:js] do
+      @session.visit('/with_js')
+      @session.find(:css,'#blank_content_editable').set('WYSIWYG')
+      @session.find(:css,'#blank_content_editable').text.should == 'WYSIWYG'
+    end
+
+    it 'should allow me to change the contents of a contenteditable elements child', :requires => [:js] do
+      pending "Selenium doesn't like editing nested contents"
+      @session.visit('/with_js')
+      @session.find(:css,'#existing_content_editable_child').set('WYSIWYG')
+      @session.find(:css,'#existing_content_editable_child').text.should == 'WYSIWYG'
+    end
   end
 
   describe "#tag_name" do
@@ -125,6 +159,8 @@ Capybara::SpecHelper.spec "node" do
 
       @session.find('//div[@id="hidden"]').should_not be_visible
       @session.find('//div[@id="hidden_via_ancestor"]').should_not be_visible
+      @session.find('//div[@id="hidden_attr"]').should_not be_visible
+      @session.find('//a[@id="hidden_attr_via_ancestor"]').should_not be_visible
     end
   end
 
@@ -178,7 +214,6 @@ Capybara::SpecHelper.spec "node" do
 
   describe '#hover', :requires => [:hover] do
     it "should allow hovering on an element" do
-      pending "Selenium with firefox doesn't currently work with this (selenium with chrome does)" if @session.respond_to?(:mode) && @session.mode == :selenium && @session.driver.browser.browser == :firefox
       @session.visit('/with_hover')
       @session.find(:css,'.hidden_until_hover', :visible => false).should_not be_visible
       @session.find(:css,'.wrapper').hover

data/lib/capybara/spec/session/reset_session_spec.rb

@@ -16,9 +16,18 @@ Capybara::SpecHelper.spec '#reset_session!' do
     @session.current_path.should == '/foo'
 
     @session.reset_session!
-    [nil, '', 'about:blank'].should include @session.current_url
+    [
+      ->(v) { v == nil },
+      ->(v) { v == '' },
+      ->(v) { v == 'about:blank' },
+      ->(v) { v.end_with? Capybara::EMPTY_HTML_FILE_PATH } # allow file:// protocol
+    ].any? { |p| p.(@session.current_url) }.should be_true
+    [
+      ->(v) { v == '' },
+      ->(v) { v == nil },
+      ->(v) { v == Capybara::EMPTY_HTML_FILE_PATH }
+    ].any? { |p| p.(@session.current_path) }.should be_true
     @session.current_host.should be_nil
-    @session.current_path.should be_nil
   end
 
   it "resets page body" do
@@ -31,6 +40,12 @@ Capybara::SpecHelper.spec '#reset_session!' do
     @session.should have_no_selector('.//h1')
   end
 
+  it "is synchronous" do
+    @session.visit("/with_html")
+    @session.reset_session!
+    @session.should have_no_selector :xpath, "/html/body/*", wait: false
+  end
+
   it "raises any errors caught inside the server", :requires => [:server] do
     quietly { @session.visit("/error") }
     expect do

data/lib/capybara/spec/session/save_page_spec.rb

@@ -37,11 +37,17 @@ Capybara::SpecHelper.spec '#save_page' do
     File.read("capybara-001122.html").should include("Another World")
   end
 
-  it "returns the filename" do
+  it "returns an absolute path in pwd" do
     result = @session.save_page
-    path = Dir.glob("capybara-*.html").first
-    filename = path.split("/").last
-    result.should == filename
+    path = File.expand_path(Dir.glob("capybara-*.html").first, Dir.pwd)
+    result.should == path
+  end
+
+  it "returns an absolute path in given directory" do
+    Capybara.save_and_open_page_path = alternative_path
+    result = @session.save_page
+    path = File.expand_path(Dir.glob(alternative_path + "/capybara-*.html").first, alternative_path)
+    result.should == path
   end
 
   context "asset_host contains a string" do

data/lib/capybara/spec/session/visit_spec.rb

@@ -17,6 +17,15 @@ Capybara::SpecHelper.spec '#visit' do
     @session.should have_content('Another World')
   end
 
+  it "should fetch a response when absolute URI doesn't have a trailing slash" do
+    # Preparation
+    @session.visit('/foo/bar')
+    root_uri = URI.parse(@session.current_url)
+
+    @session.visit("http://localhost:#{root_uri.port}")
+    @session.should have_content('Hello world!')
+  end
+
   context "when Capybara.always_include_port is true" do
 
     let(:root_uri) do
@@ -86,4 +95,11 @@ Capybara::SpecHelper.spec '#visit' do
     @session.find('//input').click
     @session.should have_content %r{http://.*/referer_base}
   end
+
+  it "can set cookie if a blank path is specified" do
+    @session.visit("")
+    @session.visit('/get_cookie')
+    @session.should have_content('root cookie')
+  end
+
 end

data/lib/capybara/spec/session/within_frame_spec.rb

@@ -42,4 +42,11 @@ Capybara::SpecHelper.spec '#within_frame', :requires => [:frames] do
       end    
     end
   end
+  it "should reset scope when changing frames" do
+    @session.within(:css, '#divInMainWindow') do
+      @session.within_frame 'parentFrame' do
+        @session.has_selector?(:css, "iframe#childFrame").should be_true
+      end
+    end
+  end
 end

data/lib/capybara/spec/session/within_window_spec.rb

@@ -35,4 +35,11 @@ Capybara::SpecHelper.spec '#within_window', :requires => [:windows] do
     end
     @session.find("//*[@id='divInMainWindow']").text.should eql 'This is the text for divInMainWindow'
   end
+  it "should reset scope when switching windows" do
+    @session.within(:css, '#divInMainWindow') do
+      @session.within_window("secondPopup") do
+        @session.find("//*[@id='divInPopupTwo']").text.should eql 'This is the text of divInPopupTwo'
+      end
+    end
+  end
 end

data/lib/capybara/spec/test_app.rb

@@ -13,6 +13,7 @@ class TestApp < Sinatra::Base
   # Also check lib/capybara/spec/views/*.erb for pages not listed here
 
   get '/' do
+    response.set_cookie('capybara', { value: 'root cookie', domain: request.host, path: request.path} )
     'Hello world! <a href="with_html">Relative</a>'
   end
 

data/lib/capybara/spec/views/form.erb

@@ -136,6 +136,14 @@
     <textarea name="form[description]" id="form_description">Descriptive text goes here</textarea>
   <p>
 
+  <p>
+    <label for="form_newline">NewLine</label></br>
+    <textarea name="form[newline]" id="form_newline">
+
+New line after and before textarea tag
+</textarea>
+  </p>
+
   <p>
     <input type="radio" name="form[gender]" value="male" id="gender_male"/>
     <label for="gender_male">Male</label>
@@ -153,6 +161,13 @@
     <input type="checkbox" value="hamster" name="form[pets][]" id="form_pets_hamster" checked="checked"/>
     <label for="form_pets_hamster">Hamster</label>
   </p>
+  
+  <p>
+    <input type="checkbox" name="form[valueless_checkbox]" id="valueless_checkbox" checked="checked"/>
+    <label for="valueless_checkbox">Valueless Checkbox</label>
+    <input type="radio" name="form[valueless_radio]" id="valueless_radio" checked="checked"/>
+    <label for="valueless_radio">Valueless Radio</label>
+  </p>
 
   <p>
     <label for="form_languages">Languages</label>
@@ -234,6 +249,13 @@
     </label>
   </p>
 
+  <p>
+    <label for="form_disabled_unchecked_checkbox">
+      Disabled Unchecked Checkbox
+      <input type="checkbox" name="form[disabled_unchecked_checkbox]" value="Should not see me" id="form_disabled_unchecked_checkbox" disabled="disabled" />
+    </label>
+  </p>
+
   <p>
     <label for="form_disabled_radio">
       Disabled Radio
@@ -283,6 +305,8 @@
   <button type="submit" name="form[other_form_button]" value="other_form_button" form="form1">Form1</button>
 </form>
 
+<button type="submit" name="form[no_form_button]" value="no_form_button">No Form</button>
+
 <textarea name="form[outside_textarea]" form="form1">Some text here</textarea>
 <select name="form[outside_select]" form="form1">
   <option>Lisp</option>
@@ -317,6 +341,20 @@
   <p>
 </form>
 
+<form action="/upload_empty" method="post" enctype="multipart/form-data">
+  <p>
+    <label>
+      <input type="file" name="form[file]" multiple="multiple"/>
+      Multiple empty files
+    </label>
+  </p>
+
+  <p>
+    <input type="hidden" name="form[dummy]" value="ensure params[:form] exists"/>
+    <input type="submit" value="Upload Empty Multiple"/>
+  <p>
+</form>
+
 <form action="/upload" method="post" enctype="multipart/form-data">
   <p>
     <label for="form_file_name">File Name</label>
@@ -402,3 +440,5 @@
     <input type="submit" name="form[no_action]" value="No Action" />
   </p>
 </form>
+
+

data/lib/capybara/spec/views/with_html.erb

@@ -66,6 +66,11 @@ banana</textarea>
   <a href="/with_simple_html" title="hidden link" class="simple">hidden link</a>
 </div>
 
+<div id="hidden_attr" hidden="hidden">
+  <a id="hidden_attr_via_ancestor">hidden attribute ancestor link</a>
+</div>
+
+
 <div id="hidden-text">
   Some of this text is <em style="display:none">hidden!</em>
 </div>

data/lib/capybara/spec/views/with_js.erb

@@ -36,6 +36,14 @@
       <input type="text" name="with_change_event" value="default value" id="with_change_event"/>
     </p>
 
+    <p>
+      <div contenteditable='true' id='existing_content_editable'>Editable content</div>
+      <div contenteditable='true' id='blank_content_editable' style='height: 1em;'></div>
+      <div contenteditable='true' style='height: 1em;'>
+        <div id='existing_content_editable_child' style='height: 1em;'>Content</div>
+      </div>
+    </p>
+
     <p>
       <input type="checkbox" id="checkbox_with_event"/>
     </p>

data/lib/capybara/version.rb

@@ -1,3 +1,3 @@
 module Capybara
-  VERSION = '2.1.0'
+  VERSION = '2.2.0'
 end

data/lib/capybara.rb

@@ -14,12 +14,14 @@ module Capybara
   class NotSupportedByDriverError < CapybaraError; end
   class InfiniteRedirectError < CapybaraError; end
 
+  EMPTY_HTML_FILE_PATH = File.expand_path('./capybara/empty.html', File.dirname(__FILE__))
+
   class << self
     attr_accessor :asset_host, :app_host, :run_server, :default_host, :always_include_port
-    attr_accessor :server_host, :server_port, :exact, :match, :exact_options, :visible_text_only
+    attr_accessor :server_port, :exact, :match, :exact_options, :visible_text_only
     attr_accessor :default_selector, :default_wait_time, :ignore_hidden_elements
     attr_accessor :save_and_open_page_path, :automatic_reload, :raise_server_errors
-    attr_writer :default_driver, :current_driver, :javascript_driver, :session_name
+    attr_writer :default_driver, :current_driver, :javascript_driver, :session_name, :server_host
     attr_accessor :app
 
     ##
@@ -166,7 +168,7 @@ module Capybara
     #
     def run_default_server(app, port)
       require 'rack/handler/webrick'
-      Rack::Handler::WEBrick.run(app, :Port => port, :AccessLog => [], :Logger => WEBrick::Log::new(nil, 0))
+      Rack::Handler::WEBrick.run(app, :Host => server_host, :Port => port, :AccessLog => [], :Logger => WEBrick::Log::new(nil, 0))
     end
 
     ##
@@ -214,6 +216,14 @@ module Capybara
       @current_driver = previous_driver
     end
 
+    ##
+    #
+    # @return [String]    The IP address bound by default server
+    #
+    def server_host
+      @server_host || '127.0.0.1'
+    end
+
     ##
     #
     # Yield a block using a specific wait time
@@ -267,6 +277,21 @@ module Capybara
       self.session_name = :default
     end
 
+    ##
+    #
+    # Parse raw html into a document using Nokogiri, and adjust textarea contents as defined by the spec.
+    #
+    # @param [String] html              The raw html
+    # @return [Nokogiri::HTML::Document]      HTML document
+    #
+    def HTML(html)
+      Nokogiri::HTML(html).tap do |document|
+        document.xpath('//textarea').each do |textarea|
+          textarea.content=textarea.content.sub(/\A\n/,'')
+        end
+      end
+    end
+
     def included(base)
       base.send(:include, Capybara::DSL)
       warn "`include Capybara` is deprecated. Please use `include Capybara::DSL` instead."

data/spec/capybara_spec.rb

@@ -31,7 +31,7 @@ describe Capybara do
     end
 
     it "should default to a proc that calls run_default_server" do
-      mock_app = mock('app')
+      mock_app = double('app')
       Capybara.should_receive(:run_default_server).with(mock_app, 8000)
       Capybara.server.call(mock_app, 8000)
     end

data/spec/result_spec.rb

@@ -28,6 +28,10 @@ describe Capybara::Result do
     result.last.text == 'Delta'
   end
 
+  it 'can supports values_at method' do
+    result.values_at(0, 2).map(&:text).should == %w(Alpha Gamma)
+  end
+
   it "can return an element by its index" do
     result.at(1).text.should == 'Beta'
     result[2].text.should == 'Gamma'
@@ -48,4 +52,14 @@ describe Capybara::Result do
       memo += element.text[0]
     end.should == 'ABGD'
   end
+
+  it 'can be sampled' do
+    result.should include(result.sample)
+  end
+
+  it 'can be indexed' do
+    result.index do |el|
+      el.text == 'Gamma'
+    end.should == 2
+  end
 end

data/spec/rspec/features_spec.rb

@@ -34,6 +34,21 @@ feature "Capybara's feature DSL" do
   scenario "doesn't pollute the Object namespace" do
     Object.new.respond_to?(:feature, true).should be_false
   end
+
+  feature 'nested features' do
+    scenario 'work as expected' do
+      visit '/'
+      page.should have_content 'Hello world!'
+    end
+
+    scenario 'are marked in the metadata as capybara_feature' do
+      example.metadata[:capybara_feature].should be_true
+    end
+
+    scenario 'have a type of :feature' do
+      example.metadata[:type].should eq :feature
+    end
+  end
 end
 
 feature "given and given! aliases to let and let!" do

data/spec/rspec/matchers_spec.rb

@@ -519,21 +519,44 @@ describe Capybara::RSpecMatchers do
   end
 
   describe "have_field matcher" do
-    let(:html) { '<p><label>Text field<input type="text"/></label></p>' }
+    let(:html) { '<p><label>Text field<input type="text" value="some value"/></label></p>' }
 
     it "gives proper description" do
       have_field('Text field').description.should == "have field \"Text field\""
     end
 
+    it "gives proper description for a given value" do
+      have_field('Text field', with: 'some value').description.should == "have field \"Text field\" with value \"some value\""
+    end
+
     it "passes if there is such a field" do
       html.should have_field('Text field')
     end
 
+    it "passes if there is such a field with value" do
+      html.should have_field('Text field', with: 'some value')
+    end
+
     it "fails if there is no such field" do
       expect do
         html.should have_field('No such Field')
       end.to raise_error(/expected to find field "No such Field"/)
     end
+
+    it "fails if there is such field but with false value" do
+      expect do
+        html.should have_field('Text field', with: 'false value')
+      end.to raise_error(/expected to find field "Text field"/)
+    end
+
+    it "treats a given value as a string" do
+      class Foo
+        def to_s
+          "some value"
+        end
+      end
+      html.should have_field('Text field', with: Foo.new)
+    end
   end
 
   describe "have_checked_field matcher" do

data/spec/selenium_spec.rb

@@ -1,7 +1,14 @@
 require 'spec_helper'
+require "selenium-webdriver"
+
+Capybara.register_driver :selenium_focus do |app|
+  profile = Selenium::WebDriver::Firefox::Profile.new
+  profile["focusmanager.testmode"] = true
+  Capybara::Selenium::Driver.new(app, browser: :firefox, profile: profile)
+end
 
 module TestSessions
-  Selenium = Capybara::Session.new(:selenium, TestApp)
+  Selenium = Capybara::Session.new(:selenium_focus, TestApp)
 end
 
 Capybara::SpecHelper.run_specs TestSessions::Selenium, "selenium", :skip => [
@@ -24,7 +31,7 @@ describe Capybara::Session do
 
     describe '#mode' do
       it "should remember the mode" do
-        @session.mode.should == :selenium
+        @session.mode.should == :selenium_focus
       end
     end
 

data/spec/selenium_spec_chrome.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+Capybara.register_driver :selenium_chrome do |app|
+  args = ENV['TRAVIS'] ? ['no-sandbox' ] : []
+  Capybara::Selenium::Driver.new(app, :browser => :chrome, :args => args)
+end
+
+class ChromeTestApp < TestApp
+  # Object.id is different from the TestApp used in firefox session so 
+  # a new Capybar::Server instance will get launched for chrome testing
+end
+
+module TestSessions
+  Chrome = Capybara::Session.new(:selenium_chrome, ChromeTestApp)
+end
+
+Capybara::SpecHelper.run_specs TestSessions::Chrome, "selenium_chrome", :skip => [
+  :response_headers,
+  :status_code,
+  :trigger  
+]

data/spec/server_spec.rb

@@ -18,13 +18,21 @@ describe Capybara::Server do
   end
 
   it "should bind to the specified host" do
-    Capybara.server_host = '0.0.0.0'
+    begin
+      app = proc { |env| [200, {}, ['Hello Server!']] }
 
-    app = proc { |env| [200, {}, ["Hello Server!"]]}
-    server = Capybara::Server.new(app).boot
-    server.host.should == '0.0.0.0'
+      Capybara.server_host = '127.0.0.1'
+      server = Capybara::Server.new(app).boot
+      res = Net::HTTP.get(URI("http://127.0.0.1:#{server.port}"))
+      expect(res).to eq('Hello Server!')
 
-    Capybara.server_host = nil
+      Capybara.server_host = '0.0.0.0'
+      server = Capybara::Server.new(app).boot
+      res = Net::HTTP.get(URI("http://127.0.0.1:#{server.port}"))
+      expect(res).to eq('Hello Server!')
+    ensure
+      Capybara.server_host = nil
+    end
   end
 
   it "should use specified port" do