capybara 2.1.0 → 2.2.0.rc1

data/lib/capybara/spec/session/assert_selector.rb

@@ -58,6 +58,16 @@ Capybara::SpecHelper.spec '#assert_selector' do
       expect { @session.assert_selector("//p//a", :text => /Red$/) }.to raise_error(Capybara::ElementNotFound)
     end
   end
+
+  context "with wait", :requires => [:js] do
+    it "should find element if it appears before given wait duration" do
+      Capybara.using_wait_time(0.1) do
+        @session.visit('/with_js')
+        @session.click_link('Click me')
+        @session.assert_selector(:css, "a#has-been-clicked", :text => "Has been clicked", :wait => 0.9)
+      end
+    end
+  end
 end
 
 Capybara::SpecHelper.spec '#assert_no_selector' do
@@ -120,4 +130,12 @@ Capybara::SpecHelper.spec '#assert_no_selector' do
       @session.assert_no_selector("//p//a", :text => /Red$/)
     end
   end
+
+  context "with wait", :requires => [:js] do
+    it "should not find element if it appears after given wait duration" do
+      @session.visit('/with_js')
+      @session.click_link('Click me')
+      @session.assert_no_selector(:css, "a#has-been-clicked", :text => "Has been clicked", :wait => 0.1)
+    end
+  end
 end

data/lib/capybara/spec/session/attach_file_spec.rb

@@ -71,6 +71,11 @@ Capybara::SpecHelper.spec "#attach_file" do
       @session.body.should include(File.read(@test_file_path))
       @session.body.should include(File.read(@another_test_file_path))
     end
+
+    it "should not send anything when attaching no files to a multiple upload field" do
+      @session.click_button('Upload Empty Multiple')
+      @session.body.should include("Successfully ignored empty file field")
+    end
   end
 
   context "with a locator that doesn't exist" do

data/lib/capybara/spec/session/check_spec.rb

@@ -96,4 +96,18 @@ Capybara::SpecHelper.spec "#check" do
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
+
+  context "with `option` option" do
+    it "can check boxes by their value" do
+      @session.check('form[pets][]', :option => "cat")
+      @session.click_button('awesome')
+      extract_results(@session)['pets'].should include('cat')
+    end
+
+    it "should raise an error if option not found" do
+      expect do
+        @session.check('form[pets][]', :option => "elephant")
+      end.to raise_error(Capybara::ElementNotFound)
+    end
+  end
 end

data/lib/capybara/spec/session/choose_spec.rb

@@ -51,4 +51,18 @@ Capybara::SpecHelper.spec "#choose" do
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
+
+  context "with `option` option" do
+    it "can check radio buttons by their value" do
+      @session.choose('form[gender]', :option => "male")
+      @session.click_button('awesome')
+      extract_results(@session)['gender'].should == "male"
+    end
+
+    it "should raise an error if option not found" do
+      expect do
+        @session.choose('form[gender]', :option => "hermaphrodite")
+      end.to raise_error(Capybara::ElementNotFound)
+    end
+  end
 end

data/lib/capybara/spec/session/click_button_spec.rb

@@ -102,10 +102,18 @@ Capybara::SpecHelper.spec '#click_button' do
         @results['gender'].should == 'female'
       end
 
+      it "should default radio value to 'on' if none specified" do
+        @results['valueless_radio'].should == 'on'
+      end
+
       it "should serialize check boxes" do
         @results['pets'].should include('dog', 'hamster')
         @results['pets'].should_not include('cat')
       end
+      
+      it "should default checkbox value to 'on' if none specififed" do
+        @results['valueless_checkbox'].should == 'on'
+      end
 
       it "should serialize text areas" do
         @results['description'].should == 'Descriptive text goes here'
@@ -126,7 +134,11 @@ Capybara::SpecHelper.spec '#click_button' do
       it "should not serialize a select tag without options" do
         @results['tendency'].should be_nil
       end
-
+      
+      it "should convert lf to cr/lf in submitted textareas" do
+        @results['newline'].should == "\r\nNew line after and before textarea tag\r\n"
+      end
+      
       it "should not submit disabled fields" do
         @results['disabled_text_field'].should be_nil
         @results['disabled_textarea'].should be_nil
@@ -225,6 +237,12 @@ Capybara::SpecHelper.spec '#click_button' do
     end
   end
 
+  context "with submit button not associated with any form" do
+    it "should not error when clicked" do
+      lambda { @session.click_button('no_form_button') }.should_not raise_error
+    end
+  end
+
   context "with alt given on an image button" do
     it "should submit the associated form" do
       @session.click_button('oh hai thar')
@@ -236,6 +254,7 @@ Capybara::SpecHelper.spec '#click_button' do
       extract_results(@session)['first_name'].should == 'John'
     end
   end
+  
 
   context "with value given on an image button" do
     it "should submit the associated form" do

data/lib/capybara/spec/session/fill_in_spec.rb

@@ -57,6 +57,12 @@ Capybara::SpecHelper.spec "#fill_in" do
     extract_results(@session)['description'].should == 'is <strong>very</strong> secret!'
   end
 
+  it "should handle newlines in a textarea", tw: true do
+    @session.fill_in('form_description', :with => "\nSome text\n")
+    @session.click_button('awesome')
+    extract_results(@session)['description'].should == "\r\nSome text\r\n"
+  end
+
   it "should fill in a field with a custom type" do
     @session.fill_in('Schmooo', :with => 'Schmooo is the game')
     @session.click_button('awesome')
@@ -109,7 +115,7 @@ Capybara::SpecHelper.spec "#fill_in" do
     extract_results(@session)['first_name'].should == 'Harry'
   end
 
-  it "casts to string if field has maxlength", :focus => true do
+  it "casts to string if field has maxlength" do
     @session.fill_in(:'form_zipcode', :with => 1234567)
     @session.click_button('awesome')
     extract_results(@session)['zipcode'].should == '12345'
@@ -119,7 +125,17 @@ Capybara::SpecHelper.spec "#fill_in" do
     it 'should only trigger onchange once' do
       @session.visit('/with_js')
       @session.fill_in('with_change_event', :with => 'some value')
-      @session.find(:css, '#with_change_event').value.should == 'some value'
+      # click outside the field to trigger the change event
+      @session.find(:css, 'body').click
+      @session.find(:css, '.change_event_triggered', :match => :one).should have_text 'some value'
+    end
+
+    it 'should trigger change when clearing field' do
+      @session.visit('/with_js')
+      @session.fill_in('with_change_event', :with => '')
+      # click outside the field to trigger the change event
+      @session.find(:css, 'body').click
+      @session.should have_selector(:css, '.change_event_triggered', :match => :one)
     end
   end
 

data/lib/capybara/spec/session/go_back_spec.rb

@@ -0,0 +1,10 @@
+Capybara::SpecHelper.spec '#go_back', :requires => [:js] do
+  it "should fetch a response from the driver from the previous page" do
+    @session.visit('/')
+    @session.should have_content('Hello world!')
+    @session.visit('/foo')
+    @session.should have_content('Another World')
+    @session.go_back
+    @session.should have_content('Hello world!')
+  end
+end

data/lib/capybara/spec/session/go_forward_spec.rb

@@ -0,0 +1,12 @@
+Capybara::SpecHelper.spec '#go_forward', :requires => [:js] do
+  it "should fetch a response from the driver from the previous page" do
+    @session.visit('/')
+    @session.should have_content('Hello world!')
+    @session.visit('/foo')
+    @session.should have_content('Another World')
+    @session.go_back
+    @session.should have_content('Hello world!')
+    @session.go_forward
+    @session.should have_content('Another World')
+  end
+end

data/lib/capybara/spec/session/has_button_spec.rb

@@ -9,9 +9,21 @@ Capybara::SpecHelper.spec '#has_button?' do
     @session.should have_button(:'crap321')
   end
 
+  it "should be true for disabled buttons if :disabled => true" do
+    @session.should have_button('Disabled button', :disabled => true)
+  end
+
   it "should be false if the given button is not on the page" do
     @session.should_not have_button('monkey')
   end
+
+  it "should be false for disabled buttons by default" do
+    @session.should_not have_button('Disabled button')
+  end
+
+  it "should be false for disabled buttons if :disabled => false" do
+    @session.should_not have_button('Disabled button', :disabled => false)
+  end
 end
 
 Capybara::SpecHelper.spec '#has_no_button?' do
@@ -24,7 +36,19 @@ Capybara::SpecHelper.spec '#has_no_button?' do
     @session.should_not have_no_button('crap321')
   end
 
+  it "should be true for disabled buttons if :disabled => true" do
+    @session.should_not have_no_button('Disabled button', :disabled => true)
+  end
+
   it "should be false if the given button is not on the page" do
     @session.should have_no_button('monkey')
   end
+
+  it "should be false for disabled buttons by default" do
+    @session.should have_no_button('Disabled button')
+  end
+
+  it "should be false for disabled buttons if :disabled => false" do
+    @session.should have_no_button('Disabled button', :disabled => false)
+  end
 end

data/lib/capybara/spec/session/has_field_spec.rb

@@ -121,6 +121,10 @@ Capybara::SpecHelper.spec '#has_checked_field?' do
     @session.should have_checked_field('Hamster')
   end
 
+  it "should be true for disabled checkboxes if :disabled => true" do
+    @session.should have_checked_field('Disabled Checkbox', :disabled => true)
+  end
+
   it "should be false if an unchecked field is on the page" do
     @session.should_not have_checked_field('form_pets_cat')
     @session.should_not have_checked_field('Male')
@@ -130,6 +134,14 @@ Capybara::SpecHelper.spec '#has_checked_field?' do
     @session.should_not have_checked_field('Does Not Exist')
   end
 
+  it "should be false for disabled checkboxes by default" do
+    @session.should_not have_checked_field('Disabled Checkbox')
+  end
+
+  it "should be false for disabled checkboxes if :disabled => false" do
+    @session.should_not have_checked_field('Disabled Checkbox', :disabled => false)
+  end
+
   it "should be true after an unchecked checkbox is checked" do
     @session.check('form_pets_cat')
     @session.should have_checked_field('form_pets_cat')
@@ -159,6 +171,10 @@ Capybara::SpecHelper.spec '#has_no_checked_field?' do
     @session.should_not have_no_checked_field('Hamster')
   end
 
+  it "should be false for disabled checkboxes if :disabled => true" do
+    @session.should_not have_no_checked_field('Disabled Checkbox', :disabled => true)
+  end
+
   it "should be true if an unchecked field is on the page" do
     @session.should have_no_checked_field('form_pets_cat')
     @session.should have_no_checked_field('Male')
@@ -167,6 +183,14 @@ Capybara::SpecHelper.spec '#has_no_checked_field?' do
   it "should be true if no field is on the page" do
     @session.should have_no_checked_field('Does Not Exist')
   end
+
+  it "should be true for disabled checkboxes by default" do
+    @session.should have_no_checked_field('Disabled Checkbox')
+  end
+
+  it "should be true for disabled checkboxes if :disabled => false" do
+    @session.should have_no_checked_field('Disabled Checkbox', :disabled => false)
+  end
 end
 
 Capybara::SpecHelper.spec '#has_unchecked_field?' do
@@ -182,10 +206,22 @@ Capybara::SpecHelper.spec '#has_unchecked_field?' do
     @session.should have_unchecked_field('Male')
   end
 
+  it "should be true for disabled unchecked fields if :disabled => true" do
+    @session.should have_unchecked_field('Disabled Unchecked Checkbox', :disabled => true)
+  end
+
   it "should be false if no field is on the page" do
     @session.should_not have_unchecked_field('Does Not Exist')
   end
 
+  it "should be false for disabled unchecked fields by default" do
+    @session.should_not have_unchecked_field('Disabled Unchecked Checkbox')
+  end
+
+  it "should be false for disabled unchecked fields if :disabled => false" do
+    @session.should_not have_unchecked_field('Disabled Unchecked Checkbox', :disabled => false)
+  end
+
   it "should be false after an unchecked checkbox is checked" do
     @session.check('form_pets_cat')
     @session.should_not have_unchecked_field('form_pets_cat')
@@ -220,7 +256,19 @@ Capybara::SpecHelper.spec '#has_no_unchecked_field?' do
     @session.should_not have_no_unchecked_field('Male')
   end
 
+  it "should be false for disabled unchecked fields if :disabled => true" do
+    @session.should_not have_no_unchecked_field('Disabled Unchecked Checkbox', :disabled => true)
+  end
+
   it "should be true if no field is on the page" do
     @session.should have_no_unchecked_field('Does Not Exist')
   end
+
+  it "should be true for disabled unchecked fields by default" do
+    @session.should have_no_unchecked_field('Disabled Unchecked Checkbox')
+  end
+
+  it "should be true for disabled unchecked fields if :disabled => false" do
+    @session.should have_no_unchecked_field('Disabled Unchecked Checkbox', :disabled => false)
+  end
 end

data/lib/capybara/spec/session/has_text_spec.rb

@@ -190,6 +190,16 @@ Capybara::SpecHelper.spec '#has_text?' do
       @session.should_not have_text('count', minimum: '3')
     end
   end
+
+  context "with wait", :requires => [:js] do
+    it "should find element if it appears before given wait duration" do
+      Capybara.using_wait_time(0.1) do
+        @session.visit('/with_js')
+        @session.click_link('Click me')
+        @session.should have_text('Has been clicked', :wait => 0.9)
+      end
+    end
+  end
 end
 
 Capybara::SpecHelper.spec '#has_no_text?' do
@@ -288,4 +298,12 @@ Capybara::SpecHelper.spec '#has_no_text?' do
     @session.click_link('Click me')
     @session.should have_no_text("I changed it")
   end
+
+  context "with wait", :requires => [:js] do
+    it "should not find element if it appears after given wait duration" do
+      @session.visit('/with_js')
+      @session.click_link('Click me')
+      @session.should have_no_text('Has been clicked', :wait => 0.1)
+    end
+  end
 end

data/lib/capybara/spec/session/node_spec.rb

@@ -58,10 +58,25 @@ Capybara::SpecHelper.spec "node" do
       @session.find('//textarea[@id="additional_newline"]').value.should == "\nbanana"
     end
 
+    it "should not swallow leading newlines for set content in textarea" do
+      @session.find('//textarea[@id="normal"]').set("\nbanana")
+      @session.find('//textarea[@id="normal"]').value.should == "\nbanana"
+    end
+
     it "return any HTML content in textarea" do
       @session.find('//textarea[1]').set("some <em>html</em> here")
       @session.find('//textarea[1]').value.should == "some <em>html</em> here"
     end
+    
+    it "defaults to 'on' for checkbox" do
+      @session.visit('/form')
+      @session.find('//input[@id="valueless_checkbox"]').value.should == 'on'
+    end
+
+    it "defaults to 'on' for radio buttons" do
+      @session.visit('/form')
+      @session.find('//input[@id="valueless_radio"]').value.should == 'on'
+    end    
   end
 
   describe "#set" do
@@ -88,6 +103,25 @@ Capybara::SpecHelper.spec "node" do
       @session.first('//textarea[@readonly]').set('changed')
       @session.first('//textarea[@readonly]').value.should == 'textarea should not change'
     end
+
+    it 'should allow me to change the contents of a contenteditable element', :requires => [:js] do
+      @session.visit('/with_js')
+      @session.find(:css,'#existing_content_editable').set('WYSIWYG')
+      @session.find(:css,'#existing_content_editable').text.should == 'WYSIWYG'
+    end
+
+    it 'should allow me to set the contents of a contenteditable element', :requires => [:js] do
+      @session.visit('/with_js')
+      @session.find(:css,'#blank_content_editable').set('WYSIWYG')
+      @session.find(:css,'#blank_content_editable').text.should == 'WYSIWYG'
+    end
+
+    it 'should allow me to change the contents of a contenteditable elements child', :requires => [:js] do
+      pending "Selenium doesn't like editing nested contents"
+      @session.visit('/with_js')
+      @session.find(:css,'#existing_content_editable_child').set('WYSIWYG')
+      @session.find(:css,'#existing_content_editable_child').text.should == 'WYSIWYG'
+    end
   end
 
   describe "#tag_name" do
@@ -125,6 +159,8 @@ Capybara::SpecHelper.spec "node" do
 
       @session.find('//div[@id="hidden"]').should_not be_visible
       @session.find('//div[@id="hidden_via_ancestor"]').should_not be_visible
+      @session.find('//div[@id="hidden_attr"]').should_not be_visible
+      @session.find('//a[@id="hidden_attr_via_ancestor"]').should_not be_visible
     end
   end
 
@@ -178,7 +214,6 @@ Capybara::SpecHelper.spec "node" do
 
   describe '#hover', :requires => [:hover] do
     it "should allow hovering on an element" do
-      pending "Selenium with firefox doesn't currently work with this (selenium with chrome does)" if @session.respond_to?(:mode) && @session.mode == :selenium && @session.driver.browser.browser == :firefox
       @session.visit('/with_hover')
       @session.find(:css,'.hidden_until_hover', :visible => false).should_not be_visible
       @session.find(:css,'.wrapper').hover

data/lib/capybara/spec/session/reset_session_spec.rb

@@ -16,9 +16,18 @@ Capybara::SpecHelper.spec '#reset_session!' do
     @session.current_path.should == '/foo'
 
     @session.reset_session!
-    [nil, '', 'about:blank'].should include @session.current_url
+    [
+      ->(v) { v == nil },
+      ->(v) { v == '' },
+      ->(v) { v == 'about:blank' },
+      ->(v) { v.end_with? Capybara::EMPTY_HTML_FILE_PATH } # allow file:// protocol
+    ].any? { |p| p.(@session.current_url) }.should be_true
+    [
+      ->(v) { v == '' },
+      ->(v) { v == nil },
+      ->(v) { v == Capybara::EMPTY_HTML_FILE_PATH }
+    ].any? { |p| p.(@session.current_path) }.should be_true
     @session.current_host.should be_nil
-    @session.current_path.should be_nil
   end
 
   it "resets page body" do
@@ -31,6 +40,12 @@ Capybara::SpecHelper.spec '#reset_session!' do
     @session.should have_no_selector('.//h1')
   end
 
+  it "is synchronous" do
+    @session.visit("/with_html")
+    @session.reset_session!
+    @session.should have_no_selector :xpath, "/html/body/*", wait: false
+  end
+
   it "raises any errors caught inside the server", :requires => [:server] do
     quietly { @session.visit("/error") }
     expect do