capybara-webkit 0.11.0 → 0.12.0

data/lib/capybara_webkit_builder.rb

@@ -22,29 +22,47 @@ module CapybaraWebkitBuilder
       "linux-g++"
     when /freebsd/
       "freebsd-g++"
+    when /mingw32/
+      "win32-g++"
     else
       "macx-g++"
     end
   end
 
   def makefile
-    system("LANG='en_US.UTF-8' #{qmake_bin} -spec #{spec}")
+    system("#{qmake_bin} -spec #{spec}")
   end
 
   def qmake
-    system("LANG='en_US.UTF-8' #{make_bin} qmake")
+    system("#{make_bin} qmake")
+  end
+
+  def path_to_binary
+    case RUBY_PLATFORM
+    when /mingw32/
+      "src/debug/webkit_server.exe"
+    else
+      "src/webkit_server"
+    end
   end
 
   def build
     system(make_bin) or return false
 
     FileUtils.mkdir("bin") unless File.directory?("bin")
-    FileUtils.cp("src/webkit_server", "bin", :preserve => true)
+    FileUtils.cp(path_to_binary, "bin", :preserve => true)
+  end
+
+  def clean
+    File.open("Makefile", "w") do |file|
+      file.print "all:\n\t@echo ok\ninstall:\n\t@echo ok"
+    end
   end
 
   def build_all
     makefile &&
     qmake &&
-    build
+    build &&
+    clean
   end
 end

data/spec/browser_spec.rb

@@ -2,42 +2,19 @@ require 'spec_helper'
 require 'self_signed_ssl_cert'
 require 'stringio'
 require 'capybara/driver/webkit/browser'
+require 'capybara/driver/webkit/connection'
 require 'socket'
 require 'base64'
 
 describe Capybara::Driver::Webkit::Browser do
 
-  let(:browser) { Capybara::Driver::Webkit::Browser.new }
-  let(:browser_ignore_ssl_err) {
-    Capybara::Driver::Webkit::Browser.new(:ignore_ssl_errors => true)
-  }
-
-  describe '#server_port' do
-    subject { browser.server_port }
-    it 'returns a valid port number' do
-      should be_a(Integer)
-    end
-
-    it 'returns a port in the allowed range' do
-      should be_between 0x400, 0xffff
+  let(:browser) { Capybara::Driver::Webkit::Browser.new(Capybara::Driver::Webkit::Connection.new) }
+  let(:browser_ignore_ssl_err) do
+    Capybara::Driver::Webkit::Browser.new(Capybara::Driver::Webkit::Connection.new).tap do |browser|
+      browser.ignore_ssl_errors
     end
   end
 
-  context 'random port' do
-    it 'chooses a new port number for a new browser instance' do
-      new_browser = Capybara::Driver::Webkit::Browser.new
-      new_browser.server_port.should_not == browser.server_port
-    end
-  end
-
-  it 'forwards stdout to the given IO object' do
-    io = StringIO.new
-    new_browser = Capybara::Driver::Webkit::Browser.new(:stdout => io)
-    new_browser.execute_script('console.log("hello world")')
-    sleep(0.5)
-    io.string.should include "hello world\n"
-  end
-
   context 'handling of SSL validation errors' do
     before do
       # set up minimal HTTPS server
@@ -81,7 +58,8 @@ describe Capybara::Driver::Webkit::Browser do
       browser_ignore_ssl_err.visit "https://#{@host}:#{@port}/"
     end
   end
-  describe "forking" do
+
+  describe "forking", :skip_on_windows => true do
     it "only shuts down the server from the main process" do
       browser.reset!
       pid = fork {}
@@ -180,4 +158,16 @@ describe Capybara::Driver::Webkit::Browser do
       @proxy_requests.size.should == 0
     end
   end
+
+  it "doesn't try to read an empty response" do
+    connection = stub("connection")
+    connection.stub(:puts)
+    connection.stub(:print)
+    connection.stub(:gets).and_return("ok\n", "0\n")
+    connection.stub(:read).and_raise(StandardError.new("tried to read empty response"))
+
+    browser = Capybara::Driver::Webkit::Browser.new(connection)
+
+    expect { browser.visit("/") }.not_to raise_error(/empty response/)
+  end
 end

data/spec/connection_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+require 'capybara/driver/webkit/connection'
+
+describe Capybara::Driver::Webkit::Connection do
+  it "boots a server to talk to" do
+    url = @rack_server.url("/")
+    connection.puts "Visit"
+    connection.puts 1
+    connection.puts url.to_s.bytesize
+    connection.print url
+    connection.gets.should == "ok\n"
+    connection.gets.should == "0\n"
+    connection.puts "Body"
+    connection.puts 0
+    connection.gets.should == "ok\n"
+    response_length = connection.gets.to_i
+    response = connection.read(response_length)
+    response.should include("Hey there")
+  end
+
+  it 'forwards stdout to the given IO object' do
+    io = StringIO.new
+    redirected_connection = Capybara::Driver::Webkit::Connection.new(:stdout => io)
+    script = 'console.log("hello world")'
+    redirected_connection.puts "Execute"
+    redirected_connection.puts 1
+    redirected_connection.puts script.to_s.bytesize
+    redirected_connection.print script
+    sleep(0.5)
+    io.string.should include "hello world\n"
+  end
+
+  it "returns the server port" do
+    connection.port.should be_between 0x400, 0xffff
+  end
+
+  it "chooses a new port number for a new connection" do
+    new_connection = Capybara::Driver::Webkit::Connection.new
+    new_connection.port.should_not == connection.port
+  end
+
+  let(:connection) { Capybara::Driver::Webkit::Connection.new }
+
+  before(:all) do
+    @app = lambda do |env|
+      body = "<html><body>Hey there</body></html>"
+      [200,
+        { 'Content-Type' => 'text/html', 'Content-Length' => body.size.to_s },
+        [body]]
+    end
+    @rack_server = Capybara::Server.new(@app)
+    @rack_server.boot
+  end
+end

data/spec/driver_resize_window_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+require 'capybara/driver/webkit'
+
+describe Capybara::Driver::Webkit, "#resize_window(width, height)" do
+
+  before(:all) do
+    app = lambda do |env|
+      body = <<-HTML
+        <html>
+          <body>
+            <h1 id="dimentions">UNKNOWN</h1>
+
+            <script>
+              window.onload = window.onresize = function(){
+                document.getElementById("dimentions").innerHTML = "[" + window.innerWidth + "x" + window.innerHeight + "]";
+              };
+            </script>
+
+          </body>
+        </html>
+      HTML
+
+      [
+        200,
+        { 'Content-Type' => 'text/html', 'Content-Length' => body.length.to_s },
+        [body]
+      ]
+    end
+
+    @driver = Capybara::Driver::Webkit.new(app, :browser => $webkit_browser)
+  end
+
+  DEFAULT_DIMENTIONS = "[1680x1050]"
+
+  it "resizes the window to the specified size" do
+    @driver.visit("/")
+
+    @driver.resize_window(800, 600)
+    @driver.body.should include("[800x600]")
+
+    @driver.resize_window(300, 100)
+    @driver.body.should include("[300x100]")
+  end
+
+  it "resizes the window to the specified size even before the document has loaded" do
+    @driver.resize_window(800, 600)
+    @driver.visit("/")
+    @driver.body.should include("[800x600]")
+  end
+
+  it "resets the window to the default size when the driver is reset" do
+    @driver.resize_window(800, 600)
+    @driver.reset!
+    @driver.visit("/")
+    @driver.body.should include(DEFAULT_DIMENTIONS)
+  end
+
+  after(:all) { @driver.reset! }
+end

data/spec/driver_spec.rb

@@ -659,6 +659,7 @@ describe Capybara::Driver::Webkit do
                 element.addEventListener("keydown", recordEvent);
                 element.addEventListener("keypress", recordEvent);
                 element.addEventListener("keyup", recordEvent);
+                element.addEventListener("input", recordEvent);
                 element.addEventListener("change", recordEvent);
                 element.addEventListener("blur", recordEvent);
                 element.addEventListener("mousedown", recordEvent);
@@ -678,7 +679,7 @@ describe Capybara::Driver::Webkit do
 
     let(:keyevents) do
       (%w{focus} +
-       newtext.length.times.collect { %w{keydown keypress keyup} } +
+       newtext.length.times.collect { %w{keydown keypress keyup input} } +
        %w{change blur}).flatten
     end
 
@@ -987,15 +988,15 @@ describe Capybara::Driver::Webkit do
     end
 
     def make_the_server_come_back
-      subject.browser.instance_variable_get(:@socket).unstub!(:gets)
-      subject.browser.instance_variable_get(:@socket).unstub!(:puts)
-      subject.browser.instance_variable_get(:@socket).unstub!(:print)
+      subject.browser.instance_variable_get(:@connection).unstub!(:gets)
+      subject.browser.instance_variable_get(:@connection).unstub!(:puts)
+      subject.browser.instance_variable_get(:@connection).unstub!(:print)
     end
 
     def make_the_server_go_away
-      subject.browser.instance_variable_get(:@socket).stub!(:gets).and_return(nil)
-      subject.browser.instance_variable_get(:@socket).stub!(:puts)
-      subject.browser.instance_variable_get(:@socket).stub!(:print)
+      subject.browser.instance_variable_get(:@connection).stub!(:gets).and_return(nil)
+      subject.browser.instance_variable_get(:@connection).stub!(:puts)
+      subject.browser.instance_variable_get(:@connection).stub!(:print)
     end
   end
 
@@ -1090,7 +1091,8 @@ describe Capybara::Driver::Webkit do
   context "with socket debugger" do
     let(:socket_debugger_class){ Capybara::Driver::Webkit::SocketDebugger }
     let(:browser_with_debugger){
-      Capybara::Driver::Webkit::Browser.new(:socket_class => socket_debugger_class)
+      connection = Capybara::Driver::Webkit::Connection.new(:socket_class => socket_debugger_class)
+      Capybara::Driver::Webkit::Browser.new(connection)
     }
     let(:driver_with_debugger){ Capybara::Driver::Webkit.new(@app, :browser => browser_with_debugger) }
 
@@ -1276,6 +1278,39 @@ describe Capybara::Driver::Webkit do
     end
   end
 
+  context "localStorage works" do
+    before(:all) do
+      @app = lambda do |env|
+        body = <<-HTML
+          <html>
+            <body>
+              <span id='output'></span>
+              <script type="text/javascript">
+                if (typeof localStorage !== "undefined") {
+                  if (!localStorage.refreshCounter) {
+                    localStorage.refreshCounter = 0;
+                  }
+                  if (localStorage.refreshCounter++ > 0) {
+                    document.getElementById("output").innerHTML = "localStorage is enabled";
+                  }
+                }
+              </script>
+            </body>
+          </html>
+        HTML
+        [200,
+          { 'Content-Type' => 'text/html', 'Content-Length' => body.length.to_s },
+          [body]]
+      end
+    end
+
+    it "displays the message on subsequent page loads" do
+      subject.find("//span[contains(.,'localStorage is enabled')]").should be_empty
+      subject.visit "/"
+      subject.find("//span[contains(.,'localStorage is enabled')]").should_not be_empty
+    end
+  end
+
   context "app with a lot of HTML tags" do
     before(:all) do
       @app = lambda do |env|
@@ -1372,33 +1407,146 @@ describe Capybara::Driver::Webkit do
     end
   end
 
+  def key_app_body(event)
+    body = <<-HTML
+        <html>
+          <head><title>Form</title></head>
+          <body>
+            <div id="charcode_value"></div>
+            <div id="keycode_value"></div>
+            <div id="which_value"></div>
+            <input type="text" id="charcode" name="charcode" on#{event}="setcharcode" />
+            <script type="text/javascript">
+              var element = document.getElementById("charcode")
+              element.addEventListener("#{event}", setcharcode);
+              function setcharcode(event) {
+                var element = document.getElementById("charcode_value");
+                element.innerHTML = event.charCode;
+                element = document.getElementById("keycode_value");
+                element.innerHTML = event.keyCode;
+                element = document.getElementById("which_value");
+                element.innerHTML = event.which;
+              }
+            </script>
+          </body>
+        </html>
+    HTML
+    body
+  end
+
+  def charCode_for(character)
+    subject.find("//input")[0].set(character)
+    subject.find("//div[@id='charcode_value']")[0].text
+  end
+
+  def keyCode_for(character)
+    subject.find("//input")[0].set(character)
+    subject.find("//div[@id='keycode_value']")[0].text
+  end
+
+  def which_for(character)
+    subject.find("//input")[0].set(character)
+    subject.find("//div[@id='which_value']")[0].text
+  end
+
   context "keypress app" do
     before(:all) do
       @app = lambda do |env|
-        body = <<-HTML
-            <html>
-              <head><title>Form</title></head>
-              <body>
-                <div id="charcode_value"></div>
-                <input type="text" id="charcode" name="charcode" onkeypress="setcharcode" />
-                <script type="text/javascript">
-                  var element = document.getElementById("charcode")
-                  element.addEventListener("keypress", setcharcode);
-                  function setcharcode(event) {
-                    var element = document.getElementById("charcode_value");
-                    element.innerHTML = event.charCode;
-                  }
-                </script>
-              </body>
-            </html>
-        HTML
+        body = key_app_body("keypress")
         [200, { 'Content-Type' => 'text/html', 'Content-Length' => body.length.to_s }, [body]]
       end
     end
 
     it "returns the charCode for the keypressed" do
-      subject.find("//input")[0].set("a")
-      subject.find("//div")[0].text.should == "97"
+      charCode_for("a").should == "97"
+      charCode_for("A").should == "65"
+      charCode_for("\r").should == "13"
+      charCode_for(",").should == "44"
+      charCode_for("<").should == "60"
+      charCode_for("0").should == "48"
+    end
+
+    it "returns the keyCode for the keypressed" do
+      keyCode_for("a").should == "97"
+      keyCode_for("A").should == "65"
+      keyCode_for("\r").should == "13"
+      keyCode_for(",").should == "44"
+      keyCode_for("<").should == "60"
+      keyCode_for("0").should == "48"
+    end
+
+    it "returns the which for the keypressed" do
+      which_for("a").should == "97"
+      which_for("A").should == "65"
+      which_for("\r").should == "13"
+      which_for(",").should == "44"
+      which_for("<").should == "60"
+      which_for("0").should == "48"
+    end
+  end
+
+  shared_examples "a keyupdown app" do
+    it "returns a 0 charCode for the event" do
+      charCode_for("a").should == "0"
+      charCode_for("A").should == "0"
+      charCode_for("\r").should == "0"
+      charCode_for(",").should == "0"
+      charCode_for("<").should == "0"
+      charCode_for("0").should == "0"
+    end
+
+    it "returns the keyCode for the event" do
+      keyCode_for("a").should == "65"
+      keyCode_for("A").should == "65"
+      keyCode_for("\r").should == "13"
+      keyCode_for(",").should == "188"
+      keyCode_for("<").should == "188"
+      keyCode_for("0").should == "48"
+    end
+
+    it "returns the which for the event" do
+      which_for("a").should == "65"
+      which_for("A").should == "65"
+      which_for("\r").should == "13"
+      which_for(",").should == "188"
+      which_for("<").should == "188"
+      which_for("0").should == "48"
+    end
+  end
+
+  context "keydown app" do
+    before(:all) do
+      @app = lambda do |env|
+        body = key_app_body("keydown")
+        [200, { 'Content-Type' => 'text/html', 'Content-Length' => body.length.to_s }, [body]]
+      end
+    end
+    it_behaves_like "a keyupdown app"
+  end
+
+  context "keyup app" do
+    before(:all) do
+      @app = lambda do |env|
+        body = key_app_body("keyup")
+        [200, { 'Content-Type' => 'text/html', 'Content-Length' => body.length.to_s }, [body]]
+      end
+    end
+
+    it_behaves_like "a keyupdown app"
+  end
+
+  context "null byte app" do
+    before(:all) do
+      @app = lambda do |env|
+        body = "Hello\0World"
+        [200,
+          { 'Content-Type' => 'text/html', 'Content-Length' => body.length.to_s },
+          [body]]
+      end
+    end
+
+    it "should include all the bytes in the source" do
+      subject.source.should == "Hello\0World"
     end
   end
 end