capybara-webkit 0.1.1 → 0.1.2

data/README.md

@@ -6,10 +6,12 @@ A [capybara](https://github.com/jnicklas/capybara) driver that uses [WebKit](htt
 Dependencies
 ------------
 
-capybara-webkit depends on a WebKit implementation from Qt, a cross-platform development toolkit. You'll need to download Qt to build and install the gem.
+capybara-webkit depends on a WebKit implementation from Qt, a cross-platform development toolkit. You'll need to download the Qt SDK to build and install the gem.
 
 * [Download Qt](http://qt.nokia.com/downloads/downloads)
 
+If you're on Ubuntu, you can install the libqt4-dev package. On Linux platforms, capybara-webkit requires an X server to run, although it doesn't create any visible windows. Xvfb works fine for this.
+
 Usage
 -----
 
@@ -28,6 +30,8 @@ About
 
 The capybara WebKit driver was written by Joe Ferris, Tristan Dunn, and Jason Morrison from [thoughtbot, inc](http://thoughtbot.com/community).
 
+![thoughtbot](http://thoughtbot.com/images/tm/logo.png)
+
 The names and logos for thoughtbot are trademarks of thoughtbot, inc.
 
 License

data/Rakefile

@@ -47,6 +47,18 @@ unless ENV["BUILD"]
     package.need_tar = true
   end
 
+  gem_file = "pkg/#{$specification.name}-#{$specification.version}.gem"
+
+  desc "Build and install the latest gem"
+  task :install => :gem do
+    sh("gem install --local #{gem_file}")
+  end
+
+  desc "Build and release the latest gem"
+  task :release => :gem do
+    sh("gem push #{gem_file}")
+  end
+
   desc "Generate a new command called NAME"
   task :generate_command do
     name = ENV['NAME'] or raise "Provide a name with NAME="

data/capybara-webkit.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = "capybara-webkit"
-  s.version = "0.1.1"
+  s.version = "0.1.2"
   s.authors = ["thoughtbot", "Joe Ferris", "Jason Morrison", "Tristan Dunn"]
   s.email = "support@thoughtbot.com"
   s.files = `git ls-files`.split("\n")

data/spec/driver_spec.rb

@@ -131,6 +131,11 @@ describe Capybara::Driver::Webkit do
         to raise_error(Capybara::Driver::Webkit::WebkitError)
     end
 
+    it "doesn't raise an error for Javascript that doesn't return anything" do
+      lambda { subject.execute_script(%<(function () { "returns nothing" })()>) }.
+        should_not raise_error
+    end
+
     it "returns a node's tag name" do
       subject.find("//p").first.tag_name.should == "p"
     end

data/src/Execute.cpp

@@ -5,7 +5,8 @@ Execute::Execute(WebPage *page, QObject *parent) : Command(page, parent) {
 }
 
 void Execute::start(QStringList &arguments) {
-  QVariant result = page()->mainFrame()->evaluateJavaScript(arguments[0]);
+  QString script = arguments[0] + QString("; 'success'");
+  QVariant result = page()->mainFrame()->evaluateJavaScript(script);
   QString response;
   if (result.isValid()) {
     emit finished(true, response);

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: capybara-webkit
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 31
   prerelease: 
   segments: 
   - 0
   - 1
-  - 1
-  version: 0.1.1
+  - 2
+  version: 0.1.2
 platform: ruby
 authors: 
 - thoughtbot
@@ -18,7 +18,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-06 00:00:00 -04:00
+date: 2011-04-13 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency