capybara-slow_finder_errors 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2ac8ff324327298695ce17961339c03d8c47649a
-  data.tar.gz: d255a4751b415d6d49d661c76025fd10805b2cd6
+  metadata.gz: 5408b07ad5d32cdf3f45dcae687569cb2156b700
+  data.tar.gz: 8750ee9ebdbb859dccd254050afdad37cabe8b81
 SHA512:
-  metadata.gz: 6a6fba191388f26e7a2ab41db205d7150e606cfbeb0ad3a4ee5544a30e2e9cc1cd15c2f9853a3bad74b9d10a2ca01ca8d75cf318be51e57cd09ec95b2bcdc4ac
-  data.tar.gz: 016d49c366165d7d2b7272acf7eea1cea53ac242f5ffddda2e0bf9b85eb78fe91f6b7257e681cc48ae20ac623ed4e3db8050814e9441d2b328ce2634954791ec
+  metadata.gz: 876319a7a881519ba2adb705cc119256070df010e2636cc243d1790e2f5264d2d27942a8e8c02b252ecb7833f9cf3436b05f5a98257db423ef640910ac79db47
+  data.tar.gz: 078c29ea8a2dacb349857c78c3b51d5b2cd27eedd2230e1e699acdf82543a10c6a46d028d40b7319f8054c940ffaf3b23cfb026136d51ba11f5fb79b86772084

data/README.md

@@ -64,6 +64,16 @@ execution expired (Timeout::Error)
 
 If you look at the lines below the gem's trace, you'll see that the slow finder is in `signed_in_user.rb` on line 31 in the `signed_in?` method. Just follow those traces and clean up your code!
 
+## RSpec
+
+If you're using RSpec and the matchers provided by Capybara like:
+
+```ruby
+expect(page).to_not have_content("abc")
+```
+
+then Capybara is already telling RSpec to use the negated method (`has_no_content?`) and thus Capybara is not waiting for the timeout before continuing.
+
 ## Common Fixes
 
 This section will hopefully grow as people contribute common situations and fixes.

data/capybara-slow_finder_errors.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "capybara-slow_finder_errors"
-  spec.version       = "0.1.0"
+  spec.version       = "0.1.1"
   spec.authors       = ["Nick Gauthier"]
   spec.email         = ["ngauthier@gmail.com"]
   spec.summary       = %q{Raises an error when you use a Capybara finder improperly}

data/lib/capybara/slow_finder_errors.rb

@@ -4,13 +4,15 @@ module Capybara
 
   module Node
     class Base
-      def synchronize_with_timeout_error(seconds=Capybara.default_wait_time, options = {}, &block)
+      def synchronize_with_timeout_error(*args, &block)
         start_time = Time.now
-        synchronize_without_timeout_error(seconds, options, &block)
+        synchronize_without_timeout_error(*args, &block)
       rescue Capybara::ElementNotFound => e
+        seconds = args.first || Capybara.default_wait_time
         if Time.now-start_time > seconds
-          raise SlowFinderError
+          raise SlowFinderError, "Timeout reached while running a *waiting* Capybara finder...perhaps you wanted to return immediately? Use a non-waiting Capybara finder. More info: http://blog.codeship.com/faster-rails-tests?utm_source=gem_exception"
         end
+        raise
       end
       alias_method :synchronize_without_timeout_error, :synchronize
       alias_method :synchronize, :synchronize_with_timeout_error

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capybara-slow_finder_errors
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Nick Gauthier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-05 00:00:00.000000000 Z
+date: 2014-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,7 +86,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.4.2
 signing_key: 
 specification_version: 4
 summary: Raises an error when you use a Capybara finder improperly