capybara-simulated 0.0.2 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a1b71c5bedf4ee1236631f583accd90b10e71317c00e5b20252c5b8f48477ea
-  data.tar.gz: b1b3a3bb91e784b579cb4d465f253ed78c3bb606ef9629afe2197693114fa10b
+  metadata.gz: edfc03fddab459b5cace9bb3bb3b05ba0ff48adc978eb2c8b401d9311f62d569
+  data.tar.gz: 74237a169f1ce04b4fa579936f86622fab1f6fa98190d81bf98caf72974cbcb5
 SHA512:
-  metadata.gz: ba4e4836908d7f607c475321edc01592b89e53df666e531330e4283725633201622461df829b4e40c37f1ad9ba5d67d74e71fbaef14efda60c11ec7abaa6441c
-  data.tar.gz: d6ecc0867f4ae527d483c337a7129e65e6f31fd24a5c507247df66ddb89ac1eeb98060101868f3e43f787caea6e1ad35390afd94504aff8c7f05b095fcaa1a09
+  metadata.gz: 80e00f33f9994046daaa5e62b6b08e1b5db4ac425bb94761f8aaa0d9be328fd9ff292f43459d1dd51a2e10a0f20e217f399ce71815d2076cbe121cda0ed29791
+  data.tar.gz: 8d0d3309b0bfb141040005a535bef99fa97a01aaf81b7f1e6b247997f9d13b0ae821d6ce53c8ba3ea62e2c10c2aa7b140a0d369e7ebe6bf77c331a58cc5de3ae

data/README.md

@@ -12,15 +12,15 @@ forms submit through `Rack::MockRequest`.
 
 ## Status
 
-PoC. Against Capybara 3.40's shared `Capybara::SpecHelper.spec` suite the
+Used in production by a Rails 8 app to run ~200 `js: true` system specs
+without spawning a headless Chrome.
+
+Against Capybara 3.40's shared `Capybara::SpecHelper.spec` suite the
 driver passes **1337 / 1357 examples (98.5%)** with the unsupported-
 capability tags `about_scheme`, `css`, `download`, `frames`, `hover`,
 `screenshot`, `scroll`, `server`, `spatial`, `windows` filtered out.
-Tags that started skipped but now pass: `active_element`, `modals`
-(alert/confirm/prompt incl. nested + page-change + async),
-`html_validation`, `send_keys`, `shadow_dom`. The remaining 20
-failures all need capabilities the driver intentionally does not
-implement:
+The remaining 20 failures all need capabilities the driver intentionally
+does not implement:
 
 - 19 `#drag_to` tests — Dragula / SortableJS / jsTree resolve drop
   targets through `elementFromPoint(clientX, clientY)`, which needs a

data/lib/capybara/simulated/browser.rb

@@ -541,7 +541,13 @@ module Capybara
         entries   = Array(details['entries'])
         return if importmap.empty? && entries.empty?
 
-        cache_key = Digest::SHA256.hexdigest(JSON.dump([importmap, entries, @current_url]))
+        # Importmap + module-script entries are page-content-derived, so
+        # keying on them alone covers different pages of the same Rails app
+        # — the bundle output is identical when the inputs are. Including
+        # `@current_url` only suppressed cache hits across visits without
+        # buying any correctness; build_module_bundle was the single biggest
+        # cost in the suite (52% of wall time on a hot test).
+        cache_key = Digest::SHA256.hexdigest(JSON.dump([importmap, entries]))
         @module_bundle_cache ||= {}
         bundle = @module_bundle_cache[cache_key] ||=
                  build_module_bundle(importmap, entries)

data/lib/capybara/simulated/version.rb

@@ -1,5 +1,5 @@
 module Capybara
   module Simulated
-    VERSION = '0.0.2'
+    VERSION = '0.0.4'
   end
 end

data/vendor/js/runtime.js

@@ -1987,6 +1987,12 @@
   // Custom DOM facade for fontoxpath that uses childNodes-based traversal
   // so happy-dom quirks around sibling links don't break root-anchored
   // queries. Mirrors the helper we built for linkedom.
+  // fontoxpath calls into this facade tens of thousands of times per
+  // traversal, so each method needs to delegate to happy-dom's native
+  // pointers rather than reconstructing them. Earlier revisions of
+  // getNextSibling / getPreviousSibling rebuilt childNodes via
+  // Array.from(parent.childNodes) and then indexOf'd the node — quadratic
+  // in tree size, and the dominant cost on any non-trivial page.
   const xpathDomFacade = {
     getAllAttributes(node) {
       if (!node || node.nodeType !== 1 || !node.attributes) return [];
@@ -2006,31 +2012,30 @@
       if (node.nodeType === 2) return node.value || '';
       return node.data || '';
     },
+    // happy-dom 20 has a quirk on `<template>`: `template.childNodes` is
+    // empty (the parsed content lives in `template.content`) but
+    // `template.firstChild` / `template.lastChild` still return the first
+    // text node of `template.content`. Walking into that ghost child
+    // makes fontoxpath traverse content as if it were a regular descendant,
+    // which scrambles every predicate downstream. Verify against
+    // childNodes.length before trusting firstChild / lastChild.
     getFirstChild(node) {
-      const cs = this.getChildNodes(node);
-      return cs.length ? cs[0] : null;
+      const fc = node?.firstChild ?? null;
+      if (!fc) return null;
+      const cs = node.childNodes;
+      if (cs && cs.length === 0) return null;
+      return fc;
     },
     getLastChild(node) {
-      const cs = this.getChildNodes(node);
-      return cs.length ? cs[cs.length - 1] : null;
+      const lc = node?.lastChild ?? null;
+      if (!lc) return null;
+      const cs = node.childNodes;
+      if (cs && cs.length === 0) return null;
+      return lc;
     },
-    getNextSibling(node) {
-      const parent = this.getParentNode(node);
-      if (!parent) return null;
-      const cs = this.getChildNodes(parent);
-      const i = cs.indexOf(node);
-      return (i >= 0 && i + 1 < cs.length) ? cs[i + 1] : null;
-    },
-    getPreviousSibling(node) {
-      const parent = this.getParentNode(node);
-      if (!parent) return null;
-      const cs = this.getChildNodes(parent);
-      const i = cs.indexOf(node);
-      return (i > 0) ? cs[i - 1] : null;
-    },
-    getParentNode(node) {
-      return node ? node.parentNode || null : null;
-    }
+    getNextSibling(node)     { return node?.nextSibling     ?? null; },
+    getPreviousSibling(node) { return node?.previousSibling ?? null; },
+    getParentNode(node)      { return node?.parentNode      ?? null; }
   };
 
   function findViaXPathFallback(xpath, root) {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara-simulated
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - Keita Urashima