capybara-playwright-driver 0.5.9 → 0.5.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a319465a40c53ac5b47d86ccd4d15136c20dcf7f6dde6fe17b3906d44cb2fd94
-  data.tar.gz: 1e38fb6020a87a07e6eaa8e997084b3abd98a0a8d5cbec4e92819a960c525f62
+  metadata.gz: a9766817ce50a7580acf4f72c062780da5a2363ea838dea3a8f17207c359c144
+  data.tar.gz: 5b48eb5b0eb4145088457e8b0c1a26c5843f80dc3e3d9acf120c095fd2d7691a
 SHA512:
-  metadata.gz: 5d1d8aeccb05f0c667c3b1a617cb1d2f19eb7fa096788a46b81985730f1a75b6ee7196ad952d2152c173b7401980090f738db399503b3ddceac097ced637678c
-  data.tar.gz: 141fd5024a9d322faf9031951e0f74a61426af350ed06d73017b2db90ec5b866e1af9b17edd5017e5c35f79f198cfa5916b220afcf621db9a2538c5fb50f443b
+  metadata.gz: d7b079c7c184643a16cfae94e7aaafd325460a3a13e3ece9cf453b127045a44a8ea008b29b65c326325ad3cbb7b3a8f092ff325267df512ac3f1645565ef6baa
+  data.tar.gz: 46290aabe5623d54094efa2cd30369261ca32525b99835e0f6e393ddc48de3e9d1e21011e64cd61dfd00531bf05818dab69525c1cb450f9f2d46679b9c19b0c5

data/AGENTS.md

@@ -105,3 +105,11 @@ end
 ## General Guidance
 - Prefer concise Ruby that reads top-to-bottom without carrying unnecessary temporary state.
 - Prefer small private helper objects only when they reduce complexity. Once extracted, give them Ruby-like method names and keep their public surface minimal.
+
+## How to execute RSpec or Ruby
+
+`ruby` uses macOS system ruby interpreter (typically 2.6 or older). rbenv should be used.
+
+- Do not run the full `spec/capybara/playwright_spec.rb` or full RSpec suite locally; run broad coverage in GitHub Actions.
+- To run a focused Playwright compatibility check locally, use an example filter, for example:
+  `RBENV_VERSION=$(cat .ruby-version) ~/.rbenv/shims/bundle exec rspec spec/capybara/playwright_spec.rb --example fill_in`

data/Gemfile

@@ -15,6 +15,7 @@ gem 'rack-test_server'
 gem 'rake', '~> 13.0.3'
 gem 'rspec', '~> 3.11.0'
 gem 'rubocop-rspec'
+gem 'selenium-webdriver', '~> 4.34.0' if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.2')
 gem 'sinatra', '>= 1.4.0'
 gem 'webrick'
 gem 'websocket-driver'

data/lib/capybara/playwright/browser.rb

@@ -89,10 +89,20 @@ module Capybara
         }
       end
 
+      private def firefox?
+        @playwright_browser.browser_type.name == 'firefox'
+      end
+
       def refresh
-        assert_page_alive {
+        if firefox?
+          # ref: https://github.com/microsoft/playwright/issues/39738
           @playwright_page.capybara_current_frame.evaluate('() => { location.reload(true) }')
-        }
+        else
+          assert_page_alive {
+            response = @playwright_page.reload
+            @playwright_page.capybara_set_last_response(response)
+          }
+        end
       end
 
       def find_xpath(query, **options)
@@ -255,7 +265,8 @@ module Capybara
           when /Element is not attached to the DOM/,
             /Execution context was destroyed, most likely because of a navigation/,
             /Cannot find context with specified id/,
-            /Unable to adopt element handle from a different document/
+            /Unable to adopt element handle from a different document/,
+            /maybe frame was detached/
             # ignore error for retry
             @internal_logger.warn(err.message)
           else
@@ -318,16 +329,35 @@ module Capybara
 
       def window_size(handle)
         on_window(handle) do |page|
-          page.evaluate('() => [window.innerWidth, window.innerHeight]')
+          outer_window_size(page)
         end
       end
 
       def resize_window_to(handle, width, height)
         on_window(handle) do |page|
-          page.viewport_size = { width: width, height: height }
+          page.viewport_size = viewport_size_for(page, width, height)
         end
       end
 
+      # Capybara follows Selenium's outer window size semantics.
+      private def outer_window_size(page)
+        page.evaluate('() => [window.outerWidth || window.innerWidth, window.outerHeight || window.innerHeight]')
+      end
+
+      private def viewport_size_for(page, width, height)
+        inset_width, inset_height = page.evaluate(<<~JAVASCRIPT)
+          () => [
+            Math.max(0, (window.outerWidth || window.innerWidth) - window.innerWidth),
+            Math.max(0, (window.outerHeight || window.innerHeight) - window.innerHeight)
+          ]
+        JAVASCRIPT
+
+        {
+          width: [width - inset_width, 0].max,
+          height: [height - inset_height, 0].max
+        }
+      end
+
       def maximize_window(handle)
         @internal_logger.warn("maximize_window is not supported in Playwright driver")
         # incomplete in Playwright

data/lib/capybara/playwright/node.rb

@@ -258,7 +258,7 @@ module Capybara
       end
 
       private def capybara_default_wait_time
-        Capybara.default_max_wait_time * 1100 # with 10% buffer for allowing overhead.
+        Capybara.default_max_wait_time.to_f * 1100 # with 10% buffer for allowing overhead.
       end
 
       class NotActionableError < StandardError ; end
@@ -411,15 +411,13 @@ module Capybara
           end
 
           text = value.to_s
-          if press_enter = text.end_with?("\n")
+          if press_enter = text.end_with?("\r\n")
+            text = text[0...-2]
+          elsif press_enter = text.end_with?("\n")
             text = text[0...-1]
           end
 
-          if options[:clear] == :none
-            @element.type(text, timeout: @timeout)
-          else
-            @element.fill(text, timeout: @timeout)
-          end
+          set_text(text, append: options[:clear] == :none)
 
           if press_enter
             @element.press('Enter', timeout: @timeout)
@@ -429,6 +427,41 @@ module Capybara
 
           @internal_logger.info("Node#set: element is not editable. #{@element}")
         end
+
+        private def set_text(text, append:)
+          # ElementHandle#type can refocus inherited contenteditable descendants and drop the input.
+          if @element.evaluate('el => el.isContentEditable') && !append
+            @element.fill(text, timeout: @timeout)
+            return
+          end
+
+          if text.include?("\t")
+            type_tab_separated_text(text, append: append)
+            return
+          end
+
+          grapheme_clusters = text.scan(/\X/)
+          fill_text = grapheme_clusters[0...-1].join
+          typed_text = grapheme_clusters[-1].to_s
+
+          if append
+            @element.type(fill_text, timeout: @timeout) unless fill_text.empty?
+          else
+            @element.fill(fill_text, timeout: @timeout)
+          end
+          @element.type(typed_text, timeout: @timeout) unless typed_text.empty?
+        end
+
+        private def type_tab_separated_text(text, append:)
+          head, *tail = text.split("\t", -1)
+          set_text(head, append: append)
+          keyboard = @element.owner_frame.page.keyboard
+
+          tail.each do |part|
+            keyboard.press('Tab')
+            keyboard.type(part) unless part.empty?
+          end
+        end
       end
 
       class FileUpload < Settable

data/lib/capybara/playwright/version.rb

@@ -2,6 +2,6 @@
 
 module Capybara
   module Playwright
-    VERSION = '0.5.9'
+    VERSION = '0.5.10'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara-playwright-driver
 version: !ruby/object:Gem::Version
-  version: 0.5.9
+  version: 0.5.10
 platform: ruby
 authors:
 - YusukeIwaki