capybara-lockstep 2.2.1 → 2.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8bad1a61632d37c5e705b886be4cb840a62923f73887c1443060fb00c6e69aa2
-  data.tar.gz: 9243b559659a33a00e6f803304284aa9cd47e5c2f110a11b47eb2e4e62441537
+  metadata.gz: dbe79968ebe67aec5235612f3699fc83fb1845205579b421c0291883ce4fffcb
+  data.tar.gz: 3fef926a33a2303f0d41940aec44c569c10001ae3a749325a59b502f38c8f2d6
 SHA512:
-  metadata.gz: 9b285d685609f913c92b4b8d5556d34d7d77e2fb6d80e5fac4cda189c81a2b81445fc65a5680726c2d21b16d0bcdcb1fcb35e3a6169b2febca3244eaa555b985
-  data.tar.gz: d598437ffb3eaf066d6cbcb747ac6c5445bed0a2c2cbc5113f42e0d947d4b71fc7bb4752ede4193cca989acafd5d126757c67d3454fbfc226014d7b42056b55f
+  metadata.gz: b0dc89fd6df23a4163f65ba33d537d40561abcfb7a96820b5757130088771d1e8b6432c51a8fbad6f22f54163a35f1ad417553bfe95e1c77d4a84bc1b6d55c01
+  data.tar.gz: ff6dda402879f2ed6de25686e144cc428e3c33d4eec05d2b705ef5cc2e3591b31244dd111799243c5b5618d7a417bf17295c8611deb72ce3ac82502f609ad07d

data/CHANGELOG.md

@@ -2,6 +2,14 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+
+# 2.2.2
+
+- We now only wait for `<script>` elements with a JavaScript type
+- We only wait for `<iframe>` elements with a `[src]` attribute
+- We no longer wait for `<video>` and `<audio>` elements to load their metadata. This did not work consistently, and would sometimes cause capybara-lockstep to wait indefinitely.
+
+
 # 2.2.1
 
 - Fixed a bug that disabled most functionality for drivers with `browser: :remote`.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    capybara-lockstep (2.2.1)
+    capybara-lockstep (2.2.2)
       activesupport (>= 4.2)
       capybara (>= 3.0)
       ruby2_keywords
@@ -71,8 +71,8 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.1)
-    rspec-wait (0.0.10)
-      rspec (>= 3.0)
+    rspec-wait (1.0.0)
+      rspec (>= 3.4)
     ruby2_keywords (0.0.5)
     rubyzip (2.3.2)
     selenium-webdriver (4.1.0)

data/README.md

@@ -72,7 +72,6 @@ When capybara-lockstep synchronizes it will:
 - wait for any pending AJAX requests to finish and their callbacks to be called.
 - wait for dynamically inserted `<script>`s to load (e.g. from [dynamic imports](https://webpack.js.org/guides/code-splitting/#dynamic-imports) or Analytics snippets).
 - wait for dynamically inserted `<img>` or `<iframe>` elements to load (ignoring [lazy-loaded](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#lazy) elements).
-- wait for dynamically inserted `<audio>` and `<video>` elements to load their [metadata](https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/loadedmetadata_event)
 
 In summary, Capybara can no longer observe or interact with the page while HTTP requests are in flight.
 This covers most async work that causes flaky tests.
@@ -86,6 +85,7 @@ Async work not synchronized by capybara-lockstep includes:
 - Websocket connections
 - Service workers
 - Work scheduled via `setTimeout()` or `setInterval()`.
+- `<audio>` and `<video>` elements
 
 You can configure capybara-lockstep to [wait for additional async work](#signaling-asynchronous-work).
 

data/lib/capybara-lockstep/helper.js

@@ -177,7 +177,7 @@ window.CapybaraLockstep = (function() {
   }
 
   function isRemoteScript(element) {
-    return element.matches('script[src]') && !hasDataSource(element)
+    return element.matches('script[src]') && !hasDataSource(element) && isTrackableScriptType(element.type)
   }
 
   function isTrackableImage(element) {
@@ -188,11 +188,15 @@ window.CapybaraLockstep = (function() {
   }
 
   function isTrackableIFrame(element) {
-    return element.matches('iframe') &&
+    return element.matches('iframe[src]') &&
       !hasDataSource(element) &&
       element.getAttribute('loading') !== 'lazy'
   }
 
+  function isTrackableScriptType(type) {
+    return !type || type === 'text/javascript' || type === 'module' || type === 'application/javascript'
+  }
+
   function hasDataSource(element) {
     // <img> can have <img src> and <img srcset>
     // <video> can have <video src> or <video><source src>
@@ -201,22 +205,11 @@ window.CapybaraLockstep = (function() {
       !!element.querySelector('source [src*="data:"], source [srcset*="data:"]')
   }
 
-  function isTrackableMediaElement(element) {
-    return element.matches('audio, video') &&
-      element.readyState === 0 && // no metadata known
-      !hasDataSource(element) &&
-      element.getAttribute('preload') !== 'none'
-  }
-
   function trackRemoteElement(element, condition, workTag) {
     trackLoadingElement(element, condition, workTag, 'load', 'error')
 
   }
 
-  function trackMediaElement(element, condition, workTag) {
-    trackLoadingElement(element, condition, workTag, 'loadedmetadata', 'error')
-  }
-
   function trackLoadingElement(element, condition, workTag, loadEvent, errorEvent) {
     if (!condition(element)) {
       return
@@ -266,7 +259,6 @@ window.CapybaraLockstep = (function() {
           trackRemoteElement(addedNode, isRemoteScript, 'Script')
           trackRemoteElement(addedNode, isTrackableImage, 'Image')
           trackRemoteElement(addedNode, isTrackableIFrame, 'Inline frame')
-          trackMediaElement(addedNode, isTrackableMediaElement, 'Media element')
         }
       })
     })

data/lib/capybara-lockstep/version.rb

@@ -1,5 +1,5 @@
 module Capybara
   module Lockstep
-    VERSION = "2.2.1"
+    VERSION = "2.2.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capybara-lockstep
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.2.2
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-06-19 00:00:00.000000000 Z
+date: 2024-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -124,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
+rubygems_version: 3.4.3
 signing_key: 
 specification_version: 4
 summary: Synchronize Capybara commands with client-side JavaScript and AJAX requests