capybara-lockstep 2.0.3 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc0373be228e0d19b35174656617d256a469fb1f652728eaa031b91a9370aa38
-  data.tar.gz: 45a3b441340e1cf477564f47af7961799ac0cf37e533a42393c89a08744f1657
+  metadata.gz: 92432e49d223c6a01c09cbe199fec3d3ad0fdc80c5eb5def77883e25f5bace80
+  data.tar.gz: 43fcb6f560accb02c5a6081506a6d1b65c571ab149b0d470efeddf49adb853b9
 SHA512:
-  metadata.gz: b3c3f17a3a6b1e32b43ee86106294b9351bc312234070f4308e93dce8dfeae4198831f04c50e20ca37fc533ecbf1f77b51fe11e24c1336f2866018380052e07a
-  data.tar.gz: 64b39c510daba699db4c0204caa5004e8d367c3e6208a9b2d0a7912925e4dd7c5223e3caf516633310c7f41dbf524af0520715c5051c1d0ead3f8494a0bb0a75
+  metadata.gz: ef3cb7e6d8789b1108602ad7d18ba7e00bf52e93135d8ebec84d9307c556f800f05218d4b23a750d66888e99f9f2939c37f76d3fd3359cdf765b5799b2a3e182
+  data.tar.gz: d2017577968548a815e9e60c9d1fa5838ab3c16fcbb1122acdaf9185e2c44c36766cca61a53de6c016ed691b4d558ae4fab282ed34cd18aa5348a8db64f527ad

data/CHANGELOG.md

@@ -3,9 +3,17 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 
+# 2.1.0
+
+- We now synchronize for an additional [JavaScript task](https://jakearchibald.com/2015/tasks-microtasks-queues-and-schedules/) after `history.pushState()`, `history.replaceState()`, `history.forward()`, `history.back()` and `history.go()`.
+- We now synchronize for an additional JavaScript task after `popstate` and `hashchange` events.
+- We now synchronize for an additional JavaScript task when the window is resized.
+- You can now disable automatic synchronization for the duration of a block: `Capybara::Lockstep.with_mode(:manual) { ... }`.
+
+
 # 2.0.3
 
-- Fix a bug where we wouldn't wait for an additional JavaScript task after a tracked event or async job.
+- Fix a bug where we wouldn't wait for an additional [JavaScript task](https://jakearchibald.com/2015/tasks-microtasks-queues-and-schedules/) after a tracked event or async job.
 - Fix a bug where the `Capybara::Lockstep.wait_tasks` configuration would be ignored.
 - Fix a bug where the `capybara_lockstep_js` helper (for use without Rails) would not include the current configuration. 
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    capybara-lockstep (2.0.3)
+    capybara-lockstep (2.1.1)
       activesupport (>= 4.2)
       capybara (>= 3.0)
       ruby2_keywords
@@ -113,4 +113,4 @@ DEPENDENCIES
   thin
 
 BUNDLED WITH
-   2.2.32
+  4.0.15

data/README.md

@@ -158,7 +158,23 @@ use Capybara::Lockstep::Middleware
 # Other middleware here
 ```
 
+### Configuring Selenium WebDriver (recommended)
 
+By default, webdrivers will automatically dismiss any user prompts (like alerts) when trying to perform an action.
+While capybara-lockstep carefully detects alerts before synchronizing, and will skip interaction with the browser to avoid accidentally dismissing alerts, it can not synchronize around some rare race conditions.
+
+[We recommend](https://makandracards.com/makandra/617366-how-to-configure-selenium-webdriver-to-not-automatically-close-alerts-or-other-browser-dialogs) you configure your webdriver to not automatically dismiss user prompts by setting the "unhandled prompt behavior" capability to [`ignore`](https://w3c.github.io/webdriver/#dfn-known-prompt-handling-approaches-table). Using "ignore", errors are raised like with the default behavior, but user prompts are kept open.
+
+For example, the Chrome driver can be configured like this:
+```ruby
+Capybara.register_driver(:selenium) do |app|
+  options = Selenium::WebDriver::Chrome::Options.new(
+    unhandled_prompt_behavior: 'ignore',
+    # ...
+  )
+  Capybara::Selenium::Driver.new(app, browser: :chrome, options: options)
+end
+```
 
 ### Verify successful integration
 
@@ -349,7 +365,23 @@ ensure
 end
 ```
 
-In the `:manual` mode you may still force synchronization by calling `Capybara::Lockstep.synchronize` manually.
+You can also disable automatic synchronization for the duration of a block:
+
+```ruby
+Capybara::Lockstep.with_mode(:manual) do
+  do_unsynchronized_work
+end
+```
+
+In the `:manual` mode you may still force synchronization by calling `Capybara::Lockstep.synchronize` manually:
+
+```ruby
+Capybara::Lockstep.with_mode(:manual) do
+  do_some_work
+  Capybara::Lockstep.synchronize
+  do_other_work
+end
+```
 
 To completely disable synchronization, even when `Capybara::Lockstep.synchronize` is called:
 
@@ -360,6 +392,8 @@ Capybara::Lockstep.synchronize # will not synchronize
 
 
 
+
+
 ## Handling legacy promises
 
 Legacy promise implementations (like jQuery's `$.Deferred` and AngularJS' `$q`) work using [tasks instead of microtasks](https://jakearchibald.com/2015/tasks-microtasks-queues-and-schedules/). Their AJAX implementations (like `$.ajax()` and `$http`) use task-based promises to signal that a request is done.

data/lib/capybara-lockstep/configuration.rb

@@ -58,7 +58,7 @@ module Capybara
         self.mode = temporary_mode
         block.call
       ensure
-        self.mode = temporary_mode
+        self.mode = old_mode
       end
 
       def enabled=(enabled)

data/lib/capybara-lockstep/helper.js

@@ -4,14 +4,14 @@ window.CapybaraLockstep = (function() {
   let jobCount
   let idleCallbacks
   let finishedWorkTags
-  let waitTasks
+  let defaultWaitTasks
   reset()
 
   function reset() {
     jobCount = 0
     idleCallbacks = []
     finishedWorkTags = []
-    waitTasks = 1
+    defaultWaitTasks = 1
     debug = false
   }
 
@@ -57,8 +57,9 @@ window.CapybaraLockstep = (function() {
     promise.then(taggedStopWork, taggedStopWork)
   }
 
-  function stopWork(tag) {
-    afterWaitTasks(stopWorkNow.bind(this, tag))
+  function stopWork(tag, waitAdditionalTasks = 0) {
+    let effectiveWaitTasks = defaultWaitTasks + waitAdditionalTasks
+    afterWaitTasks(stopWorkNow.bind(this, tag), effectiveWaitTasks)
   }
 
   function stopWorkNow(tag) {
@@ -92,6 +93,27 @@ window.CapybaraLockstep = (function() {
     }
   }
 
+  function trackHistory() {
+    // Wait an additional task because some browsers seem to require additional
+    // time before the URL changes.
+    trackEvent(document, 'popstate', 1)
+    trackEvent(document, 'hashchange', 1)
+
+    // API: https://developer.mozilla.org/en-US/docs/Web/API/History
+    for (let method of ['pushState', 'popState', 'forward', 'back', 'go']) {
+      let workTag = `history.${method}()`
+      let nativeImpl = history[method]
+      history[method] = function(...args) {
+        try {
+          startWork(workTag)
+          return nativeImpl.apply(history, args)
+        } finally {
+          stopWork(workTag, 1)
+        }
+      }
+    }
+  }
+
   function trackXHR() {
     let oldOpen = XMLHttpRequest.prototype.open
     let oldSend = XMLHttpRequest.prototype.send
@@ -135,7 +157,7 @@ window.CapybaraLockstep = (function() {
     // CapybaraLockstep.track() is called as the first script in the head.
     // jQuery will be loaded after us, so we wait until DOMContentReady.
     whenReady(function() {
-      if (!window.jQuery || waitTasks > 0) {
+      if (!window.jQuery || defaultWaitTasks > 0) {
         return
       }
 
@@ -255,11 +277,11 @@ window.CapybaraLockstep = (function() {
     }
   }
 
-  function afterWaitTasks(fn, tasksLeft = waitTasks) {
-    if (tasksLeft > 0) {
+  function afterWaitTasks(fn, waitTasks = defaultWaitTasks) {
+    if (waitTasks > 0) {
       // Wait 1 task and recurse
       setTimeout(function() {
-        afterWaitTasks(fn, tasksLeft - 1)
+        afterWaitTasks(fn, waitTasks - 1)
       })
     } else {
       fn()
@@ -282,14 +304,16 @@ window.CapybaraLockstep = (function() {
     })
   }
 
-  function trackInteraction(eventType) {
-    document.addEventListener(eventType, function() {
+  function trackEvent(eventTarget, eventType, waitAdditionalTasks = 0) {
+    eventTarget.addEventListener(eventType, function() {
       // Only litter the log with interaction events if we're actually going
       // to be busy for at least 1 task.
-      if (waitTasks > 0) {
+      let effectiveWaitTasks = defaultWaitTasks + waitAdditionalTasks
+
+      if (effectiveWaitTasks > 0) {
         let tag = eventType
         startWork(tag)
-        stopWork(tag)
+        stopWork(tag, waitAdditionalTasks)
       }
     })
   }
@@ -297,17 +321,19 @@ window.CapybaraLockstep = (function() {
   function track() {
     trackOldUnpoly()
     trackFetch()
+    trackHistory()
     trackXHR()
     trackRemoteElements()
     trackJQuery()
-    trackInteraction('touchstart')
-    trackInteraction('mousedown')
-    trackInteraction('click')
-    trackInteraction('keydown')
-    trackInteraction('focusin')
-    trackInteraction('focusout')
-    trackInteraction('input')
-    trackInteraction('change')
+    trackEvent(document, 'touchstart')
+    trackEvent(document, 'mousedown')
+    trackEvent(document, 'click')
+    trackEvent(document, 'keydown')
+    trackEvent(document, 'focusin')
+    trackEvent(document, 'focusout')
+    trackEvent(document, 'input')
+    trackEvent(document, 'change')
+    trackEvent(window, 'resize', 1)
   }
 
   function synchronize(callback) {
@@ -327,7 +353,7 @@ window.CapybaraLockstep = (function() {
     synchronize: synchronize,
     reset: reset,
     set debug(value) { debug = value },
-    set waitTasks(value) { waitTasks = value }
+    set waitTasks(value) { defaultWaitTasks = value }
   }
 })()
 

data/lib/capybara-lockstep/version.rb

@@ -1,5 +1,5 @@
 module Capybara
   module Lockstep
-    VERSION = "2.0.3"
+    VERSION = "2.1.1"
   end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: capybara-lockstep
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.1.1
 platform: ruby
 authors:
 - Henning Koch
-autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-01-08 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -66,7 +65,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
 email:
 - henning.koch@makandra.de
 executables: []
@@ -109,7 +107,6 @@ metadata:
   bug_tracker_uri: https://github.com/makandra/capybara-lockstep/issues
   changelog_uri: https://github.com/makandra/capybara-lockstep/blob/master/CHANGELOG.md
   rubygems_mfa_required: 'true'
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -124,8 +121,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.3
-signing_key: 
+rubygems_version: 4.0.15
 specification_version: 4
 summary: Synchronize Capybara commands with client-side JavaScript and AJAX requests
 test_files: []