capybara-lockstep 2.0.0 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a9d5a9ec157f65f4efb9be5ac2b33c5447552eb70e8d118438a7aad763c57492
-  data.tar.gz: 2ddde2a3b51079603d8368f0ebbe81d5205d473beeaf301bb6bdd42c80c968d3
+  metadata.gz: 495d3ed978e831569eb691423ab97e79b4a354e415ce7247c7fba01916bce60a
+  data.tar.gz: bb51f4acfbd6cbe7b19f3e326d7e8d771004babe1ed415ca9f283c1301822ac9
 SHA512:
-  metadata.gz: b7d8723fe020460efad2e46555be0cf50d38e7398103e7462b8d0c21ac8260ee312bd8f7987e1a04ca471d6acb167b6b1e21565ef5ba73b19d021711bbb8743a
-  data.tar.gz: e364cdf67046d885d2f3b27404e258a37388cba10edb1f1f83f286fbc7023ff73f872558dfb33862e95ff6df2f3516bcd687a78094b27a4468ec86cc55a6032a
+  metadata.gz: aeb726459feb3f529e02bc8cc5d8c8cd5afe2377d7906ff5e78485137770ad851cfa7e9a175a3f9ff59bbf2deb4a8fc0d14a06af584928e552a8d25bba3ddc43
+  data.tar.gz: 8f6955613d8a1073dcfeb26d003a22c0694462bdbab917ae66f31b11bbca2af36d5164394e4eafd18157b57d5684d7c9ae2afce4c0693230f91aca7c532d8528

data/CHANGELOG.md

@@ -3,6 +3,16 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 
+# 2.0.2
+
+- Fix a bug where setting a logger object with `Capybara::Lockstep.debug = logger` would crash (by @dorianmarie).
+
+
+# 2.0.1
+
+- Don't crash when an interaction closes the window (tab).
+
+
 # 2.0.0
 
 This major release detects many additional sources of flaky tests: 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    capybara-lockstep (2.0.0)
+    capybara-lockstep (2.0.2)
       activesupport (>= 4.2)
       capybara (>= 3.0)
       ruby2_keywords

data/README.md

@@ -1,4 +1,4 @@
-# capybara-lockstep
+# capybara-lockstep [![Tests](https://github.com/makandra/capybara-lockstep/actions/workflows/test.yml/badge.svg)](https://github.com/makandra/capybara-lockstep/actions)
 
 This Ruby gem synchronizes [Capybara](https://github.com/teamcapybara/capybara) commands with client-side JavaScript and AJAX requests. This greatly improves the stability of an end-to-end ("E2E") test suite, even if that suite has timing issues.
 

data/lib/capybara-lockstep/client.rb

@@ -7,6 +7,7 @@ module Capybara
       ERROR_SNIPPET_MISSING = 'Cannot synchronize: capybara-lockstep JavaScript snippet is missing'
       ERROR_PAGE_MISSING = 'Cannot synchronize with empty page'
       ERROR_ALERT_OPEN = 'Cannot synchronize while an alert is open'
+      ERROR_WINDOW_CLOSED = 'Cannot synchronize with closed window'
       ERROR_NAVIGATED_AWAY = "Browser navigated away while synchronizing"
 
       SYNCHRONIZED_IVAR = :@lockstep_synchronized_client
@@ -94,7 +95,11 @@ module Capybara
           end
         rescue ::Selenium::WebDriver::Error::UnexpectedAlertOpenError
           log ERROR_ALERT_OPEN
-          # Don't raise an error, this will happen in an innocent test.
+          # Don't raise an error, this will happen in an innocent test where a click opens an alert.
+          # We will retry on the next Capybara synchronize call.
+        rescue ::Selenium::WebDriver::Error::NoSuchWindowError
+          log ERROR_WINDOW_CLOSED
+          # Don't raise an error, this will happen in an innocent test where a click closes a window.
           # We will retry on the next Capybara synchronize call.
         rescue ::Selenium::WebDriver::Error::JavascriptError => e
           # When the URL changes while a script is running, my current selenium-webdriver

data/lib/capybara-lockstep/configuration.rb

@@ -35,7 +35,7 @@ module Capybara
         end
 
         send_config_to_browser(<<~JS)
-          CapybaraLockstep.debug = #{value.to_json}
+          CapybaraLockstep.debug = #{debug?.to_json}
         JS
 
         @debug

data/lib/capybara-lockstep/logging.rb

@@ -6,7 +6,7 @@ module Capybara
           message = "[capybara-lockstep] #{message}"
           if is_logger?(Lockstep.debug)
             # If someone set Capybara::Lockstep.debug to a logger, use that
-            Lockstep.debug(message)
+            Lockstep.debug.debug(message)
           else
             # Otherwise print to STDOUT
             puts message

data/lib/capybara-lockstep/page_access.rb

@@ -19,7 +19,7 @@ module Capybara
         # to its `getLog` API. This causes Selenium to time out with a `Net::ReadTimeout` error
         page.driver.browser.switch_to.alert
         true
-      rescue Capybara::NotSupportedByDriverError, ::Selenium::WebDriver::Error::NoSuchAlertError
+      rescue Capybara::NotSupportedByDriverError, ::Selenium::WebDriver::Error::NoSuchAlertError, ::Selenium::WebDriver::Error::NoSuchWindowError
         false
       end
 

data/lib/capybara-lockstep/version.rb

@@ -1,5 +1,5 @@
 module Capybara
   module Lockstep
-    VERSION = "2.0.0"
+    VERSION = "2.0.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capybara-lockstep
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.2
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-11-24 00:00:00.000000000 Z
+date: 2023-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara