capybara-lockstep 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec0d3874212ec29a338fa16ef831e76c0b8dc65b4a200f3a305b7ce41bd76957
-  data.tar.gz: b5d48346fb7224b2154512534757ef96638f1df9cc62f9d0f911aac8d6a5f846
+  metadata.gz: 5496cc79e785bf2ce69669e7a8a6d8ae6f862289f5151487c27a33caa20aa9f7
+  data.tar.gz: 635cb396a2ceccbf550a44b2331b3cf1a2340f555557c3eac9440cc6231f5033
 SHA512:
-  metadata.gz: 4d44c17fa50ca0fd386b34ecea302148989f4d48d63c48820bcfff75bcd51c63cfbacea0053e63fc1c27f6347fbe252f14be83372aed123a6a1c2574328fe42e
-  data.tar.gz: 9e7f5cfcbb6b3750277bc55c37484e17859aa4d96f1b8f7b6c1865f4467ae00fad5311e11ea0bfc73d5b8ec5c925df5c8ec6bb2473da6b431296736c89972794
+  metadata.gz: e69a2f28e913cef9913825fe1b2594bda44ad31af54a1041978adcd437e8f17518d91d8b3b4e4c0dc71f4259780427288db9ba474f39607e39f60e362a143a9f
+  data.tar.gz: 2bb6122c49734c852b3ed64486cbe00dc0c10d51d9de8311c7c11ce5aff85482b97105e2d8c4d6acccfb70efbd2f6855526c8a7d58e36e10237e49a15b746af8

data/CHANGELOG.md

@@ -2,6 +2,11 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+
+## 1.2.1 - 2022-09-12
+
+- Synchronize with pages constructed from non-empty [data URLs](https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URLs)
+
 ## 1.2.0 - 2022-09-12
 
 ### Synchronization around history navigation

data/Gemfile

@@ -14,3 +14,5 @@ gem 'chrome_remote'
 
 gem 'byebug'
 gem 'gemika'
+
+gem 'activesupport', '~> 6.0'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    capybara-lockstep (1.2.0)
+    capybara-lockstep (1.3.0)
       activesupport (>= 3.2)
       capybara (>= 2.0)
       ruby2_keywords
@@ -10,15 +10,16 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.1)
+    activesupport (6.1.7)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-    addressable (2.8.0)
-      public_suffix (>= 2.0.2, < 5.0)
+      zeitwerk (~> 2.3)
+    addressable (2.8.1)
+      public_suffix (>= 2.0.2, < 6.0)
     byebug (11.1.3)
-    capybara (3.36.0)
+    capybara (3.37.1)
       addressable
       matrix
       mini_mime (>= 0.1.3)
@@ -35,7 +36,7 @@ GEM
     diff-lcs (1.3)
     eventmachine (1.2.7)
     gemika (0.6.0)
-    i18n (1.10.0)
+    i18n (1.12.0)
       concurrent-ruby (~> 1.0)
     jasmine (3.6.0)
       jasmine-core (~> 3.6.0)
@@ -45,17 +46,17 @@ GEM
     jasmine-core (3.6.0)
     matrix (0.4.2)
     mini_mime (1.1.2)
-    minitest (5.15.0)
-    nokogiri (1.13.0-x86_64-linux)
+    minitest (5.16.3)
+    nokogiri (1.13.8-x86_64-linux)
       racc (~> 1.4)
     phantomjs (2.1.1.0)
-    public_suffix (4.0.6)
+    public_suffix (5.0.0)
     racc (1.6.0)
     rack (2.2.3)
-    rack-test (1.1.0)
-      rack (>= 1.0, < 3)
+    rack-test (2.0.2)
+      rack (>= 1.3)
     rake (13.0.1)
-    regexp_parser (2.2.0)
+    regexp_parser (2.5.0)
     rexml (3.2.5)
     rspec (3.7.0)
       rspec-core (~> 3.7.0)
@@ -72,26 +73,30 @@ GEM
     rspec-support (3.7.0)
     ruby2_keywords (0.0.5)
     rubyzip (2.3.2)
-    selenium-webdriver (4.1.0)
+    selenium-webdriver (4.4.0)
       childprocess (>= 0.5, < 5.0)
       rexml (~> 3.2, >= 3.2.5)
-      rubyzip (>= 1.2.2)
+      rubyzip (>= 1.2.2, < 3.0)
+      websocket (~> 1.0)
     thin (1.8.0)
       daemons (~> 1.0, >= 1.0.9)
       eventmachine (~> 1.0, >= 1.0.4)
       rack (>= 1, < 3)
-    tzinfo (2.0.4)
+    tzinfo (2.0.5)
       concurrent-ruby (~> 1.0)
+    websocket (1.2.9)
     websocket-driver (0.7.3)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
     xpath (3.2.0)
       nokogiri (~> 1.8)
+    zeitwerk (2.6.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  activesupport (~> 6.0)
   byebug
   capybara-lockstep!
   chrome_remote

data/README.md

@@ -345,6 +345,17 @@ Waiting additional tasks will have a negative performance impact on your test su
 > **Note:** When capybara-lockstep detects jQuery on the page, it will automatically patch [`$.ajax()`](https://api.jquery.com/jQuery.ajax/) to wait an additional task after the response was received. If your only concern is callbacks to `$.ajax()` you do not need so set `Capybara::Lockstep.wait_tasks`.
 
 
+## Running code after synchronization
+
+You can configure a proc to run after successful synchronization:
+
+```ruby
+Capybara::Lockstep.after_synchronize do
+  puts "Synchronized!"
+end
+````
+
+
 ## Contributing
 
 Pull requests are welcome on GitHub at <https://github.com/makandra/capybara-lockstep>.

data/lib/capybara-lockstep/configuration.rb

@@ -77,8 +77,22 @@ module Capybara
         @wait_tasks
       end
 
+      def after_synchronize(&callback)
+        after_synchronize_callbacks << callback
+      end
+
       private
 
+      def after_synchronize_callbacks
+        @before_synchronize_callbacks ||= []
+      end
+
+      def run_after_synchronize_callbacks
+        after_synchronize_callbacks.each do |callback|
+          instance_eval(&callback)
+        end
+      end
+
       def javascript_driver?
         driver.is_a?(Capybara::Selenium::Driver)
       end

data/lib/capybara-lockstep/lockstep.rb

@@ -1,7 +1,7 @@
 module Capybara
   module Lockstep
     ERROR_SNIPPET_MISSING = 'Cannot synchronize: capybara-lockstep JavaScript snippet is missing'
-    ERROR_PAGE_MISSING = 'Cannot synchronize before initial Capybara visit'
+    ERROR_PAGE_MISSING = 'Cannot synchronize with empty page'
     ERROR_ALERT_OPEN = 'Cannot synchronize while an alert is open'
     ERROR_NAVIGATED_AWAY = "Browser navigated away while synchronizing"
 
@@ -53,6 +53,8 @@ module Capybara
         end
 
         synchronize_now(log: log)
+
+        run_after_synchronize_callbacks
       end
 
       # Automatic synchronization from within the capybara-lockstep should always call #auto_synchronize.
@@ -85,8 +87,8 @@ module Capybara
                   done(#{ERROR_SNIPPET_MISSING.to_json})
                 }
               }
-              let protocol = location.protocol
-              if (protocol === 'data:' || protocol == 'about:') {
+              const emptyDataURL = /^data:[^,]*,?$/
+              if (emptyDataURL.test(location.href) || location.protocol === 'about:') {
                 done(#{ERROR_PAGE_MISSING.to_json})
               } else if (document.readyState === 'complete') {
                 // WebDriver always waits for the `load` event after a visit(),
@@ -136,9 +138,10 @@ module Capybara
           end
         rescue StandardError => e
           unhandled_synchronize_error(e)
-        ensure
-          self.synchronizing = false
         end
+
+      ensure
+        self.synchronizing = false
       end
 
       def unhandled_synchronize_error(e)

data/lib/capybara-lockstep/version.rb

@@ -1,5 +1,5 @@
 module Capybara
   module Lockstep
-    VERSION = "1.2.0"
+    VERSION = "1.3.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capybara-lockstep
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-09-12 00:00:00.000000000 Z
+date: 2023-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara