capybara-lightpanda 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d2922897678cf6ea18bd630b63703ae59ca213b4909e5c42d60e5c1b55e7faa
-  data.tar.gz: 8b01db5b4f0b7c8da5e13d2c9b157c2184463e3b22637ec1d6d5d4d3d84d17f7
+  metadata.gz: ad9d7f3b8897578e98e75f2b27f35ec4f2178c4ef884d9b69b79ad8d60378a42
+  data.tar.gz: ce602d8d708904f4f2f5dced507f838445fccb6693df8350779cf544c6871fa4
 SHA512:
-  metadata.gz: 7e09df8530d946074c1b9022820ebe3ff6c3bc19d69ee1f543df7c3e65c6d6cc2ace6c65910028fb69ca7253488a88df10f3c271bcced82358e71e44c128cb1e
-  data.tar.gz: 93feae0c267585dfc745d01ec65d651b682903794588ea2cc18c3c071b313c4b869bde6c35cd8bfbe8c2e00b1c51ac49ba1cd6ddc5b624c33f1f0e7dc8575286
+  metadata.gz: 05d437473e7f35d10af8b8d65e460f9808e395df438881fdb6eac5e0d8af3cfce36cee4fb156e17803889645411508778c927570987d85fb7512190a7af49dfe
+  data.tar.gz: edb94ac9d172c62b61496d3a92f9c408406642c9053517f053ba8829a4c704847f9c9d1903a5b79fb0acdb743aa26f476a092e8b3050b9677d2896fae0e637e1

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## [0.6.0] - 2026-06-11
+
+> **Update Lightpanda before upgrading.** Requires a nightly build ≥ 6699 (published 2026-06-11). The driver refuses to start against older binaries.
+
+### Added
+
+- File upload through Capybara's standard `attach_file` now works end to end. `attach_file("Avatar", "/path/to/photo.png")` populates the `<input type=file>` and fires `change`, and — the piece that was missing before — the file's bytes are submitted with the form as proper multipart data (filename, `Content-Type`, content). So uploads the server actually receives (avatar pickers, CSV/import forms, ActiveStorage attachments) can be driven and asserted, not just the client-side `change` handler. File paths are read on the machine running Lightpanda.
+- Drag-and-drop file and data upload through Capybara's standard `Element#drop`. `find("#dropzone").drop("/path/to/report.pdf")` reads the file and rebuilds it as a `File` inside the page; `find("#dropzone").drop("text/plain" => "hello")` drops typed string data. The driver builds a `DataTransfer` and fires `dragenter` → `dragover` → `drop`, so HTML5 dropzones (React Dropzone, Uppy, ActiveStorage direct-upload) receive the payload through `event.dataTransfer.files` / `.items`. This is drag-and-drop *upload*, not element-to-element `drag_to`, which still needs the layout geometry Lightpanda doesn't have.
+
 ## [0.5.0] - 2026-05-22
 
 > **Update Lightpanda before upgrading.** Requires a nightly build ≥ 6353 (published 2026-05-21). The driver refuses to start against older binaries.

data/lib/capybara/lightpanda/browser.rb

@@ -136,11 +136,6 @@ module Capybara
       # would otherwise require explicit cookies.clear / storage.clear /
       # close-target dance, and the browser auto-isolates state for the
       # new context. Driver#reset! delegates here.
-      #
-      # Side benefit: avoids `Page.navigate("about:blank")` against a
-      # non-blank tab, which doesn't actually replace the document on
-      # current Lightpanda nightly (lightpanda-io/browser#2363). The
-      # context-disposal path sidesteps that bug entirely.
       def reset
         dispose_browser_context
         @client.clear_subscriptions
@@ -508,6 +503,17 @@ module Capybara
         page_command("DOM.describeNode", objectId: remote_object_id).dig("node", "backendNodeId")
       end
 
+      # Populate a file <input> from one or more local file paths via
+      # DOM.setFileInputFiles (PR #2635, build ≥6625): Lightpanda resolves the
+      # objectId, replaces input.files with a real FileList, and fires
+      # `input`/`change`. The submitted form then carries the bytes as
+      # multipart/form-data (PR #2654, build ≥6672) — both halves are needed,
+      # which is why MINIMUM_NIGHTLY_BUILD sits at the 6672 floor. Paths are
+      # read off the machine running Lightpanda (local for the spawned process).
+      def set_file_input_files(remote_object_id, paths)
+        page_command("DOM.setFileInputFiles", objectId: remote_object_id, files: paths)
+      end
+
       def screenshot(path: nil, format: :png, quality: nil, full_page: false, encoding: :binary)
         params = { format: format.to_s }
         params[:quality] = quality if quality && format == :jpeg

data/lib/capybara/lightpanda/node.rb

@@ -113,14 +113,18 @@ module Capybara
         call("function() { this.dispatchEvent(new MouseEvent('mouseover', {bubbles: true, cancelable: true})) }")
       end
 
-      # Lightpanda has no rendering engine — `window.scrollTo` / `scrollIntoView`
-      # are no-ops at the browser level, and `getBoundingClientRect` reflects
-      # logical-DOM geometry rather than scroll-aware viewport coords. So
-      # there's nothing to scroll. Silently succeed so callers like
-      # `session.scroll_to(find('#thing'))` (Selenium-flavoured specs leaning
-      # on real layout) don't crash with NotImplementedError; assertions that
-      # depend on post-scroll visibility are already gated by the cuprite
-      # fallback in dual-driver setups.
+      # Kept as a deliberate no-op despite upstream now tracking scroll position
+      # (`window.scrollTo`/`scrollBy` update `window._scroll_pos`, `Element`
+      # exposes `scrollTop`/`scrollLeft` — Window.zig/Element.zig). Wiring it
+      # would still misbehave: Lightpanda never clamps to content height
+      # (`scrollHeight`/`clientHeight` are a hardcoded 1e8), so `:bottom`/`:center`
+      # are meaningless; element scroll is decoupled from window scroll; and with
+      # no layout `getBoundingClientRect` isn't scroll-aware, so `scroll_to(el,
+      # align:)` can't position anything. So there's nothing meaningful to scroll
+      # to. Silently succeed so callers like `session.scroll_to(find('#thing'))`
+      # don't crash with NotImplementedError. The `:scroll` capability stays in
+      # `capybara_skip`. (Window-position scroll IS reachable for real via
+      # `execute_script('window.scrollTo(...)')` if a caller truly needs it.)
       def scroll_to(*); end
       def scroll_by(*); end
 
@@ -147,6 +151,21 @@ module Capybara
         end
       end
 
+      # Capybara's drag-and-drop API (`Element#drop`). String/Pathname arguments
+      # are file paths — read here and rebuilt as `File` objects in the page;
+      # Hash arguments are `{ mime_type => data }` string drops. We assemble a
+      # `DataTransfer` and fire `dragenter` -> `dragover` -> `drop` on this
+      # element, so HTML5 dropzones see the payload via `event.dataTransfer`.
+      #
+      # DataTransfer/DataTransferItem/DragEvent landed upstream in PR #2671
+      # (build ≥6699) and are guaranteed by the MINIMUM_NIGHTLY_BUILD floor;
+      # without them the drop JS raises "DataTransfer is not defined".
+      def drop(*args)
+        files, strings = partition_drop_args(args)
+        call(DROP_JS, files.to_json, strings.to_json)
+        nil
+      end
+
       def select_option
         call(SELECT_OPTION_JS)
       end
@@ -272,7 +291,13 @@ module Capybara
         when "checkbox", "radio"
           call(SET_CHECKBOX_JS, value ? true : false)
         when "file"
-          raise NotImplementedError, "File uploads not yet supported by Lightpanda"
+          # DOM.setFileInputFiles (PR #2635, build ≥6625) sets input.files +
+          # fires change; multipart form submission carries the bytes upstream
+          # (PR #2654, build ≥6672, webapi/net/FormData.zig). Both halves are in
+          # the floor, so attach_file uploads end-to-end. `value` is a path
+          # String or Array<String> (multiple: true); cast each element so a
+          # Pathname / non-string locator still serializes over CDP.
+          driver.browser.set_file_input_files(@remote_object_id, Array(value).map(&:to_s))
         when "date"
           call(SET_VALUE_JS, format_date_value(value))
         when "time"
@@ -349,6 +374,44 @@ module Capybara
         n.positive? ? str[0, n] : str
       end
 
+      # Split `drop` arguments into file descriptors and string-data descriptors.
+      # Strings/Pathnames (Capybara normalizes `#to_path`) are file paths, read
+      # here and base64-encoded so binary content survives the JSON hop; Hashes
+      # are `{ type => data }` string drops. Returns `[files, strings]`.
+      def partition_drop_args(args)
+        files = []
+        strings = []
+        args.each do |arg|
+          if arg.is_a?(Hash)
+            arg.each { |type, data| strings << { type: type.to_s, data: data.to_s } }
+          else
+            path = arg.to_s
+            files << {
+              name: File.basename(path),
+              type: drop_mime_for(path),
+              b64: [File.binread(path)].pack("m0"),
+            }
+          end
+        end
+        [files, strings]
+      end
+
+      # The dropzone handler only reads `file.name`, but real upload widgets key
+      # off `file.type`, so map the common upload extensions and fall back to a
+      # generic binary type.
+      DROP_MIME_TYPES = {
+        ".jpg" => "image/jpeg", ".jpeg" => "image/jpeg", ".png" => "image/png",
+        ".gif" => "image/gif", ".webp" => "image/webp", ".svg" => "image/svg+xml",
+        ".pdf" => "application/pdf", ".txt" => "text/plain", ".csv" => "text/csv",
+        ".json" => "application/json", ".html" => "text/html", ".xml" => "application/xml",
+        ".zip" => "application/zip",
+      }.freeze
+      private_constant :DROP_MIME_TYPES
+
+      def drop_mime_for(path)
+        DROP_MIME_TYPES.fetch(File.extname(path).downcase, "application/octet-stream")
+      end
+
       # Whitespace-normalized text (Cuprite pattern). Capybara's text matchers compare
       # against this, and Lightpanda's textContent preserves source-template whitespace
       # differently than Chrome — without normalization, multi-line fixtures fail
@@ -474,6 +537,26 @@ module Capybara
         }
       JS
 
+      # Build a DataTransfer from the JSON payloads and replay the HTML5 drop
+      # sequence on this element. Files arrive base64-encoded and are rebuilt
+      # with `atob` (Blob accepts the binary string directly); string drops are
+      # added as typed items so the page can read them via getData/getAsString.
+      DROP_JS = <<~JS
+        function(filesJson, stringsJson) {
+          var el = this;
+          var dt = new DataTransfer();
+          JSON.parse(filesJson).forEach(function(f) {
+            dt.items.add(new File([atob(f.b64)], f.name, { type: f.type }));
+          });
+          JSON.parse(stringsJson).forEach(function(s) {
+            dt.items.add(s.data, s.type);
+          });
+          ['dragenter', 'dragover', 'drop'].forEach(function(name) {
+            el.dispatchEvent(new DragEvent(name, { bubbles: true, cancelable: true, dataTransfer: dt }));
+          });
+        }
+      JS
+
       VISIBLE_JS = "function() { return _lightpanda.isVisible(this); }"
 
       VISIBLE_TEXT_JS = "function() { return _lightpanda.visibleText(this); }"

data/lib/capybara/lightpanda/process.rb

@@ -68,7 +68,15 @@ module Capybara
       # unconditionally, so the floor MUST include the build that introduced
       # it; the flag is a fatal UnknownOption on builds < 6353),
       # PR #2498 (StyleManager: author display rule beats UA [hidden] — fixes
-      # the Stimulus/Alpine dropdown ElementNotFound).
+      # the Stimulus/Alpine dropdown ElementNotFound),
+      # PR #2635 (dom: DOM.setFileInputFiles backs input.files + fires change
+      # for <input type=file>) AND PR #2654 (forms: encode file inputs as
+      # multipart/form-data on submit — filename + Content-Type + bytes per
+      # RFC 7578). Both halves are required for attach_file to upload end-to-end:
+      # #2635 populates the FileList, #2654 makes form submission carry the
+      # bytes. Node#fill_input's `when "file"` branch calls
+      # Browser#set_file_input_files, so the floor MUST include the #2654 build;
+      # on builds 6625–6671 the file attaches but the form submits empty.
       # NOTE: the gem's teardown hang is the live-CDP-connection SIGTERM hang
       # (limitation #7B) — telemetry-independent, present on 6353 AND on the #2509
       # fix build, handled by the at_exit WS-close plus the SIGKILL backstop
@@ -76,9 +84,16 @@ module Capybara
       # disables telemetry, so it never creates the curl multi #2507 needs. Keep
       # both teardown defenses even after #2511 (the variant-B fix, MERGED in
       # build 6371) lands in a nightly.
-      # Build 6353 = main HEAD merge f1b0adf9 (2026-05-20) carrying #2487 +
-      # #2498; the first published nightly with it is the 2026-05-21 cut.
-      MINIMUM_NIGHTLY_BUILD = Gem::Version.new("6353")
+      # Build 6672 = the #2654 merge (22d1c5ec, 2026-06-08) — the first commit
+      # carrying both file-upload halves.
+      # PR #2671 (DataTransfer / DataTransferItem / DataTransferItemList +
+      # DragEvent, merged 2026-06-10) provides the APIs Node#drop's DROP_JS
+      # assembles its payload from; on builds without it the drop JS raises
+      # "DataTransfer is not defined".
+      # Build 6699 = the #2671 merge (d1f4c409, 2026-06-10) — now the binding
+      # floor. (The prior 6672 file-upload floor — and 6353 before it — are
+      # subsumed.)
+      MINIMUM_NIGHTLY_BUILD = Gem::Version.new("6699")
 
       attr_reader :pid, :ws_url, :version, :nightly_build
 

data/lib/capybara/lightpanda/version.rb

@@ -2,6 +2,6 @@
 
 module Capybara
   module Lightpanda
-    VERSION = "0.5.0"
+    VERSION = "0.6.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara-lightpanda
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Navid Emad