capybara-lightpanda 0.15.0 → 0.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bcfaa2e5c56f74e8f6068a969ee03d669d11d49de80ae360fb4a62a96833c8f3
-  data.tar.gz: 3a22106094a7f2de8c3447f9573286e90a4158f25f88b06701cf4540ab9e2147
+  metadata.gz: a8f6c1cfdad13de4569b3d79828d9d19848b166e220b6a91329c7c0cb2fa9781
+  data.tar.gz: 2f7c90bb35b746682f5533c9d7ebfe1b64fbf7aea1f53a6c93f563428d9f3b46
 SHA512:
-  metadata.gz: ebf7c506245fdc550ff5ac3bc643dfe6369c4324642bffe8fb4a27f891f009eaaa842effe0bb7386dfc6d50819ad934d0a3df0e7f67e4fb222116baa5a957955
-  data.tar.gz: 2aaef86e3c5a6c1a4e25c3476790352564df15c0b46c18c02745b5999e587a35090ff88837340dec8e00f977a828ec3ce1eaf9a505b10abfb0412e2538cf4d13
+  metadata.gz: 1d1632dc29185af1e1d1c594abd7a9fe4b0af584585aa6c6534428d59b23316174db581d901bd7d67430b2e708c664c9c7175918cfeca4d386ba95453816b910
+  data.tar.gz: 76a79eed2e960c294a09c1ee8882014d543c5695cd519d51c3d9560ca7b153b085ae4161f18e2a11a301465b95c0cc71140a269c3c8970c86e93d291430630cb

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [0.16.0] - 2026-10-26
+
+### Fixed
+
+- **`trigger(:click)` waits for the page it loads.** Calling `element.trigger(:click)` on a link or submit button returned before the new page arrived, so the next step ran against the old page. It now waits the way `click` does.
+- **Clicking a `<a download>` link no longer cancels the download on recent nightlies.** From nightly 11097 (and the upcoming 1.1 release line), Lightpanda starts the download itself when a link has a `download` attribute. The driver then also went to the same URL, which cancelled the download and replaced the page. The driver now leaves the download to the browser. Older browsers behave as before.
+- **`obscured?` sees overlays inside a shadow root.** On browsers that can hit-test inside shadow trees (recent nightlies), an element covered by another element in the same shadow root now counts as obscured; before, it was always reported as not obscured. Older browsers give the same answer as before.
+
 ## [0.15.0] - 2026-10-23
 
 > **Update Lightpanda before upgrading.** This release requires Lightpanda **1.0.2** or a nightly build ≥ 10965. The driver refuses anything older and names the version it found. Pin `1.0.2` for a reproducible browser.

data/lib/capybara/lightpanda/downloads.rb

@@ -12,10 +12,10 @@ module Capybara
     # `Browser.downloadProgress`. We mirror those into a completed-files list +
     # a blocking `wait`, the way ferrum's Downloads does.
     #
-    # IMPORTANT: the trigger is `Content-Disposition: attachment`, NOT MIME
-    # type. A `text/csv` (or any) response without that header is rendered as a
-    # normal navigation, not downloaded — which is why Capybara's MIME-triggered
-    # `:download` shared spec stays in capybara_skip.
+    # Navigation downloads require Content-Disposition: attachment, not just a
+    # MIME type. New browsers also honor an anchor's download attribute (build
+    # 11097 / 1.1 release line); Node#click lets that native activation finish.
+    # Capybara's MIME-only :download shared spec still stays in capybara_skip.
     #
     # Structure deliberately mirrors Network (same browser ref, same mutex +
     # subscribe/unsubscribe lifecycle, same reset-after-disposeBrowserContext

data/lib/capybara/lightpanda/javascripts/predicates.js

@@ -54,17 +54,24 @@ function isObscured(el) {
   if (cx < 0 || cy < 0 || cx > w || cy > h) return true;
   var hit = doc.elementFromPoint(cx, cy);
   if (!hit) return true;
-  if (hit === el) return false;
-  if (el.contains(hit)) return false;
-  // A hit inside a shadow tree is retargeted to its host, and there is no
-  // ShadowRoot.elementFromPoint to look further, so landing on one of el's own
-  // hosts is the best "not obscured" answer available.
-  var root = el.getRootNode ? el.getRootNode() : doc;
+  // Document hit testing retargets a shadow child to its outermost host.
+  // Check each enclosing shadow tree from the outside in: an inner root must
+  // never let us see through an overlay covering its host in an outer root.
+  var roots = [], root = el.getRootNode ? el.getRootNode() : doc;
   while (root && root !== doc && root.host) {
-    if (hit === root.host) return false;
+    roots.push(root);
     root = root.host.getRootNode();
   }
-  return true;
+  for (var i = roots.length - 1; i >= 0; i--) {
+    root = roots[i];
+    if (hit !== root.host) break;
+    // Older supported builds have no shadow hit testing. A hit on our own
+    // host remains the best available evidence that the child is actionable.
+    if (typeof root.elementFromPoint !== 'function') return false;
+    hit = root.elementFromPoint(cx, cy);
+    if (!hit) return true;
+  }
+  return hit !== el && !el.contains(hit);
 }
 
 // Capybara's `Node#disabled?` is more permissive than CSS `:disabled`:

data/lib/capybara/lightpanda/node.rb

@@ -135,7 +135,7 @@ module Capybara
       end
 
       def click(_keys = [], **_options)
-        call(CLICK_JS)
+        call(CLICK_JS, native_anchor_downloads?)
         driver.browser.wait_for_idle
       end
 
@@ -178,7 +178,9 @@ module Capybara
       # generic Event for everything else (so callers can fire custom events
       # like `node.trigger('lp:custom')`).
       def trigger(event)
-        call(TRIGGER_JS, event.to_s)
+        name = event.to_s
+        call(TRIGGER_JS, name)
+        driver.browser.wait_for_idle if name == "click"
       end
 
       def set(value, **_options)
@@ -374,6 +376,18 @@ module Capybara
 
       private
 
+      # Below #4124 a download attribute suppresses native activation entirely,
+      # so the manual navigation is still needed for attachment responses.
+      # The API has no feature marker: keep the floor path through 1.0.x and
+      # enable native download activation on build 11097 / the 1.1 release line.
+      def native_anchor_downloads?
+        browser = driver.browser
+        build = browser.nightly_build
+        return build >= Gem::Version.new("11097") if build
+
+        browser.release && browser.release >= Gem::Version.new("1.1.0")
+      end
+
       def find_hinted(method, selector, hints)
         driver.browser.find_within_hinted(@remote_object_id, method, selector, self.class.hint_spec(**hints))
               .map { |oid, cache| self.class.new(driver, oid, cache, frame_scoped: @frame_scoped) }
@@ -593,7 +607,7 @@ module Capybara
       # 6167 as duplicate `turbo:submit-start` events; the first request
       # gets aborted by the second and Turbo never renders the response.
       CLICK_JS = <<~JS
-        function() {
+        function(nativeAnchorDownloads) {
           var EventCtor = (typeof MouseEvent !== 'undefined') ? MouseEvent : Event;
           // Emulate coordinate hit-testing without a layout engine. In a real
           // browser a pointer click on a container lands on its frontmost
@@ -658,6 +672,11 @@ module Capybara
           var external = !!scheme && !/^(https?|about|blob|data|file|javascript)$/i.test(scheme[1]);
           var notCancelled = hit.dispatchEvent(clickEvt);
           if (external || !notCancelled || clickEvt.defaultPrevented) return;
+          // Native activation has already started the download. Navigating
+          // again cancels it and replaces the document. Keep the complete
+          // synthetic event sequence and its cancellation, but stop here on
+          // browsers that support the download attribute.
+          if (nativeAnchorDownloads && link && link.hasAttribute('download')) return;
           var tag = hit.tagName;
           // A `javascript:` link never navigates: the click's own activation
           // behavior has already run its code. Assigning it to location.href

data/lib/capybara/lightpanda/version.rb

@@ -2,6 +2,6 @@
 
 module Capybara
   module Lightpanda
-    VERSION = "0.15.0"
+    VERSION = "0.16.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara-lightpanda
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.16.0
 platform: ruby
 authors:
 - Navid Emad