capybara-js_finders 0.2.1 → 0.2.2

data/lib/capybara-js_finders.rb

@@ -13,29 +13,34 @@ module Capybara
     BR = "br".freeze # Bottom range
     XpathTrue = "(1=1)"
 
-    # TODO: This script is only prototype compatibile. Let it discover jquery or prototype and use proper methods.
+    # TODO: This script is only prototype compatible. Let it discover jquery or prototype and use proper methods.
+    # 
+    # If element left offset is 5 and element width is 10 then it cannot occupy pixels from 5 to 15 because that would give us 11px width.
+    # Element must occupy pixels from 6 to 15 or from 5 to 14 (including).
+    #
+    # I assume that the former answer is correct.
+    # Element starts on 6th pixel and that's why offset is equal to 5. TODO: Make sure there is test for that!
+    #
     SCRIPT = <<-JS
-    xpathResult = document.evaluate( "#{descendant(:th, :td)}", document, null, XPathResult.ANY_TYPE, null);
-    var ary = [];
-    var td;
-    while( td = xpathResult.iterateNext() ){
-      ary.push(td);
-    }
-    ary.each(function(ele){
-      try{
-        var offset = ele.cumulativeOffset();
-        var lr = offset.left;
-        var rr = lr + ele.getWidth();
-        var tr = offset.top;
-        var br = tr + ele.getHeight();
-        ele.setAttribute('#{LR}', lr);
-        ele.setAttribute('#{RR}', rr);
-        ele.setAttribute('#{TR}', tr);
-        ele.setAttribute('#{BR}', br);
-      } catch(err){
-        /* ele.getWidth() and ele.getHeight() sometimes raises an exception, just skip ele in such case, there is nothing we can do about it! */
+      xpathResult = document.evaluate( "#{descendant(:th, :td)}", document, null, XPathResult.ANY_TYPE, null);
+      var ary = [];
+      var td;
+      while( td = xpathResult.iterateNext() ){
+        ary.push(td);
       }
-    });
+      ary.each(function(ele){
+        try{
+          var dimensions = ele.getDimensions();
+          var offset = ele.cumulativeOffset();
+
+          ele.setAttribute('#{LR}', offset.left + 1);
+          ele.setAttribute('#{RR}', offset.left + dimensions.width);
+          ele.setAttribute('#{TR}', offset.top  + 1);
+          ele.setAttribute('#{BR}', offset.top  + dimensions.height);
+        } catch(err){
+          /* ele.getDimensions() sometimes raises an exception, just skip ele in such case, there is nothing we can do about it! */
+        }
+      });
     JS
     SCRIPT.freeze
 
@@ -124,7 +129,7 @@ module Capybara
       execute_script(SCRIPT)
       xpath = JsFinders.cell_condition(columns, rows)
       xpath = ".//td[ #{xpath} ]"
-      #puts xpath
+      # puts xpath
       find(:xpath, xpath, options)
     end
   end

data/lib/capybara-js_finders/version.rb

@@ -1,5 +1,5 @@
 module Capybara
   module JsFinders
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara-js_finders
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-07-18 00:00:00.000000000Z
+date: 2011-07-25 00:00:00.000000000 +02:00
+default_executable: 
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
-  requirement: &87884780 !ruby/object:Gem::Requirement
+  requirement: &78592980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +22,10 @@ dependencies:
         version: 1.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *87884780
+  version_requirements: *78592980
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &87875910 !ruby/object:Gem::Requirement
+  requirement: &78592730 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +33,10 @@ dependencies:
         version: 0.9.0
   type: :development
   prerelease: false
-  version_requirements: *87875910
+  version_requirements: *78592730
 - !ruby/object:Gem::Dependency
   name: rdoc
-  requirement: &87875680 !ruby/object:Gem::Requirement
+  requirement: &78592500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +44,10 @@ dependencies:
         version: 2.4.2
   type: :development
   prerelease: false
-  version_requirements: *87875680
+  version_requirements: *78592500
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &87875450 !ruby/object:Gem::Requirement
+  requirement: &78592270 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +55,10 @@ dependencies:
         version: 1.2.6
   type: :development
   prerelease: false
-  version_requirements: *87875450
+  version_requirements: *78592270
 - !ruby/object:Gem::Dependency
   name: erubis
-  requirement: &87875220 !ruby/object:Gem::Requirement
+  requirement: &78592040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +66,10 @@ dependencies:
         version: 2.6.6
   type: :development
   prerelease: false
-  version_requirements: *87875220
+  version_requirements: *78592040
 - !ruby/object:Gem::Dependency
   name: bbq
-  requirement: &87874990 !ruby/object:Gem::Requirement
+  requirement: &78591810 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,10 +77,10 @@ dependencies:
         version: 0.0.3
   type: :development
   prerelease: false
-  version_requirements: *87874990
+  version_requirements: *78591810
 - !ruby/object:Gem::Dependency
   name: redcarpet
-  requirement: &87874760 !ruby/object:Gem::Requirement
+  requirement: &78591580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,10 +88,10 @@ dependencies:
         version: '1.17'
   type: :development
   prerelease: false
-  version_requirements: *87874760
+  version_requirements: *78591580
 - !ruby/object:Gem::Dependency
   name: ruby-debug19
-  requirement: &87874570 !ruby/object:Gem::Requirement
+  requirement: &78591390 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,7 +99,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *87874570
+  version_requirements: *78591390
 description: ! "    Additional finders for capybara that for some reason\n    cannot
   use only xpath for finding nodes but needs to\n    execute js for some calculations.\n\n
   \   Ex: I you want to find a table cell\n    that is under or next to other cell
@@ -128,6 +129,7 @@ files:
 - test/unit/find_cell_tests/app/public/js/prototype.js
 - test/unit/find_cell_tests/app/views/table.erubis
 - test/unit/find_cell_tests/basic_test.rb
+has_rdoc: true
 homepage: https://github.com/paneq/capybara-js_finders
 licenses: []
 post_install_message: 
@@ -142,7 +144,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -398005553
+      hash: 767245201
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -151,10 +153,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -398005553
+      hash: 767245201
 requirements: []
 rubyforge_project: capybara-js_finders
-rubygems_version: 1.8.5
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Additional finders for capybara that for some reason cannot use only xpath