capybara-chromedriver-logger 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: a2adb7cdaeb7970c7f543a69bade1af3c1dd37bf
-  data.tar.gz: 5296595dcd28304754d3c6bc122463fc0b965363
+SHA256:
+  metadata.gz: a0188c7bb3434429a524f07cfe950f0a02b4bd2e4c949a5dc3e8ecd65a553644
+  data.tar.gz: 22342de9e1295f5377375ea0a248d3b5e4ff2c41da8a696ab53d772da69470ce
 SHA512:
-  metadata.gz: f99ad48a1477114a5323163a535a7ed112bee149ab8a4dccc668562c9187a256e2821b1370176de5496010ee5f21a8a0b4fd53c36b4ac93228764a0df10972bd
-  data.tar.gz: 27578f35e27085a1a800890545c85d49a9f03a65f27c642ca5b018b02713b9ccde3d5ba8d696609ea0f6a11c11e5cf0232b7fb13cdaa7dde8cf4d3642c047823
+  metadata.gz: 2b5818892be7d9ad66d4c00c741c7d4ae50f70bb863b32d20a77943d272970f53c73ce052d508e2cc03dffedfd2526a67bdf7f0907cc7ff9e8b77048f3e4e207
+  data.tar.gz: abf13f36355acf43333c0716aafae32a91fbbf7777c4870130f4785e9be9796367f2922654295507a0d300e9f8822bd639a3f2a08de3cff80357f9923ed06c24

data/.rubocop.yml

@@ -0,0 +1,141 @@
+AllCops:
+  # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
+  # to ignore them, so only the ones explicitly set in this file are enabled.
+  DisabledByDefault: true
+  TargetRubyVersion: 2.3
+
+# Prefer &&/|| over and/or.
+Style/AndOr:
+  Enabled: true
+
+# Do not use braces for hash literals when they are the last argument of a
+# method call.
+Style/BracesAroundHashParameters:
+  Enabled: true
+
+# Align `when` with `case`.
+Layout/CaseIndentation:
+  Enabled: true
+
+# Align comments with method definitions.
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/EmptyLineAfterMagicComment:
+  Enabled: true
+
+# No extra empty lines.
+Layout/EmptyLines:
+  Enabled: true
+
+# In a regular class definition, no empty lines around the body.
+Layout/EmptyLinesAroundClassBody:
+  Enabled: true
+
+# In a regular method definition, no empty lines around the body.
+Layout/EmptyLinesAroundMethodBody:
+  Enabled: true
+
+# In a regular module definition, no empty lines around the body.
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
+  Enabled: true
+
+# Method definitions after `private` or `protected` isolated calls need one
+# extra level of indentation.
+Layout/IndentationConsistency:
+  Enabled: true
+  EnforcedStyle: normal
+
+# Two spaces, no tabs (for indentation).
+Layout/IndentationWidth:
+  Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+    Enabled: true
+
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
+# Use `foo {}` not `foo{}`.
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+# Use `foo { bar }` not `foo {bar}`.
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+
+# Use `{ a: 1 }` not `{a:1}`.
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+
+# Don't care about single vs double quotes
+Style/StringLiterals:
+  Enabled: false
+  SupportedStyles:
+    - single_quotes
+    - double_quotes
+
+# Detect hard tabs, no hard tabs.
+Layout/Tab:
+  Enabled: true
+
+# Blank lines should not have any spaces.
+Layout/TrailingBlankLines:
+  Enabled: true
+
+Metrics/LineLength:
+  Enabled: true
+  Max: 80
+  IgnoredPatterns: ['\A\s*class ']
+
+Layout/MultilineMethodCallIndentation:
+  Enabled: true
+  EnforcedStyle: indented
+  IndentationWidth: 2
+
+# No trailing whitespace.
+Layout/TrailingWhitespace:
+  Enabled: true
+
+# Use quotes for string literals when they are enough.
+Style/UnneededPercentQ:
+  Enabled: true
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+Lint/EndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: variable
+
+# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+Lint/RequireParentheses:
+  Enabled: true
+
+Style/BlockDelimiters:
+  Enabled: true
+
+Style/SymbolArray:
+  Enabled: true

data/.travis.yml

@@ -1,5 +1,11 @@
 sudo: false
 language: ruby
+addons:
+  apt:
+    sources:
+      - google-chrome
+    packages:
+      - google-chrome-stable
 rvm:
   - 2.4.1
 before_install: gem install bundler -v 1.16.0

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 0.2.1 [June 23, 2018]
+
+* Added `filter_levels` option for filtering by log level (closes #4)
+* Fixed Travis CI build
+
 # 0.2.0 [Feb 17, 2018]
 
 * Stop using threads, it's a fool's errand. We now output logs at the end of each test

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    capybara-chromedriver-logger (0.2.0)
+    capybara-chromedriver-logger (0.2.1)
       capybara
       colorize
 
@@ -28,6 +28,7 @@ GEM
     colorize (0.8.1)
     diff-lcs (1.3)
     ffi (1.9.21)
+    gem-release (2.0.1)
     io-like (0.3.0)
     method_source (0.9.0)
     mini_mime (1.0.0)
@@ -39,7 +40,7 @@ GEM
       method_source (~> 0.9.0)
     public_suffix (3.0.2)
     rack (2.0.4)
-    rack-test (0.8.2)
+    rack-test (1.0.0)
       rack (>= 1.0, < 3)
     rake (10.5.0)
     rspec (3.7.0)
@@ -71,6 +72,7 @@ DEPENDENCIES
   bundler (~> 1.16)
   capybara-chromedriver-logger!
   chromedriver-helper
+  gem-release
   pry
   rake (~> 10.0)
   rspec (~> 3.0)
@@ -78,4 +80,4 @@ DEPENDENCIES
   stub_server
 
 BUNDLED WITH
-   1.16.0
+   1.16.2

data/README.md

@@ -1,3 +1,5 @@
+[![Build Status](https://travis-ci.org/dbalatero/capybara-chromedriver-logger.svg?branch=master)](https://travis-ci.org/dbalatero/capybara-chromedriver-logger)
+
 # capybara-chromedriver-logger
 
 This gem provides `console.log` debug output for Ruby feature specs running under Chromedriver.
@@ -86,6 +88,16 @@ Capybara::Chromedriver::Logger.filters = [
   /Download the React DevTools/i,
   /The SSL certificate used to load resources from/i
 ]
+
+# If you want to filter out specific severity levels, you can do so here:
+#
+# default: nil
+Capybara::Chromedriver::Logger.filter_levels = %i[
+  severe
+  info
+  warning
+  debug
+]
 ```
 
 ## Development

data/capybara-chromedriver-logger.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ["David Balatero"]
   spec.email         = ["dbalatero@gmail.com"]
 
-  spec.summary       = %q{Adds realtime console.log output to Capybara + Selenium + Chromedriver}
+  spec.summary       = 'Adds realtime console.log output to Capybara + Selenium + Chromedriver'
   spec.homepage      = "https://github.com/dbalatero/capybara-chromedriver-logger"
   spec.license       = "MIT"
 
@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
       "public gem pushes."
   end
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
   spec.bindir        = "exe"
@@ -34,6 +34,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.16"
   spec.add_development_dependency "chromedriver-helper"
+  spec.add_development_dependency "gem-release"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"

data/lib/capybara/chromedriver/logger.rb

@@ -1,11 +1,11 @@
 require 'capybara'
 require 'selenium-webdriver'
 
-require "capybara/chromedriver/logger/test_hooks"
-require "capybara/chromedriver/logger/version"
-require "capybara/chromedriver/logger/js_error"
-require "capybara/chromedriver/logger/message"
-require "capybara/chromedriver/logger/collector"
+require 'capybara/chromedriver/logger/test_hooks'
+require 'capybara/chromedriver/logger/version'
+require 'capybara/chromedriver/logger/js_error'
+require 'capybara/chromedriver/logger/message'
+require 'capybara/chromedriver/logger/collector'
 
 module Capybara
   module Chromedriver
@@ -20,6 +20,14 @@ module Capybara
         @filters = filters
       end
 
+      def filter_levels
+        @filter_levels || []
+      end
+
+      def filter_levels=(filters)
+        @filter_levels = filters && filters.map(&:upcase).map(&:to_s)
+      end
+
       def raise_js_errors?
         !!@raise_js_errors
       end

data/lib/capybara/chromedriver/logger/collector.rb

@@ -2,10 +2,12 @@ module Capybara
   module Chromedriver
     module Logger
       class Collector
-        def initialize(log_destination: $stdout, filters: nil)
-          @log_destination = log_destination
-          @filters = filters || Capybara::Chromedriver::Logger.filters
+        def initialize(options = {})
           @errors = []
+          @log_destination = options[:log_destination] || $stdout
+          @filters = options[:filters] || Capybara::Chromedriver::Logger.filters
+          @filter_levels = options[:filter_levels] ||
+            Capybara::Chromedriver::Logger.filter_levels
         end
 
         def flush_and_check_errors!
@@ -24,8 +26,7 @@ module Capybara
           formatted_errors = errors.map(&:to_s)
           error_list = formatted_errors.join("\n")
 
-          raise JsError,
-            "Got some JS errors during testing:\n\n#{error_list}"
+          raise JsError, "Got some JS errors during testing:\n\n#{error_list}"
         end
 
         def flush_logs!
@@ -55,20 +56,21 @@ module Capybara
         end
 
         def should_filter?(message)
-          filters.any? { |filter| filter =~ message.message }
+          should_filter_by_level?(message) || should_filter_content?(message)
         end
 
-        def errors
-          @errors
+        def should_filter_by_level?(message)
+          filter_levels.include?(message.level)
         end
 
-        def filters
-          @filters
+        def should_filter_content?(message)
+          filters.any? { |filter| filter =~ message.message }
         end
 
-        def log_destination
-          @log_destination
-        end
+        attr_reader :errors
+        attr_reader :filters
+        attr_reader :filter_levels
+        attr_reader :log_destination
       end
     end
   end

data/lib/capybara/chromedriver/logger/message.rb

@@ -45,6 +45,7 @@ module Capybara
         def formatted_message
           message
             .gsub('\n', "\n")
+            .gsub('\u003C', "\u003C")
             .split("\n")
             .map { |line| "#{LEADING_SPACES}#{line}" }
             .join("\n")

data/lib/capybara/chromedriver/logger/test_hooks.rb

@@ -9,8 +9,10 @@ module Capybara
 
         def self.for_rspec!
           ::RSpec.configure do |config|
-            config.after :each, type: :feature do
-              Capybara::Chromedriver::Logger::TestHooks.after_example!
+            %i[feature system].each do |type|
+              config.after :each, type: type do
+                Capybara::Chromedriver::Logger::TestHooks.after_example!
+              end
             end
           end
         end

data/lib/capybara/chromedriver/logger/version.rb

@@ -1,7 +1,7 @@
 module Capybara
   module Chromedriver
     module Logger
-      VERSION = "0.2.0"
+      VERSION = "0.2.1"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capybara-chromedriver-logger
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - David Balatero
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-18 00:00:00.000000000 Z
+date: 2018-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: gem-release
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -145,6 +159,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -183,7 +198,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Adds realtime console.log output to Capybara + Selenium + Chromedriver