capybara-box 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b4bdaec6c2c1490b88c611085694f8236508305a
-  data.tar.gz: 9d57739d0736541aa752b0654473ea72ac9aa083
+  metadata.gz: 6afd97a950443869bfe4ab875fccd59c05a3fc0a
+  data.tar.gz: 137d4cf67eb4dd6c1a04c043ebbc07e13706a8f4
 SHA512:
-  metadata.gz: 1b627d07d8a80b9e5de260068e1b095d0c18272b7b8acbec9c4c38ab39e56f3aa9c8c79fb0e812d65b367a996532ad50387e5cd76130583130cc6b598690ad9b
-  data.tar.gz: 18e0e3b30f9f7462338fbd62f3af8a839cb4f3092bfdebf389c144cd4f28ad595d4c0e511d9788cf52c76b37040375ba5e995ff633e0d6bad8b9a24bb8d5dd1e
+  metadata.gz: 07bd47774b53cc943f1b319caba4e4114458fe618b1318465b8002710ce4b65ac9d68bfc023f052887aac2c3f192e8e9add6e050b59bca6d404772f1a141cdea
+  data.tar.gz: b7e8561e2fd0fbea24983141057428ca532bb281e1e6a162db43cddb800885b79b56aa8a0fe8c3f679d3242ef2da6c63b56ffb40f32a4aff676326daec850289

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## v0.2.1
+
+- fixes
+  - `chrome_headless` was being registered with wrong name.
+
 ## v0.2.0
 
 - features

data/README.md

@@ -3,7 +3,7 @@
 [![Build Status](https://travis-ci.org/wbotelhos/capybara-box.svg)](https://travis-ci.org/wbotelhos/capybara-box)
 [![Gem Version](https://badge.fury.io/rb/capybara-box.svg)](https://badge.fury.io/rb/capybara-box)
 
-Configure Capybara with **Chrome**, **Headless Chrome** or **Firefox** with *Screenshot* feature and *Session* without lost your mind with just one line.
+Configure Capybara with **Chrome**, **Chrome Headless** or **Firefox** with *Screenshot* feature and *Session* without lost your mind with just one line.
 
 ## install
 
@@ -26,7 +26,7 @@ require 'capybara-box'
 CapybaraBox::Base.configure
 ```
 
-By default, `chrome` is de driver, but you can use `chrome`, `chrome_headless` or `firefox`.
+By default, `chrome` is the driver, but you can use `chrome_headless` and `firefox` too.
 
 ## Version
 
@@ -36,7 +36,7 @@ If you do not want install the Chrome Driver on your CI, you can specify the ver
 CapybaraBox::Base.configure version: '2.32'
 ```
 
-* This works just for Chrome, for now
+* This works just for `chrome` and `chrome_headless`, for now
 
 ## Screenshot
 
@@ -89,6 +89,7 @@ By default some Switches are enabled for a better performance, you can add yours
 
 ```ruby
 capybara_box = CapybaraBox.configure
+
 capybara_box.add_argument '--incognito'
 ```
 
@@ -108,6 +109,7 @@ By default some Preferences are enabled for a better performance, you can add yo
 
 ```ruby
 capybara_box = CapybaraBox.configure
+
 capybara_box.add_preference :credentials_enable_service, false
 ```
 

data/lib/capybara-box/base.rb

@@ -60,10 +60,6 @@ module CapybaraBox
       ]
     end
 
-    def browser
-      @browser ||= chrome_family? ? :chrome : @browser
-    end
-
     def chrome?
       @browser == :chrome
     end
@@ -77,7 +73,7 @@ module CapybaraBox
     end
 
     def configure
-      Capybara.javascript_driver     = browser
+      Capybara.javascript_driver     = @browser
       Capybara.default_max_wait_time = @max_wait_time if @max_wait_time
     end
 
@@ -106,7 +102,7 @@ module CapybaraBox
         Capybara::Screenshot.s3_configuration = screenshot_s3_config
       end
 
-      Capybara::Screenshot.register_driver(browser) do |driver, path|
+      Capybara::Screenshot.register_driver(@browser) do |driver, path|
         driver.browser.save_screenshot path
       end
     end
@@ -119,7 +115,7 @@ module CapybaraBox
       apply_version @parameters[:version]   if version?
       configure_screenshot                  if @parameters[:screenshot]
 
-      register browser
+      register @browser
 
       configure
     end
@@ -136,7 +132,7 @@ module CapybaraBox
       return @parameters[:driver_options] if @parameters[:driver_options]
 
       opts = {
-        browser:               browser,
+        browser:               chrome_family? ? :chrome : @browser,
         clear_local_storage:   true,
         clear_session_storage: true
       }

data/lib/capybara-box/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CapybaraBox
-  VERSION = '0.2.0'.freeze
+  VERSION = '0.2.1'.freeze
 end

data/spec/lib/capybara_box/base/create_spec.rb

@@ -66,12 +66,24 @@ RSpec.describe CapybaraBox::Base, '#create' do
   context 'when :browser is given' do
     subject { described_class.new parameters }
 
-    let!(:parameters) { { browser: :firefox } }
+    context 'as firefox' do
+      let!(:parameters) { { browser: :firefox } }
 
-    it 'registers the given browser' do
-      expect(subject).to receive(:register).with :firefox
+      it 'registers the given browser' do
+        expect(subject).to receive(:register).with :firefox
 
-      subject.create
+        subject.create
+      end
+    end
+
+    context 'as chrome_headless' do
+      let!(:parameters) { { browser: :chrome_headless } }
+
+      it 'registers the given browser' do
+        expect(subject).to receive(:register).with :chrome_headless
+
+        subject.create
+      end
     end
   end
 end

data/spec/lib/capybara_box/base/driver_options_spec.rb

@@ -29,7 +29,7 @@ RSpec.describe CapybaraBox::Base, '.register' do
 
     it 'uses the default driver options' do
       expect(subject.driver_options).to eq(
-        browser:               :chrome_headless,
+        browser:               :chrome,
         clear_local_storage:   true,
         clear_session_storage: true,
         driver_opts:           { log_path: 'log/capybara-box.log' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara-box
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Washington Botelho
@@ -155,7 +155,6 @@ files:
 - spec/lib/capybara_box/base/apply_preferences_spec.rb
 - spec/lib/capybara_box/base/apply_version_spec.rb
 - spec/lib/capybara_box/base/arguments_spec.rb
-- spec/lib/capybara_box/base/browser_spec.rb
 - spec/lib/capybara_box/base/chrome_family_spec.rb
 - spec/lib/capybara_box/base/chrome_headless_spec.rb
 - spec/lib/capybara_box/base/chrome_spec.rb
@@ -207,7 +206,6 @@ test_files:
 - spec/lib/capybara_box/base/apply_preferences_spec.rb
 - spec/lib/capybara_box/base/apply_version_spec.rb
 - spec/lib/capybara_box/base/arguments_spec.rb
-- spec/lib/capybara_box/base/browser_spec.rb
 - spec/lib/capybara_box/base/chrome_family_spec.rb
 - spec/lib/capybara_box/base/chrome_headless_spec.rb
 - spec/lib/capybara_box/base/chrome_spec.rb

data/spec/lib/capybara_box/base/browser_spec.rb

@@ -1,27 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe CapybaraBox::Base, '.browser' do
-  context 'when :browser is chrome family' do
-    before do
-      allow(subject).to receive(:chrome_family?) { true }
-    end
-
-    it 'is considered chrome' do
-      expect(subject.browser).to eq :chrome
-    end
-  end
-
-  context 'when :browser is not chrome family' do
-    subject { described_class.new parameters }
-
-    let!(:parameters) { { browser: :original_name } }
-
-    before do
-      allow(subject).to receive(:chrome_family?) { false }
-    end
-
-    it 'returns the original name' do
-      expect(subject.browser).to eq :original_name
-    end
-  end
-end