captive-stack-detector 0.12.4 → 0.12.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b90c2a1855bd23b857f4f142a0c674795992d33a98512e4b7a1cbcfb7db5df7f
-  data.tar.gz: 49a6d7ae837f68ed2e0995fcb8623249ceb93168ddac120108c5b032c93afff5
+  metadata.gz: e5c9cf6e0559903b9b472715ed1d425903be96cdf7ca09c4689a66f63df7b19f
+  data.tar.gz: 7146a542cf6d2887063172c47a0d8f85251d3e7e02062969c8ee04882c321398
 SHA512:
-  metadata.gz: d430ba6a7b0077093dff4a48d756b106e5f47c64f8fe981d7fbf18c5c0c89035ff8dd045e6b2da56d9705f607ab0d0a626e67247f72aa51771fb4c1b5b972c1f
-  data.tar.gz: a89e85828b1be7b804c4ef860ddc7664a3354e8c78c719714c3cd16229a0eca4d85f1084d3be6248d16a5f706d8e87d7b0a83642c2551390c90d04db75ad50e9
+  metadata.gz: d2162dfa8b2aa58308fb3523677fba79ffba3cd7abb7fa980bd2466408bc8347519845ec93bb83b8d751b308e504488c4f2edc56a2147132634ef288de5e78b1
+  data.tar.gz: 65b1daea44aa2172b74e215d3d6fd55b87e94ae6dc5115657605dee8ee880dbc5e4f0b2f04db139348cab9c34883a33d07a131e32fe5377db6256368531de625

data/lib/captive_stack_detector/github_api_client.rb

@@ -5,9 +5,14 @@ require "uri"
 require "base64"
 require "json"
 require_relative "github_tree"
+require_relative "types"
+require_relative "github_response"
 
 module CaptiveStackDetector
   class GithubApiClient
+    # Un corps illisible (JSON invalide ou sans le champ attendu) vaut une absence.
+    UNREADABLE = [ JSON::ParserError, NoMethodError, TypeError ].freeze
+
     def initialize(token, repo)
       @token = token
       @repo  = repo
@@ -18,7 +23,7 @@ module CaptiveStackDetector
       return nil unless body
 
       Base64.decode64(JSON.parse(body)["content"]).force_encoding("utf-8")
-    rescue StandardError
+    rescue *UNREADABLE
       nil
     end
 
@@ -27,7 +32,7 @@ module CaptiveStackDetector
       return [] unless body
 
       GithubTree.new(body).files_in(dir)
-    rescue StandardError
+    rescue *UNREADABLE
       []
     end
 
@@ -35,9 +40,10 @@ module CaptiveStackDetector
 
     def get(path)
       uri = URI("https://api.github.com/repos/#{@repo}/#{path}")
-      req = Net::HTTP::Get.new(uri, "Authorization" => "Bearer #{@token}", "Accept" => "application/vnd.github+json")
-      res = Net::HTTP.start(uri.host, uri.port, use_ssl: true) { |http| http.request(req) }
-      res.body if res.is_a?(Net::HTTPSuccess)
+      GithubResponse.body(Net::HTTP.get_response(uri, "Authorization" => "Bearer #{@token}",
+                                                      "Accept" => "application/vnd.github+json"))
+    rescue SystemCallError, IOError, SocketError, Timeout::Error, OpenSSL::SSL::SSLError => e
+      raise SourceUnavailable.new(:network, detail: e.message)
     end
   end
 end

data/lib/captive_stack_detector/github_response.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require "net/http"
+require_relative "types"
+
+module CaptiveStackDetector
+  # Ce que veut dire une réponse de l'API GitHub : un corps, une absence, ou un refus nommé.
+  # Change avec la façon dont GitHub signale ses erreurs, pas avec ce que l'on y lit.
+  module GithubResponse
+    # 404 : fichier absent ; 409 : dépôt vide. Tout autre échec vient de GitHub, pas du dépôt.
+    ABSENT = [ "404", "409" ].freeze
+    REFUSALS = { "401" => :unauthorized, "429" => :rate_limited }.freeze
+
+    def self.body(res)
+      return res.body if res.is_a?(Net::HTTPSuccess)
+      return nil if ABSENT.include?(res.code)
+
+      raise SourceUnavailable.new(refusal_kind(res), status: res.code.to_i)
+    end
+
+    # GitHub signale un quota épuisé par un 403 ou un 429, avec x-ratelimit-remaining à 0.
+    def self.refusal_kind(res)
+      return :rate_limited if res["x-ratelimit-remaining"] == "0"
+
+      REFUSALS.fetch(res.code) { res.is_a?(Net::HTTPServerError) ? :server_error : :forbidden }
+    end
+  end
+end

data/lib/captive_stack_detector/types.rb

@@ -26,4 +26,17 @@ module CaptiveStackDetector
       super(reason&.to_s || "unsupported stack")
     end
   end
+
+  # GitHub n'a pas laissé lire le dépôt, ce qui ne dit rien de sa stack. `kind` dit pourquoi,
+  # pour que l'appelant l'explique : :unauthorized (jeton refusé), :rate_limited (quota épuisé),
+  # :forbidden (accès refusé), :server_error (panne GitHub), :network (pas de réponse).
+  class SourceUnavailable < StandardError
+    attr_reader :kind, :status
+
+    def initialize(kind = :network, status: nil, detail: nil)
+      @kind   = kind
+      @status = status
+      super(detail || "GitHub illisible : #{kind}#{" (#{status})" if status}")
+    end
+  end
 end

data/lib/captive_stack_detector/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CaptiveStackDetector
-  VERSION = "0.12.4"
+  VERSION = "0.12.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: captive-stack-detector
 version: !ruby/object:Gem::Version
-  version: 0.12.4
+  version: 0.12.5
 platform: ruby
 authors:
 - Captive Studio
@@ -29,6 +29,7 @@ files:
 - lib/captive_stack_detector/gem_package_map.rb
 - lib/captive_stack_detector/gemfile_analyzer.rb
 - lib/captive_stack_detector/github_api_client.rb
+- lib/captive_stack_detector/github_response.rb
 - lib/captive_stack_detector/github_tree.rb
 - lib/captive_stack_detector/js_env_detector.rb
 - lib/captive_stack_detector/js_env_files.rb