captainu-tincan 0.7.2 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d1131a74590ccc72507072e98e99b76dc664b3b9
-  data.tar.gz: b54e1fae869ce79d00b979bee13db4a3196c7056
+  metadata.gz: 81b4ca24c5fc0416c16995f2b9ceeb774d4e1fec
+  data.tar.gz: 5b685303cb058bc07739d6ab76992dcf543c6457
 SHA512:
-  metadata.gz: 828686330455c64a8272530833d7e571cedf158ef0bab6a77d30fe090ced1c9a34f4c3cf73092a8ef69d13a45d77187cfd868f223272ed04f7a8c04ce035261c
-  data.tar.gz: 7180089c5bbc803b8fe0ebadd9ee9f6d4ce4578ea80bf993864d813cc3c218c12d2c3e615eeb4c0aa912566160bbae467db70d3e316abbe1012c0366e44049f8
+  metadata.gz: d0a21eec95dae01fad91ecfb7f21cbf4b0952b91c8a6a0c3a67394660f5a6a2e1f77b0e4a94ade22c88d41d5f1a1f0a5e3983845b5cb893202727b1a06879a68
+  data.tar.gz: 38c722a480c7a98c17c9835489c307df19a55d8e10a6467c47d1b445911df1f5e17f12dafb70ff01339812cbb5fb928fe566d96e0a6b807ccf0e38f5de61b4ff

data/lib/tincan/message.rb

@@ -6,7 +6,8 @@ module Tincan
   # Encapsulates a message published to (and received from) a Redis "tincan"
   # queue.
   class Message
-    attr_accessor :object_name, :change_type, :object_data, :published_at
+    attr_accessor :object_name, :change_type, :object_data, :published_at,
+                  :message_id
 
     # Creates a new instance of a notification with an object (usually an
     # ActiveModel instance).
@@ -15,6 +16,7 @@ module Tincan
     def initialize
       yield self if block_given?
       self.published_at ||= DateTime.now
+      self.message_id ||= SecureRandom.uuid
     end
 
     # Deserializes an object from a JSON string.

data/lib/tincan/sender.rb

@@ -83,7 +83,7 @@ module Tincan
     #                          unique identifier.
     # @return [Integer] A unique identifier number for the message.
     def identifier_for_message(message)
-      message.published_at.to_time.to_i
+      message.message_id
     end
 
     # Generates a key to be used as the primary destination key in Redis.

data/lib/tincan/version.rb

@@ -1,3 +1,3 @@
 module Tincan
-  VERSION = '0.7.2'
+  VERSION = '0.8.0'
 end

data/spec/sender_spec.rb

@@ -98,23 +98,22 @@ describe Tincan::Sender do
       context 'posting to all clients' do
         before do
           sender.publish(message)
-          @timestamp = Time.now.to_i
         end
 
         it 'publishes a message to Redis at a specific key' do
-          message = redis.get("data:dummy_class:messages:#{@timestamp}")
-          expect(message).to be_a(String)
+          r_message = redis.get("data:dummy_class:messages:#{message.message_id}")
+          expect(r_message).to be_a(String)
           expected = '{"object_name":"dummy_class","change_type":"create",'
           expected += '"object_data":{"name":"Some Idiot"},"published_at":'
-          expect(message).to start_with(expected)
+          expect(r_message).to start_with(expected)
         end
 
         it 'also publishes a message ID to client-specific receiver lists' do
           identifier = redis.lpop('data:dummy_class:some_client:messages')
-          expect(identifier).to eq(@timestamp.to_s)
+          expect(identifier).to eq(message.message_id)
 
           identifier = redis.lpop('data:dummy_class:bork:messages')
-          expect(identifier).to eq(@timestamp.to_s)
+          expect(identifier).to eq(message.message_id.to_s)
         end
       end
 
@@ -126,7 +125,7 @@ describe Tincan::Sender do
 
         it 'publishes message IDs to client-specific receivers, non-excluded' do
           identifier = redis.lpop('data:dummy_class:some_client:messages')
-          expect(identifier).to eq(@timestamp.to_s)
+          expect(identifier).to eq(message.message_id)
 
           identifier = redis.lpop('data:dummy_class:bork:messages')
           expect(identifier).to be_nil
@@ -138,13 +137,13 @@ describe Tincan::Sender do
   describe :formatting_helper_methods do
     describe :identifier_for_message do
       it 'generates a timestamp from the passed-in message' do
-        expect(sender.identifier_for_message(message)).to eq(1401720216)
+        expect(sender.identifier_for_message(message)).to eq(message.message_id)
       end
     end
 
     describe :primary_key_for_message do
       it 'joins namespace, object name, and more to create a unique key' do
-        expected = 'data:dummy_class:messages:1401720216'
+        expected = "data:dummy_class:messages:#{message.message_id}"
         expect(sender.primary_key_for_message(message)).to eq(expected)
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: captainu-tincan
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.8.0
 platform: ruby
 authors:
 - Ben Kreeger
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-04 00:00:00.000000000 Z
+date: 2014-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json