capistrano 3.4.1 → 3.5.0

data/spec/lib/capistrano/dsl_spec.rb

@@ -1,7 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Capistrano
-
   class DummyDSL
     include DSL
   end
@@ -12,10 +11,10 @@ module Capistrano
 
     describe '#t' do
       before do
-        I18n.expects(:t).with(:phrase, {count: 2, scope: :capistrano})
+        I18n.expects(:t).with(:phrase, count: 2, scope: :capistrano)
       end
 
-      it 'delegates to I18n' do
+      it "delegates to I18n" do
         dsl.t(:phrase, count: 2)
       end
     end
@@ -23,14 +22,14 @@ module Capistrano
     describe '#stage_set?' do
       subject { dsl.stage_set? }
 
-      context 'stage is set' do
+      context "stage is set" do
         before do
           dsl.set(:stage, :sandbox)
         end
         it { expect(subject).to be_truthy }
       end
 
-      context 'stage is not set' do
+      context "stage is not set" do
         before do
           dsl.set(:stage, nil)
         end
@@ -39,12 +38,11 @@ module Capistrano
     end
 
     describe '#sudo' do
-
       before do
         dsl.expects(:execute).with(:sudo, :my, :command)
       end
 
-      it 'prepends sudo, delegates to execute' do
+      it "prepends sudo, delegates to execute" do
         dsl.sudo(:my, :command)
       end
     end

data/spec/lib/capistrano/git_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
 
-require 'capistrano/git'
+require "capistrano/git"
 
 module Capistrano
   describe Git do
@@ -39,10 +39,20 @@ module Capistrano
 
     describe "#clone" do
       it "should run git clone" do
+        context.expects(:fetch).with(:git_shallow_clone).returns(nil)
         context.expects(:repo_url).returns(:url)
         context.expects(:repo_path).returns(:path)
+        context.expects(:execute).with(:git, :clone, "--mirror", :url, :path)
 
-        context.expects(:execute).with(:git, :clone, '--mirror', :url, :path)
+        subject.clone
+      end
+
+      it "should run git clone in shallow mode" do
+        context.expects(:fetch).with(:git_shallow_clone).returns("1")
+        context.expects(:repo_url).returns(:url)
+        context.expects(:repo_path).returns(:path)
+
+        context.expects(:execute).with(:git, :clone, "--mirror", "--depth", "1", "--no-single-branch", :url, :path)
 
         subject.clone
       end
@@ -50,7 +60,16 @@ module Capistrano
 
     describe "#update" do
       it "should run git update" do
-        context.expects(:execute).with(:git, :remote, :update)
+        context.expects(:fetch).with(:git_shallow_clone).returns(nil)
+        context.expects(:execute).with(:git, :remote, :update, "--prune")
+
+        subject.update
+      end
+
+      it "should run git update in shallow mode" do
+        context.expects(:fetch).with(:git_shallow_clone).returns("1")
+        context.expects(:fetch).with(:branch).returns(:branch)
+        context.expects(:execute).with(:git, :fetch, "--depth", "1", "origin", :branch)
 
         subject.update
       end
@@ -62,20 +81,29 @@ module Capistrano
         context.expects(:fetch).with(:branch).returns(:branch)
         context.expects(:release_path).returns(:path)
 
-        context.expects(:execute).with(:git, :archive, :branch, '| tar -x -f - -C', :path)
+        context.expects(:execute).with(:git, :archive, :branch, "| tar -x -f - -C", :path)
 
         subject.release
       end
 
       it "should run git archive with a subtree" do
-        context.expects(:fetch).with(:repo_tree).returns('tree')
+        context.expects(:fetch).with(:repo_tree).returns("tree")
         context.expects(:fetch).with(:branch).returns(:branch)
         context.expects(:release_path).returns(:path)
 
-        context.expects(:execute).with(:git, :archive, :branch, 'tree', '| tar -x --strip-components 1 -f - -C', :path)
+        context.expects(:execute).with(:git, :archive, :branch, "tree", "| tar -x --strip-components 1 -f - -C", :path)
 
         subject.release
       end
     end
+
+    describe "#fetch_revision" do
+      it "should capture git rev-list" do
+        context.expects(:fetch).with(:branch).returns(:branch)
+        context.expects(:capture).with(:git, "rev-list --max-count=1 branch").returns("81cec13b777ff46348693d327fc8e7832f79bf43")
+        revision = subject.fetch_revision
+        expect(revision).to eq("81cec13b777ff46348693d327fc8e7832f79bf43")
+      end
+    end
   end
 end

data/spec/lib/capistrano/hg_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
 
-require 'capistrano/hg'
+require "capistrano/hg"
 
 module Capistrano
   describe Hg do
@@ -42,7 +42,7 @@ module Capistrano
         context.expects(:repo_url).returns(:url)
         context.expects(:repo_path).returns(:path)
 
-        context.expects(:execute).with(:hg, "clone", '--noupdate', :url, :path)
+        context.expects(:execute).with(:hg, "clone", "--noupdate", :url, :path)
 
         subject.clone
       end
@@ -68,14 +68,23 @@ module Capistrano
       end
 
       it "should run hg archive with a subtree" do
-        context.expects(:fetch).with(:repo_tree).returns('tree')
+        context.expects(:fetch).with(:repo_tree).returns("tree")
         context.expects(:fetch).with(:branch).returns(:branch)
         context.expects(:release_path).returns(:path)
 
-        context.expects(:execute).with(:hg, "archive --type tgz -p . -I", 'tree', "--rev", :branch, '| tar -x --strip-components 1 -f - -C', :path)
+        context.expects(:execute).with(:hg, "archive --type tgz -p . -I", "tree", "--rev", :branch, "| tar -x --strip-components 1 -f - -C", :path)
 
         subject.release
       end
     end
+
+    describe "#fetch_revision" do
+      it "should capture hg log" do
+        context.expects(:fetch).with(:branch).returns(:branch)
+        context.expects(:capture).with(:hg, "log --rev branch --template \"{node}\n\"").returns("01abcde")
+        revision = subject.fetch_revision
+        expect(revision).to eq("01abcde")
+      end
+    end
   end
 end

data/spec/lib/capistrano/immutable_task_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+require "rake"
+require "capistrano/immutable_task"
+
+module Capistrano
+  describe ImmutableTask do
+    after do
+      # Ensure that any tasks we create in these tests don't pollute other tests
+      Rake::Task.clear
+    end
+
+    it "prints warning and raises when task is enhanced" do
+      extend(Rake::DSL)
+
+      load_defaults = Rake::Task.define_task("load:defaults")
+      load_defaults.extend(Capistrano::ImmutableTask)
+
+      $stderr.expects(:puts).with do |message|
+        message =~ /^WARNING: load:defaults has already been invoked/
+      end
+
+      expect do
+        namespace :load do
+          task :defaults do
+            # Never reached since load_defaults is frozen and can't be enhanced
+          end
+        end
+      end.to raise_error(/frozen/i)
+    end
+  end
+end

data/spec/lib/capistrano/plugin_spec.rb

@@ -0,0 +1,84 @@
+require "spec_helper"
+require "capistrano/plugin"
+
+module Capistrano
+  describe Plugin do
+    include Rake::DSL
+    include Capistrano::DSL
+
+    class DummyPlugin < Capistrano::Plugin
+      def define_tasks
+        task :hello do
+        end
+      end
+
+      def register_hooks
+        before "deploy:published", "hello"
+      end
+    end
+
+    class ExternalTasksPlugin < Capistrano::Plugin
+      def define_tasks
+        eval_rakefile(
+          File.expand_path("../../../support/tasks/plugin.rake", __FILE__)
+        )
+      end
+
+      # Called from plugin.rake to demonstrate that helper methods work
+      def hello
+        set :plugin_result, "hello"
+      end
+    end
+
+    before do
+      # Define an example task to allow testing hooks
+      task "deploy:published"
+    end
+
+    after do
+      # Clean up any tasks or variables we created during the tests
+      Rake::Task.clear
+      Capistrano::Configuration.reset!
+    end
+
+    it "defines tasks when constructed" do
+      install_plugin(DummyPlugin)
+      expect(Rake::Task["hello"]).not_to be_nil
+    end
+
+    it "registers hooks when constructed" do
+      install_plugin(DummyPlugin)
+      expect(Rake::Task["deploy:published"].prerequisites).to include("hello")
+    end
+
+    it "skips registering hooks if load_hooks: false" do
+      install_plugin(DummyPlugin, load_hooks: false)
+      expect(Rake::Task["deploy:published"].prerequisites).to be_empty
+    end
+
+    it "doesn't call set_defaults immediately" do
+      dummy = DummyPlugin.new
+      install_plugin(dummy)
+      dummy.expects(:set_defaults).never
+    end
+
+    it "calls set_defaults during load:defaults" do
+      dummy = DummyPlugin.new
+      dummy.expects(:set_defaults).once
+      install_plugin(dummy)
+      Rake::Task["load:defaults"].invoke
+    end
+
+    it "is able to load tasks from a .rake file" do
+      install_plugin(ExternalTasksPlugin)
+      Rake::Task["plugin_test"].invoke
+      expect(fetch(:plugin_result)).to eq("hello")
+    end
+
+    it "exposes the SSHKit backend to subclasses" do
+      SSHKit::Backend.expects(:current).returns(:backend)
+      plugin = DummyPlugin.new
+      expect(plugin.send(:backend)).to eq(:backend)
+    end
+  end
+end

data/spec/lib/capistrano/scm_spec.rb

@@ -1,13 +1,13 @@
-require 'spec_helper'
+require "spec_helper"
 
-require 'capistrano/scm'
+require "capistrano/scm"
 
 module RaiseNotImplementedMacro
   def raise_not_implemented_on(method)
     it "should raise NotImplemented on #{method}" do
-      expect {
+      expect do
         subject.send(method)
-      }.to raise_error(NotImplementedError)
+      end.to raise_error(NotImplementedError)
     end
   end
 end
@@ -63,8 +63,8 @@ module Capistrano
 
       describe "#release_path" do
         it "should return the release path according to the context" do
-          context.expects(:release_path).returns('/path/to/nowhere')
-          expect(subject.release_path).to eq('/path/to/nowhere')
+          context.expects(:release_path).returns("/path/to/nowhere")
+          expect(subject.release_path).to eq("/path/to/nowhere")
         end
       end
 
@@ -101,4 +101,3 @@ module Capistrano
     end
   end
 end
-

data/spec/lib/capistrano/svn_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require "spec_helper"
 
-require 'capistrano/svn'
+require "capistrano/svn"
 
 module Capistrano
   describe Svn do
@@ -9,7 +9,10 @@ module Capistrano
 
     describe "#svn" do
       it "should call execute svn in the context, with arguments" do
-        context.expects(:execute).with(:svn, :init)
+        context.expects(:execute).with(:svn, :init, "--username someuser", "--password somepassword")
+        context.expects(:fetch).twice.with(:svn_username).returns("someuser")
+        context.expects(:fetch).twice.with(:svn_password).returns("somepassword")
+        context.expects(:fetch).once.with(:svn_revision).returns(nil)
         subject.svn(:init)
       end
     end
@@ -20,7 +23,7 @@ module Capistrano
     subject { Capistrano::Svn.new(context, Capistrano::Svn::DefaultStrategy) }
 
     describe "#test" do
-      it "should call test for repo HEAD" do  
+      it "should call test for repo HEAD" do
         context.expects(:repo_path).returns("/path/to/repo")
         context.expects(:test).with " [ -d /path/to/repo/.svn ] "
 
@@ -31,7 +34,9 @@ module Capistrano
     describe "#check" do
       it "should test the repo url" do
         context.expects(:repo_url).returns(:url)
-        context.expects(:test).with(:svn, :info, :url).returns(true)
+        context.expects(:test).with(:svn, :info, :url, "--username someuser", "--password somepassword").returns(true)
+        context.expects(:fetch).twice.with(:svn_username).returns("someuser")
+        context.expects(:fetch).twice.with(:svn_password).returns("somepassword")
 
         subject.check
       end
@@ -41,8 +46,11 @@ module Capistrano
       it "should run svn checkout" do
         context.expects(:repo_url).returns(:url)
         context.expects(:repo_path).returns(:path)
- 
-        context.expects(:execute).with(:svn, :checkout, :url, :path)
+        context.expects(:fetch).twice.with(:svn_username).returns("someuser")
+        context.expects(:fetch).twice.with(:svn_password).returns("somepassword")
+        context.expects(:fetch).once.with(:svn_revision).returns(nil)
+
+        context.expects(:execute).with(:svn, :checkout, :url, :path, "--username someuser", "--password somepassword")
 
         subject.clone
       end
@@ -50,29 +58,47 @@ module Capistrano
 
     describe "#update" do
       it "should run svn update" do
-        context.expects(:execute).with(:svn, :update)
+        context.expects(:execute).with(:svn, :update, "--username someuser", "--password somepassword")
+        context.expects(:fetch).twice.with(:svn_username).returns("someuser")
+        context.expects(:fetch).twice.with(:svn_password).returns("somepassword")
+        context.expects(:fetch).once.with(:svn_revision).returns(nil)
+
+        subject.update
+      end
+    end
+
+    describe "#update_specific_revision" do
+      it "should run svn update and update to a specific revision" do
+        context.expects(:execute).with(:svn, :update, "--username someuser", "--password somepassword", "--revision 12345")
+        context.expects(:fetch).twice.with(:svn_username).returns("someuser")
+        context.expects(:fetch).twice.with(:svn_password).returns("somepassword")
+        context.expects(:fetch).twice.with(:svn_revision).returns("12345")
 
         subject.update
       end
     end
 
     describe "#release" do
-      it "should run svn export" do        
+      it "should run svn export" do
         context.expects(:release_path).returns(:path)
-        
-        context.expects(:execute).with(:svn, :export, '--force', '.', :path)
+        context.expects(:fetch).twice.with(:svn_username).returns("someuser")
+        context.expects(:fetch).twice.with(:svn_password).returns("somepassword")
+        context.expects(:fetch).once.with(:svn_revision).returns(nil)
+
+        context.expects(:execute).with(:svn, :export, "--force", ".", :path, "--username someuser", "--password somepassword")
 
         subject.release
       end
     end
 
     describe "#fetch_revision" do
-      it "should run fetch revision" do
+      it "should capture svn version" do
         context.expects(:repo_path).returns(:path)
 
-        context.expects(:capture).with(:svnversion, :path)
+        context.expects(:capture).with(:svnversion, :path).returns("12345")
 
-        subject.fetch_revision
+        revision = subject.fetch_revision
+        expect(revision).to eq("12345")
       end
     end
   end

data/spec/lib/capistrano/upload_task_spec.rb

@@ -1,19 +1,19 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Capistrano::UploadTask do
   let(:app) { Rake.application = Rake::Application.new }
 
-  subject(:upload_task) { described_class.define_task('path/file.yml') }
+  subject(:upload_task) { described_class.define_task("path/file.yml") }
 
   it { is_expected.to be_a(Rake::FileCreationTask) }
   it { is_expected.to be_needed }
 
-  context 'inside namespace' do
-    let(:normal_task) { Rake::Task.define_task('path/other_file.yml') }
+  context "inside namespace" do
+    let(:normal_task) { Rake::Task.define_task("path/other_file.yml") }
 
-    around { |ex| app.in_namespace('namespace', &ex) }
+    around { |ex| app.in_namespace("namespace", &ex) }
 
-    it { expect(upload_task.name).to eq('path/file.yml') }
-    it { expect(upload_task.scope.path).to eq('namespace') }
+    it { expect(upload_task.name).to eq("path/file.yml") }
+    it { expect(upload_task.scope.path).to eq("namespace") }
   end
 end