capistrano-opscomplete 0.6.1 → 0.6.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6bc31c81dbbf351fcb3670d1a496b65815149a0e06ef61ad0b80c0700e8183f5
-  data.tar.gz: 9ffe2b98d9601f4b44634aab0d95076abdfc645c0746548ff32ca7a2518578ef
+  metadata.gz: ed8a513cbd0320e4dcc3e13764c70c5dbb8752a489f3a26b1d0c8d1aa480d142
+  data.tar.gz: fd3b323ce020ed6e69da74094ac4fe8feb8d88531ad7f03475c99054f7cf238c
 SHA512:
-  metadata.gz: 79864388a7142e25ecdcfffde243c61bde9702f08a276c7b99a3d343c1f2ff2a70ee20e0a68f7fed7782ca9235b5c4b371fd20905f8ef3c20f89eec5dc9246c4
-  data.tar.gz: 3a0044c57cbc5e56e6ac3b92f716b5ec2f497d539dce256cbab0e7d71093e04747f06354fc30ea71a204c3187262004c16fc5e8b46c0e67d3df3559ec880ca7b
+  metadata.gz: a2504a842b191d5384183c14b90f74cb762eb530bd2ed36541486420d615c1ee2c347fc88c2896ffe981741a21d4c1e72c58bbecbc3fbd514bf0d280831d0340
+  data.tar.gz: 5d3aa33cadda83cc57c45248b46c0b0e7f96856aa8c51d8f3dce79cc93b7a5c7efa5e290499482cdafabc6f8ae6e6cdddc4518d1a26f03230f27e1544282cc65

data/CHANGELOG.md

@@ -1,7 +1,41 @@
-## Unreleased
+## [0.6.6] - 2020-12-08
+
+### Fixed
+- Fix the error `undefined method 'after' for main:Object (NoMethodError)` when starting the rails application with capistrano-opscomplete required
+
+## [0.6.5] - 2020-11-20
+
+### Fixed
+- Correct warning message for `opscomplete:ruby:broken_gems_warning`
+
+## [0.6.4] - 2020-11-19
+
+### Added
+- You can now manage the Node.js version which needs to be installed
+- Add two new capistrano tasks (`opscomplete:ruby:broken_gems_warning`, `opscomplete:ruby:reset`) which help to mitigate problems when a deployment fails (described in: [#19](https://github.com/makandra/capistrano-opscomplete/issues/19))
+
+### Fixed
+- Added missing namespace for code example
+
+## [0.6.3] - 2020-07-23
+
+### Fixed
+- regression after ([#18](https://github.com/makandra/capistrano-opscomplete/issues/18)) was merged
+
+## [0.6.2] - 2020-07-23
+
+### Fixed
+- rbenv-build changed behaviour of `--list` ([#20](https://github.com/makandra/capistrano-opscomplete/issues/20))
+
+### Changed
+- Bumped rack dependency from 2.1.1 to 2.2.3
+
+## [0.6.1] - 2020-04-16
+### Added
+- Use Ruby 2.6 for development
 
 ### Changed
-- Upgrade rake dependency to ~>13.0
+- Add rake as a runtime dependency
 
 ## [0.6.0] - 2020-01-13
 ### Added

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    capistrano-opscomplete (0.6.1)
+    capistrano-opscomplete (0.6.6)
       capistrano (>= 3.0, < 4.0.0)
       rake
 
@@ -17,7 +17,7 @@ GEM
       rake (>= 10.0.0)
       sshkit (>= 1.9.0)
     concurrent-ruby (1.1.6)
-    i18n (1.8.2)
+    i18n (1.8.4)
       concurrent-ruby (~> 1.0)
     jaro_winkler (1.5.4)
     makandra-rubocop (4.2.0)
@@ -29,7 +29,7 @@ GEM
     parallel (1.19.1)
     parser (2.7.0.2)
       ast (~> 2.4.0)
-    rack (2.1.1)
+    rack (2.2.3)
     rainbow (3.0.0)
     rake (13.0.1)
     rubocop (0.76.0)

data/README.md

@@ -36,7 +36,13 @@ An example configuration could look like this:
 after 'deploy:updating', 'opscomplete:ruby:ensure'
 ```
 
-and in case you enabled [`Procfile support`](https://makandracards.com/opscomplete/67829-procfile-support) you can use the following tasks:
+If you want to handle the ruby version for rollbacks too, you should add:
+
+```ruby
+after 'deploy:reverting', 'opscomplete:ruby:ensure'
+```
+
+And in case you enabled [`Procfile support`](https://makandracards.com/opscomplete/67829-procfile-support) you can use the following tasks:
 
     opscomplete:supervisor:gen_config
     opscomplete:supervisor:restart_procs
@@ -151,6 +157,24 @@ There are many hooks available in the [default deploy flow](https://capistranorb
 after 'deploy:updating', 'opscomplete:ruby:ensure'
 ```
 
+## Managing your nodejs version with `capistrano-opscomplete`
+
+You can manage NodeJS also with `capistrano-opscomplete`. It will check the `.nvmrc`, `.node-version` and `.tool-versions` in the release direcotry (in this order) or you can configure it with `:opscomplete_nodejs_version` in your capistrano configuration.
+
+Include the gem in your applications Gemfile:
+
+```ruby
+gem 'capistrano-opscomplete'
+```
+
+Now, add some [hooks](#using-capistrano-hooks) in your capistrano configuration (e.g. `deploy.rb`).
+An example configuration could look like this:
+
+```ruby
+# After unpacking your release, before bundling, compiling assets, ...
+after 'deploy:updating', 'opscomplete:nodejs:ensure'
+```
+
 ## Contributing
 
 Bug reports and pull requests are welcome. Don't hesitate to [open a new issue](https://github.com/makandra/capistrano-opscomplete/issues/new).

data/lib/capistrano/dsl/opscomplete.rb

@@ -24,17 +24,17 @@ module Capistrano
         # 1) Get version from capistrano configuration (highest precedence, 'override')
         if fetch(:opscomplete_ruby_version)
           debug("Using version from :opscomplete_ruby_version setting: #{fetch(:opscomplete_ruby_version)}.")
-          return fetch(:opscomplete_ruby_version)
+          fetch(:opscomplete_ruby_version)
 
         # 2) Get version from .ruby-version in release dir (after deploy:updating, before deploy:updated)
         elsif test("[ -f #{release_ruby_version_file_path} ]")
           debug("Using version from server's release_dir/.ruby-version file: #{capture(:cat, release_ruby_version_file_path)}")
-          return capture(:cat, release_ruby_version_file_path)
+          capture(:cat, release_ruby_version_file_path)
 
         # 3) Get version from local checkout/cwd
         elsif File.readable?('.ruby-version')
           debug("Using version from local (cwd) .ruby-version file: #{File.read('.ruby-version').strip}")
-          return File.read('.ruby-version').strip
+          File.read('.ruby-version').strip
 
         # FAIL: We have no idea which version to use
         else
@@ -65,7 +65,7 @@ module Capistrano
       end
 
       def rbenv_installable_rubies
-        rbenv_installable_rubies = capture(:rbenv, :install, '--list').split("\n")
+        rbenv_installable_rubies = capture(:rbenv, :install, '--list-all').split("\n")
         rbenv_installable_rubies.map!(&:strip)
         rbenv_installable_rubies.delete('Available version:')
         rbenv_installable_rubies
@@ -108,6 +108,38 @@ module Capistrano
       def rubygems_install(version)
         rbenv_exec("gem update --no-document --system '#{version}'")
       end
+
+      def managed_nodejs?
+        test("[ -f ${HOME}/.nodejs_managed_by_makandra ]")
+      end
+
+      def app_nodejs_version
+
+        # 1) Get version from capistrano configuration (highest precedence, 'override')
+        if fetch(:opscomplete_nodejs_version)
+          debug("Using version from :opscomplete_nodejs_version setting: #{fetch(:opscomplete_nodejs_version)}.")
+          fetch(:opscomplete_nodejs_version)
+
+        # 2) Get version from version file in release dir (after deploy:updating, before deploy:updated)
+        elsif capture(:nodejs_get_version, release_path)
+          debug("Using version from server's release_dir/.nvmrc, .node-version or .tool-versions file: #{capture(:nodejs_get_version, release_path)}")
+          capture(:nodejs_get_version, release_path)
+
+        else
+          raise Capistrano::ValidationError, 'Could not find application\'s Node.js version. Consider setting opscomplete_ruby_version.'
+        end
+      end
+
+      def nodejs_installable_versions
+        nodejs_installable_versions = capture(:nodejs_installable_versions).split("\n")
+        nodejs_installable_versions.map!(&:strip)
+        nodejs_installable_versions
+      end
+
+      def nodejs_installed_versions
+        nodejs_installed_versions = capture(:nodejs_installed_versions).split("\n")
+        nodejs_installed_versions.map!(&:strip)
+      end
     end
   end
 end

data/lib/capistrano/opscomplete.rb

@@ -4,5 +4,6 @@ require 'capistrano/opscomplete/version'
 require 'rake'
 
 load File.expand_path('opscomplete/ruby.rake', __dir__)
+load File.expand_path('opscomplete/nodejs.rake', __dir__)
 load File.expand_path('opscomplete/supervisor.rake', __dir__)
-load File.expand_path('opscomplete/deploy.rake', __dir__)
+load File.expand_path('../opscomplete/hooks.rb', __FILE__)

data/lib/capistrano/opscomplete/hooks.rb

@@ -0,0 +1 @@
+after 'deploy:failed', 'opscomplete:ruby:broken_gems_warning'

data/lib/capistrano/opscomplete/nodejs.rake

@@ -0,0 +1,53 @@
+# vim: filetype=ruby
+require 'capistrano/dsl/opscomplete'
+
+namespace :opscomplete do
+  include Capistrano::DSL::Opscomplete
+  # desc 'Validate opscomplete specific configuration'
+  task :validate do
+    invoke('opscomplete:nodejs:check')
+  end
+
+  namespace :nodejs do
+    desc 'Check if nodejs version is set according to application\'s .node-version or .nvmrc (in this order).'
+    task :check do
+      on roles fetch(:nodejs_roles, :all) do |host|
+        warn("#{host}: Managed Node.js environment! Won't do any changes to nodejs version.") if managed_nodejs?
+        unless capture(:nodejs_current_version) == app_nodejs_version
+          raise Capistrano::ValidationError,
+                "#{host}: Node.js version is not set according to application\'s .node-version or .nvmrc file. Use cap opscomplete:nodejs:ensure."
+        end
+        info("#{host}: Node.js #{app_nodejs_version} is installed.")
+      end
+    end
+
+    desc 'Update Node.js version management tool'
+    task :update_nodejs_build do
+      on roles fetch(:nodejs_roles, :all) do
+        execute :nodejs_update_management_tool
+      end
+    end
+
+    desc 'Install and configure NodeJS according to applications .nvmrc, .node-version or .tool-versions.'
+    task :ensure do
+      invoke('opscomplete:nodejs:update_nodejs_build')
+      on roles fetch(:nodejs_roles, :all) do |host|
+        if managed_nodejs?
+          raise Capistrano::ValidationError, "#{host}: Managed Node.js environment! Won't do any changes to Node.js version."
+        end
+        if nodejs_installed_versions.include?(app_nodejs_version)
+          info("#{host}: Node.js #{app_nodejs_version} is installed.")
+        elsif nodejs_installable_versions.include?(app_nodejs_version)
+          info("#{host}: Configured Node.js version is not installed, but available for installation.")
+          with tmpdir: fetch(:tmp_dir) do
+            execute(:nodejs_install_version, "'#{app_nodejs_version}'")
+          end
+        else
+          raise Capistrano::ValidationError,
+                "#{host}: Configured Node.js version is neither installed nor installable."
+        end
+        execute(:nodejs_set_version, "'#{app_nodejs_version}'")
+      end
+    end
+  end
+end

data/lib/capistrano/opscomplete/ruby.rake

@@ -106,12 +106,52 @@ namespace :opscomplete do
           raise Capistrano::ValidationError,
                 "#{host}: Configured Ruby version is neither installed nor installable using ruby-install."
         end
-        execute(:rbenv, :global, "'#{app_ruby_version}'") unless capture(:rbenv, :global) == app_ruby_version
+        unless capture(:rbenv, :global) == app_ruby_version
+          set :ruby_modified, true
+          execute(:rbenv, :global, "'#{app_ruby_version}'")
+        end
       end
       invoke('opscomplete:ruby:install_rubygems')
       invoke('opscomplete:ruby:install_bundler')
       invoke('opscomplete:ruby:install_geordi')
       invoke('opscomplete:ruby:rehash') if fetch(:rbenv_needs_rehash, false)
     end
+
+    desc 'resets the global ruby version and gems to Gemfile and .ruby-version in current_path.'
+    task :reset do
+      on roles fetch(:rbenv_roles, :all) do |host|
+        within current_path do
+          current_ruby_version_file_path = current_path.join('.ruby-version').to_s
+          if test("[ -f #{current_ruby_version_file_path} ]")
+            execute(:rbenv, :global, capture(:cat, current_ruby_version_file_path))
+          else
+            raise Capistrano::ValidationError,
+                  "#{host}: Missing .ruby-version in #{current_path}. Won't set a new global version."
+          end
+          if test("[ -f '#{current_path}/.bundle/config' ]")
+            debug("#{host}: Found #{current_path}/.bundle/config, running bundle pristine.")
+            set :bundle_gemfile, -> { current_path.join('Gemfile') }
+            execute(:bundle, :pristine)
+          else
+            raise Capistrano::ValidationError,
+              "Unable to find #{current_path}/.bundle/config, won't run bundle pristine."
+          end
+        end
+      end
+    end
+
+    desc 'Set the old ruby version before the change and invoke bundle pristine.'
+    task :broken_gems_warning do
+      on roles fetch(:rbenv_roles, :all) do |host|
+        if fetch(:ruby_modified, false)
+          warn("Deploy failed and the ruby version has been modified in this deploy.")
+          warn("If this was a minor ruby version upgrade your running application may run into issues with native gem extensions.")
+          warn("If your deploy failed before deploy:symlink:release you may run bundle exec `cap #{fetch(:stage)} opscomplete:ruby:reset`.")
+          warn("Please refer https://makandracards.com/makandra/477884-bundler-in-deploy-mode-shares-gems-between-patch-level-ruby-versions")
+        else
+          debug("#{host}: Ruby not modified in current deploy.")
+        end
+      end
+    end
   end
 end

data/lib/capistrano/opscomplete/supervisor.rake

@@ -27,7 +27,7 @@ namespace :opscomplete do
         end
       end
     end
-    
+
     # Can be used for example to quiet sidekiq with a task like this:
     #
     #     namespace :sidekiq do
@@ -36,12 +36,12 @@ namespace :opscomplete do
     #         on roles :cron do
     #           # The TSTP signal tells sidekiq to quiet all workers.
     #           # see: https://github.com/mperham/sidekiq/wiki/Signals#tstp
-    #           invoke('supervisor:signal_procs', 'TSTP', 'sidekiq')
+    #           invoke('opscomplete:supervisor:signal_procs', 'TSTP', 'sidekiq')
     #         end
     #       end
     #     end
     desc 'Sends the signal (e.g. USR1 or TSTP) to all programs or if specified to program_name.'
-    task :signal_procs, :signal, :program_name do |task_name, args|
+    task :signal_procs, :signal, :program_name do |_task_name, args|
       signal = args.fetch(:signal)
       program_name = args.fetch(:program_name, nil)
 

data/lib/capistrano/opscomplete/version.rb

@@ -1,5 +1,5 @@
 module Capistrano
   module Opscomplete
-    VERSION = '0.6.1'.freeze
+    VERSION = '0.6.6'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capistrano-opscomplete
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.6
 platform: ruby
 authors:
 - Makandra Operations
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-16 00:00:00.000000000 Z
+date: 2020-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: makandra-rubocop
@@ -89,9 +89,11 @@ files:
 - bin/console
 - bin/setup
 - capistrano-opscomplete.gemspec
+- lib/capistrano-opscomplete.rb
 - lib/capistrano/dsl/opscomplete.rb
 - lib/capistrano/opscomplete.rb
-- lib/capistrano/opscomplete/deploy.rake
+- lib/capistrano/opscomplete/hooks.rb
+- lib/capistrano/opscomplete/nodejs.rake
 - lib/capistrano/opscomplete/ruby.rake
 - lib/capistrano/opscomplete/supervisor.rake
 - lib/capistrano/opscomplete/version.rb
@@ -118,7 +120,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 2.0.1
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Capistrano tasks for easy deployment to a makandra opscomplete environment.

data/lib/capistrano/opscomplete/deploy.rake

@@ -1,10 +0,0 @@
-namespace :deploy do
-  desc 'Show deployed revision'
-  task :revision do
-    on roles :app do
-      within current_path do
-        info "Revision: #{capture(:cat, 'REVISION')}"
-      end
-    end
-  end
-end