capistrano-net_storage 0.5.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f402751b93d15bbc8660b9669a18977ac69d67381d45c0316afd89d185f750fe
-  data.tar.gz: 38905906ddf2c6aae2706679eb907b6970c1099e058eb8f8c676932656cc3f7d
+  metadata.gz: ff8a4495e5e93c5beafb4e28a03e7c4193b29d09d044070010d65490abf1cf66
+  data.tar.gz: 3ab025f3a318d792b5752beddc0eb9a2a8f5ce1ac31a3e196925da772fd3a1ce
 SHA512:
-  metadata.gz: 3c61f03392a39f8f69c824fc196ef3e056c206e1c00ecce038e73f18b8782074d4ef5895fbf65d4c5e42666950ab0b0c53b99ceeeeb5d428122c92caa1dc8373
-  data.tar.gz: cd42fc4f35a13075920dff572727a93e4f9db1d28249833d0af85a5edc82d661303a2595511ab2b7067f5a3939cead39d5a5a68ffe7a2577799ea94f03b9c099
+  metadata.gz: 52a6a1c75575a63469395ded4e89c448045791fa45ff01f899462859b741e562d9b1055309b0773f80617cc635b71651ec0d32a5e792cc5cd29a0833b8ca9b47
+  data.tar.gz: be6cb831bb78fe7781f87fc17304a7384ee697f7c345cb99298e49f5f1693f3034ff35f2cf3389e5ff281c00f78acd811e33758018268913cc43d00e7ccafb7e

data/CHANGELOG.md

@@ -1,3 +1,66 @@
+## 1.0.0 (2023/08/07)
+
+**Scalable by Default**
+
+Major Update by @aeroastro
+
+The main objective of this update is scalable by default. You can enjoy the scalability and fine-tuned settings just out of the box.
+
+New Features:
+
+- `:net_storage_multi_app_mode` (default: `false`) has been introduced to deploy a repository with multiple applications (#14)
+  - This mode is more convenient than `repo_tree` when there is a dependency among subdirectories.
+- Plugin style is now officially supported for Capistrano >= 3.7 (#22)
+- Officially supported task hook point is introduced `after 'net_storage:prepare_archive'` (#22)
+- `:net_storage_keep_remote_archives` has been introduced to control the number of remote archives (#24)
+
+Changes
+
+- Default archiver is now `.tar.gz` instead of `.zip` to improve integrity (#19)
+- Default value of `:net_storage_config_files` has been changed from `nil` to `[]` (#20)
+- Minimum required Ruby version is now 2.7 (#21)
+- Minimum required Bundler version is now 2.1 (#21)
+- Minimum required Capistrano version is now 3.7.0 (#22)
+- `:net_storage_archive_on_missing` has been renamed to `:net_storage_reuse_archive` (#22)
+- Default value of `:net_storage_max_parallels` is now 1000 (#22)
+- Default value of `:net_storage_local_base_path` is now `.local_net_storage` (#22)
+- `:net_storage_local_#{mirror,releases,bundle,archives}_path` has been removed from settings (#22)
+- `:net_storage_with_bundle` is renamed to `:net_storage_skip_bundle` (#22)
+- Default value of `:net_storage_skip_bundle` is changed to conduct `bundle install` (#22)
+- Default value of `:net_storage_upload_files_by_rsync` is now `true` (#22)
+
+
+Bug Fixes:
+
+- `IOError: closed stream` error from SSHKit has been fixed. (#13)
+- Deprecation warning of `bundle install --path` and other option have been fixed (#14)
+- Fix bug when `config_files` is an empty array (#14)
+- Fix deprecation warning coming from Bundler.with_clean_env (#21)
+- Allow Capistrano::NetStorage to deploy different Ruby versions (#28)
+
+Improvement:
+
+- The speed of config file deployment is dramatically improved by reducing `rsync` to 1 command (#13)
+- The need of `.bundle/config` deployment is properly removed, and deployment becomes faster. (#14)
+- Jitter duration has been introduced to increase stability for `rsync` and transport layer. (#22)
+
+Internal Improvement (mainly for maintainers and plugin developers):
+
+- Delegation system has been improved.
+  - `file_extension` is delegated to `:archiver` class (#14)
+  - Checking `local_bundle_path` is delegated to `:bundler` class (#14)
+- `rsync` mechanism between cache and install directory has been improved (#14)
+- Caching at `Capistrano::NetStorage::Config` has been removed to remove potential bugs (#14)
+- `Capistrano::NetStorage::Transport#cleanup` is now mandatory (#15)
+- GitHub Actions have been introduced for CI (#16, #17, #18)
+- `:net_storage_archiver` class must implement `Capistrano::NetStorage::Archiver::SomeClass#.file_extension` (#22)
+- `Capistrano::NetStorage::Config#archive_suffix` now shows deprecation warnings. (#22)
+- All the default settings can be consulted via `Capistrano::NetStorage::Plugin#set_defaults` (#22)
+- `:net_storage_servers` has been removed (#22)
+- Large-scale refactoring (#22)
+- `NotImplementedError` message has been improved to ease debugging for plugin developers (#25)
+
+
 ## 0.4.0 (2022/05/17)
 
 Fix Bug:

data/README.md

@@ -1,5 +1,6 @@
 [![Gem Version](https://badge.fury.io/rb/capistrano-net_storage.svg)](https://badge.fury.io/rb/capistrano-net_storage)
-[![Build Status](https://travis-ci.org/DeNADev/capistrano-net_storage.svg?branch=master)](https://travis-ci.org/DeNADev/capistrano-net_storage)
+[![Test](https://github.com/DeNADev/capistrano-net_storage/actions/workflows/test.yml/badge.svg)](https://github.com/DeNADev/capistrano-net_storage/actions/workflows/test.yml?query=branch%3Amaster)
+
 # Capistrano::NetStorage
 
 **Capistrano::NetStorage** is a [Capistrano](http://capistranorb.com/) plugin to deploy application
@@ -13,13 +14,14 @@ Logically, this tool enables _O(1)_ deployment.
 
 The image below illustrates the concept of **Capistrano::NetStorage**.
 
-![concept](https://github.com/DeNADev/capistrano-net_storage/raw/resource/images/concept.png)
+![concept](docs/images/concept.png)
 
-This library goes following procedures as _capistrano tasks_:
+This library conducts the following procedures as _capistrano tasks_:
 
 1. Prepare an archive of application to upload.
-  * Clone or update source code repository on deploy server.
-  * Do `bundle install` by an option.
+  * Clone and update source code repository on deploy server.
+  * Extract the internals to local release directory.
+  * Further prepare the local release. (e.g. `bundle install` and `assets:precompile`)
 2. Upload the archive to _remote storage_.
 3. Download the archive from _remote storage_ on application servers.
   * This task is executed in parallel way.
@@ -44,26 +46,39 @@ Or install it yourself as:
 
 Set Capistrano variables by `set name, value`.
 
+You can consult configuration of Capistrano itself at https://capistranorb.com/documentation/getting-started/configuration/
+
+Configurations of Capistrano::NetStorage are as follows:
+
+#### General Settings
+
+ Name | Default | Description
+------|---------|------------
+ `:net_storage_transport` | NO DEFAULT | Transport class for _remote storage_ e.g. `Capistrano::NetStorage::S3`
+ `:net_storage_config_files` | `[]` | Files to sync `config/` directory on target servers' application directory
+
+#### Settings for Behavioral Changes
+
+ Name | Default | Description
+------|---------|------------
+ `:net_storage_skip_bundle` | `false` | Skip `bundle install` when creating archive (might be work for non-Ruby app)
+ `:net_storage_multi_app_mode` | `false` | Deploy a repository with multiple Rails apps at the top directory
+
+#### Other Settings
+
+**NOTE: We strongly recommend the defaults for integrity and performance. Change at your own risk.**
+
  Name | Default | Description
 ------|---------|------------
- `:scm`  | `nil` | Set `:net_storage` for capistrano before v3.7
- `:branch` | `master` | Target branch of SCM to release
- `:keep_releases` | `5` | Numbers to keep released versions
- `:net_storage_archiver` | `Capistrano::NetStorage::Archiver::Zip` | Archiver class
+ `:net_storage_archiver` | `Capistrano::NetStorage::Archiver::TarGzip` | Archiver class
  `:net_storage_scm` | `Capistrano::NetStorage::SCM::Git` | Internal scm class for application repository
- `:net_storage_transport` | `nil` | Transport class for _remote storage_
- `:net_storage_archive_on_missing` | `true` | If `true`, create and upload archive only when target archive is missing on remote storage
- `:net_storage_config_files` | `nil` | Files to sync `config/` directory on target servers' application directory
- `:net_storage_max_parallels` | number of servers | Max concurrency for remote tasks
+ `:net_storage_upload_files_by_rsync` | `true` | Use rsync(1) to deploy config files
  `:net_storage_rsync_options` | `#{ssh_options}` | SSH options for rsync command to sync configs
- `:net_storage_upload_files_by_rsync` | `false` | Use rsync(1) to deploy config files
- `:net_storage_with_bundle` | `false` | Do `bundle install` when creating archive
- `:net_storage_local_base_path` | `.local_repo` | Base directory on deploy server
- `:net_storage_local_mirror_path` | `#{net_storage_local_base_path}/mirror` | Path to clone repository on deploy server
- `:net_storage_local_releases_path` | `#{net_storage_local_base_path}/releases` | Path to keep release directories on deploy server
- `:net_storage_local_bundle_path` | `#{net_storage_local_base_path}/bundle` | Shared directory to install gems on deploy server
- `:net_storage_local_archives_path` | `#{net_storage_local_base_path}/archives` | Archive directories on deploy server
+ `:net_storage_max_parallels` | 1000 | Max concurrency for remote tasks. (This default is being tuned by maintainers.)
+ `:net_storage_reuse_archive` | `true` | If `true`, it reuses archive with the same commit hash at remote storage and uploads archives only when it does not exist.
+ `:net_storage_local_base_path` | `.local_net_storage` | Base directory on deploy server
  `:net_storage_archives_path` | `#{deploy_to}/net_storage_archives` | Archive directories on application server
+ `:net_storage_keep_remote_archives` | 10 | Number of archive files keep on remote storage
 
 ### Transport Plugins
 
@@ -76,6 +91,8 @@ If you wish a plugin for other types of _remote storage_, you can develop it. It
 
 ## Usage
 
+Below is the typical usage of Capistrano::NetStorage.
+
 Edit Capfile:
 
 ```ruby
@@ -86,34 +103,37 @@ require 'capistrano/setup'
 require 'capistrano/deploy'
 
 # Includes tasks from other gems included in your Gemfile
-if Gem::Version.new(Capistrano::VERSION) < Gem::Version.new('3.7.0')
-  require 'capistrano/net_storage'
-else
-  require "capistrano/net_storage/plugin"
-  install_plugin Capistrano::NetStorage::Plugin
-end
+require "capistrano/net_storage/plugin"
+install_plugin Capistrano::NetStorage::Plugin
 
 # Load transport plugin for Capistrano::NetStorage
-# require 'capistrano/net_storage/s3'
+require 'capistrano/net_storage/s3' # or your_custom_transport
 ```
 
 Edit your `config/deploy.rb`:
 
 ```ruby
-if Gem::Version.new(Capistrano::VERSION) < Gem::Version.new('3.7.0')
-  set :scm, :net_storage
-end
-set :net_storage_transport, Your::TransportPluginModule
-# set :net_storage_transport, Capistrano::NetStorage::S3::Transport # w/ capistrano-net_storage-s3
-# set :net_storage_config_files, [your_config_files]
-# set :net_storage_with_bundle, true
-# set :net_storage_archiver, Capistrano::NetStorage::Archiver::TarGzip
+set :net_storage_transport, Capistrano::NetStorage::S3::Transport # or YourCustomTransport class
+set :net_storage_config_files, Pathname('path/to/config').glob('*.yml')
 ```
 
-## Example
+When you want to further prepare the release before deployment, you can write it as follows:
 
-You can see typical usage of this library by
-[capistrano-net_storage_demo](https://github.com/DeNADev/capistrano-net_storage_demo).
+```ruby
+namespace :your_namespace do
+  task :prepare_archive do
+    run_locally do
+      within Capistrano::NetStorage.config.local_release_app_path do
+        # The resultant artifacts are to be archived with other files
+        execute :bundle, 'exec', 'rake', 'build_in_memory_cache_bundle'
+        execute :bundle, 'exec', 'rake', 'assets:precompile'
+      end
+    end
+  end
+end
+
+after 'net_storage:prepare_archive', 'your_namespace:prepare_archive'
+```
 
 ## License
 
@@ -123,4 +143,4 @@ Copyright (c) 2017 DeNA Co., Ltd., IKEDA Kiyoshi
 
 ## Special Thanks
 
-The previous version of this program was originally developed by @bobpp.
+The previous version of this program was originally developed by @bobpp.

data/capistrano-net_storage.gemspec

@@ -16,12 +16,12 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/DeNADev/capistrano-net_storage'
   spec.license       = 'MIT'
 
-  spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(\.github|docs|test|spec|features)/}) }
   spec.require_paths = ['lib']
-  spec.required_ruby_version = '>= 2.0'
+  spec.required_ruby_version = '>= 2.7'
 
-  spec.add_runtime_dependency 'capistrano', '>= 3.3.3'
-  spec.add_runtime_dependency 'bundler'
+  spec.add_runtime_dependency 'capistrano', '>= 3.7'
+  spec.add_runtime_dependency 'bundler', '>= 2.1'
 
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'

data/lib/capistrano/net_storage/archiver/base.rb

@@ -1,25 +1,22 @@
 module Capistrano
   module NetStorage
     module Archiver
-      # Abstract class to archive and extract whole application contents
-      # @abstract
+      # Abstract class to archive release in local and extract release in remote
       class Base
-        # Check prerequisites to archive
-        # @abstract
         def check
-          raise NotImplementedError
+          raise NotImplementedError, "Implement `#{self.class}#{__method__}` to check prerequisites for Archiver"
         end
 
-        # Create archive
-        # @abstract
         def archive
-          raise NotImplementedError
+          raise NotImplementedError, "Implement `#{self.class}#{__method__}` to create archive from `Capistrano::NetStorage.config.local_release_path` to `Capistrano::NetStorage.config.local_archive_path`"
         end
 
-        # Extract archive
-        # @abstract
         def extract
-          raise NotImplementedError
+          raise NotImplementedError, "Implement `#{self.class}#{__method__}` to extract archive from `Capistrano::NetStorage.config.archive_path` to `release_path`"
+        end
+
+        def self.file_extension
+          raise NotImplementedError, "Implement `#{self.class}#{__method__}` to return file extension String such as 'zip' or 'tar.gz'"
         end
       end
     end

data/lib/capistrano/net_storage/archiver/tar_gzip.rb

@@ -1,10 +1,7 @@
 require 'capistrano/net_storage/archiver/base'
-require 'capistrano/net_storage/utils'
 
 # Archiver class for .tar.gz format
 class Capistrano::NetStorage::Archiver::TarGzip < Capistrano::NetStorage::Archiver::Base
-  include Capistrano::NetStorage::Utils
-
   def check
     run_locally do
       execute :which, 'tar'
@@ -12,22 +9,27 @@ class Capistrano::NetStorage::Archiver::TarGzip < Capistrano::NetStorage::Archiv
   end
 
   def archive
-    c = config
+    config = Capistrano::NetStorage.config
+
     run_locally do
-      within c.local_release_path do
-        execute :tar, 'czf', c.local_archive_path, '.'
+      within config.local_release_path do
+        execute :tar, 'czf', config.local_archive_path, '.'
       end
     end
   end
 
   def extract
-    c = config
-    on c.servers, in: :groups, limit: c.max_parallels do
-      execute :mkdir, '-p', c.archives_path
+    config = Capistrano::NetStorage.config
+
+    on release_roles(:all), in: :groups, limit: config.max_parallels do
       execute :mkdir, '-p', release_path
       within release_path do
-        execute :tar, 'xzf', c.archive_path
+        execute :tar, 'xzf', config.archive_path
       end
     end
   end
+
+  def self.file_extension
+    'tar.gz'
+  end
 end

data/lib/capistrano/net_storage/archiver/zip.rb

@@ -1,10 +1,7 @@
 require 'capistrano/net_storage/archiver/base'
-require 'capistrano/net_storage/utils'
 
 # Archiver class for zip format
 class Capistrano::NetStorage::Archiver::Zip < Capistrano::NetStorage::Archiver::Base
-  include Capistrano::NetStorage::Utils
-
   def check
     run_locally do
       execute :which, 'zip'
@@ -12,22 +9,28 @@ class Capistrano::NetStorage::Archiver::Zip < Capistrano::NetStorage::Archiver::
   end
 
   def archive
-    c = config
+    config = Capistrano::NetStorage.config
+
     run_locally do
-      within c.local_release_path do
-        execute :zip, c.local_archive_path, '-r', '.'
+      within config.local_release_path do
+        execute :zip, config.local_archive_path, '-r', '.'
       end
     end
   end
 
   def extract
-    c = config
-    on c.servers, in: :groups, limit: c.max_parallels do
-      execute :mkdir, '-p', c.archives_path
+    config = Capistrano::NetStorage.config
+
+    on release_roles(:all), in: :groups, limit: config.max_parallels do
+      execute :mkdir, '-p', config.archives_path
       execute :mkdir, '-p', release_path
       within release_path do
-        execute :unzip, c.archive_path
+        execute :unzip, config.archive_path
       end
     end
   end
+
+  def self.file_extension
+    'zip'
+  end
 end

data/lib/capistrano/net_storage/bundler/default.rb

@@ -0,0 +1,55 @@
+require 'bundler'
+
+module Capistrano
+  module NetStorage
+    module Bundler
+      class Default
+        def check
+          config = Capistrano::NetStorage.config
+
+          run_locally do
+            execute :which, 'bundle'
+            execute :mkdir, '-p', config.local_bundle_path
+          end
+        end
+
+        # bundle install locally. `.bundle/config` and installed gems are to be included in the release and archive.
+        def install
+          config = Capistrano::NetStorage.config
+
+          run_locally do
+            within config.local_release_app_path do
+              ::Bundler.with_unbundled_env do
+                with rbenv_version: nil, rbenv_dir: nil do
+                  bundle = if test :rbenv, 'version'
+                    %w[rbenv exec bundle]
+                  else
+                    %w[bundle]
+                  end
+
+                  install_path = Pathname.new('vendor/bundle') # must be a relative path for portability between local and remote
+                  execute :mkdir, '-p', install_path
+
+                  # Sync installed gems from shared directory to speed up installation
+                  execute :rsync, '-a', '--delete', "#{config.local_bundle_path}/", install_path
+
+                  # Always set config
+                  execute *bundle, 'config', 'set', '--local', 'deployment', 'true'
+                  execute *bundle, 'config', 'set', '--local', 'path', install_path
+                  execute *bundle, 'config', 'set', '--local', 'without', 'development test'
+                  execute *bundle, 'config', 'set', '--local', 'disable_shared_gems', 'true'
+
+                  execute *bundle, 'install', '--quiet'
+                  execute *bundle, 'clean'
+
+                  # Sync back to shared directory for the next release
+                  execute :rsync, '-a', '--delete', "#{install_path}/", config.local_bundle_path
+                end
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/capistrano/net_storage/bundler/null.rb

@@ -0,0 +1,15 @@
+module Capistrano
+  module NetStorage
+    module Bundler
+      class Null
+        def check
+          # Do nothing
+        end
+
+        def install
+          # Do nothing
+        end
+      end
+    end
+  end
+end

data/lib/capistrano/net_storage/cleaner.rb

@@ -1,35 +1,20 @@
-require 'capistrano/net_storage/utils'
-
 module Capistrano
   module NetStorage
     # Executor class for cleaning tasks
     class Cleaner
-      include Capistrano::NetStorage::Utils
+      # Check for prerequisites.
+      # Same interface to delegated class
+      def check
+      end
 
       # Clean up old release directories on local.
       # Assumes they are under +config.local_releases_path+
       # @see Capistrano::NetStorage::Config#local_releases_path
       def cleanup_local_releases
-        c = config
-        run_locally do
-          contents = capture(:ls, '-x', c.local_releases_path).split
-          # reference
-          # https://github.com/capistrano/capistrano/blob/cc4f31fdfcb4a21c569422a95868d0bb52844c75/lib/capistrano/tasks/deploy.rake#L152
-          releases, invalid = contents.partition { |e| /^\d{14}$/ =~ e }
-
-          if invalid.any?
-            warn "Invalid contents in #{c.local_releases_path} on local:\n#{invalid.join("\n")}"
-          end
+        config = Capistrano::NetStorage.config
 
-          if releases.count > fetch(:keep_releases)
-            info "Keeping #{fetch(:keep_releases)} of #{releases.count} releases on local"
-            old_releases = (releases - releases.last(fetch(:keep_releases))).map do |release|
-              c.local_releases_path.join(release).to_s
-            end
-            execute :rm, '-rf', *old_releases
-          else
-            info "No old releases (keeping newest #{fetch(:keep_releases)}) in #{c.local_releases_path} on local"
-          end
+        run_locally do
+          Capistrano::NetStorage::Cleaner.clean_targets(config.local_releases_path, /^\d{14}$/)
         end
       end
 
@@ -37,24 +22,10 @@ module Capistrano
       # Assumes they are under +config.local_archives_path+
       # @see Capistrano::NetStorage::Config#local_archives_path
       def cleanup_local_archives
-        c = config
-        run_locally do
-          contents = capture(:ls, '-x', c.local_archives_path).split
-          archives, invalid = contents.partition { |e| /^\d{14}\.#{Regexp.escape(c.archive_suffix)}$/ =~ e }
-
-          if invalid.any?
-            warn "Invalid contents in #{c.local_archives_path} on local:\n#{invalid.join("\n")}"
-          end
+        config = Capistrano::NetStorage.config
 
-          if archives.count > fetch(:keep_releases)
-            info "Keeping #{fetch(:keep_releases)} of #{archives.count} archives on local"
-            old_archives = (archives - archives.last(fetch(:keep_releases))).map do |archive|
-              c.local_archives_path.join(archive).to_s
-            end
-            execute :rm, '-f', *old_archives
-          else
-            info "No old archives (keeping newest #{fetch(:keep_releases)}) in #{c.local_archives_path} on local"
-          end
+        run_locally do
+          Capistrano::NetStorage::Cleaner.clean_targets(config.local_archives_path, /^\d{14}\..+$/) # Do not care file extension
         end
       end
 
@@ -62,42 +33,37 @@ module Capistrano
       # Assumes they are under +config.archives_path+
       # @see Capistrano::NetStorage::Config#archives_path
       def cleanup_archives
-        c = config
-        on c.servers, in: :groups, limit: c.max_parallels do |host|
-          contents = capture(:ls, '-x', c.archives_path).split
-          archives, invalid = contents.partition { |e| /^\d{14}\.#{Regexp.escape(c.archive_suffix)}$/ =~ e }
+        config = Capistrano::NetStorage.config
 
-          if invalid.any?
-            warn "Invalid contents in #{c.archives_path} on #{host}:\n#{invalid.join("\n")}"
-          end
+        on release_roles(:all), in: :groups, limit: config.max_parallels do
+          Capistrano::NetStorage::Cleaner.clean_targets(config.archives_path, /^\d{14}\..+$/) # Do not care file extension
+        end
+      end
 
-          if archives.count > fetch(:keep_releases)
-            info "Keeping #{fetch(:keep_releases)} of #{archives.count} archives on #{host}"
-            old_archives = (archives - archives.last(fetch(:keep_releases))).map do |archive|
-              c.archives_path.join(archive).to_s
-            end
+      def self.clean_targets(target_parent_path, target_regexp)
+        files_or_directories = backend.capture(:ls, '-x', target_parent_path).split
+        targets, invalid = files_or_directories.partition { |e| target_regexp =~ e }
 
-            if test("[ -d #{current_path} ]")
-              current_release = capture(:readlink, current_path).to_s
-              current_release_archive = c.archives_path.join("#{File.basename(current_release)}.#{c.archive_suffix}")
-              if old_archives.include?(current_release_archive)
-                warn "Current release archive was marked for being removed but it's going to be skipped on #{host}"
-                old_archives.delete(current_release_archive)
-              end
-            else
-              debug "There is no current release present on #{host}"
-            end
+        if invalid.any?
+          backend.warn "Invalid targets in #{target_parent_path} on #{backend.host}: #{invalid.inspect}"
+        end
 
-            if old_archives.any?
-              old_archives.each_slice(100) do |old_archives_batch|
-                execute :rm, '-f', *old_archives_batch
-              end
-            end
-          else
-            info "No old archives (keeping newest #{fetch(:keep_releases)}) in #{c.archives_path} on #{host}"
+        if targets.count > fetch(:keep_releases)
+          backend.info "Keeping #{fetch(:keep_releases)} of #{targets.count} in #{target_parent_path} on #{backend.host}"
+          old_targets = (targets - targets.last(fetch(:keep_releases))).map do |target|
+            target_parent_path.join(target).to_s
+          end
+          old_targets.each_slice(100) do |old_targets_batch|
+            backend.execute :rm, '-rf', *old_targets_batch
           end
+        else
+          backend.info "No old targets (keeping newest #{fetch(:keep_releases)}) in #{target_parent_path} on #{backend.host}"
         end
       end
+
+      def self.backend
+        SSHKit::Backend.current
+      end
     end
   end
 end