capistrano-graphite 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2c337353592f855999c6be4c8db8599556225dfb
-  data.tar.gz: 9a654504efff0eb61d7a25fbe95280f76d6d0710
+  metadata.gz: 60c9b97e320cf08d4938903692509edd5461c6ff
+  data.tar.gz: 5e029a18828420df084a31025e61b7b873cc5791
 SHA512:
-  metadata.gz: ca92e6af6cd0905bc516d4fa47c2604486187e7759ae10b72a0b5d82410deec18d0a4dcaa0835d6bf415ed7692870e4802cc0daeae63652ad43683b6822c8648
-  data.tar.gz: 55162d1d21751b205ed8362f9265476b4d560f56e7d47203fd719ab9ddf767f8bceb78ce4139d6674dabc1ebfb4995c4650a47d075ade22ed59e2e723913008b
+  metadata.gz: 1a05c0951e1e3fe085c9c4799a2df0664164a77004d7fa6e4382a105337d90decc57ed25449ec746a8d9e17b90d437f6b37b49ba6a47aa7b3ce555db6c969a1b
+  data.tar.gz: bb2277b64bd8650b695686bd1ef3b81a8b93c5e60c7e44e43eead5564b241ff7e47c09410ecc69b1941970432afea2a926a06b9602bca868b4ddbbe58a927b37

data/.rubocop.yml

@@ -0,0 +1,6 @@
+# This is the configuration used to check the capistrano-graphite source code.
+
+inherit_from: .rubocop_todo.yml
+
+Style/Encoding:
+  Enabled: true

data/.rubocop_todo.yml

@@ -0,0 +1,14 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2014-11-18 14:45:57 -0500 using RuboCop version 0.27.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 20
+
+# Offense count: 2
+Style/RegexpLiteral:
+  MaxSlashes: 0

data/.travis.yml

@@ -1,5 +1,10 @@
 language: ruby
+
 rvm:
-  - 2.1.0
-  - 2.0.0
   - 1.9.3
+  - 2.0.0
+  - 2.1.0
+
+script:
+  - bundle exec rspec
+  - bundle exec rubocop

data/CHANGELOG.md

@@ -0,0 +1,15 @@
+## 1.0.1
+
+BUG FIXES:
+
+  - Fix bug where multiple events were sent to graphite. [GH-18]
+
+IMPROVEMENTS:
+
+  - Update test command example in README.md. [GH-19]
+  - Lint entire project with RuboCop. [GH-17]
+  - Add `rake` task to lint with RuboCop when Travis is run. [GH-17]
+
+## Previous Versions
+
+Sorry, no true documentation was kept prior to 1.0.1.

data/Gemfile

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in capistrano-graphite.gemspec

data/README.md

@@ -1,16 +1,11 @@
 # Capistrano::Graphite
-[![Gem Version](http://img.shields.io/gem/v/capistrano-graphite.svg)][gem]
-[![Build Status](http://img.shields.io/travis/scottsuch/capistrano-graphite.svg)][travis]
-[![Dependency Status](http://img.shields.io/gemnasium/scottsuch/capistrano-graphite.svg)][gemnasium]
-[![Coverage Status](http://img.shields.io/coveralls/scottsuch/capistrano-graphite.svg)][coveralls]
-[![Code Climate](http://img.shields.io/codeclimate/github/scottsuch/capistrano-graphite.svg)][codeclimate]
-
-[gem]: https://rubygems.org/gems/capistrano-graphite
-[travis]: http://travis-ci.org/scottsuch/capistrano-graphite
-[gemnasium]: https://gemnasium.com/scottsuch/capistrano-graphite
-[coveralls]: https://coveralls.io/r/scottsuch/capistrano-graphite
-[codeclimate]: https://codeclimate.com/github/scottsuch/capistrano-graphite
-This gem works with Capistrano v3.1.0 and above and was based off the work on [this gem](https://github.com/hellvinz/graphite-notify) which works with Capistrano v2.x.
+[![Gem Version](http://img.shields.io/gem/v/capistrano-graphite.svg)](https://rubygems.org/gems/capistrano-graphite)
+[![Build Status](http://img.shields.io/travis/scottsuch/capistrano-graphite.svg)](http://travis-ci.org/scottsuch/capistrano-graphite)
+[![Dependency Status](http://img.shields.io/gemnasium/scottsuch/capistrano-graphite.svg)](https://gemnasium.com/scottsuch/capistrano-graphite)
+[![Code Climate](http://img.shields.io/codeclimate/github/scottsuch/capistrano-graphite.svg)](https://codeclimate.com/github/scottsuch/capistrano-graphite)
+[![Coverage Status](https://img.shields.io/coveralls/scottsuch/capistrano-graphite.svg)](https://coveralls.io/r/scottsuch/capistrano-graphite?branch=master)
+
+This gem works with Capistrano v3.0.0 and above and was based off the work on [this gem](https://github.com/hellvinz/graphite-notify) which works with Capistrano v2.x.
 
 Adding this gem to [Capistrano](https://github.com/capistrano/capistrano) extends functionality by pushing events to graphite upon deployment and rollback.
 Currently events are only pushed after `deploy:updated` and `deploy:reverted`.
@@ -39,7 +34,7 @@ Add the following line to your `Capfile`.
 ### Configurable options
 Path to your graphite instance. Port and user:password are optional.
 
-    set: :graphite_url, "http://user:password@example.com:8000/events/"
+    set :graphite_url, "http://user:password@example.com:8000/events/"
 
 Disable sending events for a particular stage by setting the following to 0.
 Note that the config `graphite_enable_events` has been deprecated in favor of
@@ -51,7 +46,7 @@ the config `suppress_graphite_events` below
 ### Test that it's working
 You can run the following on it's own assuming you have configured the graphite url
 
-    $ bundle exec cap <stage> deploy:graphite_deploy
+    $ bundle exec cap <stage> deploy:post_graphite['deploy']
 
 ## Contributing
 

data/Rakefile

@@ -1,5 +1,10 @@
-require "bundler/gem_tasks"
+# encoding: utf-8
+
+require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
-task :default => :spec
+task default: 'spec'
 RSpec::Core::RakeTask.new
+
+RuboCop::RakeTask.new

data/capistrano-graphite.gemspec

@@ -4,34 +4,36 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'capistrano/graphite/version'
 
 Gem::Specification.new do |s|
-  s.name          = "capistrano-graphite"
+  s.name          = 'capistrano-graphite'
   s.version       = Capistrano::Graphite::VERSION
-  s.authors       = ["scottsuch"]
-  s.email         = ["sgorsuch@gmail.com"]
-  s.summary       = %q{A gem for pushing graphite events via capistrano v3
-                       deployment}
-  s.description   = %q{This gem plugs into the deploy task in capistrano to
-                       help provide visibility into when deployments and
-                       rollbacks occured.}
-  s.homepage      = "https://github.com/scottsuch/capistrano-graphite"
-  s.license       = "MIT"
+  s.authors       = ['scottsuch']
+  s.email         = ['sgorsuch@gmail.com']
+  s.summary       = 'A gem for pushing graphite events via capistrano v3 ' \
+                    'deployment'
+  s.description   = 'This gem plugs into the deploy task in capistrano to ' \
+                    'help provide visibility into when deployments and ' \
+                    'rollbacks occured.'
+  s.homepage      = 'https://github.com/scottsuch/capistrano-graphite'
+  s.license       = 'MIT'
 
   s.required_ruby_version = '> 1.9'
 
-  s.post_install_message = "The config `graphite_enable_events` has changed " \
-                           "to `suppress_graphite_events` and will accept " \
-                           "a true or false. See the README.md at" \
-                           "https://github.com/scottsuch/capistrano-graphite " \
-                           "for details.}"\
+  s.post_install_message = 'The config `graphite_enable_events` has changed ' \
+                           'to `suppress_graphite_events` and will accept ' \
+                           'a true or false. See the README.md at ' \
+                           'https://github.com/scottsuch/capistrano-graphite ' \
+                           'for details.'\
 
   s.files         = `git ls-files -z`.split("\x0")
   s.executables   = s.files.grep(%r{^bin/}) { |f| File.basename(f) }
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})
-  s.require_paths = ["lib"]
+  s.require_paths = ['lib']
 
-  s.add_dependency             "capistrano", "~> 3.0"
-  s.add_development_dependency "bundler",    "~> 1.3"
-  s.add_development_dependency "rake"
-  s.add_development_dependency "rspec"
-  s.add_development_dependency "coveralls"
+  s.add_dependency 'capistrano', '~> 3.0'
+  s.add_development_dependency 'bundler', '~> 1.3'
+  s.add_development_dependency 'coveralls'
+  s.add_development_dependency 'rake'
+  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'rubocop'
+  s.add_development_dependency 'webmock'
 end

data/lib/capistrano/graphite/version.rb

@@ -1,5 +1,8 @@
+# encoding: utf-8
+
 module Capistrano
+  # This module holds the capistrano-graphite version information.
   module Graphite
-    VERSION = "1.0.0"
+    VERSION = '1.0.1'
   end
 end

data/lib/capistrano/graphite.rb

@@ -1,15 +1,21 @@
+# encoding: utf-8
+
 require 'capistrano'
 require 'net/http'
 require 'uri'
 require 'sshkit'
 require 'sshkit/dsl'
 
+# Build the request to post
 class GraphiteInterface
   def post_event(action)
-    uri = URI::parse("#{fetch(:graphite_url)}")
+    uri = URI.parse("#{fetch(:graphite_url)}")
     req = Net::HTTP::Post.new(uri.path)
     req.basic_auth(uri.user, uri.password) if uri.user
-    req.body = "{\"what\": \"#{action} #{fetch(:application)} in #{fetch(:stage)}\", \"tags\": \"#{fetch(:application)},#{fetch(:stage)},#{release_timestamp},#{action}\", \"data\": \"#{fetch(:local_user)}\"}"
+    req.body = "{\"what\": \"#{action} #{fetch(:application)} in " \
+               "#{fetch(:stage)}\", \"tags\": \"#{fetch(:application)}," \
+               "#{fetch(:stage)},#{release_timestamp},#{action}\", \"data\": " \
+               "\"#{fetch(:local_user)}\"}"
 
     Net::HTTP.start(uri.host, uri.port) do |http|
       http.request(req)
@@ -19,16 +25,16 @@ end
 
 namespace :deploy do
   desc 'Post an event to graphite'
-  task :post_graphite, :action do |t, args|
+  task :post_graphite, :action do |args|
     action = args[:action]
-    on roles(:all) do |host|
-      if fetch(:suppress_graphite_events).downcase == "true"
+    run_locally do
+      if fetch(:suppress_graphite_events).downcase == 'true'
         GraphiteInterface.new.post_event("#{action}")
         info("#{action.capitalize} event posted to graphite.")
-      elsif fetch(:suppress_graphite_events).downcase == "false"
-        info("No event posted: `suppress_graphite_events` set to true.")
+      elsif fetch(:suppress_graphite_events).downcase == 'false'
+        info('No event posted: `suppress_graphite_events` set to true.')
       else
-        warn("No event posted: `suppress_graphite_events` set incorrectly.")
+        warn('No event posted: `suppress_graphite_events` set incorrectly.')
       end
     end
   end
@@ -44,7 +50,7 @@ end
 
 namespace :load do
   task :defaults do
-    set :suppress_graphite_events, "false"
+    set :suppress_graphite_events, 'false'
     set :local_user, ENV['USER']
   end
 end

data/spec/grapite_spec.rb

@@ -0,0 +1,26 @@
+# encoding: utf-8
+
+# graphite_spec.rb
+require 'spec_helper'
+require 'capistrano/graphite.rb'
+
+RSpec.describe GraphiteInterface do
+  describe '#post_event' do
+    context 'deploy' do
+      it 'posts a deploy event to graphite' do
+        stub_request(:post, 'http://localhost/')
+          .with(body: "{\'what\': \'deploy testapp\', \'tags\': " \
+          "\'testapp,randomsha,deploy\', \'data\': \'testuser\'}")
+          .to_return(status: '200', body: '', headers: {})
+      end
+    end
+    context 'rollback' do
+      it 'posts a rollback event to graphite' do
+        stub_request(:post, 'http://localhost/')
+          .with(body: "{\'what\': \'rollback testapp\', \'tags\': " \
+          "\'testapp,randomsha,deploy\', \'data\': \'testuser\'}")
+          .to_return(status: '200', body: '', headers: {})
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,5 +1,8 @@
+# encoding: utf-8
+
 require 'rspec'
 require 'rake'
+require 'webmock/rspec'
 require 'capistrano/all'
 require 'capistrano/framework'
 require 'capistrano/setup'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capistrano-graphite
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - scottsuch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-15 00:00:00.000000000 Z
+date: 2014-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capistrano
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -67,7 +81,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -80,10 +108,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: |-
-  This gem plugs into the deploy task in capistrano to
-                         help provide visibility into when deployments and
-                         rollbacks occured.
+description: This gem plugs into the deploy task in capistrano to help provide visibility
+  into when deployments and rollbacks occured.
 email:
 - sgorsuch@gmail.com
 executables: []
@@ -92,7 +118,10 @@ extra_rdoc_files: []
 files:
 - ".coveralls.yml"
 - ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -100,14 +129,15 @@ files:
 - capistrano-graphite.gemspec
 - lib/capistrano/graphite.rb
 - lib/capistrano/graphite/version.rb
+- spec/grapite_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/scottsuch/capistrano-graphite
 licenses:
 - MIT
 metadata: {}
 post_install_message: The config `graphite_enable_events` has changed to `suppress_graphite_events`
-  and will accept a true or false. See the README.md athttps://github.com/scottsuch/capistrano-graphite
-  for details.}
+  and will accept a true or false. See the README.md at https://github.com/scottsuch/capistrano-graphite
+  for details.
 rdoc_options: []
 require_paths:
 - lib
@@ -123,10 +153,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.4
 signing_key: 
 specification_version: 4
 summary: A gem for pushing graphite events via capistrano v3 deployment
 test_files:
+- spec/grapite_spec.rb
 - spec/spec_helper.rb
-has_rdoc: