capistrano-asg-rolling 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7f6b6214ffbebb1d5c6866126ce143ca0ca1917be593c03a60b3e53bbc425294
-  data.tar.gz: 8098e48a08bbbd61e1945c5a420939118d2951ddfb250ea669b0f4d8d141ed10
+  metadata.gz: 140ff8c2812256ee7b0db1c2675052859dd933593d6f3766adf68e855c2297b5
+  data.tar.gz: 76ba60506093dac285def220cb11c8f114140c525d3c65644e5d6af983edaaaf
 SHA512:
-  metadata.gz: '08d8756a4754a72fb9e5e688f633a5cbc4f495d1db2abdb777548f05efddc25a0714d8d53cf13de66fa01691ec15fd99f8797997205018c7861ccf7939ebaa63'
-  data.tar.gz: d985258bb1de520e96a577a5fcbf1c77de176172aa674a381e5e729d661d4218b683d8fd21e9629f2a016fbf56cc1a803cd661381c569d0ac91b7a7b14af49ca
+  metadata.gz: 85c502bd99f24aea1dd05fc2a499dbc3aec81be2b951dd9be3c056d1527ba51bf0d605eca6b3ab40ece1f3a7d559f400cafb50ca5884567d214c665fd7e50057
+  data.tar.gz: bd945c98f2dc32c63e7fac3df0a82ea9ab7a75b2cc2caeab6b24d640bd7af9bfe79c1f6f863f467a42f14d7043f18775667706cae4631552d7199a45a55b6edc

data/.github/workflows/test.yml

@@ -1,13 +1,15 @@
 name: CI
 
-on: [push]
+on:
+  - push
+  - pull_request
 
 jobs:
   test:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.5', '2.6', '2.7', '3.0']
+        ruby-version: ['2.5', '2.6', '2.7', '3.0', '3.1']
 
     steps:
     - uses: actions/checkout@v2

data/Gemfile

@@ -7,7 +7,7 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 # Specify your gem's dependencies in capistrano-asg-rolling.gemspec
 gemspec
 
-gem 'rubocop', '~> 1.22.1'
-gem 'rubocop-performance', '~> 1.11.5'
+gem 'rubocop', '~> 1.26.1'
+gem 'rubocop-performance', '~> 1.13.3'
 gem 'rubocop-rake', '~> 0.6.0'
-gem 'rubocop-rspec', '~> 2.5.0'
+gem 'rubocop-rspec', '~> 2.9.0'

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    capistrano-asg-rolling (0.1.0)
-      aws-sdk-autoscaling (~> 1, >= 1.39)
+    capistrano-asg-rolling (0.2.0)
+      aws-sdk-autoscaling (~> 1, >= 1.67.0)
       aws-sdk-ec2 (~> 1)
       capistrano (~> 3)
       concurrent-ruby (~> 1)
@@ -16,74 +16,74 @@ GEM
       sshkit (>= 1.6.1, != 1.7.0)
     ast (2.4.2)
     aws-eventstream (1.2.0)
-    aws-partitions (1.516.0)
-    aws-sdk-autoscaling (1.69.0)
-      aws-sdk-core (~> 3, >= 3.120.0)
+    aws-partitions (1.570.0)
+    aws-sdk-autoscaling (1.78.0)
+      aws-sdk-core (~> 3, >= 3.127.0)
       aws-sigv4 (~> 1.1)
-    aws-sdk-core (3.121.1)
+    aws-sdk-core (3.130.0)
       aws-eventstream (~> 1, >= 1.0.2)
-      aws-partitions (~> 1, >= 1.239.0)
+      aws-partitions (~> 1, >= 1.525.0)
       aws-sigv4 (~> 1.1)
       jmespath (~> 1.0)
-    aws-sdk-ec2 (1.270.0)
-      aws-sdk-core (~> 3, >= 3.120.0)
+    aws-sdk-ec2 (1.303.0)
+      aws-sdk-core (~> 3, >= 3.127.0)
       aws-sigv4 (~> 1.1)
     aws-sigv4 (1.4.0)
       aws-eventstream (~> 1, >= 1.0.2)
-    capistrano (3.16.0)
+    capistrano (3.17.0)
       airbrussh (>= 1.0.0)
       i18n
       rake (>= 10.0.0)
       sshkit (>= 1.9.0)
-    concurrent-ruby (1.1.9)
+    concurrent-ruby (1.1.10)
     crack (0.4.5)
       rexml
-    diff-lcs (1.4.4)
+    diff-lcs (1.5.0)
     hashdiff (1.0.1)
-    i18n (1.8.10)
+    i18n (1.10.0)
       concurrent-ruby (~> 1.0)
-    jmespath (1.4.0)
+    jmespath (1.6.1)
     net-scp (3.0.0)
       net-ssh (>= 2.6.5, < 7.0.0)
     net-ssh (6.1.0)
-    parallel (1.21.0)
-    parser (3.0.2.0)
+    parallel (1.22.0)
+    parser (3.1.1.0)
       ast (~> 2.4.1)
     public_suffix (4.0.6)
-    rainbow (3.0.0)
+    rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.1.1)
+    regexp_parser (2.2.1)
     rexml (3.2.5)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
       rspec-expectations (~> 3.10.0)
       rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
+    rspec-core (3.10.2)
       rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
+    rspec-expectations (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.2)
+    rspec-mocks (3.10.3)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
-    rubocop (1.22.1)
+    rspec-support (3.10.3)
+    rubocop (1.26.1)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.12.0, < 2.0)
+      rubocop-ast (>= 1.16.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.12.0)
-      parser (>= 3.0.1.1)
-    rubocop-performance (1.11.5)
+    rubocop-ast (1.16.0)
+      parser (>= 3.1.1.0)
+    rubocop-performance (1.13.3)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.5.0)
+    rubocop-rspec (2.9.0)
       rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
     sshkit (1.21.2)
@@ -99,15 +99,15 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 1.17)
+  bundler (~> 2.0)
   capistrano-asg-rolling!
   rake (~> 13.0)
   rspec (~> 3.0)
-  rubocop (~> 1.22.1)
-  rubocop-performance (~> 1.11.5)
+  rubocop (~> 1.26.1)
+  rubocop-performance (~> 1.13.3)
   rubocop-rake (~> 0.6.0)
-  rubocop-rspec (~> 2.5.0)
+  rubocop-rspec (~> 2.9.0)
   webmock (~> 3.11)
 
 BUNDLED WITH
-   1.17.3
+   2.3.7

data/README.md

@@ -11,8 +11,8 @@ Instead of deploying to live servers, capistrano-asg-rolling will create a tempo
 - Launch an instance from the AMI defined in the Launch Template of the Auto Scaling Group(s).
 - Deploy your application to the launched instances.
 - After deployment, stop the instances and create an AMI for each instance.
-- Create new Launch Template versions with the new AMIs.
-- Trigger Instance Refresh on the Auto Scaling Group(s) to perform an rolling update.
+- Create new Launch Template versions for the new AMIs.
+- Trigger Instance Refresh on the Auto Scaling Group(s) to perform a rolling update.
 - Delete any outdated Launch Template versions, AMIs and snapshots created by previous deployments.
 - Terminate the no longer needed instances.
 
@@ -26,7 +26,7 @@ Please be aware of the limitations of using instance refresh, in particular "Ins
 
 This gem depends on Auto Scaling Groups with Launch Templates. Using an Auto Scaling Group with a Launch Configuration is not supported, and will raise an `Capistrano::ASG::Rolling::NoLaunchTemplate`.
 
-Make sure you have configured the Auto Scaling Groups with the Launch Template version set to `Latest` so instance refresh will work.
+Instance refresh uses the desired configuration to update the Launch Template version of the Auto Scaling Group after a succesful deployment. Setting the Launch Template version to `Latest` on the Auto Scaling Group is not needed.
 
 #### Experimental
 
@@ -36,14 +36,6 @@ The configuration options are not considered stable and might be changed or remo
 
 The gem could have a better / fancier name.
 
-#### Bugs
-
-Currently all Launch Template versions and AMIs will be deleted, also when not created by this gem.
-
-When an Instance refresh is already in progress, the deployment will fail with an `Aws::AutoScaling::Errors::InstanceRefreshInProgress`.
-
-Documentation is incomplete.
-
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -123,7 +115,7 @@ Now start a deployment with `cap <stage> deploy` and enjoy.
 
 ### Deploy without rolling update
 
-There might be cases where you just want to deploy your code to the servers in the Auto Scaling Group(s) without a rolling update. 
+There might be cases where you just want to deploy your code to the servers in the Auto Scaling Group(s) without a rolling update.
 
 You can configure rolling updates per autoscaling group by using the `rolling` option:
 

data/capistrano-asg-rolling.gemspec

@@ -14,6 +14,8 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/KentaaNL/capistrano-asg-rolling'
   spec.license       = 'MIT'
 
+  spec.metadata      = { 'rubygems_mfa_required' => 'true' }
+
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files         = Dir.chdir(File.expand_path(__dir__)) do
@@ -26,12 +28,12 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.5.0'
 
-  spec.add_development_dependency 'bundler', '~> 1.17'
+  spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'webmock', '~> 3.11'
 
-  spec.add_dependency 'aws-sdk-autoscaling', '~> 1', '>= 1.39'
+  spec.add_dependency 'aws-sdk-autoscaling', '~> 1', '>= 1.67.0'
   spec.add_dependency 'aws-sdk-ec2', '~> 1'
   spec.add_dependency 'capistrano', '~> 3'
   spec.add_dependency 'concurrent-ruby', '~> 1'

data/lib/capistrano/asg/rolling/ami.rb

@@ -25,12 +25,12 @@ module Capistrano
           }
 
           if tags
-            options[:tag_specifications] = tags.flat_map do |key, value|
-              [
-                { resource_type: 'image', tags: [{ key: key, value: value }] },
-                { resource_type: 'snapshot', tags: [{ key: key, value: value }] }
-              ]
-            end
+            tag_specifications = tags.map { |key, value| { key: key, value: value } }
+
+            options[:tag_specifications] = [
+              { resource_type: 'image', tags: tag_specifications },
+              { resource_type: 'snapshot', tags: tag_specifications }
+            ]
           end
 
           response = aws_ec2_client.create_image(options)
@@ -65,6 +65,24 @@ module Capistrano
           end
         end
 
+        def tags
+          @tags ||= aws_ec2_image.tags.map { |tag| [tag.key, tag.value] }.to_h
+        end
+
+        def tag?(key)
+          tags.key?(key)
+        end
+
+        def ==(other)
+          id == other.id
+        end
+
+        alias eql? ==
+
+        def hash
+          id.hash
+        end
+
         private
 
         def aws_ec2_image

data/lib/capistrano/asg/rolling/autoscale_group.rb

@@ -28,7 +28,7 @@ module Capistrano
             template = aws_autoscaling_group.launch_template
             raise Capistrano::ASG::Rolling::NoLaunchTemplate if template.nil?
 
-            LaunchTemplate.new(template.launch_template_id, template.version)
+            LaunchTemplate.new(template.launch_template_id, template.version, template.launch_template_name)
           end
         end
 
@@ -40,15 +40,24 @@ module Capistrano
           aws_autoscaling_group.health_check_grace_period
         end
 
-        def start_instance_refresh
+        def start_instance_refresh(launch_template)
           aws_autoscaling_client.start_instance_refresh(
             auto_scaling_group_name: name,
             strategy: 'Rolling',
+            desired_configuration: {
+              launch_template: {
+                launch_template_id: launch_template.id,
+                version: launch_template.version
+              }
+            },
             preferences: {
               instance_warmup: instance_warmup_time,
-              min_healthy_percentage: 100
+              min_healthy_percentage: 100,
+              skip_matching: true
             }
           )
+        rescue Aws::AutoScaling::Errors::InstanceRefreshInProgress => e
+          raise Capistrano::ASG::Rolling::InstanceRefreshFailed, e
         end
 
         # Returns instances with lifecycle state "InService" for this Auto Scaling Group.

data/lib/capistrano/asg/rolling/autoscale_groups.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'set'
-
 module Capistrano
   module ASG
     module Rolling
@@ -21,27 +19,13 @@ module Capistrano
           @groups.reject { |group| filtered?(group) }.each(&block)
         end
 
-        def with_launch_template(launch_template)
-          self.class.new(select { |group| group.launch_template == launch_template })
-        end
-
-        def update_launch_templates(amis:, description: nil)
-          launch_templates = Set.new
-
-          amis.each do |ami|
-            old_image_id = ami.instance.image_id
-            new_image_id = ami.id
-
-            find_launch_templates_for(image_id: old_image_id).each do |launch_template|
-              launch_templates << launch_template.create_version(image_id: new_image_id, description: description)
-            end
-          end
-
-          launch_templates
+        def launch_templates
+          templates = @groups.map(&:launch_template)
+          LaunchTemplates.new(templates)
         end
 
-        def start_instance_refresh
-          each(&:start_instance_refresh)
+        def with_launch_template(launch_template)
+          self.class.new(select { |group| group.launch_template == launch_template })
         end
 
         private
@@ -51,19 +35,6 @@ module Capistrano
 
           Configuration.auto_scaling_group_name != group.name
         end
-
-        def find_launch_templates_for(image_id:)
-          launch_templates = Set.new
-
-          each do |group|
-            launch_template = group.launch_template
-            next if launch_template.image_id != image_id
-
-            launch_templates << launch_template
-          end
-
-          launch_templates
-        end
       end
     end
   end

data/lib/capistrano/asg/rolling/aws.rb

@@ -27,7 +27,7 @@ module Capistrano
         end
 
         def aws_credentials
-          ::Aws::Credentials.new(aws_access_key_id, aws_secret_access_key)
+          ::Aws::Credentials.new(aws_access_key_id, aws_secret_access_key, aws_session_token)
         end
 
         def aws_access_key_id
@@ -38,6 +38,10 @@ module Capistrano
           Configuration.aws_secret_access_key
         end
 
+        def aws_session_token
+          Configuration.aws_session_token
+        end
+
         def aws_region
           Configuration.aws_region
         end

data/lib/capistrano/asg/rolling/configuration.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'set'
-
 module Capistrano
   module ASG
     module Rolling
@@ -23,7 +21,7 @@ module Capistrano
 
         # Updated Launch Templates.
         def launch_templates
-          @launch_templates ||= Set.new
+          @launch_templates ||= LaunchTemplates.new
         end
 
         def aws_access_key_id
@@ -34,6 +32,10 @@ module Capistrano
           fetch(:aws_secret_access_key)
         end
 
+        def aws_session_token
+          fetch(:aws_session_token)
+        end
+
         def aws_region
           fetch(:aws_region)
         end

data/lib/capistrano/asg/rolling/exception.rb

@@ -12,6 +12,9 @@ module Capistrano
 
       class NoLaunchTemplate < Capistrano::ASG::Rolling::Exception
       end
+
+      class InstanceRefreshFailed < Capistrano::ASG::Rolling::Exception
+      end
     end
   end
 end

data/lib/capistrano/asg/rolling/instance.rb

@@ -46,9 +46,12 @@ module Capistrano
           # Optionally override settings in the Launch Template.
           options.merge!(overrides) if overrides
 
+          resource_tags = [
+            { key: 'Name', value: autoscaling_group.name_tag }
+          ]
           options[:tag_specifications] = [
-            { resource_type: 'instance', tags: [{ key: 'Name', value: autoscaling_group.name_tag }] },
-            { resource_type: 'volume', tags: [{ key: 'Name', value: autoscaling_group.name_tag }] }
+            { resource_type: 'instance', tags: resource_tags },
+            { resource_type: 'volume', tags: resource_tags }
           ]
 
           response = aws_ec2_client.run_instances(options)
@@ -90,11 +93,20 @@ module Capistrano
           @terminated = true
         end
 
-        def create_ami(name: nil, description: nil)
-          now = Time.now
-          name ||= "#{autoscale_group.name_tag} on #{now.strftime('%Y-%m-%d')} at #{now.strftime('%H.%M.%S')}"
+        def create_ami(name: nil, description: nil, tags: nil)
+          ami_tags = {
+            'Name' => autoscale_group.name_tag,
+            'capistrano-asg-rolling:version' => Capistrano::ASG::Rolling::VERSION
+          }
+          ami_tags.merge!(tags) if tags
+
+          AMI.create(instance: self, name: name || ami_name, description: description, tags: ami_tags)
+        end
+
+        private
 
-          AMI.create(instance: self, name: name, description: description, tags: { 'Name' => autoscale_group.name_tag })
+        def ami_name
+          "#{autoscale_group.name_tag} on #{Time.now.strftime('%Y-%m-%d at %H.%M.%S')}"
         end
       end
     end

data/lib/capistrano/asg/rolling/instances.rb

@@ -43,9 +43,9 @@ module Capistrano
           Parallel.run(instances, &:terminate)
         end
 
-        def create_ami(name: nil, description: nil)
+        def create_ami(name: nil, description: nil, tags: nil)
           Parallel.run(instances) do |instance|
-            instance.create_ami(name: name, description: description)
+            instance.create_ami(name: name, description: description, tags: tags)
           end
         end
 

data/lib/capistrano/asg/rolling/launch_template.rb

@@ -7,12 +7,13 @@ module Capistrano
       class LaunchTemplate
         include AWS
 
-        attr_reader :id, :version, :default_version
+        attr_reader :id, :version, :name, :default_version
         alias default_version? default_version
 
-        def initialize(id, version, default_version: false)
+        def initialize(id, version, name, default_version: false)
           @id = id
           @version = version.to_s
+          @name = name
           @default_version = default_version
         end
 
@@ -25,7 +26,7 @@ module Capistrano
           )
           version = response.launch_template_version
 
-          self.class.new(version.launch_template_id, version.version_number, default_version: version.default_version)
+          self.class.new(version.launch_template_id, version.version_number, version.launch_template_name, default_version: version.default_version)
         end
 
         def delete
@@ -44,7 +45,7 @@ module Capistrano
                         .launch_template_versions
                         .sort_by { |v| -v.version_number }
                         .select { |v| v.version_number < version_number }
-                        .map { |v| self.class.new(v.launch_template_id, v.version_number, default_version: v.default_version) }
+                        .map { |v| self.class.new(v.launch_template_id, v.version_number, v.launch_template_name, default_version: v.default_version) }
         end
 
         def version_number

data/lib/capistrano/asg/rolling/launch_templates.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+require 'set'
+
+module Capistrano
+  module ASG
+    module Rolling
+      # Collection of Launch Templates.
+      class LaunchTemplates
+        include Enumerable
+
+        def initialize(templates = [])
+          @templates = Set.new(templates)
+        end
+
+        def <<(template)
+          @templates << template
+        end
+
+        def merge(templates)
+          @templates.merge(templates)
+        end
+
+        def each(&block)
+          @templates.each(&block)
+        end
+
+        def empty?
+          @templates.empty?
+        end
+
+        def update(amis:, description: nil)
+          updated_templates = []
+
+          amis.each do |ami|
+            old_image_id = ami.instance.image_id
+            new_image_id = ami.id
+
+            with_image(old_image_id).each do |template|
+              updated_templates << template.create_version(image_id: new_image_id, description: description)
+            end
+          end
+
+          self.class.new(updated_templates)
+        end
+
+        private
+
+        def with_image(image_id)
+          self.class.new(select { |template| template.image_id == image_id })
+        end
+      end
+    end
+  end
+end

data/lib/capistrano/asg/rolling/logger.rb

@@ -14,25 +14,26 @@ module Capistrano
         end
 
         def error(text)
-          $stderr.puts color(format_text(text), :red) # rubocop:disable Style/StderrPuts
+          $stderr.puts format_text(text, color: :red) # rubocop:disable Style/StderrPuts
         end
 
         def verbose(text)
           info(text) if @verbose
         end
 
-        def bold(text, color = :light_white)
-          color(text, color, :bold)
-        end
+        private
 
-        def color(text, color, mode = nil)
-          _color.colorize(text, color, mode)
+        def format_text(text, color: nil)
+          text = colorize_text(text, color) if color
+          text.gsub(/\*\*(.+?)\*\*/, bold_text('\\1'))
         end
 
-        private
+        def bold_text(text)
+          "\e[1m#{text}\e[22m"
+        end
 
-        def format_text(text)
-          text.gsub(/\*\*(.+?)\*\*/, bold('\\1'))
+        def colorize_text(text, color)
+          _color.colorize(text, color)
         end
 
         def _color

data/lib/capistrano/asg/rolling/plugin.rb

@@ -12,10 +12,6 @@ module Capistrano
       #
       class Plugin < Capistrano::Plugin
         def set_defaults
-          set_if_empty :aws_access_key_id, ENV['AWS_ACCESS_KEY_ID']
-          set_if_empty :aws_secret_access_key, ENV['AWS_SECRET_ACCESS_KEY']
-          set_if_empty :aws_region, ENV['AWS_REGION']
-
           set_if_empty :asg_rolling_group_name, ENV['asg_name']
           set_if_empty :asg_rolling_use_private_ip_address, true
           set_if_empty :asg_rolling_verbose, true

data/lib/capistrano/asg/rolling/version.rb

@@ -3,7 +3,7 @@
 module Capistrano
   module ASG
     module Rolling
-      VERSION = '0.1.0'
+      VERSION = '0.2.0'
     end
   end
 end

data/lib/capistrano/asg/rolling.rb

@@ -12,6 +12,7 @@ require 'capistrano/asg/rolling/exception'
 require 'capistrano/asg/rolling/instance'
 require 'capistrano/asg/rolling/instances'
 require 'capistrano/asg/rolling/launch_template'
+require 'capistrano/asg/rolling/launch_templates'
 require 'capistrano/asg/rolling/logger'
 require 'capistrano/asg/rolling/parallel'
 require 'capistrano/asg/rolling/plugin'

data/lib/capistrano/asg/tasks/rolling.rake

@@ -53,35 +53,55 @@ namespace :rolling do
       amis = config.instances.create_ami(description: revision_log_message)
 
       logger.info 'Updating Launch Template(s) with the new AMI(s)...'
-      launch_templates = config.autoscale_groups.update_launch_templates(amis: amis, description: revision_log_message)
+      launch_templates = config.autoscale_groups.launch_templates
+      updated_templates = launch_templates.update(amis: amis, description: revision_log_message)
 
       logger.info 'Triggering Instance Refresh on Auto Scaling Group(s)...'
-      launch_templates.each do |launch_template|
-        config.autoscale_groups.with_launch_template(launch_template).start_instance_refresh
+      updated_templates.each do |launch_template|
+        config.autoscale_groups.with_launch_template(launch_template).each do |group|
+          group.start_instance_refresh(launch_template)
+
+          logger.verbose "Successfully started Instance Refresh on Auto Scaling Group **#{group.name}**."
+        rescue Capistrano::ASG::Rolling::InstanceRefreshFailed => e
+          logger.info "Failed to start Instance Refresh on Auto Scaling Group **#{group.name}**: #{e.message}"
+        end
       end
 
-      config.launch_templates.merge(launch_templates)
+      config.launch_templates.merge(updated_templates)
     end
   end
 
   desc 'Clean up old Launch Template versions and AMIs and terminate instances'
   task :cleanup do
     unless config.launch_templates.empty?
+      # Keep track of deleted AMIs, so we can clean up Launch Templates that use the same AMI.
+      deleted_amis = []
+
       logger.info 'Cleaning up old Launch Template version(s) and AMI(s)...'
       config.launch_templates.each do |launch_template|
-        launch_template.previous_versions.drop(config.keep_versions).each do |version|
-          next if version.default_version?
-
+        launch_template.previous_versions.reject(&:default_version?).drop(config.keep_versions).each do |version|
           # Need to retrieve AMI before deleting the Launch Template version.
           ami = version.ami
+          exists = ami.exists?
+          deleted = deleted_amis.include?(ami)
+
+          if !exists && !deleted
+            logger.info("WARNING: AMI **#{ami.id}** does not exist for Launch Template **#{version.name}** version **#{version.version}**.")
+            next
+          end
+
+          # Only clean up when AMI was tagged by us.
+          next if exists && !ami.tag?('capistrano-asg-rolling:version')
 
-          logger.verbose "Deleting Launch Template version **#{version.version}**..."
+          logger.verbose "Deleting Launch Template **#{version.name}** version **#{version.version}**..."
           version.delete
 
-          if ami.exists?
-            logger.verbose "Deleting AMI **#{version.ami.id}** and snapshots..."
-            ami.delete
-          end
+          next if deleted
+
+          logger.verbose "Deleting AMI **#{ami.id}** and snapshots..."
+          ami.delete
+
+          deleted_amis << ami
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capistrano-asg-rolling
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Kentaa
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-10-15 00:00:00.000000000 Z
+date: 2022-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -75,7 +75,7 @@ dependencies:
         version: '1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.39'
+        version: 1.67.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -85,7 +85,7 @@ dependencies:
         version: '1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.39'
+        version: 1.67.0
 - !ruby/object:Gem::Dependency
   name: aws-sdk-ec2
   requirement: !ruby/object:Gem::Requirement
@@ -159,6 +159,7 @@ files:
 - lib/capistrano/asg/rolling/instance.rb
 - lib/capistrano/asg/rolling/instances.rb
 - lib/capistrano/asg/rolling/launch_template.rb
+- lib/capistrano/asg/rolling/launch_templates.rb
 - lib/capistrano/asg/rolling/logger.rb
 - lib/capistrano/asg/rolling/parallel.rb
 - lib/capistrano/asg/rolling/plugin.rb
@@ -169,7 +170,8 @@ files:
 homepage: https://github.com/KentaaNL/capistrano-asg-rolling
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -185,7 +187,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.9
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Capistrano plugin for performing rolling updates to AWS Auto Scaling Groups