canvas_sync 0.22.0.beta1 → 0.22.0.beta3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cfdaa60184f19d01fd1609144d0b3bf07d4cb0c1f186f4057951a0be52830baa
-  data.tar.gz: 96a9be57f09b9eedaaf03ad1b6470a77f3ff23b6d5368ef728e1185eb649a9fa
+  metadata.gz: cb3c747b85ec69477a5694b82dfd6841056b315a86322dded93f2fbb5b3aa13c
+  data.tar.gz: e01aa76838d8391e5289183303623349b6258b4265b3dda6b8bfb4b14cde42ca
 SHA512:
-  metadata.gz: b10a559f1afbe287584d82e4a345c2929372327ba719d930f751a0bd03a365e170f11b117cf063eb8d0c816e98a9a8dc2d0bb4271628a9d697511bd062c8011a
-  data.tar.gz: b3a9ef0cbc3234852b4f2a5e6afbb909e2cbc0b184e330f665dda6d1ee8c165fe2f07fc555f0f6e49d65d219da8745ef816eadf1bde4bedf4131c93f2d7a8fb3
+  metadata.gz: 68f8c77089b5fd7784af2d22dbe836c529fc862688fa8c6f42dd3004312ec518d886458c3ca4b28cac08c8d9c823b55893f11a37a05de3eab872fc7a3529bf04
+  data.tar.gz: 286dd6f0693b320afe381728fbb45de6964fea94d84d0258dffbc608f528684a347831249c13e0f4b3c97ebeb3fa790f4c193fdf096b4532300d3b8158654abe

data/lib/canvas_sync/job_uniqueness/compat/active_job.rb

@@ -11,7 +11,7 @@ module CanvasSync::JobUniqueness
         def reenqueue(schedule_in:)
           job_class.set(
             queue: job_queue.to_sym,
-            set: schedule_in,
+            wait: schedule_in,
             priortity: job_instance.priority,
           ).perform_later(*job_instance.arguments)
         end

data/lib/canvas_sync/job_uniqueness/on_conflict/reschedule.rb

@@ -13,7 +13,7 @@ module CanvasSync::JobUniqueness
       end
 
       def schedule_in
-        lock_context.config[:reschedule_in] || 5
+        lock_context.config[:reschedule_in] || 60
       end
     end
   end

data/lib/canvas_sync/job_uniqueness/on_conflict.rb

@@ -8,9 +8,30 @@ module CanvasSync::JobUniqueness
     autoload :NullStrategy
     autoload :Raise
     autoload :Reject
-    # autoload :Replace
     autoload :Reschedule
 
+    # Replace is... hard. It involves hacking into some of the inner workings of Sidekiq and/or ActiveJob.
+    # The best solution would be to somehow mark the previously-scheduled job as dead and let it be picked up by workers but not invoke
+    #   its perform method (technically this would mess with success numbers, but does anybody really care about those?).
+    # Replace will also conflict with the UntilExecuted strategy as it wouldn't be able to replace a job that has begun executing.
+    #
+    # Replace is useful for two cases:
+    #   1. Moving the job to the back of the queue, eg for debouncing purposes
+    #   2. Replacing non-hashed params with updated values
+    # A solution to (2) would be to store the latest params outside of the Job params - eg in the DB or in Redis directly.
+    # (1) is solvebale in a similar out-of-band way, but other, better solutions may exist as well
+    #
+    # If the param in question is a (eg) a list that you want to append to, you could:
+    #   Push to the list in Redis
+    #   Queue the job
+    #   (Push another param to the list in Redis)
+    #   (Re-enqueue the job, but it won't enqueue because it is locked)
+    #   When the job begins, it pulls all values from the field in Redis an processes
+    #   Adding more params from this point would allow another job to enqueue
+    #
+    # We may implement some tooling for this at some point, but for now the recommendation is to handle this yourself,
+    # autoload :Replace
+
     class << self
       def lookup(strategy)
         matching_strategy(strategy.to_s.camelize) ||

data/lib/canvas_sync/job_uniqueness/unique_job_common.rb

@@ -10,7 +10,7 @@ module CanvasSync::JobUniqueness
     class_methods do
       # ensure_uniqueness(
       #   strategy: :until_executed, # :until_executed, :until_executing, :until_expired, :until_and_while_executing, :while_executing
-      #   on_conflict: :raise, # :raise, :replace, :log, :reject, :reschedule, { enqueue: ..., perform: ... }, proc
+      #   on_conflict: :raise, # :raise, :log, :reject, :reschedule, { enqueue: ..., perform: ... }, proc
       #   lock_ttl: 7.days, # seconds
       #   lock_timeout: 0, # seconds
 
@@ -32,7 +32,7 @@ module CanvasSync::JobUniqueness
         begin
           require "sidekiq_unique_jobs"
         rescue LoadError
-          raise LoadError, "SidekiqUniqueJobs is required for ensure_uniqueness"
+          raise LoadError, "sidekiq-unique-jobs is required for ensure_uniqueness"
         end
 
         OnConflict.validate!(kwargs[:on_conflict], kwargs[:strategy]) if kwargs[:on_conflict].present?

data/lib/canvas_sync/version.rb

@@ -1,3 +1,3 @@
 module CanvasSync
-  VERSION = "0.22.0.beta1".freeze
+  VERSION = "0.22.0.beta3".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: canvas_sync
 version: !ruby/object:Gem::Version
-  version: 0.22.0.beta1
+  version: 0.22.0.beta3
 platform: ruby
 authors:
 - Instructure CustomDev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-07-24 00:00:00.000000000 Z
+date: 2024-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails