canvas_sync 0.19.0.beta8 → 0.19.0.beta9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 016fb182ae3234080415fdcd2283d6d05b40cc77c5ed36cfb3345c42b17d39b3
-  data.tar.gz: 3d485ca044b6f377aee719156206e6ca6a59ce2ff489c9b4d84ba713c7500ca8
+  metadata.gz: f1552d94643db48ef054d304102ffe1afcad0a7d149ace187a5b10f0d9e35c8b
+  data.tar.gz: e9d91a46ade6380bbd48a4c51dd540a8df65de64228107c400f4567ec13e64d0
 SHA512:
-  metadata.gz: 5bff1ac3d68f5b01aed96f19cc66d61af8d23db671b14bc354397b8217fc30a103a63aa7c200771b15b756a784423ab2f92eeac598a1939938ced433a7eb11af
-  data.tar.gz: 5b38641379b39c8d3f85b01d6e06c1771a6ceb85e13d8878baa4b0ab1ae3a3f7e091776a5e77245b516f85c49f9c7c5cd56b4f570d936eb1bc3aae38b28b3055
+  metadata.gz: 9904cb4fab07d92c2c0bbc64b308197b28a4652064e1d6992955f393f2b8a55e9f7f22b01dbb02f6de94df97f1743a52eb2d08c9a8e55a60e8606f234dc6c7d7
+  data.tar.gz: f80dfe46eb813956444932d943fd3236cd384205b359f42138553dd92441bc887c959b392d848e056f23d59a957d52394e93b5a2c63092fae225778d46118ecd

data/lib/canvas_sync/job_batches/pool.rb

@@ -90,7 +90,7 @@ module CanvasSync
 
         activec, pactivec, pendingc, clean_when_empty, keep_open = redis.multi do |r|
           r.hlen("#{redis_key}-active")
-          r.hincrby(redis_key, "_active_count", 0)
+          r.hget(redis_key, "_active_count")
           pending_count(r)
           r.hget(redis_key, 'clean_when_empty')
           r.hget(redis_key, 'keep_open')
@@ -98,7 +98,7 @@ module CanvasSync
 
         return if keep_open == 'true' || clean_when_empty == 'false'
 
-        if activec <= 0 && pactivec <= 0 && pendingc <= 0
+        if activec <= 0 && (pactivec.try(:to_i) || 0) <= 0 && pendingc <= 0
           cleanup_redis
         end
       end
@@ -125,9 +125,7 @@ module CanvasSync
       end
 
       def job_checked_in(status, options)
-        redis.hdel("#{redis_key}-active", status.bid)
-        redis.hincrby(redis_key, "complete_count", 1)
-        active_count = refill_allotment
+        active_count = refill_allotment(status.bid)
         cleanup_if_empty unless active_count > 0
       end
 
@@ -150,8 +148,8 @@ module CanvasSync
         "POOLID-#{pid}"
       end
 
-      def refill_allotment
-        active_count, job_descs = POOL_REFILL.call(redis, [redis_key, "#{redis_key}-jobs", "#{redis_key}-active"], [])
+      def refill_allotment(checkin_bid = nil)
+        active_count, job_descs = POOL_REFILL.call(redis, [redis_key, "#{redis_key}-jobs", "#{redis_key}-active"], [checkin_bid || ""])
         return active_count if active_count < 0
 
         pending_job_descs = job_descs.dup
@@ -220,27 +218,6 @@ module CanvasSync
         end
       end
 
-      # @deprecated
-      def pop_job_from_pool
-        jobs_key = "#{redis_key}-jobs"
-        order = self.order || 'fifo'
-
-        job_json = case order.to_sym
-        when :fifo
-          redis.lpop(jobs_key)
-        when :lifo
-          redis.rpop(jobs_key)
-        when :random
-          redis.spop(jobs_key)
-        when :priority
-          redis.zpopmax(jobs_key)&.[](0)
-        end
-
-        return nil unless job_json.present?
-
-        ::ActiveJob::Arguments.deserialize(JSON.parse(job_json))[0]&.symbolize_keys
-      end
-
       def self.redis(&blk)
         Batch.redis &blk
       end

data/lib/canvas_sync/job_batches/pool_refill.lua

@@ -3,10 +3,17 @@ local poolkey = KEYS[1]
 local qkey = KEYS[2]
 local activekey = KEYS[3]
 
+local checkin_item = ARGV[1]
+
 if redis.call('EXISTS', poolkey) == 0 then
     return { -1, {} } -- pool doesn't exist
 end
 
+if checkin_item ~= "" then
+    redis.call("HDEL", activekey, checkin_item)
+    redis.call("HINCRBY", poolkey, "complete_count", 1)
+end
+
 local pool_type = redis.call('HGET', poolkey, "order")
 local allotment = tonumber(redis.call("HGET", poolkey, "concurrency"))
 local active = redis.call("HLEN", activekey) + (redis.call("HGET", poolkey, "_active_count") or 0)

data/lib/canvas_sync/version.rb

@@ -1,3 +1,3 @@
 module CanvasSync
-  VERSION = "0.19.0.beta8".freeze
+  VERSION = "0.19.0.beta9".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: canvas_sync
 version: !ruby/object:Gem::Version
-  version: 0.19.0.beta8
+  version: 0.19.0.beta9
 platform: ruby
 authors:
 - Instructure CustomDev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-03-07 00:00:00.000000000 Z
+date: 2024-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails