canvas_sync 0.17.5 → 0.17.8.beta1

data/spec/job_batching/batch_spec.rb

@@ -227,6 +227,34 @@ RSpec.describe CanvasSync::JobBatches::Batch do
         end
       end
 
+      it 'delays triggering callbacks if keep_open is set' do
+        ActiveJob::Base.queue_adapter = :sidekiq
+        CanvasSync::JobBatches::Batch::Callback.worker_class = CanvasSync::JobBatches::Sidekiq::SidekiqCallbackWorker
+
+        callback_instance = double('SampleCallback')
+        expect(SampleCallback).to receive(:new).at_least(1).times.and_return(callback_instance)
+        expect(callback_instance).not_to receive(:on_complete)
+        expect(callback_instance).not_to receive(:on_success)
+
+        batch.on(:complete, SampleCallback)
+        batch.on(:success, SampleCallback)
+        batch.keep_open!
+
+        Sidekiq::Testing.inline! do
+          CanvasSync::JobBatches::Batch.process_failed_job(bid, jid)
+          CanvasSync::JobBatches::Batch.process_successful_job(bid, jid)
+        end
+
+        RSpec::Mocks.space.proxy_for(callback_instance).reset
+
+        expect(callback_instance).to receive(:on_complete)
+        expect(callback_instance).to receive(:on_success)
+
+        Sidekiq::Testing.inline! do
+          batch.let_close!
+        end
+      end
+
       it 'triggers callbacks as expected' do
         ActiveJob::Base.queue_adapter = :sidekiq
         CanvasSync::JobBatches::Batch.redis { |r| r.hset("BID-#{bid}", 'pending', 0) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: canvas_sync
 version: !ruby/object:Gem::Version
-  version: 0.17.5
+  version: 0.17.8.beta1
 platform: ruby
 authors:
 - Nate Collings
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-02 00:00:00.000000000 Z
+date: 2021-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -421,6 +421,7 @@ files:
 - lib/canvas_sync/job_batches/pool.rb
 - lib/canvas_sync/job_batches/redis_model.rb
 - lib/canvas_sync/job_batches/redis_script.rb
+- lib/canvas_sync/job_batches/schedule_callback.lua
 - lib/canvas_sync/job_batches/sidekiq.rb
 - lib/canvas_sync/job_batches/sidekiq/web.rb
 - lib/canvas_sync/job_batches/sidekiq/web/helpers.rb
@@ -644,9 +645,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
 signing_key: