canvas_statsd 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f4d82332ae38bf5817fccb8a0bc7558427e9bc1c
-  data.tar.gz: b007d80588d91577b3997008fe236386e86551c5
+  metadata.gz: 20b65aeab0a367d302645a5fa07c71e7872cb01c
+  data.tar.gz: 5462c8e69bb13a7d9f45edec5798e6a14314fec9
 SHA512:
-  metadata.gz: 623fdba2e7573d930fa7ae361703957e32ad476a270e3ca6b27116e1ca63e6b2866a55c76cfb2c53f56416e3453133d3055de62153719350d5d6753727f077e2
-  data.tar.gz: c4b10a26a2bdec126571e3128ae68a68060f550eb05178e25c30a99b595a17f715110d73244e35bd024ec64814840c2944ad6846c23d564bcd44ef1692819656
+  metadata.gz: aee1dbcd4be2719c96495044846a917f422e2ce02e1cd1f0f142280afb50a4e25a30c92ee7055a1922be08b7c0299f6752cea06d90b9112b31b3ab25310f36f9
+  data.tar.gz: 49c787c0a6a4ee69f9f68370405218311428d68a7e1f4a1c8449b2eba1108bea6f4b2ecd464961807f08cc9078e6e6d9c1f056d3a6f2b644a7d21474bcbf9450

data/lib/canvas_statsd/request_logger.rb

@@ -25,7 +25,7 @@ module CanvasStatsd
       message = "[#{header}]"
       VALUES_MAP.each do |k,v|
         value = request_stat.respond_to?(v) ? request_stat.send(v) : nil
-        message += " (#{k}: #{value})" if value
+        message += " (#{k}: #{"%.2f" % value})" if value
       end
       message
     end

data/spec/canvas_statsd/request_logger_spec.rb

@@ -7,44 +7,63 @@ describe CanvasStatsd::RequestLogger do
     before :all do
       @logger = CanvasStatsd::RequestLogger.new(Logger.new(STDOUT))
     end
-    it 'should include the supplied header' do
+    it 'includes the supplied header' do
       request_stat = double('request_stat')
       results = @logger.build_log_message(request_stat, 'FOO_STATS')
       expect(results).to eq("[FOO_STATS]")
     end
-    it 'should fallback to the default header' do
+    it 'falls back to the default header' do
       request_stat = double('request_stat')
       results = @logger.build_log_message(request_stat)
       expect(results).to eq("[STATSD]")
     end
-    it 'should include stats that are available' do
+    it 'includes stats that are available' do
       request_stat = double('request_stat')
-      request_stat.stub(:ms).and_return(100.2)
+      request_stat.stub(:ms).and_return(100.21)
       request_stat.stub(:ar_count).and_return(24)
       results = @logger.build_log_message(request_stat)
-      expect(results).to eq("[STATSD] (total: 100.2) (active_record: 24)")
+      expect(results).to eq("[STATSD] (total: 100.21) (active_record: 24.00)")
     end
-    it 'should not include nil stats' do
+    it 'doesnt include nil stats' do
       request_stat = double('request_stat')
-      request_stat.stub(:ms).and_return(100.2)
+      request_stat.stub(:ms).and_return(100.22)
       request_stat.stub(:ar_count).and_return(nil)
       results = @logger.build_log_message(request_stat)
-      expect(results).to eq("[STATSD] (total: 100.2)")
+      expect(results).to eq("[STATSD] (total: 100.22)")
     end
+
+    describe 'decimal precision' do
+      it 'forces 2 decimal precision' do
+        request_stat = double('request_stat')
+        request_stat.stub(:ms).and_return(72.1)
+        results = @logger.build_log_message(request_stat)
+        expect(results).to eq("[STATSD] (total: 72.10)")
+      end
+      it 'rounds values to 2 decimals' do
+        request_stat = double('request_stat')
+        request_stat.stub(:ms).and_return(72.1382928)
+        results = @logger.build_log_message(request_stat)
+        expect(results).to eq("[STATSD] (total: 72.14)")
+        request_stat.stub(:ms).and_return(72.1348209)
+        results = @logger.build_log_message(request_stat)
+        expect(results).to eq("[STATSD] (total: 72.13)")
+      end
+    end
+
   end
 
   describe '#log' do
-    it 'should send info method to logger if logger exists' do
+    it 'sends info method to logger if logger exists' do
       std_out_logger = Logger.new(STDOUT)
       logger = CanvasStatsd::RequestLogger.new(std_out_logger)
       expect(std_out_logger).to receive(:info)
       request_stat = double('request_stat')
       logger.log(request_stat)
     end
-    it 'should send info method with build_log_message output if logger exists' do
+    it 'sends info method with build_log_message output if logger exists' do
       std_out_logger = Logger.new(STDOUT)
       logger = CanvasStatsd::RequestLogger.new(std_out_logger)
-      expect(std_out_logger).to receive(:info).with("[DEFAULT_METRICS] (total: 100.2)")
+      expect(std_out_logger).to receive(:info).with("[DEFAULT_METRICS] (total: 100.20)")
       request_stat = double('request_stat')
       request_stat.stub(:ms).and_return(100.2)
       logger.log(request_stat, "DEFAULT_METRICS")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: canvas_statsd
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Nick Cloward
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-17 00:00:00.000000000 Z
+date: 2015-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: statsd-ruby