cant_wait 0.0.1

data/.gitignore

@@ -0,0 +1,18 @@
+*.gem
+*.rbc
+.bundle
+.config
+.DS_Store
+.yardoc
+Gemfile.lock
+InstalledFiles
+_yardoc
+coverage
+doc/
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp

data/Gemfile

@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+
+gemspec

data/LICENSE.txt

@@ -0,0 +1,22 @@
+Copyright (c) 2013 Carlos A. Carro Duplá
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -0,0 +1,65 @@
+# cant_wait
+
+This ruby gem allows to add a statement timeout for PostgreSQL databases within a Ruby on Rails application.
+
+If any SQL statement takes more time than the timeout value (measured in milliseconds), its execution will be cancelled, and Active Record
+would raise a PGError exception.
+
+    ActiveRecord::StatementInvalid: PGError: ERROR:  canceling statement due to statement timeout
+
+From the PostgreSQL documentation:
+
+>     statement_timeout (integer)
+> 
+>          Abort any statement that takes more than the specified number of milliseconds, starting from the time the command arrives at the server from the client. If log_min_error_statement is set to ERROR or lower, the statement that timed out will also be logged.  A value of zero (the default) turns this off.
+> 
+>          Setting statement_timeout in postgresql.conf is not recommended because it would affect all sessions.
+> 
+>     (© 1996-2013 The PostgreSQL Global Development Group)
+
+(Visit <http://www.postgresql.org/docs/devel/static/runtime-config-client.html> for more information)
+
+
+The gem has been tested for ruby 1.9.2 and above, as well as with Rails 3.0.3 and above.  Tested also with PostgreSQL 8 and 9, but it may work also in other versions supported by Active Record (see PostgreSQL documentation).
+
+If you find any problems, please feel free to open any issues within the gem repository ([GitHub](https://github.com/CarlosCD/cant_wait)).
+
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+    gem 'cant_wait', '~> 0.0.1'
+
+And then execute:
+
+    $ bundle
+
+
+## Usage
+
+In the file config/database.yml, indicate a timeout in milliseconds for each environment:
+
+    production:
+      adapter: postgresql
+      timeout: 120_000  # 2 minutes
+      ...
+
+Then restart the application to establish the new configuration parameter(s).
+
+
+## Development / Contributing
+
+* Source hosted on [GitHub](https://github.com/CarlosCD/cant_wait)
+* Details on the test setup are in the file Readme.md within the test folder. It includes details on testing in several Ruby and Rails versions.
+
+Contributing:
+
+1. Fork it
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am 'Add some feature'`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Create new Pull Request
+
+
+May 2013

data/Rakefile

@@ -0,0 +1,18 @@
+@gem_spec = eval(File.read(Dir['*.gemspec'].first))
+
+Dir[File.join('tasks', '*.rake')].each do |file_name|
+  load file_name
+end
+
+task :default do
+  puts 'No default task defined. Please take a look to test/Readme.md for details.'
+  puts 'Here is what you can do:'
+  puts
+  system 'bundle exec rake -T'
+end
+
+private
+
+def boolean_env_param(environment_var, *values)
+  ENV[environment_var] && values.include?(ENV[environment_var].strip.downcase)
+end

data/cant_wait.gemspec

@@ -0,0 +1,49 @@
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'cant_wait/version'
+
+Gem::Specification.new do |spec|
+  spec.name          = 'cant_wait'
+  spec.version       = CantWait::VERSION
+  spec.authors       = ['Carlos A. Carro Duplá']
+  spec.email         = ['ccarrodupla@gmail.com']
+  spec.description   = <<-EOF
+    Adds a timeout setting for PostgreSQL databases in a Ruby on Rails application.
+    If any SQL statement takes more time than the timeout value, it will be cancelled, and ActiveRecord
+    would raise a PGError exception.
+    In the config/database.yml file, indicate a timeout in milliseconds for each environment:
+      production:
+        adapter: postgresql
+        timeout: 120_000  # 2 minutes
+        ...
+    (see documentation for more details)
+  EOF
+  spec.summary       = %q{Adds statement timeout for PostgreSQL databases in Ruby on Rails. Timeout is measured in milliseconds.}
+  spec.homepage      = 'https://github.com/CarlosCD/cant_wait'
+  spec.license       = 'MIT'
+  spec.signing_key = '/users/CarlosCD/.ssh/private_key.pem'
+  spec.cert_chain  = ['/users/CarlosCD/.ssh/public_cert.pem']
+
+  spec.add_dependency 'rails', '>= 3.0.3'
+  spec.files         = `git ls-files`.split($/)
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ['lib']
+
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  if RUBY_ENGINE == 'jruby' && RUBY_PLATFORM == 'java'
+    spec.add_development_dependency 'activerecord-jdbc-adapter', '~> 1.2'
+    spec.add_development_dependency 'activerecord-jdbcpostgresql-adapter', '~> 1.2'
+    spec.add_development_dependency 'jdbc-postgres', '~> 9'
+  else
+    spec.add_development_dependency 'pg', '~> 0'
+  end
+  if RUBY_PLATFORM =~ /darwin/i
+    spec.add_development_dependency 'minitest-growl', '~> 0.0.3'
+    # minitest-growl small problem with minitest 5:
+    spec.add_development_dependency('minitest', '~> 4.7.4')
+  else
+    spec.add_development_dependency('minitest', '~> 5') if RUBY_VERSION < '1.9.3'
+  end
+end

data/lib/cant_wait/cant_wait_railtie.rb

@@ -0,0 +1,20 @@
+##
+# This class is a Railtie which adds an initializer to Rails
+#
+# It reads the database configuration timeout, and if the adapter is PostgreSQL,
+# sets its value as the PostgreSQL statement_timeout.
+
+class CantWaitRailtie < Rails::Railtie
+
+  initializer 'cant_wait.set_timeout' do
+    begin
+      database_config = Rails.configuration.database_configuration[Rails.env]
+      if (database_config['adapter'].downcase == 'postgresql') && database_config['timeout']
+        ActiveRecord::Base.connection.execute "set statement_timeout = #{database_config['timeout']}"
+      end
+    rescue Exception => e
+      puts "\n#{e.message}\n\n"
+    end
+  end
+
+end

data/lib/cant_wait/version.rb

@@ -0,0 +1,3 @@
+module CantWait
+  VERSION = '0.0.1'
+end

data/lib/cant_wait.rb

@@ -0,0 +1,6 @@
+begin
+  require 'cant_wait/version'
+  require 'cant_wait/cant_wait_railtie' if defined? Rails
+rescue LoadError
+  puts 'Some needed files are not accessible to the cant_wait gem, please check its integrity.'
+end

data/tasks/debugging.rake

@@ -0,0 +1,108 @@
+# Development and debugging:
+#
+#  rake debug:build       # Temporarily builds the gem without committing files to git
+#  rake debug:try         # Temporarily install the gem without committing files to git
+
+namespace :debug do
+
+  # rake debug:build SLOW=y
+  # rake debug:build
+  desc 'Temporarily builds the gem without committing files to git'
+  # Creates the gem file, without installing it, to try it somewhere else.
+  #   It doesn't alter the git repository, even if some things may not have been commited yet
+  # Argument (env.):
+  #   SLOW=t     Pauses or not in each step.
+  #              Other possible values (meaning the same): t, true, y, yes, on, ok
+  #              Default: no pause (no flag)
+  task :build do
+    pausing = boolean_env_param 'SLOW', 't', 'y', 'on', 'ok', 'yes', 'true'
+    use_gem_as_it_is @gem_spec, pausing, get_it_back: true
+  end
+
+  # rake debug:install SLOW=y
+  # rake debug:install
+  desc 'Temporarily install the gem without committing files to git'
+  # Install the gem as it is, during the development cycle, in order to try it out
+  #   It doesn't alter the git repository, even if some things may not have been committed yet
+  # Argument (env.):
+  #   SLOW=t     Pauses or not in each step.
+  #              Other possible values (meaning the same): t, true, y, yes, on, ok
+  #              Default: no pause (no flag)
+  task :install do
+    pausing = boolean_env_param 'SLOW', 't', 'y', 'on', 'ok', 'yes', 'true'
+    use_gem_as_it_is @gem_spec, pausing, install_gem: true
+  end
+
+  private
+
+  # options = { get_it_back: false, install_gem: false }
+  def use_gem_as_it_is(gem_spec, pause=true, options={})
+
+    gem_name = gem_spec.name
+    gem_version = gem_spec.version
+    gem_pkg_directory = FileUtils.pwd+'/pkg'
+
+    little_step 'Removing previous test files from the /tmp folder', pause do
+      FileUtils.rm_rf "/tmp/#{gem_name}"
+    end
+
+    little_step 'Copying the gem folder to /tmp...', pause do
+      FileUtils.cp_r '.', "/tmp/#{gem_name}"
+    end
+
+    little_step "Changing work directory to /tmp/#{gem_name}", pause do
+      FileUtils.cd "/tmp/#{gem_name}"
+      puts "And now the folder is (pwd): #{FileUtils.pwd}"
+    end
+
+    little_step 'Commiting changes to GIT', pause do
+      system 'git add .'
+      system 'git commit -m "Just testing"'
+    end
+
+    # Note: This may have issues with Ruby 2.0.0
+    little_step 'Changing permisions in the gem files to make them world-readeable', pause do
+      gem_spec.files.each do |file_name|
+        FileUtils.chmod(File.stat(file_name).mode | 444, file_name, { verbose: true }) if (File.stat(file_name).mode & 444) != 444
+      end
+    end
+
+    little_step 'Building the gem', pause do
+      system "gem build #{gem_name}.gemspec"
+    end
+
+    # Now do something with the new gem:
+
+    if options[:get_it_back]
+      little_step 'Copying the gem file to the initial folder', pause do
+        FileUtils.mkdir gem_pkg_directory rescue nil
+        FileUtils.cp "#{gem_name}-#{gem_version}.gem", gem_pkg_directory
+      end
+    end
+
+    if options[:install_gem]
+      little_step 'Installing the gem locally (rvm-dependent)', pause do
+        system "rvm current"
+        system "gem install #{gem_name}-#{gem_version}.gem"
+      end
+    end
+
+    little_step 'Cleaning up temporary files', pause do
+      FileUtils.rm_rf "/tmp/#{gem_name}"
+    end
+
+  end
+
+  def little_step (message, pause=true)
+    puts "#{message}..."
+    yield if block_given?
+    wait_for_input if pause
+    puts '---'
+  end
+
+  def wait_for_input(message='Press [enter] to continue')
+    puts message
+    STDIN.gets
+  end
+
+end

data/tasks/publishing.rake

@@ -0,0 +1,37 @@
+# Gem building and publication:
+#
+#  rake gemspec_valid     # Validate the gemspec
+#
+#  rake build             # Build cant_wait-0.0.1.gem into the pkg directory.
+#  rake clean             # Clean automatically generated gem files (removes the pkg folder).
+#
+#  rake install           # Build and install cant_wait-0.0.1.gem into system gems.
+#
+#  rake push              # Push pkg/cant_wait-0.0.1.gem to rubygems, if it exists.
+#  rake release           # Create tag v0.0.1 and build and push cant_wait-0.0.1.gem to Rubygems
+
+begin
+  require 'bundler/gem_tasks'  # Adds these tasks: build, install and release
+rescue LoadError
+  puts 'You may need Bundler to build this gem.'
+end
+
+desc 'Validate the gemspec'
+#  It calls the instance method Gem::Specification.validate
+#    It checks that the specification contains all required fields, and does a very basic sanity check.
+#    It raises InvalidSpecificationException if the spec does not pass the checks...
+#      Otherwise outputs nothing
+#    See http://rubygems.rubyforge.org/rubygems-update/Gem/Specification.html
+task :gemspec_valid do
+  @gem_spec.validate
+end
+
+desc 'Clean automatically generated gem files (removes the pkg folder).'
+task :clean do
+  FileUtils.rm_rf 'pkg'
+end
+
+desc "Push pkg/#{@gem_spec.name}-#{@gem_spec.version}.gem to rubygems, if it exists."
+task :push do
+  system "gem push pkg/#{@gem_spec.name}-#{@gem_spec.version}.gem"
+end

data/tasks/testing.rake

@@ -0,0 +1,134 @@
+# Testing:
+#
+#  rake test:bundle       # Installs gems needed for the test apps (Bundle Install for each Rails app's Gemfile)
+#  rake test:run          # Tests the gem's behavior, using 5 test rails apps of different versions, and random timeouts
+
+namespace :test do
+
+  TEST_RAILS_APP = [{ version: '3.0.3',     rails_root: 'test/test_apps/Test_3_0_3'},
+                    { version: '3.0.20',    rails_root: 'test/test_apps/Test_3_0_20'},
+                    { version: '3.1.12',    rails_root: 'test/test_apps/Test_3_1_12'},
+                    { version: '3.2.13',    rails_root: 'test/test_apps/Test_3_2_13'},
+                    { version: '4.0.0.rc1', rails_root: 'test/test_apps/Test_4_0_0_rc1'}]
+
+  # Argument (env.):
+  #    VERBOSE=t     Gives more information about what's going on
+  #                  Other possible values (meaning the same): t, true, y, yes, on, ok
+  #                  Default: no verbose (no flag)
+  desc "Tests the gem's behavior, using 5 test rails apps of different versions, and random timeouts"
+  task :run do
+    # Verbose setting:
+    verbose = boolean_env_param 'VERBOSE', 't', 'y', 'on', 'ok', 'yes', 'true'
+    if verbose
+      puts '------------------------------------------------'
+      puts 'VERBOSE mode ON'
+      print 'rvm setting (if rvm is being used): '
+      system 'rvm current'
+      puts "We'll run 5 times the test #1 (5 rails versions)"
+      puts "Gem's ENV['BUNDLE_GEMFILE']='#{ENV['BUNDLE_GEMFILE']}'"
+    end
+    can_wait_bundle_gemfile = ENV['BUNDLE_GEMFILE']
+    5.times do |num|
+      puts "====TESTING Rails version #{TEST_RAILS_APP[num][:version]}================="
+      if (TEST_RAILS_APP[num][:version] >= '4') && (RUBY_VERSION < '1.9.3')
+        puts 'At least Ruby 1.9.3 is required for rails 4 or above...'
+      else
+        # Uses Gemfile for the given version of rails
+        gemfile_path = escape_filename_espaces TEST_RAILS_APP[num][:rails_root]
+        gemfile = gemfile_path<<'/Gemfile'
+        ENV['BUNDLE_GEMFILE'] = gemfile
+        if verbose
+          puts "Gemfile to be used in this case (ENV['BUNDLE_GEMFILE']): '#{ENV['BUNDLE_GEMFILE']}'"
+          print 'echo $BUNDLE_GEMFILE: '
+          system 'echo $BUNDLE_GEMFILE'
+        end
+        # We check the Gemfile and bundle install:
+        puts 'bundle check' if verbose
+        if system("bundle check --gemfile='#{gemfile_path}' > /dev/null")
+          if verbose
+            puts "The Gemfile's dependencies are satisfied"
+            puts 'Testing....'
+          end
+          # Run several timeouts test for that version of rails (bundle exec...)
+          #   Only the last argument (V) is optional here:
+          system "bundle exec ruby test/cant_wait_test.rb #{num} #{@gem_spec.version} #{'V' if verbose}"
+        else
+          puts ' bundle check and bundle failed! Check your rails test app Gemfile.'
+          puts ' If there are missing gems, run rake test:bundle_apps'
+        end
+      end
+    end
+    puts '------------------------------------------------'
+    ENV['BUNDLE_GEMFILE'] = can_wait_bundle_gemfile
+    if verbose
+      puts "Finally set again the gem ENV['BUNDLE_GEMFILE'] as:"
+      puts "  '#{ENV['BUNDLE_GEMFILE']}'"
+    end
+  end
+
+  # Arguments (env.):
+  #   VERBOSE=t   It gives more information about what's going on
+  #   REBUILD=t   It removes the Gemfile.lock, so it forces a clean bundle install
+  #   Other possible values (meaning the same): t, true, y, yes, on, ok
+  #   Default: no verbose (no flags)
+  # Example:
+  #   $ rake test:bundle_apps REBUILD=y
+  desc "Installs gems needed for the test apps (Bundle Install for each Rails app's Gemfile)"
+  task :bundle do
+    # Rebuild setting:
+    rebuild = boolean_env_param 'REBUILD', 't', 'y', 'on', 'ok', 'yes', 'true'
+    # Verbose setting:
+    verbose = boolean_env_param 'VERBOSE', 't', 'y', 'on', 'ok', 'yes', 'true'
+    if verbose
+      puts "We'll bundle install for each of the 5 test rails apps"
+      puts '============================================================'
+      print '  rvm setting (if rvm is being used): '
+      system 'rvm current'
+      puts "  Gem's ENV['BUNDLE_GEMFILE']='#{ENV['BUNDLE_GEMFILE']}'" if verbose
+    end
+    can_wait_bundle_gemfile = ENV['BUNDLE_GEMFILE']
+    initial_directory = FileUtils.pwd
+    puts "  Initial task directory: #{initial_directory}" if verbose
+    5.times do |num|
+      if (TEST_RAILS_APP[num][:version] >= '4') && (RUBY_VERSION < '1.9.3')
+        puts 'At least Ruby 1.9.3 is required for rails 4 or above...'
+      else
+        puts "====Rails app for Rails v. #{TEST_RAILS_APP[num][:version]}================"
+        if verbose
+          puts "  Present directory (pwd): #{FileUtils.pwd}"
+          puts "  Changing to the app root..."
+        end
+        FileUtils.cd escape_filename_espaces TEST_RAILS_APP[num][:rails_root]
+        puts "  Now present directory (pwd) is: #{FileUtils.pwd}" if verbose
+        app_root = escape_filename_espaces FileUtils.pwd
+        puts " App Root: #{app_root}" if verbose
+        # Rebuilding the Gemfile.lock installs missing gems
+        if rebuild
+          puts 'Removing Gemfile.lock by installing any missing gems' if verbose
+          FileUtils.rm 'Gemfile.lock' rescue nil
+        end
+        # Uses the Gemfile for the given version of rails
+        ENV['BUNDLE_GEMFILE'] = 'Gemfile'
+        puts "  Gemfile used in this case: (ENV['BUNDLE_GEMFILE']): '#{ENV['BUNDLE_GEMFILE']}'" if verbose
+        # Bundle install this Gemfile:
+        puts 'Bundle install failed! Check your rails test app' unless system('bundle')
+        # Back to where we were:
+        puts " Changing to the initial directory..." if verbose
+        FileUtils.cd initial_directory
+      end
+    end
+    puts '------------------------------------------------'
+    ENV['BUNDLE_GEMFILE'] = can_wait_bundle_gemfile
+    if verbose
+      puts "Finally set again the gem ENV['BUNDLE_GEMFILE'] as:"
+      puts "  '#{ENV['BUNDLE_GEMFILE']}'"
+    end
+  end
+
+  private
+
+  def escape_filename_espaces(filename)
+    filename.gsub(' ', '\ ')
+  end
+
+end

data/test/README.md

@@ -0,0 +1,100 @@
+# cant_wait
+# Development and Test
+
+
+## Test preferences and setup
+
+- Minitest, to keep things simple.
+- PostgreSQL database server (localhost or not).
+- I used rvm (not a need if other ruby version manager is preferred). 
+
+
+## Test strategy: different Rails apps with random timeouts
+
+The approach of using minimal Rails components (ActiveRecord, Railties) is problematic due to the amount of code that Rails loads and of how it changes in the default behavior of Ruby.  Running several Rails apps at the same time, and even if it is done in different threads, may result in:
+
+    RuntimeError: You cannot have more than one Rails::Application
+
+This approach also makes the test cases too distant to the real conditions you may encounter in isolated Rails applications.  I finally choose to test several versions of Rails/ActiveRecord independently.
+
+I created 5 simple Rails apps in the folder test/test_apps.  Then I modified their Gemfile by adding gems for PostgreSQL, Minitest and Growl:
+
+    if RUBY_ENGINE == 'jruby' && RUBY_PLATFORM == 'java'
+      gem 'activerecord-jdbc-adapter', '~> 1.2'
+      gem 'activerecord-jdbcpostgresql-adapter', '~> 1.2'
+      gem 'jdbc-postgres', '~> 9'
+    else
+      gem 'pg', '~> 0'
+    end
+
+    if RUBY_PLATFORM =~ /darwin/i
+      gem 'minitest-growl', '~> 0.0.3'
+      gem 'minitest', '~> 4.7.4'
+    else
+      gem('minitest', '~> 5') if RUBY_VERSION < '1.9.3'
+    end
+
+    gem 'cant_wait', path: File.expand_path('../../../..', __FILE__)
+
+The rails apps require bundle install, specially when changing the version of Ruby to be used. To make it easier, I added a rake task (rake test:bundle).
+
+The test is run through the rake test:run command.  Due to the complex setup needed, I choose not to use the rake default to run the test.
+
+The test (rake test:run) goes over each rails app in sequence and:
+
+1. It sets Bundle to use the test app's Gemfile
+2. It creates the app's config/database.yml with a random timeout
+3. It starts Rails
+4. It checks the version of Rails and ActiveRecord running.
+5. It checks that the PostgreSQL connection's statement_timeout is the expected.
+
+
+## The Testing process
+
+After cloning the gem, you can start testing it by following these steps:
+
+1. Choose the version of Ruby you want to use.
+    For example, if you have a rvm 1.9.3 installed, and a gemset called mygemset:
+
+        rvm use 1.9.3@mygemset
+
+2. Optional: if you are using Mac OS, get Growl
+
+3. Get the gem's dependencies:
+
+        bundle
+
+4. Set up your PostgreSQL test database and edit accordingly the file test/database.yml
+
+5. Get the Rails gems used by the test rails apps included:
+
+        rake test:bundle
+
+6. You are now done setting all up.  To run the tests:
+
+        rake test:run
+
+If so wanted, run the tests several times.  The tests use different random timeout scenarios, so each run may be a bit different.
+
+
+## Tested for
+
+* Versions of Ruby:
+
+        jruby 1.7.4
+        1.9.2-p320  (MRI's last patchlevel of 1.9.2)
+        1.9.3-p429  (MRI last patchlevel of 1.9.3)
+        2.0.0-p195  (MRI last patchlevel of 2.0.0)
+
+* Versions of Rails:
+
+        Rails 3.0.3      First version using Bundler 1.3.5 (incompatible with Bundler 1.0.X)
+        Rails 3.0.20     Last patchlevel of Rails 3.0 (at this moment)
+        Rails 3.1.12     Last patchlevel of Rails 3.1
+        Rails 3.2.13     Last patchlevel of Rails 3.2 (many security fixes, last stable version)
+        Rails 4.0.0.rc1  Last Release candidate for Rails 4, the most stable version at this point in time.
+
+* PostgreSQL versions 8.3.6 and 9.2.4.
+
+
+June 2013