canon 0.2.7 → 0.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1800400419926b8607eb146490d0bc4a0ecf5e4bfaf2b3007a87e99d440661f3
-  data.tar.gz: 0fc8298171e94fec5e9c4b650001fcc31e79ca774e1d7ad0f19fe91308199b18
+  metadata.gz: a13457a67f3e2ab91e00cec19684c502605ab807bdd87eb1120e77d190a99c2e
+  data.tar.gz: 35c0c873340e12c63048adf2222fda2f8c2ae3972337dcc212b26d391191ac35
 SHA512:
-  metadata.gz: 5c553b671df23a70814bedb7521836b01ce7d6e0ab1af99f00aa05ca6f4ef875d8e8af2e4e63c208443d8ddbab92ed7a05c3c8c6828da2608c42bf6a38f0b7c4
-  data.tar.gz: e183e77684bc3fe7c072caa904cf709a3c20e2f6c38099a42f099e3367d2b0c2336f5407a6def0147f7405056a26a639f4b9dd5075deb6b51a60bcb7921c7c44
+  metadata.gz: 8db915564eebd4ca4dfadd65358f721aa70bca318c22dc1c02eff5e3527cf646ea19722b760072851f358b3fabefd12fc5f6dfc216bce146423c7091f3bf7eac
+  data.tar.gz: f92e7491d781c8762483335558ede985a1653bcfb88613858115aa87e50bb326f95b0b76b845c54154e657fb9f25b3d1f348bf8e9baa926ea1c6bfbbd77d6ca6

data/.rspec-opal

@@ -0,0 +1,7 @@
+--default-path=spec
+--pattern='spec/canon/opal_xml_smoke_spec.rb'
+-I lib
+--opal-opt=-g,canon
+-I spec
+--require=spec_helper
+--require=support/opal

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2026-04-27 09:48:55 UTC using RuboCop version 1.86.0.
+# on 2026-05-24 10:34:05 UTC using RuboCop version 1.86.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -11,51 +11,13 @@ Gemspec/RequiredRubyVersion:
   Exclude:
     - 'canon.gemspec'
 
-# Offense count: 30
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_argument, with_fixed_indentation
-Layout/ArgumentAlignment:
-  Exclude:
-    - 'lib/canon/comparison/xml_comparator.rb'
-    - 'spec/canon/comparison/html4_html5_whitespace_parity_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyleAlignWith.
-# SupportedStylesAlignWith: either, start_of_block, start_of_line
-Layout/BlockAlignment:
-  Exclude:
-    - 'lib/canon/diff_formatter/diff_detail_formatter/text_utils.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/BlockEndNewline:
-  Exclude:
-    - 'lib/canon/diff_formatter/diff_detail_formatter/text_utils.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Width, EnforcedStyleAlignWith, AllowedPatterns.
-# SupportedStylesAlignWith: start_of_line, relative_to_receiver
-Layout/IndentationWidth:
-  Exclude:
-    - 'lib/canon/diff_formatter/diff_detail_formatter/text_utils.rb'
-
-# Offense count: 1347
+# Offense count: 1358
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Max, AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, AllowRBSInlineAnnotation, AllowCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https
 Layout/LineLength:
   Enabled: false
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowInHeredoc.
-Layout/TrailingWhitespace:
-  Exclude:
-    - 'lib/canon/comparison/xml_comparator.rb'
-
 # Offense count: 58
 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches, IgnoreDuplicateElseBranch.
 Lint/DuplicateBranch:
@@ -69,13 +31,12 @@ Lint/EmptyConditionalBody:
     - 'spec/canon/comparison/html_comparator_spec.rb'
     - 'spec/canon/comparison_spec.rb'
 
-# Offense count: 6
+# Offense count: 5
 # Configuration parameters: MaximumRangeSize.
 Lint/MissingCopEnableDirective:
   Exclude:
     - 'lib/canon/commands/format_command.rb'
     - 'lib/canon/xml/attribute_handler.rb'
-    - 'lib/canon/xml/data_model.rb'
     - 'lib/canon/xml/namespace_handler.rb'
     - 'lib/canon/xml/processor.rb'
     - 'lib/canon/xml/xml_base_handler.rb'
@@ -101,7 +62,7 @@ Lint/UselessConstantScoping:
   Exclude:
     - 'lib/canon/diff_formatter/theme.rb'
 
-# Offense count: 322
+# Offense count: 313
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Enabled: false
@@ -117,12 +78,12 @@ Metrics/BlockLength:
 Metrics/BlockNesting:
   Max: 4
 
-# Offense count: 281
+# Offense count: 276
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/CyclomaticComplexity:
   Enabled: false
 
-# Offense count: 517
+# Offense count: 523
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 146
@@ -132,7 +93,7 @@ Metrics/MethodLength:
 Metrics/ParameterLists:
   Max: 10
 
-# Offense count: 225
+# Offense count: 214
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/PerceivedComplexity:
   Enabled: false
@@ -165,13 +126,13 @@ Performance/CollectionLiteralInLoop:
     - 'lib/canon/xml/xml_base_handler.rb'
     - 'spec/canon/diff/diff_node_mapper_comments_spec.rb'
 
-# Offense count: 85
+# Offense count: 107
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Enabled: false
 
-# Offense count: 43
+# Offense count: 47
 # Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:
   Enabled: false
@@ -182,7 +143,7 @@ RSpec/DescribeMethod:
     - 'spec/canon/comparison/multiple_differences_spec.rb'
     - 'spec/canon/diff_formatter/character_map_customization_spec.rb'
 
-# Offense count: 847
+# Offense count: 874
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 44
@@ -196,12 +157,6 @@ RSpec/ExpectActual:
     - 'spec/canon/rspec_matchers_spec.rb'
     - 'spec/canon/string_matcher_spec.rb'
 
-# Offense count: 7
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/IncludeExamples:
-  Exclude:
-    - 'spec/canon/comparison/html4_html5_whitespace_parity_spec.rb'
-
 # Offense count: 177
 # Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
 RSpec/IndexedLet:
@@ -240,7 +195,7 @@ RSpec/MultipleDescribes:
   Exclude:
     - 'spec/canon/comparison/match_options_spec.rb'
 
-# Offense count: 694
+# Offense count: 736
 RSpec/MultipleExpectations:
   Max: 15
 
@@ -249,7 +204,7 @@ RSpec/MultipleExpectations:
 RSpec/MultipleMemoizedHelpers:
   Max: 16
 
-# Offense count: 17
+# Offense count: 29
 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
 # SupportedStyles: always, named_only
 RSpec/NamedSubject:
@@ -258,17 +213,18 @@ RSpec/NamedSubject:
     - 'spec/canon/pretty_printer/json_spec.rb'
     - 'spec/canon/pretty_printer/xml_spec.rb'
 
-# Offense count: 53
+# Offense count: 54
 # Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:
   Max: 4
 
-# Offense count: 10
+# Offense count: 11
 # Configuration parameters: AllowedPatterns.
 # AllowedPatterns: ^expect_, ^assert_
 RSpec/NoExpectationExample:
   Exclude:
     - 'spec/canon/context_grouping_spec.rb'
+    - 'spec/canon/diff_formatter/diff_detail_formatter_spec.rb'
     - 'spec/canon/informative_diffs_debug_spec.rb'
     - 'spec/canon/isodoc_blockquotes_spec.rb'
     - 'spec/canon/match_scenarios_spec.rb'
@@ -292,14 +248,13 @@ RSpec/SpecFilePathFormat:
     - 'spec/canon/yaml/formatter_spec.rb'
     - 'spec/xml_c14n_spec.rb'
 
-# Offense count: 134
+# Offense count: 72
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
     - 'spec/canon/comparison/diff_node_builder_spec.rb'
     - 'spec/canon/comparison/whitespace_sensitivity_spec.rb'
     - 'spec/canon/diff/diff_classifier_spec.rb'
-    - 'spec/canon/diff/path_builder_spec.rb'
     - 'spec/canon/diff/xml_serialization_formatter_spec.rb'
     - 'spec/canon/diff_formatter/diff_detail_formatter_spec.rb'
     - 'spec/canon/tree_diff/operation_converter_spec.rb'

data/README.adoc

@@ -618,6 +618,11 @@ See link:docs/MODES[Diff modes] for details.
   reported as a dedicated `:whitespace_adjacency` dimension with direction
   wording (`before`/`after`/`adjacent to`) instead of cascading into
   misleading `:text_content` mismatches
+* **Asymmetric comment reporting**: A `<!-- ... -->` node present on only
+  one side is reported as a dedicated `:comments` dimension diff anchored
+  at the comment node, instead of shifting children alignment and
+  surfacing a misleading `:element_structure` "Element removed" diff
+  against an unrelated trailing sibling
 * **Non-ASCII detection**: Warnings for unexpected Unicode characters
 * **Customizable**: Character maps, context lines, grouping options
 

data/Rakefile

@@ -5,10 +5,27 @@ require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
+begin
+  require "opal/rspec/rake_task"
+rescue LoadError
+  # Opal not available or incompatible with current Ruby version
+end
+
 require "rubocop/rake_task"
 
 RuboCop::RakeTask.new
 
 Dir.glob("lib/tasks/**/*.rake").each { |r| load r }
 
+namespace :spec do
+  if defined?(Opal::RSpec::RakeTask)
+    desc "Run Opal (JavaScript) tests"
+    Opal::RSpec::RakeTask.new(:opal) do |server, runner|
+      server.append_path "lib"
+      runner.default_path = "spec"
+      runner.pattern = "spec/canon/opal_xml_smoke_spec.rb"
+    end
+  end
+end
+
 task default: %i[spec rubocop]

data/docs/features/diff-formatting/comment-asymmetry.adoc

@@ -0,0 +1,160 @@
+---
+title: Comment asymmetry in diff reports
+parent: Diff Formatting
+nav_order: 9
+---
+= Comment asymmetry in diff reports
+:toc:
+:toclevels: 2
+
+== Purpose
+
+Canon's diff reports anchor `<!-- ... -->` comment nodes that have no
+counterpart on the other side to a dedicated `:comments` dimension
+instead of letting the resulting children-array length mismatch cascade
+into a misleading `:element_structure` "Element removed" diff against
+the trailing named sibling.
+
+This is a *report-only* shape change — equivalence verdicts are
+unchanged. Whether asymmetric comments cause a non-equivalent verdict
+or not depends on the `comments` match option (`:strict` /
+`:ignore` / `:exact`), as before.
+
+== The problem
+
+Consider an HTML fragment compared with `verbose: true`:
+
+[source,html]
+----
+<!-- expected -->
+<body>
+  <div>first</div>
+  <div>second</div>
+  <!-- a comment that exists only on side A -->
+  <div style="mso-element:footnote-list"></div>
+</body>
+
+<!-- actual -->
+<body>
+  <div>first</div>
+  <div>second</div>
+  <div style="mso-element:footnote-list"></div>
+</body>
+----
+
+The `<div style="mso-element:footnote-list">` is byte-identical between
+the two sides; the only real difference is the comment on the expected
+side. Pre-#144, the diff report contained:
+
+[source]
+----
+DIFFERENCE #1 — element_structure: Element removed:
+                  <div style="mso-element:footnote-list"/>
+----
+
+That is the wrong dimension, anchored at the wrong node. The element is
+present on both sides — what is missing is the comment.
+
+The cascade comes from positional alignment in
+`Canon::Comparison::HtmlComparator#compare_fragment_children` (and the
+analogous walker in `XmlComparatorHelpers::ChildComparison`): in
+verbose mode, comments are intentionally kept by `filter_children` so
+informative differences can be recorded, but the resulting unequal
+children-array lengths fell through to a name-based mismatch heuristic
+that filtered out generic `#`-prefixed names (`#text`, `#comment`),
+leaving the trailing named element to take the blame.
+
+== The contract
+
+When the children alignment encounters a comment node on one side
+paired against a non-comment node on the other (or sitting past the
+trailing edge of the shorter side), Canon:
+
+1. Treats the comment as a *single-side gap* in the alignment.
+2. Emits one `:comments` diff entry anchored at the comment node
+   itself (not at a mis-paired neighbouring element).
+3. Advances only the cursor that carries the comment, so the next
+   iteration aligns content against content.
+
+The Reason line names the side that carries the comment and surfaces
+its text:
+
+[source]
+----
+DIFFERENCE #1 — comments: Comment present on EXPECTED only:
+                  <!-- a comment that exists only on side A -->
+----
+
+== Combined with whitespace asymmetry
+
+The same realignment walk handles asymmetric whitespace-only text
+nodes (link:whitespace-adjacency.adoc[issue #137]) and asymmetric
+comment nodes together. When a children mismatch is fully explained by
+a combination of asymmetric whitespace and asymmetric comments, the
+walker emits one diff per asymmetric node with the appropriate
+dimension (`:whitespace_adjacency` for whitespace, `:comments` for
+comments) — no `:element_structure` diff is produced.
+
+When a real structural mismatch coexists with an asymmetric comment,
+both kinds of diff are emitted — the structural one under
+`:element_structure`, the comment one under `:comments`.
+
+== Working with :comments diffs programmatically
+
+[source,ruby]
+----
+result = Canon::Comparison.equivalent?(html1, html2,
+  format: :html5, verbose: true)
+
+comment_diffs = result.differences.select { |d| d.dimension == :comments }
+
+# Whether these affect equivalence depends on the comments match option.
+# Under the default :ignore profile they are informative; under :strict
+# they are normative.
+----
+
+== What this contract does NOT do
+
+* **Does not silence asymmetric comments.** They are always reported
+  in verbose output; the change is the dimension label and the anchor
+  node.
+* **Does not affect symmetric comments.** When both sides carry
+  parallel comment nodes, those compare normally — content-vs-content
+  comparison applies.
+* **Does not change equivalence outcomes.** A comparison whose
+  equivalence verdict was driven by asymmetric comments retains the
+  same verdict; only the report shape changes.
+
+== Where it runs
+
+The noise-aware realignment is a single shared implementation:
+
+* `Canon::Comparison::ChildRealignment` — the two-cursor walk that
+  detects noise nodes via `NodeInspector.noise_dimension_for`,
+  emits per-orphan diffs with the appropriate dimension
+  (`:whitespace_adjacency`, `:comments`), and advances only the
+  noise-side cursor so content nodes stay aligned.
+
+Both comparison paths delegate to `ChildRealignment.walk`:
+
+* `Canon::Comparison::HtmlComparator#compare_fragment_children` — the
+  HTML fragment path (passes `emit_structural_orphans: true` because it
+  has no separate length-mismatch step).
+* `Canon::Comparison::XmlComparatorHelpers::ChildComparison` — the XML
+  comparator path (passes `emit_structural_orphans: false`; structural
+  orphans are handled by the pre-walk length-mismatch step via
+  `asymmetric_noise_explains_length_diff?`).
+
+== Related
+
+* link:whitespace-adjacency.adoc[Whitespace adjacency] — sibling
+  contract for asymmetric whitespace-only text nodes.
+* link:../../advanced/diff-classification.adoc[Diff classification] —
+  Normative vs informative differences.
+
+== History
+
+The false-positive cascade was reported in
+https://github.com/lutaml/canon/issues/144[issue #144]. The fix
+mirrors the structure of the `:whitespace_adjacency` work in
+https://github.com/lutaml/canon/issues/137[issue #137].

data/lib/canon/cli.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "thor"
+require "thor" unless RUBY_ENGINE == "opal"
 require_relative "commands/format_command"
 require_relative "commands/diff_command"
 require_relative "options/registry"

data/lib/canon/color_detector.rb

@@ -67,11 +67,9 @@ module Canon
       # @param io [IO] Output stream
       # @return [Boolean] true if the stream is a TTY
       def tty?(io)
-        return false unless io.respond_to?(:tty?)
-        return false unless io.respond_to?(:isatty)
-
-        # Ruby 2.5+ uses tty?, older uses isatty
-        io.tty? || io.isatty
+        io.tty?
+      rescue NoMethodError
+        false
       rescue ArgumentError, IOError
         # Stream might be closed or invalid
         false

data/lib/canon/comparison/child_realignment.rb

@@ -0,0 +1,140 @@
+# frozen_string_literal: true
+
+require_relative "node_inspector"
+
+module Canon
+  module Comparison
+    # Shared two-cursor walk over child arrays with noise-aware realignment.
+    #
+    # When positional pairing would match a noise node (whitespace-only
+    # text or comment) against a content node, the walker treats the
+    # noise node as a single-side gap: emits a diff for it and advances
+    # only that cursor, so the next iteration aligns content against
+    # content.
+    #
+    # Noise classification is delegated to +NodeInspector.noise_dimension_for+,
+    # making the walk open for extension — new noise types only require
+    # adding a branch there.
+    #
+    # The walk is parameterised by a diff emitter (a callable that
+    # receives node1, node2, diff1, diff2, dimension) so both the HTML
+    # comparator (DiffNodeBuilder.build) and the XML comparator
+    # (comparator.add_difference) reuse the same cursor logic.
+    module ChildRealignment
+      class << self
+        # Walk two child arrays, emitting diffs for noise nodes and
+        # yielding matched content pairs.
+        #
+        # @param children1 [Array] Left-side children
+        # @param children2 [Array] Right-side children
+        # @param emitter [#call] Callable receiving
+        #   (node1, node2, diff1, diff2, dimension)
+        # @param emit_structural_orphans [Boolean] When true, trailing-edge
+        #   non-noise orphans are emitted as +:element_structure+ diffs.
+        #   HTML fragment path sets this to true (it has no separate
+        #   length-mismatch step); XML path sets it to false (structural
+        #   orphans are already recorded by +use_positional_comparison+).
+        # @yield [child1, child2] Compare two matched content nodes.
+        #   Must return a Comparison result constant.
+        # @return [Symbol] Worst comparison result encountered
+        def walk(children1, children2, emitter,
+                 emit_structural_orphans: false)
+          worst = Comparison::EQUIVALENT
+          i = 0
+          j = 0
+
+          while i < children1.length || j < children2.length
+            child1 = children1[i]
+            child2 = children2[j]
+
+            if child1.nil?
+              result = emit_orphan(child2, :right, emitter,
+                                   emit_structural_orphans)
+              worst = result if result && result != Comparison::EQUIVALENT
+              j += 1
+              next
+            elsif child2.nil?
+              result = emit_orphan(child1, :left, emitter,
+                                   emit_structural_orphans)
+              worst = result if result && result != Comparison::EQUIVALENT
+              i += 1
+              next
+            end
+
+            dim1 = NodeInspector.noise_dimension_for(child1)
+            dim2 = NodeInspector.noise_dimension_for(child2)
+
+            if dim1 && !dim2
+              result = emit_inline_noise(child1, child2, dim1, :left, emitter)
+              worst = result unless result == Comparison::EQUIVALENT
+              i += 1
+              next
+            elsif dim2 && !dim1
+              result = emit_inline_noise(child1, child2, dim2, :right, emitter)
+              worst = result unless result == Comparison::EQUIVALENT
+              j += 1
+              next
+            end
+
+            if block_given?
+              child_result = yield(child1, child2)
+              worst = child_result unless child_result == Comparison::EQUIVALENT
+            end
+            i += 1
+            j += 1
+          end
+
+          worst
+        end
+
+        private
+
+        # Emit a diff for an inline noise node that sits opposite a
+        # content node.  Whitespace passes both nodes for context;
+        # comments pass only the comment node.
+        def emit_inline_noise(node_left, node_right, dimension, noise_side,
+emitter)
+          if dimension == :whitespace_adjacency
+            emitter.call(node_left, node_right,
+                         Comparison::UNEQUAL_TEXT_CONTENTS,
+                         Comparison::UNEQUAL_TEXT_CONTENTS,
+                         dimension)
+            Comparison::UNEQUAL_TEXT_CONTENTS
+          else
+            n1 = noise_side == :left ? node_left : nil
+            n2 = noise_side == :right ? node_right : nil
+            emitter.call(n1, n2,
+                         Comparison::MISSING_NODE,
+                         Comparison::MISSING_NODE,
+                         dimension)
+            Comparison::UNEQUAL_ELEMENTS
+          end
+        end
+
+        # Emit a diff for a trailing-edge orphan (one side exhausted).
+        # Noise orphans are always emitted; structural orphans only when
+        # +emit_structural+ is true.
+        def emit_orphan(orphan, side, emitter, emit_structural)
+          dim = NodeInspector.noise_dimension_for(orphan)
+          if dim
+            n1 = side == :left ? orphan : nil
+            n2 = side == :right ? orphan : nil
+            emitter.call(n1, n2,
+                         Comparison::MISSING_NODE,
+                         Comparison::MISSING_NODE,
+                         dim)
+            Comparison::UNEQUAL_ELEMENTS
+          elsif emit_structural
+            n1 = side == :left ? orphan : nil
+            n2 = side == :right ? orphan : nil
+            emitter.call(n1, n2,
+                         Comparison::MISSING_NODE,
+                         Comparison::MISSING_NODE,
+                         :element_structure)
+            Comparison::UNEQUAL_ELEMENTS
+          end
+        end
+      end
+    end
+  end
+end

data/lib/canon/comparison/compare_profile.rb

@@ -82,14 +82,11 @@ module Canon
         %i[text_content structural_whitespace].include?(dimension)
       end
 
-      private
-
       # Get the behavior setting for a dimension
       # @param dimension [Symbol] The match dimension
       # @return [Symbol] The behavior (:strict, :normalize, :ignore)
       def behavior_for(dimension)
-        # Handle both ResolvedMatchOptions and Hash
-        if match_options.respond_to?(:behavior_for)
+        if match_options.is_a?(ResolvedMatchOptions)
           match_options.behavior_for(dimension)
         elsif match_options.is_a?(Hash)
           match_options[dimension] || :strict

data/lib/canon/comparison/dimensions/attribute_order_dimension.rb

@@ -21,14 +21,10 @@ module Canon
         def extract_data(node)
           return [] unless node
 
-          # Handle Moxml nodes
-          if node.is_a?(Moxml::Node)
-            extract_from_moxml(node)
-          # Handle Nokogiri nodes
-          elsif node.is_a?(Nokogiri::XML::Node)
+          if Canon::XmlBackend.nokogiri?
             extract_from_nokogiri(node)
           else
-            []
+            extract_from_moxml(node)
           end
         end
 

data/lib/canon/comparison/dimensions/attribute_presence_dimension.rb

@@ -21,14 +21,10 @@ module Canon
         def extract_data(node)
           return [] unless node
 
-          # Handle Moxml nodes
-          if node.is_a?(Moxml::Node)
-            extract_from_moxml(node)
-          # Handle Nokogiri nodes
-          elsif node.is_a?(Nokogiri::XML::Node)
+          if Canon::XmlBackend.nokogiri?
             extract_from_nokogiri(node)
           else
-            []
+            extract_from_moxml(node)
           end
         end
 

data/lib/canon/comparison/dimensions/attribute_values_dimension.rb

@@ -27,14 +27,10 @@ module Canon
         def extract_data(node)
           return {} unless node
 
-          # Handle Moxml nodes
-          if node.is_a?(Moxml::Node)
-            extract_from_moxml(node)
-          # Handle Nokogiri nodes
-          elsif node.is_a?(Nokogiri::XML::Node)
+          if Canon::XmlBackend.nokogiri?
             extract_from_nokogiri(node)
           else
-            {}
+            extract_from_moxml(node)
           end
         end
 

data/lib/canon/comparison/dimensions/comments_dimension.rb

@@ -21,14 +21,10 @@ module Canon
         def extract_data(node)
           return [] unless node
 
-          # Handle Moxml nodes
-          if node.is_a?(Moxml::Node)
-            extract_from_moxml(node)
-          # Handle Nokogiri nodes
-          elsif node.is_a?(Nokogiri::XML::Node)
+          if Canon::XmlBackend.nokogiri?
             extract_from_nokogiri(node)
           else
-            []
+            extract_from_moxml(node)
           end
         end